diff for duplicates of <1579052789.2871.0.camel@realtek.com> diff --git a/a/1.txt b/N1/1.txt index 036b6fd..b8576b9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,22 +1,33 @@ -T24gVHVlLCAyMDIwLTAxLTE0IGF0IDE2OjU2ICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG -cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gVmFy -aWFibGUgY29uZCBpcyBiZWluZyBhc3NpZ25lZCB3aXRoIGEgdmFsdWUgdGhhdCBpcyBuZXZlcg0K -PiByZWFkLCBpdCBpcyBhc3NpZ25lZCBhIG5ldyB2YWx1ZSBsYXRlciBvbi4gVGhlIGFzc2lnbm1l -bnQgaXMNCj4gcmVkdW5kYW50IGFuZCBjYW4gYmUgcmVtb3ZlZC4NCj4gDQo+IEFkZHJlc3Nlcy1D -b3Zlcml0eTogKCJVbnVzZWQgdmFsdWUiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2lu -ZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KDQpBY2tlZC1ieTogUGluZy1LZSBTaGloIDxw -a3NoaWhAcmVhbHRlay5jb20+DQoNClRoYW5rIHlvdSEhDQoNCj4gLS0tDQo+IMKgZHJpdmVycy9u -ZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL3J0bDgxODhlZS9waHkuYyB8IDIgKy0NCj4gwqAx -IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYg -LS1naXQgYS9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvcnRsODE4OGVlL3Bo -eS5jDQo+IGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL3J0bDgxODhlZS9w -aHkuYw0KPiBpbmRleCA1Y2E5MDBmOTdkNjYuLmQxMzk4M2VjMDlhZCAxMDA2NDQNCj4gLS0tIGEv -ZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL3J0bDgxODhlZS9waHkuYw0KPiAr -KysgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvcnRsODE4OGVlL3BoeS5j -DQo+IEBAIC0yNjQsNyArMjY0LDcgQEAgc3RhdGljIGJvb2wgX3J0bDg4ZV9jaGVja19jb25kaXRp -b24oc3RydWN0IGllZWU4MDIxMV9odw0KPiAqaHcsDQo+IMKgCXUzMiBfYm9hcmQgPSBydGxlZnVz -ZS0+Ym9hcmRfdHlwZTsgLypuZWVkIGVmdXNlIGRlZmluZSovDQo+IMKgCXUzMiBfaW50ZXJmYWNl -ID0gcnRsaGFsLT5pbnRlcmZhY2U7DQo+IMKgCXUzMiBfcGxhdGZvcm0gPSAweDA4Oy8qU3VwcG9y -dFBsYXRmb3JtICovDQo+IC0JdTMyIGNvbmQgPSBjb25kaXRpb247DQo+ICsJdTMyIGNvbmQ7DQo+ -IMKgDQo+IMKgCWlmIChjb25kaXRpb24gPT0gMHhDRENEQ0RDRCkNCj4gwqAJCXJldHVybiB0cnVl -Ow0K +On Tue, 2020-01-14 at 16:56 +0000, Colin King wrote: +> From: Colin Ian King <colin.king@canonical.com> +> +> Variable cond is being assigned with a value that is never +> read, it is assigned a new value later on. The assignment is +> redundant and can be removed. +> +> Addresses-Coverity: ("Unused value") +> Signed-off-by: Colin Ian King <colin.king@canonical.com> + +Acked-by: Ping-Ke Shih <pkshih@realtek.com> + +Thank you!! + +> --- +> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c +> b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c +> index 5ca900f97d66..d13983ec09ad 100644 +> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c +> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c +> @@ -264,7 +264,7 @@ static bool _rtl88e_check_condition(struct ieee80211_hw +> *hw, +> u32 _board = rtlefuse->board_type; /*need efuse define*/ +> u32 _interface = rtlhal->interface; +> u32 _platform = 0x08;/*SupportPlatform */ +> - u32 cond = condition; +> + u32 cond; +> +> if (condition == 0xCDCDCDCD) +> return true; diff --git a/a/content_digest b/N1/content_digest index ca7f0b5..667392f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -11,27 +11,38 @@ " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gVHVlLCAyMDIwLTAxLTE0IGF0IDE2OjU2ICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG\n" - "cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gVmFy\n" - "aWFibGUgY29uZCBpcyBiZWluZyBhc3NpZ25lZCB3aXRoIGEgdmFsdWUgdGhhdCBpcyBuZXZlcg0K\n" - "PiByZWFkLCBpdCBpcyBhc3NpZ25lZCBhIG5ldyB2YWx1ZSBsYXRlciBvbi4gVGhlIGFzc2lnbm1l\n" - "bnQgaXMNCj4gcmVkdW5kYW50IGFuZCBjYW4gYmUgcmVtb3ZlZC4NCj4gDQo+IEFkZHJlc3Nlcy1D\n" - "b3Zlcml0eTogKCJVbnVzZWQgdmFsdWUiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2lu\n" - "ZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KDQpBY2tlZC1ieTogUGluZy1LZSBTaGloIDxw\n" - "a3NoaWhAcmVhbHRlay5jb20+DQoNClRoYW5rIHlvdSEhDQoNCj4gLS0tDQo+IMKgZHJpdmVycy9u\n" - "ZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL3J0bDgxODhlZS9waHkuYyB8IDIgKy0NCj4gwqAx\n" - "IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYg\n" - "LS1naXQgYS9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvcnRsODE4OGVlL3Bo\n" - "eS5jDQo+IGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL3J0bDgxODhlZS9w\n" - "aHkuYw0KPiBpbmRleCA1Y2E5MDBmOTdkNjYuLmQxMzk4M2VjMDlhZCAxMDA2NDQNCj4gLS0tIGEv\n" - "ZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL3J0bDgxODhlZS9waHkuYw0KPiAr\n" - "KysgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvcnRsODE4OGVlL3BoeS5j\n" - "DQo+IEBAIC0yNjQsNyArMjY0LDcgQEAgc3RhdGljIGJvb2wgX3J0bDg4ZV9jaGVja19jb25kaXRp\n" - "b24oc3RydWN0IGllZWU4MDIxMV9odw0KPiAqaHcsDQo+IMKgCXUzMiBfYm9hcmQgPSBydGxlZnVz\n" - "ZS0+Ym9hcmRfdHlwZTsgLypuZWVkIGVmdXNlIGRlZmluZSovDQo+IMKgCXUzMiBfaW50ZXJmYWNl\n" - "ID0gcnRsaGFsLT5pbnRlcmZhY2U7DQo+IMKgCXUzMiBfcGxhdGZvcm0gPSAweDA4Oy8qU3VwcG9y\n" - "dFBsYXRmb3JtICovDQo+IC0JdTMyIGNvbmQgPSBjb25kaXRpb247DQo+ICsJdTMyIGNvbmQ7DQo+\n" - "IMKgDQo+IMKgCWlmIChjb25kaXRpb24gPT0gMHhDRENEQ0RDRCkNCj4gwqAJCXJldHVybiB0cnVl\n" - Ow0K + "On Tue, 2020-01-14 at 16:56 +0000, Colin King wrote:\n" + "> From: Colin Ian King <colin.king@canonical.com>\n" + "> \n" + "> Variable cond is being assigned with a value that is never\n" + "> read, it is assigned a new value later on. The assignment is\n" + "> redundant and can be removed.\n" + "> \n" + "> Addresses-Coverity: (\"Unused value\")\n" + "> Signed-off-by: Colin Ian King <colin.king@canonical.com>\n" + "\n" + "Acked-by: Ping-Ke Shih <pkshih@realtek.com>\n" + "\n" + "Thank you!!\n" + "\n" + "> ---\n" + "> \302\240drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c | 2 +-\n" + "> \302\2401 file changed, 1 insertion(+), 1 deletion(-)\n" + "> \n" + "> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c\n" + "> b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c\n" + "> index 5ca900f97d66..d13983ec09ad 100644\n" + "> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c\n" + "> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c\n" + "> @@ -264,7 +264,7 @@ static bool _rtl88e_check_condition(struct ieee80211_hw\n" + "> *hw,\n" + "> \302\240\tu32 _board = rtlefuse->board_type; /*need efuse define*/\n" + "> \302\240\tu32 _interface = rtlhal->interface;\n" + "> \302\240\tu32 _platform = 0x08;/*SupportPlatform */\n" + "> -\tu32 cond = condition;\n" + "> +\tu32 cond;\n" + "> \302\240\n" + "> \302\240\tif (condition == 0xCDCDCDCD)\n" + "> \302\240\t\treturn true;" -a6d74f662733e3af413a879e7e3010223d9708b9eac25fd5d92aa28bddb2da57 +f35d075b142fea4312020bbc7a5a6d7a67399a0ee808006ba0b12568d13f4fca
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.