From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:c345:0:0:0:0:0 with SMTP id t66csp7057764lff; Wed, 15 Jan 2020 07:24:27 -0800 (PST) X-Google-Smtp-Source: APXvYqy169y6tZpr7F/JOQQBHLYvpKNrQkVQ9yQ6Q5csNmEDRBho8sQ7cZxJMB+0D4pWuLkiZ7ix X-Received: by 2002:a0c:e34e:: with SMTP id a14mr22574340qvm.73.1579101867341; Wed, 15 Jan 2020 07:24:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579101867; cv=none; d=google.com; s=arc-20160816; b=NVm2I9B0Ja7WhI/9QPXiITviutIrPj22DM5Rgxx/eidFn8L5gGb+usEqX+00KiTtxH U6uju39pTs6d0KpKzLP+gBuTKwcl1qWjisWzYiD0pakveQjISNJco949T5G7HTMlLLue bG/Uzf/rfOdHybka5atZm0DfKW+54S/Jzz4IrJzOyYj6cB0l9e7TBj3NN4NV7IDltJ52 bEemM77GQsotW+UcsBbofevMq9O9/k1xisgYNr9GWEkRGKjg1+rr/gB9wuL+/rO0+/Mx odz3BE7k2XtAzeK+14rlVVc6k/TWTrsF7qegcp1Pm2lgC3Q3Uh9eqDiG2H3PMHv+QmmN 4lbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=C7eMkXK4I5/XcYe5vwEjKWldJQcF0yNWsxv2OU7gvbs=; b=bYVhziqaLmhN0fZkHDghab6zqianrBbtglMwRuxnh9UeiF/8aJK32AtMuWXEGW/cSa 3aSFzMAt4BTt39zAqt32vHyR71UL8YlXjY+aZYDZCV9kB/WP4453c3xdoIFyPWJdrFfc DYwQDAyzPpgS4QwMWv8x2omyhMFlzWFspz1InEjY4sc0y3aAPTi8zEXYS38xmysxX+wV C+C2P53A7jFjdGtLpq0xRVkw0HpbbFUOz42p3CUmGC+9dAso8l+LHtagsdpMOBmfHLBq 3blHOOGormzZff/AuemTiI5daSKZTghg7n0nLQP91sAo9URZqvCecnQJ1n1C5HFwv7jv s1ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=hgbSuPSP; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h131si10906705qke.244.2020.01.15.07.24.27 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Jan 2020 07:24:27 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=hgbSuPSP; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:55724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irkWw-0001yj-9k for alex.bennee@linaro.org; Wed, 15 Jan 2020 10:24:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48793) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irkJz-0007Yn-Ek for qemu-devel@nongnu.org; Wed, 15 Jan 2020 10:11:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irkJy-000850-7a for qemu-devel@nongnu.org; Wed, 15 Jan 2020 10:11:03 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:43097 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irkJy-00083x-1s for qemu-devel@nongnu.org; Wed, 15 Jan 2020 10:11:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579101059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C7eMkXK4I5/XcYe5vwEjKWldJQcF0yNWsxv2OU7gvbs=; b=hgbSuPSPsvj1cueJTSd1LYc5UFiSw3vvl6PPtirAZq6mv8ddEduUbWpKldDyZa+omlOpgl KWDe4GLfdZKV1lNTxYm+0pP1YRxrqfp8ihFa2FEci8DMBRwOnKyxos4VNUgodoEK2wtsTF r+F+L4pnFgULg39eIeJBue/h0mPRXoE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-nvc1VmhoOjuAlGdDJ89jzw-1; Wed, 15 Jan 2020 10:10:55 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6EF8E1927B96; Wed, 15 Jan 2020 15:10:54 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 48F1B19757; Wed, 15 Jan 2020 15:10:53 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH v2 15/86] arm:imx25_pdk: drop RAM size fixup Date: Wed, 15 Jan 2020 16:06:30 +0100 Message-Id: <1579100861-73692-16-git-send-email-imammedo@redhat.com> In-Reply-To: <1579100861-73692-1-git-send-email-imammedo@redhat.com> References: <1579100861-73692-1-git-send-email-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: nvc1VmhoOjuAlGdDJ89jzw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, jcd@tribudubois.net Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: 8cjFXLq2Ke17 If user provided non-sense RAM size, board will complain and continue running with max RAM size supported. Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user. Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values. Signed-off-by: Igor Mammedov --- CC: jcd@tribudubois.net CC: peter.maydell@linaro.org CC: qemu-arm@nongnu.org --- hw/arm/imx25_pdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/imx25_pdk.c b/hw/arm/imx25_pdk.c index c76fc2b..a2b7b35 100644 --- a/hw/arm/imx25_pdk.c +++ b/hw/arm/imx25_pdk.c @@ -78,10 +78,10 @@ static void imx25_pdk_init(MachineState *machine) =20 /* We need to initialize our memory */ if (machine->ram_size > (FSL_IMX25_SDRAM0_SIZE + FSL_IMX25_SDRAM1_SIZE= )) { - warn_report("RAM size " RAM_ADDR_FMT " above max supported, " + error_report("RAM size " RAM_ADDR_FMT " above max supported, " "reduced to %x", machine->ram_size, FSL_IMX25_SDRAM0_SIZE + FSL_IMX25_SDRAM1_SIZE); - machine->ram_size =3D FSL_IMX25_SDRAM0_SIZE + FSL_IMX25_SDRAM1_SIZ= E; + exit(EXIT_FAILURE); } =20 memory_region_allocate_system_memory(&s->ram, NULL, "imx25.ram", --=20 2.7.4