From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF393C33CB1 for ; Thu, 16 Jan 2020 06:21:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B82AE2081E for ; Thu, 16 Jan 2020 06:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579155693; bh=fMhT46q4PoSd5jFYY6QltFeELTTAVrDbliwfAO7u8vU=; h=Subject:To:From:Date:List-ID:From; b=fcCR7fXsTZEPh80VLjgvb6d0muknFtfzkQtVAwFvV9R9aYePD4jknrfWl9WPBDA06 aVZSpDDUTke0fK2Q/eMVgntdO4D5F6ICO0TlsROB/GLlrdnphe5ga2qiNg9nkVSmQE QTO7cvv4ytunlo+Wd+rWgnWp8qpU45+xLyDrvChY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730241AbgAPGVd (ORCPT ); Thu, 16 Jan 2020 01:21:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:58602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725768AbgAPGVd (ORCPT ); Thu, 16 Jan 2020 01:21:33 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7632520728; Thu, 16 Jan 2020 06:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579155692; bh=fMhT46q4PoSd5jFYY6QltFeELTTAVrDbliwfAO7u8vU=; h=Subject:To:From:Date:From; b=iT+CBwXgdAMAy/A1v88nPOZC2z+/fOvN9MoagiuZPku5cEGRBr0uSoRO8l65TnAAj 6F87m+IUYjG548w7z8dlXwRaUWMCBXuPsJ+j9ctFuXdfrCavzqIxcnvKgFqubgm+f3 oXXfSp/d87Va8dPfWMah5HZ4GfK64HqZVByPmoRQ= Subject: patch "staging: wlan-ng: ensure error return is actually returned" added to staging-next To: colin.king@canonical.com, gregkh@linuxfoundation.org, stable@vger.kernel.org From: Date: Thu, 16 Jan 2020 07:20:45 +0100 Message-ID: <157915564513941@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This is a note to let you know that I've just added the patch titled staging: wlan-ng: ensure error return is actually returned to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. >From 4cc41cbce536876678b35e03c4a8a7bb72c78fa9 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Tue, 14 Jan 2020 18:16:04 +0000 Subject: staging: wlan-ng: ensure error return is actually returned Currently when the call to prism2sta_ifst fails a netdev_err error is reported, error return variable result is set to -1 but the function always returns 0 for success. Fix this by returning the error value in variable result rather than 0. Addresses-Coverity: ("Unused value") Fixes: 00b3ed168508 ("Staging: add wlan-ng prism2 usb driver") Signed-off-by: Colin Ian King Cc: stable Link: https://lore.kernel.org/r/20200114181604.390235-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index 7350fe5d96a3..a8860d2aee68 100644 --- a/drivers/staging/wlan-ng/prism2mgmt.c +++ b/drivers/staging/wlan-ng/prism2mgmt.c @@ -959,7 +959,7 @@ int prism2mgmt_flashdl_state(struct wlandevice *wlandev, void *msgp) } } - return 0; + return result; } /*---------------------------------------------------------------- -- 2.25.0