From: Tom Zanussi <zanussi@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: gregkh@linuxfoundation.org, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] tracing: Fix histogram code when expression has same var as" failed to apply to 4.19-stable tree
Date: Mon, 27 Jan 2020 13:19:28 -0600 [thread overview]
Message-ID: <1580152768.2442.2.camel@kernel.org> (raw)
In-Reply-To: <20200127135147.5c1ae6d1@gandalf.local.home>
On Mon, 2020-01-27 at 13:51 -0500, Steven Rostedt wrote:
> On Mon, 27 Jan 2020 12:36:21 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> > Hi Steve,
> >
> > For 4.19, this patch applies if these patches are applied first:
> >
> > commit 656fe2ba85e81d00e4447bf77b8da2be3c47acb2
> > Author: Tom Zanussi <tom.zanussi@linux.intel.com>
> > Date: Tue Dec 18 14:33:24 2018 -0600
> >
> > tracing: Use hist trigger's var_ref array to destroy var_refs
> >
> > commit de40f033d4e84e843d6a12266e3869015ea9097c
> > Author: Tom Zanussi <tom.zanussi@linux.intel.com>
> > Date: Tue Dec 18 14:33:23 2018 -0600
> >
> > tracing: Remove open-coding of hist trigger var_ref management
> >
> > After applying all 3 to 4.19, I built and ran the ftrace/trigger
> > selftests and didn't see any problems.
> >
>
> Thanks, I was cherry-picking parts of those changes, but it wasn't
> fixing the issue itself. Let me just backport both of them in full
> and
> see if that works.
It does fix the issue for me and passes the selftests. Remember that
4.19 doesn't have the .trace() hist action - you need to use the event
name e.g. .first()
Tom
>
> -- Steve
next prev parent reply other threads:[~2020-01-27 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 15:37 FAILED: patch "[PATCH] tracing: Fix histogram code when expression has same var as" failed to apply to 4.19-stable tree gregkh
2020-01-27 18:36 ` Tom Zanussi
2020-01-27 18:51 ` Steven Rostedt
2020-01-27 19:19 ` Tom Zanussi [this message]
2020-01-27 19:36 ` Steven Rostedt
2020-01-27 22:31 ` Steven Rostedt
2020-01-28 8:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1580152768.2442.2.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.