From: Tom Zanussi <zanussi@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: artem.bityutskiy@linux.intel.com, mhiramat@kernel.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH 1/4] tracing: Consolidate some synth_event_trace code
Date: Fri, 31 Jan 2020 16:47:38 -0600 [thread overview]
Message-ID: <1580510858.5607.0.camel@kernel.org> (raw)
In-Reply-To: <20200131174344.5606d154@gandalf.local.home>
Hi Steve,
On Fri, 2020-01-31 at 17:43 -0500, Steven Rostedt wrote:
> On Fri, 31 Jan 2020 15:55:31 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> > +++ b/kernel/trace/trace_events_hist.c
> > @@ -2053,24 +2053,72 @@ int synth_event_trace_start(struct
> > trace_event_file *file,
> > }
> > EXPORT_SYMBOL_GPL(synth_event_trace_start);
> >
> > -static int save_synth_val(struct synth_field *field, u64 val,
> > +int __synth_event_add_val(const char *field_name, u64 val,
>
> Hmm, shouldn't __synth_event_add_val() still be static?
>
It's a new function, but yeah, it should be static.
Tom
> -- Steve
>
> > struct synth_event_trace_state
> > *trace_state)
> > {
> > - struct synth_trace_event *entry = trace_state->entry;
> > + struct synth_field *field = NULL;
> > + struct synth_trace_event *entry;
> > + struct synth_event *event;
> > + int i, ret = 0;
> > +
next prev parent reply other threads:[~2020-01-31 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 21:55 [PATCH 0/4] tracing: Updates to dynamic event API Tom Zanussi
2020-01-31 21:55 ` [PATCH 1/4] tracing: Consolidate some synth_event_trace code Tom Zanussi
2020-01-31 22:43 ` Steven Rostedt
2020-01-31 22:47 ` Tom Zanussi [this message]
2020-01-31 23:00 ` Tom Zanussi
2020-01-31 23:33 ` Steven Rostedt
2020-02-04 10:00 ` kbuild test robot
2020-02-04 10:00 ` [RFC PATCH] tracing: __synth_event_add_val() can be static kbuild test robot
2020-01-31 21:55 ` [PATCH 2/4] tracing: Remove check_arg() callbacks from dynevent args Tom Zanussi
2020-02-01 7:28 ` Masami Hiramatsu
2020-01-31 21:55 ` [PATCH 3/4] tracing: Remove useless code in dynevent_arg_pair_add() Tom Zanussi
2020-02-01 7:28 ` Masami Hiramatsu
2020-01-31 21:55 ` [PATCH 4/4] tracing: Use seq_buf for building dynevent_cmd string Tom Zanussi
2020-02-01 7:48 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1580510858.5607.0.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=artem.bityutskiy@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.