From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF60C35247 for ; Tue, 4 Feb 2020 00:54:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3ED82084E for ; Tue, 4 Feb 2020 00:54:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dfkx7fcH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="bAGxRWqR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3ED82084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NqbVrXtj79teaO6vLlzWFctKBT5MNLA4wjgAoik/JD0=; b=dfkx7fcHznyaHn R6qQI/h1k8u1GR98nOYxduAH8hF3k7i0WY7eY/gQvuukl2itxsHHNp8lMRqEPOtT+RnR/g83Q9zfn wB4uhODv+9LYzurVrSW2+4SOVaNJwQ6HunmWraLiBrStxBan5n/XUAS4DiV5QobncuYrTAa7yKash eMt73qg2QFFVo78+wy5tJcFIYJbxcJTuXSptYIbywoTUCnxzczXtOzN7qH6AZKqoS/n73QwFXhHU8 VgYXF+KyFDf1XCHY3jUCttbNYTL0Axeez6gL18rZ6r0yApFAh8wiNKI4LsxNHnG1HHCWRanjuNqeP 4gVWz8zfBGbABxFUTqIQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iymU9-000297-1h; Tue, 04 Feb 2020 00:54:37 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iymU0-00023w-IK; Tue, 04 Feb 2020 00:54:31 +0000 X-UUID: d391a02244254eceb83a790f4b61c53f-20200203 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=5GT0W0D4fp1R9e9GcyJmXd1HEmQL0ETrvY40fzATcrY=; b=bAGxRWqRT1Ty4qarjsRGSiKWZfm4/fmRF+ofrie3juJEv//55/vg7Cx5pNzJa9jVLHFd97FCkMzVLrD7XdYpJPvNn8auiWS5FtQ2KyHUjgSCUIs9cjCQanmURnLcuYPD9OfAcynFXK1yP4ZJNbSmlZLHb2UMBd/6JyOZI+kbYhU=; X-UUID: d391a02244254eceb83a790f4b61c53f-20200203 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1170873240; Mon, 03 Feb 2020 16:54:17 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 3 Feb 2020 16:44:13 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 4 Feb 2020 08:43:34 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 4 Feb 2020 08:44:29 +0800 Message-ID: <1580777053.4621.1.camel@mtkswgap22> Subject: Re: [PATCH 1/3] [1/3] mmc: core: expose MMC_CAP2_CQE* to dt From: Chun-Hung Wu To: Ulf Hansson Date: Tue, 4 Feb 2020 08:44:13 +0800 In-Reply-To: References: <1572590582-11056-1-git-send-email-chun-hung.wu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200203_165428_616348_DC2E3CF0 X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kate Stewart , wsd_upstream@mediatek.com, DTML , Martin Blumenstingl , Greg Kroah-Hartman , Linus Walleij , Kuohong Wang , Linux Kernel Mailing List , Rob Herring , linux-mediatek@lists.infradead.org, Linux ARM , Pavel Machek , Matthias Brugger , "linux-mmc@vger.kernel.org" , Thomas Gleixner , Stanley Chu , Pan Bian , Chaotian Jing Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Thanks for the review , will remove the tag in v2 driver. On Mon, 2019-11-11 at 14:04 +0100, Ulf Hansson wrote: > On Fri, 1 Nov 2019 at 07:43, Chun-Hung Wu wrote: > > > > Expose MMC_CAP2_CQE and MMC_CAP2_CQE_DCMD > > to host->caps2 if > > 1. "supports-cqe" is defined in dt and > > 2. "disable-cqe-dcmd" is not defined in dt. > > > > Change-Id: I3d172e6bcfac34520c3932a6f8df2e20f2c0d05b > > CR-Id: > > Feature: > > Remove these tags please. > > > Signed-off-by: Chun-Hung Wu > > --- > > drivers/mmc/core/host.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > > index 105b7a7..efb0dbe 100644 > > --- a/drivers/mmc/core/host.c > > +++ b/drivers/mmc/core/host.c > > @@ -319,6 +319,14 @@ int mmc_of_parse(struct mmc_host *host) > > host->caps2 |= MMC_CAP2_NO_SD; > > if (device_property_read_bool(dev, "no-mmc")) > > host->caps2 |= MMC_CAP2_NO_MMC; > > + if (device_property_read_bool(dev, "supports-cqe")) > > + host->caps2 |= MMC_CAP2_CQE; > > + > > + /* Must be after "supports-cqe" check */ > > + if (!device_property_read_bool(dev, "disable-cqe-dcmd")) { > > + if (host->caps2 & MMC_CAP2_CQE) > > + host->caps2 |= MMC_CAP2_CQE_DCMD; > > + } > > > > /* Must be after "non-removable" check */ > > if (device_property_read_u32(dev, "fixed-emmc-driver-type", &drv_type) == 0) { > > -- > > 1.9.1 > > > > Otherwise, this looks good to me. > > Kind regards > Uffe _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47613C35247 for ; Tue, 4 Feb 2020 00:44:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D8622166E for ; Tue, 4 Feb 2020 00:44:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="fsToL9Vi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbgBDAoU (ORCPT ); Mon, 3 Feb 2020 19:44:20 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:30771 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726928AbgBDAoU (ORCPT ); Mon, 3 Feb 2020 19:44:20 -0500 X-UUID: 1a1ab3d8e5a645109859a7adbcd181ea-20200204 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=5GT0W0D4fp1R9e9GcyJmXd1HEmQL0ETrvY40fzATcrY=; b=fsToL9ViJWcZIICJM27OSDhjNoyoImIJQbMjTeHViMESeY6WIzQhavCKcknZyTi8PCVd8zzUydDg6B1nIZgCvnB+d+t9ilhp1AuRPVw0/JAHXczEyfDpdrav7QwXJTk0i7Qk2gnxLNZgCXwd2iXmWtA43ZuGsEmYEKZ1/da68Is=; X-UUID: 1a1ab3d8e5a645109859a7adbcd181ea-20200204 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1633236549; Tue, 04 Feb 2020 08:44:15 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 4 Feb 2020 08:43:34 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 4 Feb 2020 08:44:29 +0800 Message-ID: <1580777053.4621.1.camel@mtkswgap22> Subject: Re: [PATCH 1/3] [1/3] mmc: core: expose MMC_CAP2_CQE* to dt From: Chun-Hung Wu To: Ulf Hansson CC: Chaotian Jing , Rob Herring , Mark Rutland , "Matthias Brugger" , Linus Walleij , Pavel Machek , Kate Stewart , Greg Kroah-Hartman , Martin Blumenstingl , Pan Bian , Thomas Gleixner , Stanley Chu , Kuohong Wang , "Linux Kernel Mailing List" , "linux-mmc@vger.kernel.org" , , DTML , , Linux ARM Date: Tue, 4 Feb 2020 08:44:13 +0800 In-Reply-To: References: <1572590582-11056-1-git-send-email-chun-hung.wu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org VGhhbmtzIGZvciB0aGUgcmV2aWV3ICwgd2lsbCByZW1vdmUgdGhlIHRhZyBpbiB2MiBkcml2ZXIu DQoNCk9uIE1vbiwgMjAxOS0xMS0xMSBhdCAxNDowNCArMDEwMCwgVWxmIEhhbnNzb24gd3JvdGU6 DQo+IE9uIEZyaSwgMSBOb3YgMjAxOSBhdCAwNzo0MywgQ2h1bi1IdW5nIFd1IDxjaHVuLWh1bmcu d3VAbWVkaWF0ZWsuY29tPiB3cm90ZToNCj4gPg0KPiA+IEV4cG9zZSBNTUNfQ0FQMl9DUUUgYW5k IE1NQ19DQVAyX0NRRV9EQ01EDQo+ID4gdG8gaG9zdC0+Y2FwczIgaWYNCj4gPiAxLiAic3VwcG9y dHMtY3FlIiBpcyBkZWZpbmVkIGluIGR0IGFuZA0KPiA+IDIuICJkaXNhYmxlLWNxZS1kY21kIiBp cyBub3QgZGVmaW5lZCBpbiBkdC4NCj4gPg0KPiA+IENoYW5nZS1JZDogSTNkMTcyZTZiY2ZhYzM0 NTIwYzM5MzJhNmY4ZGYyZTIwZjJjMGQwNWINCj4gPiBDUi1JZDoNCj4gPiBGZWF0dXJlOg0KPiAN Cj4gUmVtb3ZlIHRoZXNlIHRhZ3MgcGxlYXNlLg0KPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBDaHVu LUh1bmcgV3UgPGNodW4taHVuZy53dUBtZWRpYXRlay5jb20+DQo+ID4gLS0tDQo+ID4gIGRyaXZl cnMvbW1jL2NvcmUvaG9zdC5jIHwgOCArKysrKysrKw0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgOCBp bnNlcnRpb25zKCspDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tbWMvY29yZS9ob3N0 LmMgYi9kcml2ZXJzL21tYy9jb3JlL2hvc3QuYw0KPiA+IGluZGV4IDEwNWI3YTcuLmVmYjBkYmUg MTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9tbWMvY29yZS9ob3N0LmMNCj4gPiArKysgYi9kcml2 ZXJzL21tYy9jb3JlL2hvc3QuYw0KPiA+IEBAIC0zMTksNiArMzE5LDE0IEBAIGludCBtbWNfb2Zf cGFyc2Uoc3RydWN0IG1tY19ob3N0ICpob3N0KQ0KPiA+ICAgICAgICAgICAgICAgICBob3N0LT5j YXBzMiB8PSBNTUNfQ0FQMl9OT19TRDsNCj4gPiAgICAgICAgIGlmIChkZXZpY2VfcHJvcGVydHlf cmVhZF9ib29sKGRldiwgIm5vLW1tYyIpKQ0KPiA+ICAgICAgICAgICAgICAgICBob3N0LT5jYXBz MiB8PSBNTUNfQ0FQMl9OT19NTUM7DQo+ID4gKyAgICAgICBpZiAoZGV2aWNlX3Byb3BlcnR5X3Jl YWRfYm9vbChkZXYsICJzdXBwb3J0cy1jcWUiKSkNCj4gPiArICAgICAgICAgICAgICAgaG9zdC0+ Y2FwczIgfD0gTU1DX0NBUDJfQ1FFOw0KPiA+ICsNCj4gPiArICAgICAgIC8qIE11c3QgYmUgYWZ0 ZXIgInN1cHBvcnRzLWNxZSIgY2hlY2sgKi8NCj4gPiArICAgICAgIGlmICghZGV2aWNlX3Byb3Bl cnR5X3JlYWRfYm9vbChkZXYsICJkaXNhYmxlLWNxZS1kY21kIikpIHsNCj4gPiArICAgICAgICAg ICAgICAgaWYgKGhvc3QtPmNhcHMyICYgTU1DX0NBUDJfQ1FFKQ0KPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgIGhvc3QtPmNhcHMyIHw9IE1NQ19DQVAyX0NRRV9EQ01EOw0KPiA+ICsgICAgICAg fQ0KPiA+DQo+ID4gICAgICAgICAvKiBNdXN0IGJlIGFmdGVyICJub24tcmVtb3ZhYmxlIiBjaGVj ayAqLw0KPiA+ICAgICAgICAgaWYgKGRldmljZV9wcm9wZXJ0eV9yZWFkX3UzMihkZXYsICJmaXhl ZC1lbW1jLWRyaXZlci10eXBlIiwgJmRydl90eXBlKSA9PSAwKSB7DQo+ID4gLS0NCj4gPiAxLjku MQ0KPiA+DQo+IA0KPiBPdGhlcndpc2UsIHRoaXMgbG9va3MgZ29vZCB0byBtZS4NCj4gDQo+IEtp bmQgcmVnYXJkcw0KPiBVZmZlDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE210C35247 for ; Tue, 4 Feb 2020 00:54:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A071A2084E for ; Tue, 4 Feb 2020 00:54:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ola6tsDC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="bAGxRWqR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A071A2084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y9qMPD746kJqUOE6+75LxGaf6EoaoznvGF1JN7viBNw=; b=ola6tsDC03TWWk Yr69sPt4MUg07tgjloCf+BMil5xUghPUq57AptR452S97vkDipF65gQ0w/CUR/y4EQFcDOv5h+OFi Qt02LoWd+JOYf21HElevZU16DySrytWkZAL3WiDwfNIBz8ueCoFjuKhD37FkNuZ+AQt5+91v4eHi/ bkjs8Uq0Y0iBlb/wBH/bzVi2gWljuqDeV+LDqEJo1HpwpeKmCxyDtfczGbkGCwm0dv7cFuZpUcSCY c9wK0TmZuRWmC184/Sx7Jn6PefpWOAMshpqge27hbJnCYDKvq5fZvPX8RjHo9wq8iNYtICKj7QO15 Gua7DnEsFPi4xVtsgl8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iymU5-00024S-4o; Tue, 04 Feb 2020 00:54:33 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iymU0-00023w-IK; Tue, 04 Feb 2020 00:54:31 +0000 X-UUID: d391a02244254eceb83a790f4b61c53f-20200203 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=5GT0W0D4fp1R9e9GcyJmXd1HEmQL0ETrvY40fzATcrY=; b=bAGxRWqRT1Ty4qarjsRGSiKWZfm4/fmRF+ofrie3juJEv//55/vg7Cx5pNzJa9jVLHFd97FCkMzVLrD7XdYpJPvNn8auiWS5FtQ2KyHUjgSCUIs9cjCQanmURnLcuYPD9OfAcynFXK1yP4ZJNbSmlZLHb2UMBd/6JyOZI+kbYhU=; X-UUID: d391a02244254eceb83a790f4b61c53f-20200203 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1170873240; Mon, 03 Feb 2020 16:54:17 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 3 Feb 2020 16:44:13 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 4 Feb 2020 08:43:34 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 4 Feb 2020 08:44:29 +0800 Message-ID: <1580777053.4621.1.camel@mtkswgap22> Subject: Re: [PATCH 1/3] [1/3] mmc: core: expose MMC_CAP2_CQE* to dt From: Chun-Hung Wu To: Ulf Hansson Date: Tue, 4 Feb 2020 08:44:13 +0800 In-Reply-To: References: <1572590582-11056-1-git-send-email-chun-hung.wu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200203_165428_616348_DC2E3CF0 X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kate Stewart , wsd_upstream@mediatek.com, DTML , Martin Blumenstingl , Greg Kroah-Hartman , Linus Walleij , Kuohong Wang , Linux Kernel Mailing List , Rob Herring , linux-mediatek@lists.infradead.org, Linux ARM , Pavel Machek , Matthias Brugger , "linux-mmc@vger.kernel.org" , Thomas Gleixner , Stanley Chu , Pan Bian , Chaotian Jing Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks for the review , will remove the tag in v2 driver. On Mon, 2019-11-11 at 14:04 +0100, Ulf Hansson wrote: > On Fri, 1 Nov 2019 at 07:43, Chun-Hung Wu wrote: > > > > Expose MMC_CAP2_CQE and MMC_CAP2_CQE_DCMD > > to host->caps2 if > > 1. "supports-cqe" is defined in dt and > > 2. "disable-cqe-dcmd" is not defined in dt. > > > > Change-Id: I3d172e6bcfac34520c3932a6f8df2e20f2c0d05b > > CR-Id: > > Feature: > > Remove these tags please. > > > Signed-off-by: Chun-Hung Wu > > --- > > drivers/mmc/core/host.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > > index 105b7a7..efb0dbe 100644 > > --- a/drivers/mmc/core/host.c > > +++ b/drivers/mmc/core/host.c > > @@ -319,6 +319,14 @@ int mmc_of_parse(struct mmc_host *host) > > host->caps2 |= MMC_CAP2_NO_SD; > > if (device_property_read_bool(dev, "no-mmc")) > > host->caps2 |= MMC_CAP2_NO_MMC; > > + if (device_property_read_bool(dev, "supports-cqe")) > > + host->caps2 |= MMC_CAP2_CQE; > > + > > + /* Must be after "supports-cqe" check */ > > + if (!device_property_read_bool(dev, "disable-cqe-dcmd")) { > > + if (host->caps2 & MMC_CAP2_CQE) > > + host->caps2 |= MMC_CAP2_CQE_DCMD; > > + } > > > > /* Must be after "non-removable" check */ > > if (device_property_read_u32(dev, "fixed-emmc-driver-type", &drv_type) == 0) { > > -- > > 1.9.1 > > > > Otherwise, this looks good to me. > > Kind regards > Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel