From: Wei Wang <wei.w.wang@intel.com>
To: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org
Cc: tysand@google.com, mst@redhat.com, david@redhat.com,
alexander.h.duyck@linux.intel.com, rientjes@google.com,
mhocko@kernel.org, namit@vmware.com,
penguin-kernel@I-love.SAKURA.ne.jp, wei.w.wang@intel.com
Subject: [PATCH RFC] virtio_balloon: conservative balloon page shrinking
Date: Thu, 6 Feb 2020 16:01:47 +0800 [thread overview]
Message-ID: <1580976107-16013-1-git-send-email-wei.w.wang@intel.com> (raw)
There are cases that users want to shrink balloon pages after the
pagecache depleted. The conservative_shrinker lets the shrinker
shrink balloon pages when all the pagecache has been reclaimed.
Signed-off-by: Wei Wang <wei.w.wang@intel.com>
---
drivers/virtio/virtio_balloon.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 93f995f6cf36..b4c5bb13a867 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -42,6 +42,10 @@
static struct vfsmount *balloon_mnt;
#endif
+static bool conservative_shrinker = true;
+module_param(conservative_shrinker, bool, 0644);
+MODULE_PARM_DESC(conservative_shrinker, "conservatively shrink balloon pages");
+
enum virtio_balloon_vq {
VIRTIO_BALLOON_VQ_INFLATE,
VIRTIO_BALLOON_VQ_DEFLATE,
@@ -796,6 +800,10 @@ static unsigned long shrink_balloon_pages(struct virtio_balloon *vb,
{
unsigned long pages_freed = 0;
+ /* Balloon pages only gets shrunk when the pagecache depleted */
+ if (conservative_shrinker && global_node_page_state(NR_FILE_PAGES))
+ return 0;
+
/*
* One invocation of leak_balloon can deflate at most
* VIRTIO_BALLOON_ARRAY_PFNS_MAX balloon pages, so we call it
@@ -837,7 +845,11 @@ static unsigned long virtio_balloon_shrinker_count(struct shrinker *shrinker,
struct virtio_balloon, shrinker);
unsigned long count;
- count = vb->num_pages / VIRTIO_BALLOON_PAGES_PER_PAGE;
+ if (conservative_shrinker && global_node_page_state(NR_FILE_PAGES))
+ count = 0;
+ else
+ count = vb->num_pages / VIRTIO_BALLOON_PAGES_PER_PAGE;
+
count += vb->num_free_page_blocks * VIRTIO_BALLOON_HINT_BLOCK_PAGES;
return count;
--
2.17.1
next reply other threads:[~2020-02-06 8:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 8:01 Wei Wang [this message]
2020-02-06 9:04 ` [PATCH RFC] virtio_balloon: conservative balloon page shrinking Michael S. Tsirkin
2020-02-06 9:27 ` Wang, Wei W
2020-02-06 9:31 ` Michael S. Tsirkin
2020-02-06 9:43 ` Wang, Wei W
2020-02-06 11:26 ` Michael S. Tsirkin
2020-02-06 9:09 ` David Hildenbrand
2020-02-06 9:28 ` Wang, Wei W
2020-02-06 9:32 ` David Hildenbrand
2020-02-06 9:44 ` Wang, Wei W
2020-02-06 9:49 ` David Hildenbrand
2020-02-08 12:32 ` Tetsuo Handa
2020-02-10 3:13 ` Wang, Wei W
2020-02-10 3:57 ` Tetsuo Handa
2020-02-10 7:27 ` Wang, Wei W
2020-02-11 14:18 ` Tetsuo Handa
2020-02-14 20:22 ` Tyler Sanderson via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1580976107-16013-1-git-send-email-wei.w.wang@intel.com \
--to=wei.w.wang@intel.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=namit@vmware.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=tysand@google.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.