From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75844C35247 for ; Thu, 6 Feb 2020 19:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E68B218AC for ; Thu, 6 Feb 2020 19:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581017085; bh=bkq0KxZLo3XRlie+kpBDXiVW8St9bY8KFVpTZVoy8zM=; h=Subject:To:Cc:From:Date:List-ID:From; b=VpIAldJTibN5y0KPSzINLajgk4r7zu0HZ3/3yxpSoQE5inGq5KapPP2IAUKTnmlL+ Jz8BRKImsxilAeSKNnQR5CVEVSTjL1NmWMmS8R2IWa473jOFXBvISmcZyhcv9Uva6c AfNy9z0MAaeePO8p3k1z85erZrXtrsd9WlpafvHE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727979AbgBFTYo (ORCPT ); Thu, 6 Feb 2020 14:24:44 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38235 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727738AbgBFTYo (ORCPT ); Thu, 6 Feb 2020 14:24:44 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E2A9921DC6; Thu, 6 Feb 2020 14:24:43 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 06 Feb 2020 14:24:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=fFEwnW gD+xWTmJxzgxRjj+vA7Q1h5FpE5u6PMA650VI=; b=irr32GfP4ojNUQhGp8tMyC EL2HXRw6NZ8U9KaieBcXNwIG2dj3daaFxSepb2+S10Dq7e/12qvNEafflu5ioRQj xAfokQ1eKxSQc7HTU9ThUNYMvXQTTunmjvLACGqdhMoGnH1IXfRoCXXXxeHXzPQZ m14DkT9OzD6llEP4FHDZiAxg0xQgGJS7Y9NvKyL9Drbn+TsA72oXrikART9+XhhI JaoYMNNMSfHwB0ZmmvmG/9zq9pHE+TpVNcv7oIpMaJEiSYf9U4bd0DzaEuOSlkZY qzHSMVvWQbr0I4WqXSGhEYhv0KUMqp8l10IR0M4k2XlSrdKW0Vrh7GH9Wx5Mwufw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrheefgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvffhfffkgggtgfesthekredttd dtlfenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhr gheqnecukfhppeekfedrkeeirdekledruddtjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 7BFFA328005E; Thu, 6 Feb 2020 14:24:43 -0500 (EST) Subject: FAILED: patch "[PATCH] PCI: keystone: Fix link training retries initiation" failed to apply to 4.19-stable tree To: monakov.y@gmail.com, andrew.murray@arm.com, lorenzo.pieralisi@arm.com Cc: From: Date: Thu, 06 Feb 2020 20:06:45 +0100 Message-ID: <158101600590150@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 6df19872d881641e6394f93ef2938cffcbdae5bb Mon Sep 17 00:00:00 2001 From: Yurii Monakov Date: Tue, 17 Dec 2019 14:38:36 +0300 Subject: [PATCH] PCI: keystone: Fix link training retries initiation ks_pcie_stop_link() function does not clear LTSSM_EN_VAL bit so link training was not triggered more than once after startup. In configurations where link can be unstable during early boot, for example, under low temperature, it will never be established. Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver") Signed-off-by: Yurii Monakov Signed-off-by: Lorenzo Pieralisi Acked-by: Andrew Murray Cc: stable@vger.kernel.org diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index af677254a072..d4de4f6cff8b 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -510,7 +510,7 @@ static void ks_pcie_stop_link(struct dw_pcie *pci) /* Disable Link training */ val = ks_pcie_app_readl(ks_pcie, CMD_STATUS); val &= ~LTSSM_EN_VAL; - ks_pcie_app_writel(ks_pcie, CMD_STATUS, LTSSM_EN_VAL | val); + ks_pcie_app_writel(ks_pcie, CMD_STATUS, val); } static int ks_pcie_start_link(struct dw_pcie *pci)