From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C6EC35242 for ; Fri, 14 Feb 2020 06:48:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 136542187F for ; Fri, 14 Feb 2020 06:48:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jSgqUVdZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="mNOYLuie" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 136542187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hlKTACYP3X6UKTND/WIVQKdIWVb0YgjyHVdk59dbFEs=; b=jSgqUVdZw6VUEW rTtUD7zz+v2EZX5wB5xvhin9N500LfTczKLtEn4m3ZxLjp+ARUAq1ORePBExGWiosLN0UO9fw7isi CxzVF+lU8LeaKT3wN16BTVdCpv8lcTOfD0NZoj2Fo6xFOleHubOb9J/6/gtiOfZpExfqo6kW2rD+g 1QQGiBqZo9FaUoZ1p7F/7W4A8hmvcVsgYMnZ2aZDQdrWLwfxf08YBSuTGwcXszAeLP+C/BO6mL2ky 8tmzCM1h7MyKQMjwXdJ9w8mRUa/3vHvZjl8u38hYwMVpCZajlmkOYzvtnkzdciB/XWcujWKEV0Mac BXpvANRTAmVtvz796HuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2UmP-0003dE-Fn; Fri, 14 Feb 2020 06:48:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2UmF-0003Uh-1E; Fri, 14 Feb 2020 06:48:40 +0000 X-UUID: f115d0698aaa436380569af2208ee355-20200213 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=793AtRhL6KTU8oRy5ebaU3z1XDM9P+It3bT3YTeZoSU=; b=mNOYLuie8RFfAObLdxVKO47u9kXFV9XODlwdMQBEcAs/8GHTOLaBqkdm0YIMMXTK6xRaEKjsdVmN3S7XyjLLC8fcRMvcrbQ32vCQvHhtjySMHNWP+RXOIUVsnohSlwPNEbUNU1DMVrz/mMGiepG83AUfnrHOxmDNkYubsbdkY+g=; X-UUID: f115d0698aaa436380569af2208ee355-20200213 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 786401139; Thu, 13 Feb 2020 22:48:35 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 13 Feb 2020 22:48:32 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 14 Feb 2020 14:47:41 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 14 Feb 2020 14:48:32 +0800 Message-ID: <1581662912.17949.4.camel@mtksdaap41> Subject: Re: [PATCH 2/3] drm/mediatek: make sure previous message done or be aborted before send From: CK Hu To: Bibby Hsieh Date: Fri, 14 Feb 2020 14:48:32 +0800 In-Reply-To: <20200214044954.16923-2-bibby.hsieh@mediatek.com> References: <20200214044954.16923-1-bibby.hsieh@mediatek.com> <20200214044954.16923-2-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200213_224839_086768_84E0CA1F X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Fri, 2020-02-14 at 12:49 +0800, Bibby Hsieh wrote: > Mediatek CMDQ driver removed atomic parameter and implementation > related to atomic. DRM driver need to make sure previous message > done or be aborted before we send next message. > > If previous message is still waiting for event, it means the > setting hasn't been updated into display hardware register, > we can abort the message and send next message to update the > newest setting into display hardware. > If previous message already started, we have to wait it until > transmission has been completed. > > So we flush mbox client before we send new message to controller > driver. > Reviewed-by: CK Hu > This patch depends on ptach: > [0/3] Remove atomic_exec > https://patchwork.kernel.org/cover/11381677/ > > Signed-off-by: Bibby Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index 3c53ea22208c..e35b66c5ba0f 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -491,6 +491,7 @@ static void mtk_drm_crtc_hw_config(struct mtk_drm_crtc *mtk_crtc) > } > #if IS_ENABLED(CONFIG_MTK_CMDQ) > if (mtk_crtc->cmdq_client) { > + mbox_flush(mtk_crtc->cmdq_client->chan, 2000); > cmdq_handle = cmdq_pkt_create(mtk_crtc->cmdq_client, PAGE_SIZE); > cmdq_pkt_clear_event(cmdq_handle, mtk_crtc->cmdq_event); > cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event); _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38237C35242 for ; Fri, 14 Feb 2020 06:48:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BE382187F for ; Fri, 14 Feb 2020 06:48:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XySZFyBa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="mNOYLuie" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BE382187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OuG+TNpxNzPl3tjSskyBFN1z1/snnTpbvCPL2Ibp1YI=; b=XySZFyBaVjM+bG CfD5+6bD2CoLuoSAO/Zcg2eTK1W6oYeIW6GCnkVp587MlOzkssLLzTmAe1SzMZLe+KamkunxuDDh1 9dSqJVH9lC3V66ApMter8pZM/amxrA+y0slwb0S8F8+ipo4iqfoajLcwkC4T08mdluxYu+d+HJIgX mZgiRxVlkkGEPe73BDSbEk7CpXA83uF0cL2hG+0/vIwCV+K7Tai7Rn8LbhDi+k9OtYr6/Uw7xmpt8 mZdBx/2S/RtgVAnPYh9h04iJEvn6NoVGK9EqFLtpfOrevZGLvoVFsKEkMbwG1Zv2jAJ6OhzllWyQT tkT2cIwNVKZsifhtNZKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2UmI-0003VG-2b; Fri, 14 Feb 2020 06:48:42 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2UmF-0003Uh-1E; Fri, 14 Feb 2020 06:48:40 +0000 X-UUID: f115d0698aaa436380569af2208ee355-20200213 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=793AtRhL6KTU8oRy5ebaU3z1XDM9P+It3bT3YTeZoSU=; b=mNOYLuie8RFfAObLdxVKO47u9kXFV9XODlwdMQBEcAs/8GHTOLaBqkdm0YIMMXTK6xRaEKjsdVmN3S7XyjLLC8fcRMvcrbQ32vCQvHhtjySMHNWP+RXOIUVsnohSlwPNEbUNU1DMVrz/mMGiepG83AUfnrHOxmDNkYubsbdkY+g=; X-UUID: f115d0698aaa436380569af2208ee355-20200213 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 786401139; Thu, 13 Feb 2020 22:48:35 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 13 Feb 2020 22:48:32 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 14 Feb 2020 14:47:41 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 14 Feb 2020 14:48:32 +0800 Message-ID: <1581662912.17949.4.camel@mtksdaap41> Subject: Re: [PATCH 2/3] drm/mediatek: make sure previous message done or be aborted before send From: CK Hu To: Bibby Hsieh Date: Fri, 14 Feb 2020 14:48:32 +0800 In-Reply-To: <20200214044954.16923-2-bibby.hsieh@mediatek.com> References: <20200214044954.16923-1-bibby.hsieh@mediatek.com> <20200214044954.16923-2-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200213_224839_086768_84E0CA1F X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, YT Shen , Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Fri, 2020-02-14 at 12:49 +0800, Bibby Hsieh wrote: > Mediatek CMDQ driver removed atomic parameter and implementation > related to atomic. DRM driver need to make sure previous message > done or be aborted before we send next message. > > If previous message is still waiting for event, it means the > setting hasn't been updated into display hardware register, > we can abort the message and send next message to update the > newest setting into display hardware. > If previous message already started, we have to wait it until > transmission has been completed. > > So we flush mbox client before we send new message to controller > driver. > Reviewed-by: CK Hu > This patch depends on ptach: > [0/3] Remove atomic_exec > https://patchwork.kernel.org/cover/11381677/ > > Signed-off-by: Bibby Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index 3c53ea22208c..e35b66c5ba0f 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -491,6 +491,7 @@ static void mtk_drm_crtc_hw_config(struct mtk_drm_crtc *mtk_crtc) > } > #if IS_ENABLED(CONFIG_MTK_CMDQ) > if (mtk_crtc->cmdq_client) { > + mbox_flush(mtk_crtc->cmdq_client->chan, 2000); > cmdq_handle = cmdq_pkt_create(mtk_crtc->cmdq_client, PAGE_SIZE); > cmdq_pkt_clear_event(cmdq_handle, mtk_crtc->cmdq_event); > cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3473C35242 for ; Fri, 14 Feb 2020 06:48:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9C8C2187F for ; Fri, 14 Feb 2020 06:48:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="mNOYLuie" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9C8C2187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B5C16E44A; Fri, 14 Feb 2020 06:48:38 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTP id 914046E44A for ; Fri, 14 Feb 2020 06:48:36 +0000 (UTC) X-UUID: 8c8f9b2b36a54850b631df62dc69840b-20200214 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=793AtRhL6KTU8oRy5ebaU3z1XDM9P+It3bT3YTeZoSU=; b=mNOYLuie8RFfAObLdxVKO47u9kXFV9XODlwdMQBEcAs/8GHTOLaBqkdm0YIMMXTK6xRaEKjsdVmN3S7XyjLLC8fcRMvcrbQ32vCQvHhtjySMHNWP+RXOIUVsnohSlwPNEbUNU1DMVrz/mMGiepG83AUfnrHOxmDNkYubsbdkY+g=; X-UUID: 8c8f9b2b36a54850b631df62dc69840b-20200214 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 313290993; Fri, 14 Feb 2020 14:48:33 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 14 Feb 2020 14:47:41 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 14 Feb 2020 14:48:32 +0800 Message-ID: <1581662912.17949.4.camel@mtksdaap41> Subject: Re: [PATCH 2/3] drm/mediatek: make sure previous message done or be aborted before send From: CK Hu To: Bibby Hsieh Date: Fri, 14 Feb 2020 14:48:32 +0800 In-Reply-To: <20200214044954.16923-2-bibby.hsieh@mediatek.com> References: <20200214044954.16923-1-bibby.hsieh@mediatek.com> <20200214044954.16923-2-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Bibby: On Fri, 2020-02-14 at 12:49 +0800, Bibby Hsieh wrote: > Mediatek CMDQ driver removed atomic parameter and implementation > related to atomic. DRM driver need to make sure previous message > done or be aborted before we send next message. > > If previous message is still waiting for event, it means the > setting hasn't been updated into display hardware register, > we can abort the message and send next message to update the > newest setting into display hardware. > If previous message already started, we have to wait it until > transmission has been completed. > > So we flush mbox client before we send new message to controller > driver. > Reviewed-by: CK Hu > This patch depends on ptach: > [0/3] Remove atomic_exec > https://patchwork.kernel.org/cover/11381677/ > > Signed-off-by: Bibby Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index 3c53ea22208c..e35b66c5ba0f 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -491,6 +491,7 @@ static void mtk_drm_crtc_hw_config(struct mtk_drm_crtc *mtk_crtc) > } > #if IS_ENABLED(CONFIG_MTK_CMDQ) > if (mtk_crtc->cmdq_client) { > + mbox_flush(mtk_crtc->cmdq_client->chan, 2000); > cmdq_handle = cmdq_pkt_create(mtk_crtc->cmdq_client, PAGE_SIZE); > cmdq_pkt_clear_event(cmdq_handle, mtk_crtc->cmdq_event); > cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event); _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 834A0C35242 for ; Fri, 14 Feb 2020 06:48:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 462A1222C4 for ; Fri, 14 Feb 2020 06:48:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="mNOYLuie" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728761AbgBNGsk (ORCPT ); Fri, 14 Feb 2020 01:48:40 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:3591 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725897AbgBNGsk (ORCPT ); Fri, 14 Feb 2020 01:48:40 -0500 X-UUID: 8c8f9b2b36a54850b631df62dc69840b-20200214 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=793AtRhL6KTU8oRy5ebaU3z1XDM9P+It3bT3YTeZoSU=; b=mNOYLuie8RFfAObLdxVKO47u9kXFV9XODlwdMQBEcAs/8GHTOLaBqkdm0YIMMXTK6xRaEKjsdVmN3S7XyjLLC8fcRMvcrbQ32vCQvHhtjySMHNWP+RXOIUVsnohSlwPNEbUNU1DMVrz/mMGiepG83AUfnrHOxmDNkYubsbdkY+g=; X-UUID: 8c8f9b2b36a54850b631df62dc69840b-20200214 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 313290993; Fri, 14 Feb 2020 14:48:33 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 14 Feb 2020 14:47:41 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 14 Feb 2020 14:48:32 +0800 Message-ID: <1581662912.17949.4.camel@mtksdaap41> Subject: Re: [PATCH 2/3] drm/mediatek: make sure previous message done or be aborted before send From: CK Hu To: Bibby Hsieh CC: David Airlie , Matthias Brugger , Daniel Vetter , , , Philipp Zabel , YT Shen , Thierry Reding , , , , , Date: Fri, 14 Feb 2020 14:48:32 +0800 In-Reply-To: <20200214044954.16923-2-bibby.hsieh@mediatek.com> References: <20200214044954.16923-1-bibby.hsieh@mediatek.com> <20200214044954.16923-2-bibby.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIEJpYmJ5Og0KDQpPbiBGcmksIDIwMjAtMDItMTQgYXQgMTI6NDkgKzA4MDAsIEJpYmJ5IEhz aWVoIHdyb3RlOg0KPiBNZWRpYXRlayBDTURRIGRyaXZlciByZW1vdmVkIGF0b21pYyBwYXJhbWV0 ZXIgYW5kIGltcGxlbWVudGF0aW9uDQo+IHJlbGF0ZWQgdG8gYXRvbWljLiBEUk0gZHJpdmVyIG5l ZWQgdG8gbWFrZSBzdXJlIHByZXZpb3VzIG1lc3NhZ2UNCj4gZG9uZSBvciBiZSBhYm9ydGVkIGJl Zm9yZSB3ZSBzZW5kIG5leHQgbWVzc2FnZS4NCj4gDQo+IElmIHByZXZpb3VzIG1lc3NhZ2UgaXMg c3RpbGwgd2FpdGluZyBmb3IgZXZlbnQsIGl0IG1lYW5zIHRoZQ0KPiBzZXR0aW5nIGhhc24ndCBi ZWVuIHVwZGF0ZWQgaW50byBkaXNwbGF5IGhhcmR3YXJlIHJlZ2lzdGVyLA0KPiB3ZSBjYW4gYWJv cnQgdGhlIG1lc3NhZ2UgYW5kIHNlbmQgbmV4dCBtZXNzYWdlIHRvIHVwZGF0ZSB0aGUNCj4gbmV3 ZXN0IHNldHRpbmcgaW50byBkaXNwbGF5IGhhcmR3YXJlLg0KPiBJZiBwcmV2aW91cyBtZXNzYWdl IGFscmVhZHkgc3RhcnRlZCwgd2UgaGF2ZSB0byB3YWl0IGl0IHVudGlsDQo+IHRyYW5zbWlzc2lv biBoYXMgYmVlbiBjb21wbGV0ZWQuDQo+IA0KPiBTbyB3ZSBmbHVzaCBtYm94IGNsaWVudCBiZWZv cmUgd2Ugc2VuZCBuZXcgbWVzc2FnZSB0byBjb250cm9sbGVyDQo+IGRyaXZlci4NCj4gDQoNClJl dmlld2VkLWJ5OiBDSyBIdSA8Y2suaHVAbWVkaWF0ZWsuY29tPg0KDQo+IFRoaXMgcGF0Y2ggZGVw ZW5kcyBvbiBwdGFjaDoNCj4gWzAvM10gUmVtb3ZlIGF0b21pY19leGVjDQo+IGh0dHBzOi8vcGF0 Y2h3b3JrLmtlcm5lbC5vcmcvY292ZXIvMTEzODE2NzcvDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBC aWJieSBIc2llaCA8YmliYnkuaHNpZWhAbWVkaWF0ZWsuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMv Z3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyB8IDEgKw0KPiAgMSBmaWxlIGNoYW5nZWQs IDEgaW5zZXJ0aW9uKCspDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21lZGlh dGVrL210a19kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0 Yy5jDQo+IGluZGV4IDNjNTNlYTIyMjA4Yy4uZTM1YjY2YzViYTBmIDEwMDY0NA0KPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMNCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQo+IEBAIC00OTEsNiArNDkxLDcgQEAgc3Rh dGljIHZvaWQgbXRrX2RybV9jcnRjX2h3X2NvbmZpZyhzdHJ1Y3QgbXRrX2RybV9jcnRjICptdGtf Y3J0YykNCj4gIAl9DQo+ICAjaWYgSVNfRU5BQkxFRChDT05GSUdfTVRLX0NNRFEpDQo+ICAJaWYg KG10a19jcnRjLT5jbWRxX2NsaWVudCkgew0KPiArCQltYm94X2ZsdXNoKG10a19jcnRjLT5jbWRx X2NsaWVudC0+Y2hhbiwgMjAwMCk7DQo+ICAJCWNtZHFfaGFuZGxlID0gY21kcV9wa3RfY3JlYXRl KG10a19jcnRjLT5jbWRxX2NsaWVudCwgUEFHRV9TSVpFKTsNCj4gIAkJY21kcV9wa3RfY2xlYXJf ZXZlbnQoY21kcV9oYW5kbGUsIG10a19jcnRjLT5jbWRxX2V2ZW50KTsNCj4gIAkJY21kcV9wa3Rf d2ZlKGNtZHFfaGFuZGxlLCBtdGtfY3J0Yy0+Y21kcV9ldmVudCk7DQoNCg==