From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C01DCC3B1A4 for ; Fri, 14 Feb 2020 16:41:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 901D52468E for ; Fri, 14 Feb 2020 16:41:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="YFofNpbv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405467AbgBNQWc (ORCPT ); Fri, 14 Feb 2020 11:22:32 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:45247 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2405454AbgBNQWa (ORCPT ); Fri, 14 Feb 2020 11:22:30 -0500 X-UUID: 5c86b13085f6448bb26c2de4c3496cdc-20200215 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jz50ovHuZ2AHAX6u5vv4PbRhypnsxyFahZczIki6Y+E=; b=YFofNpbvXaSGOcwur6pHAuRri8d4esErOX8+TM0/XglRKiFQiwvWboVD0cVMZbcO4eEg2Bdu3tvLWNbuHdZoNaqJMwcHCdjwAIJky3BCpeSYZXezShWXG87N07MBXE51OUsM5wvD2SrQ7ifnP7mUs3ps5CjZZY0WwXbPVfnDd3Y=; X-UUID: 5c86b13085f6448bb26c2de4c3496cdc-20200215 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1937256230; Sat, 15 Feb 2020 00:22:25 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 15 Feb 2020 00:21:35 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 15 Feb 2020 00:22:21 +0800 Message-ID: <1581697343.12471.4.camel@mtksdaap41> Subject: Re: [PATCH v7 01/13] dt-bindings: arm: move mmsys description to display From: CK Hu To: Enric Balletbo i Serra , Matthias Brugger CC: , , , , , , , , , Weiyi Lu , , mtk01761 , , , , , , , , , , Matthias Brugger , , , , Daniel Vetter Date: Sat, 15 Feb 2020 00:22:23 +0800 In-Reply-To: <022e8f64-b414-67a5-722e-bdd7c00230ff@collabora.com> References: <20200213201953.15268-1-matthias.bgg@kernel.org> <20200213201953.15268-2-matthias.bgg@kernel.org> <1581662577.17949.3.camel@mtksdaap41> <2bda2dd7-9ed2-8b4c-897e-e585ccfa1fa5@gmail.com> <022e8f64-b414-67a5-722e-bdd7c00230ff@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org SGksIE1hdHRoaWFzICYgRW5yaWM6DQoNCk9uIEZyaSwgMjAyMC0wMi0xNCBhdCAxMzoxOSArMDEw MCwgRW5yaWMgQmFsbGV0Ym8gaSBTZXJyYSB3cm90ZToNCj4gSGkgQ0ssDQo+IA0KPiBPbiAxNC8y LzIwIDExOjAxLCBNYXR0aGlhcyBCcnVnZ2VyIHdyb3RlOg0KPiA+IA0KPiA+IA0KPiA+IE9uIDE0 LzAyLzIwMjAgMDc6NDIsIENLIEh1IHdyb3RlOg0KPiA+PiBIaSwgTWF0dGhpYXM6DQo+ID4+DQo+ ID4+IE9uIFRodSwgMjAyMC0wMi0xMyBhdCAyMToxOSArMDEwMCwgbWF0dGhpYXMuYmdnQGtlcm5l bC5vcmcgd3JvdGU6DQo+ID4+PiBGcm9tOiBNYXR0aGlhcyBCcnVnZ2VyIDxtYnJ1Z2dlckBzdXNl LmNvbT4NCj4gPj4+DQo+ID4+PiBUaGUgbW1zeXMgYmxvY2sgcHJvdmlkZXMgcmVnaXN0ZXJzIGFu ZCBjbG9ja3MgZm9yIHRoZSBkaXNwbGF5DQo+ID4+PiBzdWJzeXN0ZW0uIFRoZSBiaW5kaW5nIGRl c2NyaXB0aW9uIHNob3VsZCB0aGVyZWZvcmUgbGl2ZSB0b2dldGhlciB3aXRoDQo+ID4+PiB0aGUg cmVzdCBvZiB0aGUgZGlzcGxheSBkZXNjcmlwdGlvbnMuIE1vdmUgaXQgdG8gZGlzcGxheS9tZWRp YXRlay4NCj4gPj4+DQo+ID4+DQo+ID4+IFllcywgZm9yIHRoZSB1cHN0cmVhbWVkIGRyaXZlciwg b25seSBkaXNwbGF5IChEUk0pIHVzZSBtbXN5cyBjbG9jay4gRm9yDQo+ID4+IHNvbWUgTURQIHBh dGNoZXMgWzFdIGluIHByb2dyZXNzLCBNRFAgYWxzbyB1c2UgbW1zeXMgY2xvY2suIFNvIHdlIGp1 c3QNCj4gPj4gY29uc2lkZXIgd2hhdCdzIHVwc3RyZWFtZWQgbm93Pw0KPiA+IA0KPiANCj4gTGV0 IG1lIGp1bXAgaW50byB0aGUgZGlzY3Vzc2lvbiwgYW5kIHNvcnJ5IGlmIG15IHF1ZXN0aW9uIGlz IHNpbGx5IGJlY2F1c2UgSSdtDQo+IGp1c3Qgc3RhcnRpbmcgdG8gbG9vayBhdCB0aGlzIGNvZGUu DQo+IA0KPiBJTU8gd2Ugc2hvdWxkIGNvbnNpZGVyIGFsbCB0aGUgY2FzZXMgdG8gZmluZCBhIHBy b3BlciBmaXggb24gYWxsIHRoaXMsIGFuZCBpZg0KPiBNRFAgdXNlcyBhbHNvIG1tc3lzIGNsb2Nr cyB0aGlzIGFwcHJvYWNoIHdpbGwgbm90IHdvcmsuIEkgdGhpbmsgdGhlIG1haW4gcHJvYmxlbQ0K PiBoZXJlIGFuZCB0aGUgYmlnIHF1ZXN0aW9uIGlzIHdoYXQgZXhhY3RseSBpcyB0aGUgTU1TWVMg YmxvY2ssIGlzIGFuIGluZGVwZW5kZW50DQo+IGNsb2NrIGNvbnRyb2xsZXIgdGhhdCBwcm92aWRl cyBjbG9ja3MgdG8gRFJNIGFuZCBvdGhlciBibG9ja3M/IG9yIGlzIGhhcmRseSB0aWVkDQo+IHRv IHRoZSBEUk0gYmxvY2sgaW4gc29tZSB3YXk/DQo+IA0KPiBDb3VsZCB5b3UgZ2l2ZSB1cyBhIGJs b2NrIHNjaGVtYSBvbiBob3cgdGhlIHRoaW5ncyBhcmUgaW50ZXJjb25uZWN0ZWQ/DQo+IA0KPiBJ ZiBpcyBhbiBpbmRlcGVuZGVudCBjbG9jayBjb250cm9sbGVyIEkgdGhpbmsgdGhlcmUgd2FzIGEg bWlzdGFrZSB3aGVuIHRoZSBmaXJzdA0KPiBkcm0gZHJpdmVyIHdhcyBwdXNoZWQgYnkgdXNpbmcg dGhlIGNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQ4MTczLW1tc3lzIiBhcyBpZA0KPiBmb3IgdGhh dCBkcml2ZXIuDQo+IA0KDQpJIGNvcnJlY3QgbXkgbWlzdGFrZSBmaXJzdC4gSW4gbXQ4MTczLCBt ZHAgaGFzIGFscmVhZHkgdXBzdHJlYW1lZCBbMV0uDQoNClRoZXJlIGFyZSBtYW55IHBhcnRpdGlv bnMgaW4gTWVkaWF0ZWsgU29DLiBtbXN5cyBpcyBvbmUgb2YgdGhlc2UNCnBhcnRpdGlvbi4gVGhl cmUgYXJlIG1hbnkgZnVuY3Rpb24gYmxvY2tzIGluIG1tc3lzIHN1Y2ggYXMgT1ZMLCBSRE1BLA0K UlNaLCBXUk9ULCAuLi4uIFNvbWUgZGF0YSByb3V0aW5nIGJldHdlZW4gdGhlc2UgYmxvY2tzIGFy ZSBmaXhlZCBidXQNCnNvbWUgYXJlIGNoYW5nZWFibGUuIEZvciBhcHBsaWNhdGlvbiwgd2UgZ3Jv dXAgdGhlbSBpbnRvIGRpc3BsYXkgcGF0aA0KYW5kIG1kcCBwYXRoLiBDbG9jayBnYXRpbmcgcmVn aXN0ZXIgb2YgdGhlc2UgYmxvY2tzIGFyZSBpbiB0aGUgcmFuZ2Ugb2YNCjB4MTQwMDAwMDAgfiAw eDE0MDAwZmZmLiBUaGUgcm91dGluZyBjb250cm9sIHJlZ2lzdGVyIG9mIHRoZXNlIGJsb2Nrcw0K YXJlIGFsc28gaW4gdGhlIHJhbmdlIG9mIDB4MTQwMDAwMDAgfiAweDE0MDAwZmZmLiBTbyB0aGUg Y29udHJvbA0KZnVuY3Rpb24gYmVsb25nIHRvIG1tc3lzIHBhcnRpdGlvbiBidXQgbm90IGJlbG9u ZyB0byBzcGVjaWZpYyBmdW5jdGlvbg0KYmxvY2sgd291bGQgaW4gdGhlIHJlZ2lzdGVyIHJhbmdl IG9mIDB4MTQwMDAwMDAgfiAweDE0MDAwZmZmLiBJIHRoaW5rDQp0aGVyZSBjb3VsZCBiZSB0d28g ZGVmaW5pdGlvbiBvZiBtbXN5cyBkZXZpY2UuIE9uZSBpcyB0aGF0IG1tc3lzIGRldmljZQ0KaXMg dGhlIHdob2xlIG1tc3lzIHBhcnRpb3Rpb24sIHNvIE9WTCwgUkRNQSwgLi4uIHdvdWxkIGJlIHN1 YiBkZXZpY2Ugb2YNCml0LiBBbm90aGVyIGlzIHRoYXQgbW1zeXMganVzdCBjb250cm9sIHJlZ2lz dGVyIG9mIDB4MTQwMDAwMDAgfg0KMHgxNDAwMGZmZiwgc28gaXQncyBwYXJ0IG9mIG1tc3lzIHBh cnRpdGlvbiBsaWtlIE9WTCwgUkRNQSwgLi4uLi4NCkN1cnJlbnRseSB3ZSBkZWZpbmUgbW1zeXMg YXMgdGhlIGxhdHRlciBvbmUuIEkndmUgbm8gaWRlYSBob3cgdG8gbWFwDQptbXN5cyBpbnRvIGN1 cnJlbnQgTGludXggaGFyZHdhcmUgY2F0ZWdvcnksIGJ1dCBJIHRoaW5rIGl0IGlzIG5vdCBqdXN0 IGENCmRpc3BsYXkgZGV2aWNlLg0KDQpbMV0NCmh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3Nj bS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL2FyY2gvYXJtNjQvYm9v dC9kdHMvbWVkaWF0ZWsvbXQ4MTczLmR0c2k/aD12NS42LXJjMQ0KDQpSZWdhcmRzLA0KQ0sNCg0K PiBUaGFua3MsDQo+ICBFbnJpYw0KPiANCj4gDQo+ID4gSSdtIG5vdCBzdXJlIGlmIEkgdW5kZXJz dGFuZCB5b3UgY29ycmVjdGx5LiBBcmUgeW91IHByb3Bvc2luZyB0byBrZWVwIHRoZQ0KPiA+IGJp bmRpbmcgZGVzY3JpcHRpb24gaW4gYXJtL21lZGlhdGVrPw0KPiA+IA0KPiA+IFJlZ2FyZHMsDQo+ ID4gTWF0dGhpYXMNCj4gPiANCj4gPj4NCj4gPj4gWzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5l bC5vcmcvcGF0Y2gvMTExNDA3NDcvDQo+ID4+DQo+ID4+IFJlZ2FyZHMsDQo+ID4+IENLDQo+ID4+ DQo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBNYXR0aGlhcyBCcnVnZ2VyIDxtYnJ1Z2dlckBzdXNlLmNv bT4NCj4gPj4+DQo+ID4+PiAtLS0NCj4gPj4+DQo+ID4+PiBDaGFuZ2VzIGluIHY3Og0KPiA+Pj4g LSBtb3ZlIHRoZSBiaW5kaW5nIGRlc2NyaXB0aW9uDQo+ID4+Pg0KPiA+Pj4gQ2hhbmdlcyBpbiB2 NjogTm9uZQ0KPiA+Pj4gQ2hhbmdlcyBpbiB2NTogTm9uZQ0KPiA+Pj4gQ2hhbmdlcyBpbiB2NDog Tm9uZQ0KPiA+Pj4gQ2hhbmdlcyBpbiB2MzogTm9uZQ0KPiA+Pj4gQ2hhbmdlcyBpbiB2MjogTm9u ZQ0KPiA+Pj4NCj4gPj4+ICAuLi4vYmluZGluZ3Mve2FybSA9PiBkaXNwbGF5fS9tZWRpYXRlay9t ZWRpYXRlayxtbXN5cy50eHQgICAgICAgICB8IDANCj4gPj4+ICAxIGZpbGUgY2hhbmdlZCwgMCBp bnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQ0KPiA+Pj4gIHJlbmFtZSBEb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3Mve2FybSA9PiBkaXNwbGF5fS9tZWRpYXRlay9tZWRpYXRlayxt bXN5cy50eHQgKDEwMCUpDQo+ID4+Pg0KPiA+Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vbWVkaWF0ZWsvbWVkaWF0ZWssbW1zeXMudHh0IGIvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvbWVkaWF0ZWsvbWVkaWF0ZWss bW1zeXMudHh0DQo+ID4+PiBzaW1pbGFyaXR5IGluZGV4IDEwMCUNCj4gPj4+IHJlbmFtZSBmcm9t IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vbWVkaWF0ZWsvbWVkaWF0ZWss bW1zeXMudHh0DQo+ID4+PiByZW5hbWUgdG8gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2Rpc3BsYXkvbWVkaWF0ZWsvbWVkaWF0ZWssbW1zeXMudHh0DQo+ID4+DQo+ID4+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+ID4+IGxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0DQo+ID4+IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZw0KPiA+PiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwNCj4gPj4NCj4gDQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fDQo+IExpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlzdA0KPiBM aW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnDQo+IGh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91370C2BA83 for ; Fri, 14 Feb 2020 16:59:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58B322067D for ; Fri, 14 Feb 2020 16:59:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Rlxgysyi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="YFofNpbv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58B322067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8zcPLiD1ziAxsh04KQkF3jXbZLe/NcQBN8D5L+8CwC8=; b=RlxgysyiBMAGW+ 18j8S34jl0ywFTWwMEF1vnmP5qox24fR3UCYFKkTRs11EBvQEBxi5nPomAA+chJfh/cWdzFemsBME qKrCYV9UQmmaE7y0LbMhtWEmxIy1TV6jQAJoLnhYdkltLv32qApfP3HV8H9Lz4VJavvEQtfq+wjGX JrHKg4K8iaDG1jJlTDHq6+XaBsOuQKLuTLTwxfWOyVnjJtj6K+JZGrrIWj9LEbajP5gnVI+g1wbG7 vYfEfpq2Mhz5+lEduihxiuyWkdMSq+ahN7WSvbsIfBLNdMuBxOr5Bnu1jnlbrCJFaFYwEfdZlllov YiUIv9SHJ9DJOIy2xTlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2eJL-0008KB-Iq; Fri, 14 Feb 2020 16:59:27 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2dtJ-0001Be-0c; Fri, 14 Feb 2020 16:32:36 +0000 X-UUID: 2d557a2cf9294a1488d2d52c09ee7ced-20200214 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jz50ovHuZ2AHAX6u5vv4PbRhypnsxyFahZczIki6Y+E=; b=YFofNpbvXaSGOcwur6pHAuRri8d4esErOX8+TM0/XglRKiFQiwvWboVD0cVMZbcO4eEg2Bdu3tvLWNbuHdZoNaqJMwcHCdjwAIJky3BCpeSYZXezShWXG87N07MBXE51OUsM5wvD2SrQ7ifnP7mUs3ps5CjZZY0WwXbPVfnDd3Y=; X-UUID: 2d557a2cf9294a1488d2d52c09ee7ced-20200214 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1600719844; Fri, 14 Feb 2020 08:32:27 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 14 Feb 2020 08:22:25 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 15 Feb 2020 00:21:35 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 15 Feb 2020 00:22:21 +0800 Message-ID: <1581697343.12471.4.camel@mtksdaap41> Subject: Re: [PATCH v7 01/13] dt-bindings: arm: move mmsys description to display From: CK Hu To: Enric Balletbo i Serra , Matthias Brugger Date: Sat, 15 Feb 2020 00:22:23 +0800 In-Reply-To: <022e8f64-b414-67a5-722e-bdd7c00230ff@collabora.com> References: <20200213201953.15268-1-matthias.bgg@kernel.org> <20200213201953.15268-2-matthias.bgg@kernel.org> <1581662577.17949.3.camel@mtksdaap41> <2bda2dd7-9ed2-8b4c-897e-e585ccfa1fa5@gmail.com> <022e8f64-b414-67a5-722e-bdd7c00230ff@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_083233_095257_F458C462 X-CRM114-Status: GOOD ( 24.12 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, linux-clk@vger.kernel.org, drinkcat@chromium.org, Weiyi Lu , wens@csie.org, mtk01761 , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Daniel Vetter , frank-w@public-files.de, sean.wang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , sboyd@kernel.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, matthias.bgg@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Matthias & Enric: On Fri, 2020-02-14 at 13:19 +0100, Enric Balletbo i Serra wrote: > Hi CK, > > On 14/2/20 11:01, Matthias Brugger wrote: > > > > > > On 14/02/2020 07:42, CK Hu wrote: > >> Hi, Matthias: > >> > >> On Thu, 2020-02-13 at 21:19 +0100, matthias.bgg@kernel.org wrote: > >>> From: Matthias Brugger > >>> > >>> The mmsys block provides registers and clocks for the display > >>> subsystem. The binding description should therefore live together with > >>> the rest of the display descriptions. Move it to display/mediatek. > >>> > >> > >> Yes, for the upstreamed driver, only display (DRM) use mmsys clock. For > >> some MDP patches [1] in progress, MDP also use mmsys clock. So we just > >> consider what's upstreamed now? > > > > Let me jump into the discussion, and sorry if my question is silly because I'm > just starting to look at this code. > > IMO we should consider all the cases to find a proper fix on all this, and if > MDP uses also mmsys clocks this approach will not work. I think the main problem > here and the big question is what exactly is the MMSYS block, is an independent > clock controller that provides clocks to DRM and other blocks? or is hardly tied > to the DRM block in some way? > > Could you give us a block schema on how the things are interconnected? > > If is an independent clock controller I think there was a mistake when the first > drm driver was pushed by using the compatible = "mediatek,mt8173-mmsys" as id > for that driver. > I correct my mistake first. In mt8173, mdp has already upstreamed [1]. There are many partitions in Mediatek SoC. mmsys is one of these partition. There are many function blocks in mmsys such as OVL, RDMA, RSZ, WROT, .... Some data routing between these blocks are fixed but some are changeable. For application, we group them into display path and mdp path. Clock gating register of these blocks are in the range of 0x14000000 ~ 0x14000fff. The routing control register of these blocks are also in the range of 0x14000000 ~ 0x14000fff. So the control function belong to mmsys partition but not belong to specific function block would in the register range of 0x14000000 ~ 0x14000fff. I think there could be two definition of mmsys device. One is that mmsys device is the whole mmsys partiotion, so OVL, RDMA, ... would be sub device of it. Another is that mmsys just control register of 0x14000000 ~ 0x14000fff, so it's part of mmsys partition like OVL, RDMA, ..... Currently we define mmsys as the latter one. I've no idea how to map mmsys into current Linux hardware category, but I think it is not just a display device. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/mediatek/mt8173.dtsi?h=v5.6-rc1 Regards, CK > Thanks, > Enric > > > > I'm not sure if I understand you correctly. Are you proposing to keep the > > binding description in arm/mediatek? > > > > Regards, > > Matthias > > > >> > >> [1] https://patchwork.kernel.org/patch/11140747/ > >> > >> Regards, > >> CK > >> > >>> Signed-off-by: Matthias Brugger > >>> > >>> --- > >>> > >>> Changes in v7: > >>> - move the binding description > >>> > >>> Changes in v6: None > >>> Changes in v5: None > >>> Changes in v4: None > >>> Changes in v3: None > >>> Changes in v2: None > >>> > >>> .../bindings/{arm => display}/mediatek/mediatek,mmsys.txt | 0 > >>> 1 file changed, 0 insertions(+), 0 deletions(-) > >>> rename Documentation/devicetree/bindings/{arm => display}/mediatek/mediatek,mmsys.txt (100%) > >>> > >>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt > >>> similarity index 100% > >>> rename from Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > >>> rename to Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt > >> > >> _______________________________________________ > >> linux-arm-kernel mailing list > >> linux-arm-kernel@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >> > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0895C3B1A4 for ; Fri, 14 Feb 2020 16:59:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91B9B2067D for ; Fri, 14 Feb 2020 16:59:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="udQgO0Pb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="YFofNpbv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91B9B2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ujn7o/uLFVMuhQKscBd2pVxzCVn8vDwGNO/iR9jJoWI=; b=udQgO0PbbEH+6L 8PvHHPEEPCZnq1hhm/OTrQM7el+Y7DfzsxvMxiRNwLYdxf7nUKif8YeKt1BsrSMPORB0MyXjijqtp FsUkF0KdefGrUUMb7cXneH/Q8g7yQHDdQACHCIrCdyDWVSrJwVb2UF8JosjjaPmJbRO1lm413bWoG p2O4skIzALg+LQbxjEN1N22u9KIc1/GHWkAtdH1Fpq4jXvl5AX36KiMNURU73RE644XocoqUhzg1q DZstRU7PElZ1yXLtfvnv0Q/r3NRDZayGq/BxktO2YDmnUHjWOqityLOqZObwTTeeEhG6KiMQsS17F 6g5rkAM33TbbnXq5sF3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2eJS-0008Of-PY; Fri, 14 Feb 2020 16:59:34 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2dtJ-0001Be-0c; Fri, 14 Feb 2020 16:32:36 +0000 X-UUID: 2d557a2cf9294a1488d2d52c09ee7ced-20200214 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jz50ovHuZ2AHAX6u5vv4PbRhypnsxyFahZczIki6Y+E=; b=YFofNpbvXaSGOcwur6pHAuRri8d4esErOX8+TM0/XglRKiFQiwvWboVD0cVMZbcO4eEg2Bdu3tvLWNbuHdZoNaqJMwcHCdjwAIJky3BCpeSYZXezShWXG87N07MBXE51OUsM5wvD2SrQ7ifnP7mUs3ps5CjZZY0WwXbPVfnDd3Y=; X-UUID: 2d557a2cf9294a1488d2d52c09ee7ced-20200214 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1600719844; Fri, 14 Feb 2020 08:32:27 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 14 Feb 2020 08:22:25 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 15 Feb 2020 00:21:35 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 15 Feb 2020 00:22:21 +0800 Message-ID: <1581697343.12471.4.camel@mtksdaap41> Subject: Re: [PATCH v7 01/13] dt-bindings: arm: move mmsys description to display From: CK Hu To: Enric Balletbo i Serra , Matthias Brugger Date: Sat, 15 Feb 2020 00:22:23 +0800 In-Reply-To: <022e8f64-b414-67a5-722e-bdd7c00230ff@collabora.com> References: <20200213201953.15268-1-matthias.bgg@kernel.org> <20200213201953.15268-2-matthias.bgg@kernel.org> <1581662577.17949.3.camel@mtksdaap41> <2bda2dd7-9ed2-8b4c-897e-e585ccfa1fa5@gmail.com> <022e8f64-b414-67a5-722e-bdd7c00230ff@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_083233_095257_F458C462 X-CRM114-Status: GOOD ( 24.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, linux-clk@vger.kernel.org, drinkcat@chromium.org, Weiyi Lu , wens@csie.org, mtk01761 , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Daniel Vetter , frank-w@public-files.de, sean.wang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , sboyd@kernel.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, matthias.bgg@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Matthias & Enric: On Fri, 2020-02-14 at 13:19 +0100, Enric Balletbo i Serra wrote: > Hi CK, > > On 14/2/20 11:01, Matthias Brugger wrote: > > > > > > On 14/02/2020 07:42, CK Hu wrote: > >> Hi, Matthias: > >> > >> On Thu, 2020-02-13 at 21:19 +0100, matthias.bgg@kernel.org wrote: > >>> From: Matthias Brugger > >>> > >>> The mmsys block provides registers and clocks for the display > >>> subsystem. The binding description should therefore live together with > >>> the rest of the display descriptions. Move it to display/mediatek. > >>> > >> > >> Yes, for the upstreamed driver, only display (DRM) use mmsys clock. For > >> some MDP patches [1] in progress, MDP also use mmsys clock. So we just > >> consider what's upstreamed now? > > > > Let me jump into the discussion, and sorry if my question is silly because I'm > just starting to look at this code. > > IMO we should consider all the cases to find a proper fix on all this, and if > MDP uses also mmsys clocks this approach will not work. I think the main problem > here and the big question is what exactly is the MMSYS block, is an independent > clock controller that provides clocks to DRM and other blocks? or is hardly tied > to the DRM block in some way? > > Could you give us a block schema on how the things are interconnected? > > If is an independent clock controller I think there was a mistake when the first > drm driver was pushed by using the compatible = "mediatek,mt8173-mmsys" as id > for that driver. > I correct my mistake first. In mt8173, mdp has already upstreamed [1]. There are many partitions in Mediatek SoC. mmsys is one of these partition. There are many function blocks in mmsys such as OVL, RDMA, RSZ, WROT, .... Some data routing between these blocks are fixed but some are changeable. For application, we group them into display path and mdp path. Clock gating register of these blocks are in the range of 0x14000000 ~ 0x14000fff. The routing control register of these blocks are also in the range of 0x14000000 ~ 0x14000fff. So the control function belong to mmsys partition but not belong to specific function block would in the register range of 0x14000000 ~ 0x14000fff. I think there could be two definition of mmsys device. One is that mmsys device is the whole mmsys partiotion, so OVL, RDMA, ... would be sub device of it. Another is that mmsys just control register of 0x14000000 ~ 0x14000fff, so it's part of mmsys partition like OVL, RDMA, ..... Currently we define mmsys as the latter one. I've no idea how to map mmsys into current Linux hardware category, but I think it is not just a display device. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/mediatek/mt8173.dtsi?h=v5.6-rc1 Regards, CK > Thanks, > Enric > > > > I'm not sure if I understand you correctly. Are you proposing to keep the > > binding description in arm/mediatek? > > > > Regards, > > Matthias > > > >> > >> [1] https://patchwork.kernel.org/patch/11140747/ > >> > >> Regards, > >> CK > >> > >>> Signed-off-by: Matthias Brugger > >>> > >>> --- > >>> > >>> Changes in v7: > >>> - move the binding description > >>> > >>> Changes in v6: None > >>> Changes in v5: None > >>> Changes in v4: None > >>> Changes in v3: None > >>> Changes in v2: None > >>> > >>> .../bindings/{arm => display}/mediatek/mediatek,mmsys.txt | 0 > >>> 1 file changed, 0 insertions(+), 0 deletions(-) > >>> rename Documentation/devicetree/bindings/{arm => display}/mediatek/mediatek,mmsys.txt (100%) > >>> > >>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt > >>> similarity index 100% > >>> rename from Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > >>> rename to Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt > >> > >> _______________________________________________ > >> linux-arm-kernel mailing list > >> linux-arm-kernel@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >> > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46090C2BA83 for ; Fri, 14 Feb 2020 16:22:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DE27246D5 for ; Fri, 14 Feb 2020 16:22:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="YFofNpbv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DE27246D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 60EC76FB26; Fri, 14 Feb 2020 16:22:31 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id BE87D6FB19 for ; Fri, 14 Feb 2020 16:22:29 +0000 (UTC) X-UUID: 5c86b13085f6448bb26c2de4c3496cdc-20200215 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jz50ovHuZ2AHAX6u5vv4PbRhypnsxyFahZczIki6Y+E=; b=YFofNpbvXaSGOcwur6pHAuRri8d4esErOX8+TM0/XglRKiFQiwvWboVD0cVMZbcO4eEg2Bdu3tvLWNbuHdZoNaqJMwcHCdjwAIJky3BCpeSYZXezShWXG87N07MBXE51OUsM5wvD2SrQ7ifnP7mUs3ps5CjZZY0WwXbPVfnDd3Y=; X-UUID: 5c86b13085f6448bb26c2de4c3496cdc-20200215 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1937256230; Sat, 15 Feb 2020 00:22:25 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 15 Feb 2020 00:21:35 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 15 Feb 2020 00:22:21 +0800 Message-ID: <1581697343.12471.4.camel@mtksdaap41> Subject: Re: [PATCH v7 01/13] dt-bindings: arm: move mmsys description to display From: CK Hu To: Enric Balletbo i Serra , Matthias Brugger Date: Sat, 15 Feb 2020 00:22:23 +0800 In-Reply-To: <022e8f64-b414-67a5-722e-bdd7c00230ff@collabora.com> References: <20200213201953.15268-1-matthias.bgg@kernel.org> <20200213201953.15268-2-matthias.bgg@kernel.org> <1581662577.17949.3.camel@mtksdaap41> <2bda2dd7-9ed2-8b4c-897e-e585ccfa1fa5@gmail.com> <022e8f64-b414-67a5-722e-bdd7c00230ff@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, linux-clk@vger.kernel.org, drinkcat@chromium.org, Weiyi Lu , wens@csie.org, mtk01761 , linux-media@vger.kernel.org, devicetree@vger.kernel.org, frank-w@public-files.de, sean.wang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , sboyd@kernel.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, matthias.bgg@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Matthias & Enric: On Fri, 2020-02-14 at 13:19 +0100, Enric Balletbo i Serra wrote: > Hi CK, > > On 14/2/20 11:01, Matthias Brugger wrote: > > > > > > On 14/02/2020 07:42, CK Hu wrote: > >> Hi, Matthias: > >> > >> On Thu, 2020-02-13 at 21:19 +0100, matthias.bgg@kernel.org wrote: > >>> From: Matthias Brugger > >>> > >>> The mmsys block provides registers and clocks for the display > >>> subsystem. The binding description should therefore live together with > >>> the rest of the display descriptions. Move it to display/mediatek. > >>> > >> > >> Yes, for the upstreamed driver, only display (DRM) use mmsys clock. For > >> some MDP patches [1] in progress, MDP also use mmsys clock. So we just > >> consider what's upstreamed now? > > > > Let me jump into the discussion, and sorry if my question is silly because I'm > just starting to look at this code. > > IMO we should consider all the cases to find a proper fix on all this, and if > MDP uses also mmsys clocks this approach will not work. I think the main problem > here and the big question is what exactly is the MMSYS block, is an independent > clock controller that provides clocks to DRM and other blocks? or is hardly tied > to the DRM block in some way? > > Could you give us a block schema on how the things are interconnected? > > If is an independent clock controller I think there was a mistake when the first > drm driver was pushed by using the compatible = "mediatek,mt8173-mmsys" as id > for that driver. > I correct my mistake first. In mt8173, mdp has already upstreamed [1]. There are many partitions in Mediatek SoC. mmsys is one of these partition. There are many function blocks in mmsys such as OVL, RDMA, RSZ, WROT, .... Some data routing between these blocks are fixed but some are changeable. For application, we group them into display path and mdp path. Clock gating register of these blocks are in the range of 0x14000000 ~ 0x14000fff. The routing control register of these blocks are also in the range of 0x14000000 ~ 0x14000fff. So the control function belong to mmsys partition but not belong to specific function block would in the register range of 0x14000000 ~ 0x14000fff. I think there could be two definition of mmsys device. One is that mmsys device is the whole mmsys partiotion, so OVL, RDMA, ... would be sub device of it. Another is that mmsys just control register of 0x14000000 ~ 0x14000fff, so it's part of mmsys partition like OVL, RDMA, ..... Currently we define mmsys as the latter one. I've no idea how to map mmsys into current Linux hardware category, but I think it is not just a display device. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/mediatek/mt8173.dtsi?h=v5.6-rc1 Regards, CK > Thanks, > Enric > > > > I'm not sure if I understand you correctly. Are you proposing to keep the > > binding description in arm/mediatek? > > > > Regards, > > Matthias > > > >> > >> [1] https://patchwork.kernel.org/patch/11140747/ > >> > >> Regards, > >> CK > >> > >>> Signed-off-by: Matthias Brugger > >>> > >>> --- > >>> > >>> Changes in v7: > >>> - move the binding description > >>> > >>> Changes in v6: None > >>> Changes in v5: None > >>> Changes in v4: None > >>> Changes in v3: None > >>> Changes in v2: None > >>> > >>> .../bindings/{arm => display}/mediatek/mediatek,mmsys.txt | 0 > >>> 1 file changed, 0 insertions(+), 0 deletions(-) > >>> rename Documentation/devicetree/bindings/{arm => display}/mediatek/mediatek,mmsys.txt (100%) > >>> > >>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt > >>> similarity index 100% > >>> rename from Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > >>> rename to Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt > >> > >> _______________________________________________ > >> linux-arm-kernel mailing list > >> linux-arm-kernel@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >> > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel