From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34BFDC35DF5 for ; Tue, 25 Feb 2020 11:08:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00D3F20726 for ; Tue, 25 Feb 2020 11:08:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n7xUTtxR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Ipz4bO+D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00D3F20726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TAYqmhNN9D78WMFkgzR7QH6E0+oom4tvnJSFxA6nBRs=; b=n7xUTtxR3VURCd eyTXuj5IbkYMoVT0wZ6zYn4SsUn2RZx4AwS9fHhGZn2xetJ2Q7LDzWEBhvXzuqYdOTlydOKJk+BcB ZjkredLaQmHCWDXBdL40BZPzkGLZWaMDxkXwsX8Oldb+LQcaf2qqrz8oOzB6gOxYmTPK7DEwGTTkS bwGTkOc/PqL9DVjYPvm5TFlwNohuCi+SEWIPuevRN3cG3wOFh5KPKj0PVFrrszU1Oyq7+OKyV7wBe qqsn6lstusqVm08f2A1k6KIsjON0wnScqIPsAWxrNV5w/oKUwJtXTuI4ins8QC/InThuq/27aMpvR 88GzsVGo+CPDQSVT0Fyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6Y4N-0000HB-JE; Tue, 25 Feb 2020 11:08:07 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6Y4C-000082-M6; Tue, 25 Feb 2020 11:07:58 +0000 X-UUID: 57e6f028456641f387ff3079bccd1239-20200225 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NIVA4F3l7yQpEwqBqiJgTY82QKy3hO5czh6wpcjlijk=; b=Ipz4bO+D3YZ9Y9KXCCPN+lEr4fmGYyzfYDpyIEMemegZZoCB71iSkjODWd04jRlkz6ssb/WsobqN8qZ3hgvHrs5XRU022KA0ciirYZz68kmqxRd2euDvEGEu7KXMgW+/sYnCraC93eFjoGE8RdDJ92ZekTE1Eu+8gPnXy2j6g+g=; X-UUID: 57e6f028456641f387ff3079bccd1239-20200225 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 315484505; Tue, 25 Feb 2020 03:07:52 -0800 Received: from MTKMBS01N2.mediatek.inc (172.21.101.79) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 25 Feb 2020 03:08:26 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 25 Feb 2020 19:03:29 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 25 Feb 2020 19:07:22 +0800 Message-ID: <1582628855.31160.3.camel@mtkswgap22> Subject: Re: [PATCH v3] usb: gadget: f_fs: try to fix AIO issue under ARM 64 bit TAGGED mode From: Miles Chen To: Macpaul Lin Date: Tue, 25 Feb 2020 19:07:35 +0800 In-Reply-To: <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> References: <1582472947-22471-1-git-send-email-macpaul.lin@mediatek.com> <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 4C2CF332432AB414CFC0F2323587578A8A6BD2A698FE908B77F606313F3EF5E22000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200225_030756_728857_D5A29586 X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Shen Jing , CC Hwang , Mediatek WSD Upstream , Jerry Zhang , linux-usb@vger.kernel.org, Loda Chou , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andrzej Pietrasiewicz , John Stultz , Al Viro , Vincent Pelletier , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2020-02-25 at 18:41 +0800, Macpaul Lin wrote: > This issue was found when adbd trying to open functionfs with AIO mode. > Usually, we need to set "setprop sys.usb.ffs.aio_compat 0" to enable > adbd with AIO mode on Android. > > When adbd is opening functionfs, it will try to read 24 bytes at the > first read I/O control. If this reading has been failed, adbd will > try to send FUNCTIONFS_CLEAR_HALT to functionfs. When adbd is in AIO > mode, functionfs will be acted with asyncronized I/O path. After the > successful read transfer has been completed by gadget hardware, the > following series of functions will be called. > ffs_epfile_async_io_complete() -> ffs_user_copy_worker() -> > copy_to_iter() -> _copy_to_iter() -> copyout() -> > iterate_and_advance() -> iterate_iovec() > > Adding debug trace to these functions, it has been found that in > copyout(), access_ok() will check if the user space address is valid > to write. However if CONFIG_ARM64_TAGGED_ADDR_ABI is enabled, adbd > always passes user space address start with "0x3C" to gadget's AIO > blocks. This tagged address will cause access_ok() check always fail. > Which causes later calculation in iterate_iovec() turn zero. > Copyout() won't copy data to userspace since the length to be copied > "v.iov_len" will be zero. Finally leads ffs_copy_to_iter() always return > -EFAULT, causes adbd cannot open functionfs and send > FUNCTIONFS_CLEAR_HALT. > > Signed-off-by: Macpaul Lin > --- > Changes for v3: > - Fix misspelling in commit message. Could you say "thank you" to Peter for his comment and add "Cc: Peter Chen " to this patch, please? > > Changes for v2: > - Fix build error for 32-bit load. An #if defined(CONFIG_ARM64) still need > for avoiding undeclared defines. > > drivers/usb/gadget/function/f_fs.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index ce1d023..728c260 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -35,6 +35,7 @@ > #include > #include > #include > +#include > > #include "u_fs.h" > #include "u_f.h" > @@ -826,6 +827,10 @@ static void ffs_user_copy_worker(struct work_struct *work) > if (io_data->read && ret > 0) { > mm_segment_t oldfs = get_fs(); > > +#if defined(CONFIG_ARM64) > + if (IS_ENABLED(CONFIG_ARM64_TAGGED_ADDR_ABI)) > + set_thread_flag(TIF_TAGGED_ADDR); > +#endif > set_fs(USER_DS); > use_mm(io_data->mm); > ret = ffs_copy_to_iter(io_data->buf, ret, &io_data->data); _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E0AC35DFF for ; Tue, 25 Feb 2020 11:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD16A2467C for ; Tue, 25 Feb 2020 11:07:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Ipz4bO+D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730371AbgBYLHo (ORCPT ); Tue, 25 Feb 2020 06:07:44 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:33669 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729034AbgBYLHn (ORCPT ); Tue, 25 Feb 2020 06:07:43 -0500 X-UUID: 27556acbd761478096be470492a74c69-20200225 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NIVA4F3l7yQpEwqBqiJgTY82QKy3hO5czh6wpcjlijk=; b=Ipz4bO+D3YZ9Y9KXCCPN+lEr4fmGYyzfYDpyIEMemegZZoCB71iSkjODWd04jRlkz6ssb/WsobqN8qZ3hgvHrs5XRU022KA0ciirYZz68kmqxRd2euDvEGEu7KXMgW+/sYnCraC93eFjoGE8RdDJ92ZekTE1Eu+8gPnXy2j6g+g=; X-UUID: 27556acbd761478096be470492a74c69-20200225 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1274444266; Tue, 25 Feb 2020 19:07:38 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 25 Feb 2020 19:03:29 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 25 Feb 2020 19:07:22 +0800 Message-ID: <1582628855.31160.3.camel@mtkswgap22> Subject: Re: [PATCH v3] usb: gadget: f_fs: try to fix AIO issue under ARM 64 bit TAGGED mode From: Miles Chen To: Macpaul Lin CC: Matthias Brugger , Shen Jing , Sasha Levin , John Stultz , Andrzej Pietrasiewicz , Vincent Pelletier , Jerry Zhang , , , , , Mediatek WSD Upstream , CC Hwang , Loda Chou , Al Viro , Date: Tue, 25 Feb 2020 19:07:35 +0800 In-Reply-To: <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> References: <1582472947-22471-1-git-send-email-macpaul.lin@mediatek.com> <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 4C2CF332432AB414CFC0F2323587578A8A6BD2A698FE908B77F606313F3EF5E22000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org T24gVHVlLCAyMDIwLTAyLTI1IGF0IDE4OjQxICswODAwLCBNYWNwYXVsIExpbiB3cm90ZToNCj4g VGhpcyBpc3N1ZSB3YXMgZm91bmQgd2hlbiBhZGJkIHRyeWluZyB0byBvcGVuIGZ1bmN0aW9uZnMg d2l0aCBBSU8gbW9kZS4NCj4gVXN1YWxseSwgd2UgbmVlZCB0byBzZXQgInNldHByb3Agc3lzLnVz Yi5mZnMuYWlvX2NvbXBhdCAwIiB0byBlbmFibGUNCj4gYWRiZCB3aXRoIEFJTyBtb2RlIG9uIEFu ZHJvaWQuDQo+IA0KPiBXaGVuIGFkYmQgaXMgb3BlbmluZyBmdW5jdGlvbmZzLCBpdCB3aWxsIHRy eSB0byByZWFkIDI0IGJ5dGVzIGF0IHRoZQ0KPiBmaXJzdCByZWFkIEkvTyBjb250cm9sLiBJZiB0 aGlzIHJlYWRpbmcgaGFzIGJlZW4gZmFpbGVkLCBhZGJkIHdpbGwNCj4gdHJ5IHRvIHNlbmQgRlVO Q1RJT05GU19DTEVBUl9IQUxUIHRvIGZ1bmN0aW9uZnMuIFdoZW4gYWRiZCBpcyBpbiBBSU8NCj4g bW9kZSwgZnVuY3Rpb25mcyB3aWxsIGJlIGFjdGVkIHdpdGggYXN5bmNyb25pemVkIEkvTyBwYXRo LiBBZnRlciB0aGUNCj4gc3VjY2Vzc2Z1bCByZWFkIHRyYW5zZmVyIGhhcyBiZWVuIGNvbXBsZXRl ZCBieSBnYWRnZXQgaGFyZHdhcmUsIHRoZQ0KPiBmb2xsb3dpbmcgc2VyaWVzIG9mIGZ1bmN0aW9u cyB3aWxsIGJlIGNhbGxlZC4NCj4gICBmZnNfZXBmaWxlX2FzeW5jX2lvX2NvbXBsZXRlKCkgLT4g ZmZzX3VzZXJfY29weV93b3JrZXIoKSAtPg0KPiAgICAgY29weV90b19pdGVyKCkgLT4gX2NvcHlf dG9faXRlcigpIC0+IGNvcHlvdXQoKSAtPg0KPiAgICAgaXRlcmF0ZV9hbmRfYWR2YW5jZSgpIC0+ IGl0ZXJhdGVfaW92ZWMoKQ0KPiANCj4gQWRkaW5nIGRlYnVnIHRyYWNlIHRvIHRoZXNlIGZ1bmN0 aW9ucywgaXQgaGFzIGJlZW4gZm91bmQgdGhhdCBpbg0KPiBjb3B5b3V0KCksIGFjY2Vzc19vaygp IHdpbGwgY2hlY2sgaWYgdGhlIHVzZXIgc3BhY2UgYWRkcmVzcyBpcyB2YWxpZA0KPiB0byB3cml0 ZS4gSG93ZXZlciBpZiBDT05GSUdfQVJNNjRfVEFHR0VEX0FERFJfQUJJIGlzIGVuYWJsZWQsIGFk YmQNCj4gYWx3YXlzIHBhc3NlcyB1c2VyIHNwYWNlIGFkZHJlc3Mgc3RhcnQgd2l0aCAiMHgzQyIg dG8gZ2FkZ2V0J3MgQUlPDQo+IGJsb2Nrcy4gVGhpcyB0YWdnZWQgYWRkcmVzcyB3aWxsIGNhdXNl IGFjY2Vzc19vaygpIGNoZWNrIGFsd2F5cyBmYWlsLg0KPiBXaGljaCBjYXVzZXMgbGF0ZXIgY2Fs Y3VsYXRpb24gaW4gaXRlcmF0ZV9pb3ZlYygpIHR1cm4gemVyby4NCj4gQ29weW91dCgpIHdvbid0 IGNvcHkgZGF0YSB0byB1c2Vyc3BhY2Ugc2luY2UgdGhlIGxlbmd0aCB0byBiZSBjb3BpZWQNCj4g InYuaW92X2xlbiIgd2lsbCBiZSB6ZXJvLiBGaW5hbGx5IGxlYWRzIGZmc19jb3B5X3RvX2l0ZXIo KSBhbHdheXMgcmV0dXJuDQo+IC1FRkFVTFQsIGNhdXNlcyBhZGJkIGNhbm5vdCBvcGVuIGZ1bmN0 aW9uZnMgYW5kIHNlbmQNCj4gRlVOQ1RJT05GU19DTEVBUl9IQUxULg0KPiANCj4gU2lnbmVkLW9m Zi1ieTogTWFjcGF1bCBMaW4gPG1hY3BhdWwubGluQG1lZGlhdGVrLmNvbT4NCj4gLS0tDQo+IENo YW5nZXMgZm9yIHYzOg0KPiAgIC0gRml4IG1pc3NwZWxsaW5nIGluIGNvbW1pdCBtZXNzYWdlLg0K DQpDb3VsZCB5b3Ugc2F5ICJ0aGFuayB5b3UiIHRvIFBldGVyIGZvciBoaXMgY29tbWVudCBhbmQg YWRkIA0KIkNjOiBQZXRlciBDaGVuIDxwZXRlci5jaGVuQG54cC5jb20+IiB0byB0aGlzIHBhdGNo LCBwbGVhc2U/DQoNCj4gDQo+IENoYW5nZXMgZm9yIHYyOg0KPiAgIC0gRml4IGJ1aWxkIGVycm9y IGZvciAzMi1iaXQgbG9hZC4gQW4gI2lmIGRlZmluZWQoQ09ORklHX0FSTTY0KSBzdGlsbCBuZWVk DQo+ICAgICBmb3IgYXZvaWRpbmcgdW5kZWNsYXJlZCBkZWZpbmVzLg0KPiANCj4gIGRyaXZlcnMv dXNiL2dhZGdldC9mdW5jdGlvbi9mX2ZzLmMgfCAgICA1ICsrKysrDQo+ICAxIGZpbGUgY2hhbmdl ZCwgNSBpbnNlcnRpb25zKCspDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvZ2FkZ2V0 L2Z1bmN0aW9uL2ZfZnMuYyBiL2RyaXZlcnMvdXNiL2dhZGdldC9mdW5jdGlvbi9mX2ZzLmMNCj4g aW5kZXggY2UxZDAyMy4uNzI4YzI2MCAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy91c2IvZ2FkZ2V0 L2Z1bmN0aW9uL2ZfZnMuYw0KPiArKysgYi9kcml2ZXJzL3VzYi9nYWRnZXQvZnVuY3Rpb24vZl9m cy5jDQo+IEBAIC0zNSw2ICszNSw3IEBADQo+ICAjaW5jbHVkZSA8bGludXgvbW11X2NvbnRleHQu aD4NCj4gICNpbmNsdWRlIDxsaW51eC9wb2xsLmg+DQo+ICAjaW5jbHVkZSA8bGludXgvZXZlbnRm ZC5oPg0KPiArI2luY2x1ZGUgPGxpbnV4L3RocmVhZF9pbmZvLmg+DQo+ICANCj4gICNpbmNsdWRl ICJ1X2ZzLmgiDQo+ICAjaW5jbHVkZSAidV9mLmgiDQo+IEBAIC04MjYsNiArODI3LDEwIEBAIHN0 YXRpYyB2b2lkIGZmc191c2VyX2NvcHlfd29ya2VyKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykN Cj4gIAlpZiAoaW9fZGF0YS0+cmVhZCAmJiByZXQgPiAwKSB7DQo+ICAJCW1tX3NlZ21lbnRfdCBv bGRmcyA9IGdldF9mcygpOw0KPiAgDQo+ICsjaWYgZGVmaW5lZChDT05GSUdfQVJNNjQpDQo+ICsJ CWlmIChJU19FTkFCTEVEKENPTkZJR19BUk02NF9UQUdHRURfQUREUl9BQkkpKQ0KPiArCQkJc2V0 X3RocmVhZF9mbGFnKFRJRl9UQUdHRURfQUREUik7DQo+ICsjZW5kaWYNCj4gIAkJc2V0X2ZzKFVT RVJfRFMpOw0KPiAgCQl1c2VfbW0oaW9fZGF0YS0+bW0pOw0KPiAgCQlyZXQgPSBmZnNfY29weV90 b19pdGVyKGlvX2RhdGEtPmJ1ZiwgcmV0LCAmaW9fZGF0YS0+ZGF0YSk7DQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E09EBC35DF5 for ; Tue, 25 Feb 2020 11:07:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E0CD20726 for ; Tue, 25 Feb 2020 11:07:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YnIu13+H"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Ipz4bO+D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E0CD20726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ibCWiy8e3miwJQDT8J0DmXjqmhh3jV6oZHQjDL03/D4=; b=YnIu13+HXf0rpt eV81RiC6FzhJx2og66Eng2zOG8u52mV/HHQb3bP9n2++ndXHyvEfx7wuVWMmyjyvL+lVGUt1cob3k 8IfqhPWucxpr55YMkAASKiBIP2HQDiT7wkGA5+tq/UkfTMBmWerLLAG34jdmd6SwR83HbaOFPJz1c 5p1Oo4ykSUf80PFf7yyiHnM1c0XyjM9ec07majJ18IGIFrPAqaszJ1+KxZT4g+0lvG1zAj2gBgu3O OEnpo/YinGsq5pqExbhDpv3ypXltoaCARUFVqyH9+SR/X0Dwy2MC+2QT2t5MESEjVyjGlIOERM28n ymM2f6HLHU631LkF/b8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6Y4F-00008U-8s; Tue, 25 Feb 2020 11:07:59 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6Y4C-000082-M6; Tue, 25 Feb 2020 11:07:58 +0000 X-UUID: 57e6f028456641f387ff3079bccd1239-20200225 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NIVA4F3l7yQpEwqBqiJgTY82QKy3hO5czh6wpcjlijk=; b=Ipz4bO+D3YZ9Y9KXCCPN+lEr4fmGYyzfYDpyIEMemegZZoCB71iSkjODWd04jRlkz6ssb/WsobqN8qZ3hgvHrs5XRU022KA0ciirYZz68kmqxRd2euDvEGEu7KXMgW+/sYnCraC93eFjoGE8RdDJ92ZekTE1Eu+8gPnXy2j6g+g=; X-UUID: 57e6f028456641f387ff3079bccd1239-20200225 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 315484505; Tue, 25 Feb 2020 03:07:52 -0800 Received: from MTKMBS01N2.mediatek.inc (172.21.101.79) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 25 Feb 2020 03:08:26 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 25 Feb 2020 19:03:29 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 25 Feb 2020 19:07:22 +0800 Message-ID: <1582628855.31160.3.camel@mtkswgap22> Subject: Re: [PATCH v3] usb: gadget: f_fs: try to fix AIO issue under ARM 64 bit TAGGED mode From: Miles Chen To: Macpaul Lin Date: Tue, 25 Feb 2020 19:07:35 +0800 In-Reply-To: <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> References: <1582472947-22471-1-git-send-email-macpaul.lin@mediatek.com> <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 4C2CF332432AB414CFC0F2323587578A8A6BD2A698FE908B77F606313F3EF5E22000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200225_030756_728857_D5A29586 X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Shen Jing , CC Hwang , Mediatek WSD Upstream , Jerry Zhang , linux-usb@vger.kernel.org, Loda Chou , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andrzej Pietrasiewicz , John Stultz , Al Viro , Vincent Pelletier , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2020-02-25 at 18:41 +0800, Macpaul Lin wrote: > This issue was found when adbd trying to open functionfs with AIO mode. > Usually, we need to set "setprop sys.usb.ffs.aio_compat 0" to enable > adbd with AIO mode on Android. > > When adbd is opening functionfs, it will try to read 24 bytes at the > first read I/O control. If this reading has been failed, adbd will > try to send FUNCTIONFS_CLEAR_HALT to functionfs. When adbd is in AIO > mode, functionfs will be acted with asyncronized I/O path. After the > successful read transfer has been completed by gadget hardware, the > following series of functions will be called. > ffs_epfile_async_io_complete() -> ffs_user_copy_worker() -> > copy_to_iter() -> _copy_to_iter() -> copyout() -> > iterate_and_advance() -> iterate_iovec() > > Adding debug trace to these functions, it has been found that in > copyout(), access_ok() will check if the user space address is valid > to write. However if CONFIG_ARM64_TAGGED_ADDR_ABI is enabled, adbd > always passes user space address start with "0x3C" to gadget's AIO > blocks. This tagged address will cause access_ok() check always fail. > Which causes later calculation in iterate_iovec() turn zero. > Copyout() won't copy data to userspace since the length to be copied > "v.iov_len" will be zero. Finally leads ffs_copy_to_iter() always return > -EFAULT, causes adbd cannot open functionfs and send > FUNCTIONFS_CLEAR_HALT. > > Signed-off-by: Macpaul Lin > --- > Changes for v3: > - Fix misspelling in commit message. Could you say "thank you" to Peter for his comment and add "Cc: Peter Chen " to this patch, please? > > Changes for v2: > - Fix build error for 32-bit load. An #if defined(CONFIG_ARM64) still need > for avoiding undeclared defines. > > drivers/usb/gadget/function/f_fs.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index ce1d023..728c260 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -35,6 +35,7 @@ > #include > #include > #include > +#include > > #include "u_fs.h" > #include "u_f.h" > @@ -826,6 +827,10 @@ static void ffs_user_copy_worker(struct work_struct *work) > if (io_data->read && ret > 0) { > mm_segment_t oldfs = get_fs(); > > +#if defined(CONFIG_ARM64) > + if (IS_ENABLED(CONFIG_ARM64_TAGGED_ADDR_ABI)) > + set_thread_flag(TIF_TAGGED_ADDR); > +#endif > set_fs(USER_DS); > use_mm(io_data->mm); > ret = ffs_copy_to_iter(io_data->buf, ret, &io_data->data); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel