From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18E6C4BA3B for ; Thu, 27 Feb 2020 10:28:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2F5724691 for ; Thu, 27 Feb 2020 10:28:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XgPNEdc2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="hd69dLLI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2F5724691 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/DCfrg8cUamtkcc5ArWMAtfUmzIzmwmwa2dxBbn4c64=; b=XgPNEdc2k9irqP fBCF5OEb2Spdm39Ew8RW/ZuDDRBtvsrRV1LmCziM1iUnSwf1MpEGMB34TeVwOZ4RMii8YIEqfBLy1 vN2OM7i4Qa+X9qUyChtIaTsXJsUAa/d01yxoYZqQdJU3r6j//3nnC/kdUDTxLu5czhsvDD8XB6zwI 0WGKDwaFarMUAa/AG71yb4MChccvSHwfXzrm8Wn+K1V+Fc1D0BCoURT7jinw2SmJLQRgLdcIr5KDO MTo5zM6off+nvGQgervpehjZ/OSlpiwwk5ngXxYpcVttXnvMRmmyKZDhdSf6njMJqG36lx8vpci1V TzbsDji1flCudL23JP2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7GPE-0004Uv-0p; Thu, 27 Feb 2020 10:28:36 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7GPA-0004UM-Ib; Thu, 27 Feb 2020 10:28:35 +0000 X-UUID: 2e029f293bd74d5f9b408351b56bf309-20200227 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=LEaZatPGQmSTfFljV7UsLw7F1kUhEvQfFkNEr7oUNNE=; b=hd69dLLIulXRKM4L8dzuOAO0bc1n/LqO4Bhzsq3RRc2lahOAQhpDH9w3rmsK11b6U8vR8PeQ4wr0qnSGQ/IKcO4CalqELPXGuEcAtu+YW1+8LXEs5WpjAm+mseCw5vP84MA+PGvooxwUv6wwQdiFalQUrJa3E2qi5KTTfwa+EYI=; X-UUID: 2e029f293bd74d5f9b408351b56bf309-20200227 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1969439318; Thu, 27 Feb 2020 02:28:29 -0800 Received: from MTKMBS06N1.mediatek.inc (172.21.101.129) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 27 Feb 2020 02:28:26 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 27 Feb 2020 18:28:25 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 27 Feb 2020 18:28:13 +0800 Message-ID: <1582799305.12083.12.camel@mtkswgap22> Subject: Re: [PATCH v4] usb: gadget: f_fs: try to fix AIO issue under ARM 64 bit TAGGED mode From: Macpaul Lin To: Catalin Marinas Date: Thu, 27 Feb 2020 18:28:25 +0800 In-Reply-To: <20200227095521.GA3281767@arrakis.emea.arm.com> References: <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> <1582718512-28923-1-git-send-email-macpaul.lin@mediatek.com> <20200227095521.GA3281767@arrakis.emea.arm.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200227_022832_625422_A9A97484 X-CRM114-Status: GOOD ( 27.91 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Shen Jing , CC Hwang , Peter Chen , Mediatek WSD Upstream , Jerry Zhang , andreyknvl@google.com, linux-usb@vger.kernel.org, Loda Chou , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andrzej Pietrasiewicz , Miles Chen , John Stultz , Al Viro , Vincent Pelletier , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-02-27 at 09:55 +0000, Catalin Marinas wrote: > On Wed, Feb 26, 2020 at 08:01:52PM +0800, Macpaul Lin wrote: > > This issue was found when adbd trying to open functionfs with AIO mode. > > Usually, we need to set "setprop sys.usb.ffs.aio_compat 0" to enable > > adbd with AIO mode on Android. > > > > When adbd is opening functionfs, it will try to read 24 bytes at the > > first read I/O control. If this reading has been failed, adbd will > > try to send FUNCTIONFS_CLEAR_HALT to functionfs. When adbd is in AIO > > mode, functionfs will be acted with asyncronized I/O path. After the > > successful read transfer has been completed by gadget hardware, the > > following series of functions will be called. > > ffs_epfile_async_io_complete() -> ffs_user_copy_worker() -> > > copy_to_iter() -> _copy_to_iter() -> copyout() -> > > iterate_and_advance() -> iterate_iovec() > > > > Adding debug trace to these functions, it has been found that in > > copyout(), access_ok() will check if the user space address is valid > > to write. However if CONFIG_ARM64_TAGGED_ADDR_ABI is enabled, adbd > > always passes user space address start with "0x3C" to gadget's AIO > > blocks. This tagged address will cause access_ok() check always fail. > > Which causes later calculation in iterate_iovec() turn zero. > > Copyout() won't copy data to user space since the length to be copied > > "v.iov_len" will be zero. Finally leads ffs_copy_to_iter() always return > > -EFAULT, causes adbd cannot open functionfs and send > > FUNCTIONFS_CLEAR_HALT. > > > > Signed-off-by: Macpaul Lin > > Cc: Peter Chen > > Cc: Catalin Marinas > > Cc: Miles Chen > > --- > > Changes for v4: > > - Abandon solution v3 by adding "TIF_TAGGED_ADDR" flag to gadget driver. > > According to Catalin's suggestion, change the solution by untagging > > user space address passed by AIO in gadget driver. > > Well, this was suggested in case you have a strong reason not to do the > untagging in adbd. As I said, tagged pointers in user space were > supported long before we introduced CONFIG_ARM64_TAGGED_ADDR_ABI. How > did adb cope with such tagged pointers before? It was not supposed to > pass them to the kernel. Thank for your explanation. Since adbd was developed by Google and we can only suggest (like, file an issue) to them. Here provides a temporary solution for other developer to solve there needs in a short period. Yes, I understood not supposed to pass those tagged pointers to kernel and will also explain this to Google adbd owners. > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > > index ce1d023..192935f 100644 > > --- a/drivers/usb/gadget/function/f_fs.c > > +++ b/drivers/usb/gadget/function/f_fs.c > > @@ -715,7 +715,20 @@ static void ffs_epfile_io_complete(struct usb_ep *_ep, struct usb_request *req) > > > > static ssize_t ffs_copy_to_iter(void *data, int data_len, struct iov_iter *iter) > > { > > - ssize_t ret = copy_to_iter(data, data_len, iter); > > + ssize_t ret; > > + > > +#if defined(CONFIG_ARM64) > > + /* > > + * Replace tagged address passed by user space application before > > + * copying. > > + */ > > + if (IS_ENABLED(CONFIG_ARM64_TAGGED_ADDR_ABI) && > > + (iter->type == ITER_IOVEC)) { > > + *(unsigned long *)&iter->iov->iov_base = > > + (unsigned long)untagged_addr(iter->iov->iov_base); > > + } > > +#endif > > + ret = copy_to_iter(data, data_len, iter); > > Here you should probably drop all the #ifdefs and IS_ENABLED checks > since untagged_addr() is defined globally as a no-op (and overridden by > arm64 and sparc). > > Please don't send another patch until we understand (a) whether this is > a user-space problem to fix or (b) if we fix it in the kernel, is this > the only/right place? If we settle for the in-kernel untagging, do we > explicitly untag the addresses in such kernel threads or we default to > TIF_TAGGED_ADDR for all kernel threads, in case they ever call use_mm() > (or we could even hook something in use_mm() to set this TIF flag > temporarily). > > Looking for feedback from the Android folk and a better analysis of the > possible solution. > If we have any further update about this user space issue, I'll update the solution to this thread for other developers who need to solve this issue. Thanks! Macpaul Lin _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40DC4C4BA3D for ; Thu, 27 Feb 2020 10:28:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BE6E24692 for ; Thu, 27 Feb 2020 10:28:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="hd69dLLI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728712AbgB0K2d (ORCPT ); Thu, 27 Feb 2020 05:28:33 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:17818 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728652AbgB0K2d (ORCPT ); Thu, 27 Feb 2020 05:28:33 -0500 X-UUID: 595f9f8033474e46bb46bd07602317cc-20200227 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=LEaZatPGQmSTfFljV7UsLw7F1kUhEvQfFkNEr7oUNNE=; b=hd69dLLIulXRKM4L8dzuOAO0bc1n/LqO4Bhzsq3RRc2lahOAQhpDH9w3rmsK11b6U8vR8PeQ4wr0qnSGQ/IKcO4CalqELPXGuEcAtu+YW1+8LXEs5WpjAm+mseCw5vP84MA+PGvooxwUv6wwQdiFalQUrJa3E2qi5KTTfwa+EYI=; X-UUID: 595f9f8033474e46bb46bd07602317cc-20200227 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 198747016; Thu, 27 Feb 2020 18:28:27 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 27 Feb 2020 18:28:25 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 27 Feb 2020 18:28:13 +0800 Message-ID: <1582799305.12083.12.camel@mtkswgap22> Subject: Re: [PATCH v4] usb: gadget: f_fs: try to fix AIO issue under ARM 64 bit TAGGED mode From: Macpaul Lin To: Catalin Marinas CC: Matthias Brugger , Shen Jing , Sasha Levin , John Stultz , Andrzej Pietrasiewicz , Vincent Pelletier , Jerry Zhang , , , , , Mediatek WSD Upstream , CC Hwang , Loda Chou , Al Viro , , , Peter Chen , Miles Chen Date: Thu, 27 Feb 2020 18:28:25 +0800 In-Reply-To: <20200227095521.GA3281767@arrakis.emea.arm.com> References: <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> <1582718512-28923-1-git-send-email-macpaul.lin@mediatek.com> <20200227095521.GA3281767@arrakis.emea.arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org T24gVGh1LCAyMDIwLTAyLTI3IGF0IDA5OjU1ICswMDAwLCBDYXRhbGluIE1hcmluYXMgd3JvdGU6 DQo+IE9uIFdlZCwgRmViIDI2LCAyMDIwIGF0IDA4OjAxOjUyUE0gKzA4MDAsIE1hY3BhdWwgTGlu IHdyb3RlOg0KPiA+IFRoaXMgaXNzdWUgd2FzIGZvdW5kIHdoZW4gYWRiZCB0cnlpbmcgdG8gb3Bl biBmdW5jdGlvbmZzIHdpdGggQUlPIG1vZGUuDQo+ID4gVXN1YWxseSwgd2UgbmVlZCB0byBzZXQg InNldHByb3Agc3lzLnVzYi5mZnMuYWlvX2NvbXBhdCAwIiB0byBlbmFibGUNCj4gPiBhZGJkIHdp dGggQUlPIG1vZGUgb24gQW5kcm9pZC4NCj4gPiANCj4gPiBXaGVuIGFkYmQgaXMgb3BlbmluZyBm dW5jdGlvbmZzLCBpdCB3aWxsIHRyeSB0byByZWFkIDI0IGJ5dGVzIGF0IHRoZQ0KPiA+IGZpcnN0 IHJlYWQgSS9PIGNvbnRyb2wuIElmIHRoaXMgcmVhZGluZyBoYXMgYmVlbiBmYWlsZWQsIGFkYmQg d2lsbA0KPiA+IHRyeSB0byBzZW5kIEZVTkNUSU9ORlNfQ0xFQVJfSEFMVCB0byBmdW5jdGlvbmZz LiBXaGVuIGFkYmQgaXMgaW4gQUlPDQo+ID4gbW9kZSwgZnVuY3Rpb25mcyB3aWxsIGJlIGFjdGVk IHdpdGggYXN5bmNyb25pemVkIEkvTyBwYXRoLiBBZnRlciB0aGUNCj4gPiBzdWNjZXNzZnVsIHJl YWQgdHJhbnNmZXIgaGFzIGJlZW4gY29tcGxldGVkIGJ5IGdhZGdldCBoYXJkd2FyZSwgdGhlDQo+ ID4gZm9sbG93aW5nIHNlcmllcyBvZiBmdW5jdGlvbnMgd2lsbCBiZSBjYWxsZWQuDQo+ID4gICBm ZnNfZXBmaWxlX2FzeW5jX2lvX2NvbXBsZXRlKCkgLT4gZmZzX3VzZXJfY29weV93b3JrZXIoKSAt Pg0KPiA+ICAgICBjb3B5X3RvX2l0ZXIoKSAtPiBfY29weV90b19pdGVyKCkgLT4gY29weW91dCgp IC0+DQo+ID4gICAgIGl0ZXJhdGVfYW5kX2FkdmFuY2UoKSAtPiBpdGVyYXRlX2lvdmVjKCkNCj4g PiANCj4gPiBBZGRpbmcgZGVidWcgdHJhY2UgdG8gdGhlc2UgZnVuY3Rpb25zLCBpdCBoYXMgYmVl biBmb3VuZCB0aGF0IGluDQo+ID4gY29weW91dCgpLCBhY2Nlc3Nfb2soKSB3aWxsIGNoZWNrIGlm IHRoZSB1c2VyIHNwYWNlIGFkZHJlc3MgaXMgdmFsaWQNCj4gPiB0byB3cml0ZS4gSG93ZXZlciBp ZiBDT05GSUdfQVJNNjRfVEFHR0VEX0FERFJfQUJJIGlzIGVuYWJsZWQsIGFkYmQNCj4gPiBhbHdh eXMgcGFzc2VzIHVzZXIgc3BhY2UgYWRkcmVzcyBzdGFydCB3aXRoICIweDNDIiB0byBnYWRnZXQn cyBBSU8NCj4gPiBibG9ja3MuIFRoaXMgdGFnZ2VkIGFkZHJlc3Mgd2lsbCBjYXVzZSBhY2Nlc3Nf b2soKSBjaGVjayBhbHdheXMgZmFpbC4NCj4gPiBXaGljaCBjYXVzZXMgbGF0ZXIgY2FsY3VsYXRp b24gaW4gaXRlcmF0ZV9pb3ZlYygpIHR1cm4gemVyby4NCj4gPiBDb3B5b3V0KCkgd29uJ3QgY29w eSBkYXRhIHRvIHVzZXIgc3BhY2Ugc2luY2UgdGhlIGxlbmd0aCB0byBiZSBjb3BpZWQNCj4gPiAi di5pb3ZfbGVuIiB3aWxsIGJlIHplcm8uIEZpbmFsbHkgbGVhZHMgZmZzX2NvcHlfdG9faXRlcigp IGFsd2F5cyByZXR1cm4NCj4gPiAtRUZBVUxULCBjYXVzZXMgYWRiZCBjYW5ub3Qgb3BlbiBmdW5j dGlvbmZzIGFuZCBzZW5kDQo+ID4gRlVOQ1RJT05GU19DTEVBUl9IQUxULg0KPiA+IA0KPiA+IFNp Z25lZC1vZmYtYnk6IE1hY3BhdWwgTGluIDxtYWNwYXVsLmxpbkBtZWRpYXRlay5jb20+DQo+ID4g Q2M6IFBldGVyIENoZW4gPHBldGVyLmNoZW5AbnhwLmNvbT4NCj4gPiBDYzogQ2F0YWxpbiBNYXJp bmFzIDxjYXRhbGluLm1hcmluYXNAYXJtLmNvbT4NCj4gPiBDYzogTWlsZXMgQ2hlbiA8bWlsZXMu Y2hlbkBtZWRpYXRlay5jb20+DQo+ID4gLS0tDQo+ID4gQ2hhbmdlcyBmb3IgdjQ6DQo+ID4gICAt IEFiYW5kb24gc29sdXRpb24gdjMgYnkgYWRkaW5nICJUSUZfVEFHR0VEX0FERFIiIGZsYWcgdG8g Z2FkZ2V0IGRyaXZlci4NCj4gPiAgICAgQWNjb3JkaW5nIHRvIENhdGFsaW4ncyBzdWdnZXN0aW9u LCBjaGFuZ2UgdGhlIHNvbHV0aW9uIGJ5IHVudGFnZ2luZyANCj4gPiAgICAgdXNlciBzcGFjZSBh ZGRyZXNzIHBhc3NlZCBieSBBSU8gaW4gZ2FkZ2V0IGRyaXZlci4NCj4gDQo+IFdlbGwsIHRoaXMg d2FzIHN1Z2dlc3RlZCBpbiBjYXNlIHlvdSBoYXZlIGEgc3Ryb25nIHJlYXNvbiBub3QgdG8gZG8g dGhlDQo+IHVudGFnZ2luZyBpbiBhZGJkLiBBcyBJIHNhaWQsIHRhZ2dlZCBwb2ludGVycyBpbiB1 c2VyIHNwYWNlIHdlcmUNCj4gc3VwcG9ydGVkIGxvbmcgYmVmb3JlIHdlIGludHJvZHVjZWQgQ09O RklHX0FSTTY0X1RBR0dFRF9BRERSX0FCSS4gSG93DQo+IGRpZCBhZGIgY29wZSB3aXRoIHN1Y2gg dGFnZ2VkIHBvaW50ZXJzIGJlZm9yZT8gSXQgd2FzIG5vdCBzdXBwb3NlZCB0bw0KPiBwYXNzIHRo ZW0gdG8gdGhlIGtlcm5lbC4NCg0KVGhhbmsgZm9yIHlvdXIgZXhwbGFuYXRpb24uIFNpbmNlIGFk YmQgd2FzIGRldmVsb3BlZCBieSBHb29nbGUgYW5kIHdlDQpjYW4gb25seSBzdWdnZXN0IChsaWtl LCBmaWxlIGFuIGlzc3VlKSB0byB0aGVtLiBIZXJlIHByb3ZpZGVzIGENCnRlbXBvcmFyeSBzb2x1 dGlvbiBmb3Igb3RoZXIgZGV2ZWxvcGVyIHRvIHNvbHZlIHRoZXJlIG5lZWRzIGluIGEgc2hvcnQN CnBlcmlvZC4gWWVzLCBJIHVuZGVyc3Rvb2Qgbm90IHN1cHBvc2VkIHRvIHBhc3MgdGhvc2UgdGFn Z2VkIHBvaW50ZXJzIHRvDQprZXJuZWwgYW5kIHdpbGwgYWxzbyBleHBsYWluIHRoaXMgdG8gR29v Z2xlIGFkYmQgb3duZXJzLg0KDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2dhZGdldC9m dW5jdGlvbi9mX2ZzLmMgYi9kcml2ZXJzL3VzYi9nYWRnZXQvZnVuY3Rpb24vZl9mcy5jDQo+ID4g aW5kZXggY2UxZDAyMy4uMTkyOTM1ZiAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL3VzYi9nYWRn ZXQvZnVuY3Rpb24vZl9mcy5jDQo+ID4gKysrIGIvZHJpdmVycy91c2IvZ2FkZ2V0L2Z1bmN0aW9u L2ZfZnMuYw0KPiA+IEBAIC03MTUsNyArNzE1LDIwIEBAIHN0YXRpYyB2b2lkIGZmc19lcGZpbGVf aW9fY29tcGxldGUoc3RydWN0IHVzYl9lcCAqX2VwLCBzdHJ1Y3QgdXNiX3JlcXVlc3QgKnJlcSkN Cj4gPiAgDQo+ID4gIHN0YXRpYyBzc2l6ZV90IGZmc19jb3B5X3RvX2l0ZXIodm9pZCAqZGF0YSwg aW50IGRhdGFfbGVuLCBzdHJ1Y3QgaW92X2l0ZXIgKml0ZXIpDQo+ID4gIHsNCj4gPiAtCXNzaXpl X3QgcmV0ID0gY29weV90b19pdGVyKGRhdGEsIGRhdGFfbGVuLCBpdGVyKTsNCj4gPiArCXNzaXpl X3QgcmV0Ow0KPiA+ICsNCj4gPiArI2lmIGRlZmluZWQoQ09ORklHX0FSTTY0KQ0KPiA+ICsJLyoN Cj4gPiArCSAqIFJlcGxhY2UgdGFnZ2VkIGFkZHJlc3MgcGFzc2VkIGJ5IHVzZXIgc3BhY2UgYXBw bGljYXRpb24gYmVmb3JlDQo+ID4gKwkgKiBjb3B5aW5nLg0KPiA+ICsJICovDQo+ID4gKwlpZiAo SVNfRU5BQkxFRChDT05GSUdfQVJNNjRfVEFHR0VEX0FERFJfQUJJKSAmJg0KPiA+ICsJCShpdGVy LT50eXBlID09IElURVJfSU9WRUMpKSB7DQo+ID4gKwkJKih1bnNpZ25lZCBsb25nICopJml0ZXIt Pmlvdi0+aW92X2Jhc2UgPQ0KPiA+ICsJCQkodW5zaWduZWQgbG9uZyl1bnRhZ2dlZF9hZGRyKGl0 ZXItPmlvdi0+aW92X2Jhc2UpOw0KPiA+ICsJfQ0KPiA+ICsjZW5kaWYNCj4gPiArCXJldCA9IGNv cHlfdG9faXRlcihkYXRhLCBkYXRhX2xlbiwgaXRlcik7DQo+IA0KPiBIZXJlIHlvdSBzaG91bGQg cHJvYmFibHkgZHJvcCBhbGwgdGhlICNpZmRlZnMgYW5kIElTX0VOQUJMRUQgY2hlY2tzDQo+IHNp bmNlIHVudGFnZ2VkX2FkZHIoKSBpcyBkZWZpbmVkIGdsb2JhbGx5IGFzIGEgbm8tb3AgKGFuZCBv dmVycmlkZGVuIGJ5DQo+IGFybTY0IGFuZCBzcGFyYykuDQo+IA0KPiBQbGVhc2UgZG9uJ3Qgc2Vu ZCBhbm90aGVyIHBhdGNoIHVudGlsIHdlIHVuZGVyc3RhbmQgKGEpIHdoZXRoZXIgdGhpcyBpcw0K PiBhIHVzZXItc3BhY2UgcHJvYmxlbSB0byBmaXggb3IgKGIpIGlmIHdlIGZpeCBpdCBpbiB0aGUg a2VybmVsLCBpcyB0aGlzDQo+IHRoZSBvbmx5L3JpZ2h0IHBsYWNlPyBJZiB3ZSBzZXR0bGUgZm9y IHRoZSBpbi1rZXJuZWwgdW50YWdnaW5nLCBkbyB3ZQ0KPiBleHBsaWNpdGx5IHVudGFnIHRoZSBh ZGRyZXNzZXMgaW4gc3VjaCBrZXJuZWwgdGhyZWFkcyBvciB3ZSBkZWZhdWx0IHRvDQo+IFRJRl9U QUdHRURfQUREUiBmb3IgYWxsIGtlcm5lbCB0aHJlYWRzLCBpbiBjYXNlIHRoZXkgZXZlciBjYWxs IHVzZV9tbSgpDQo+IChvciB3ZSBjb3VsZCBldmVuIGhvb2sgc29tZXRoaW5nIGluIHVzZV9tbSgp IHRvIHNldCB0aGlzIFRJRiBmbGFnDQo+IHRlbXBvcmFyaWx5KS4NCj4gDQo+IExvb2tpbmcgZm9y IGZlZWRiYWNrIGZyb20gdGhlIEFuZHJvaWQgZm9sayBhbmQgYSBiZXR0ZXIgYW5hbHlzaXMgb2Yg dGhlDQo+IHBvc3NpYmxlIHNvbHV0aW9uLg0KPiANCg0KSWYgd2UgaGF2ZSBhbnkgZnVydGhlciB1 cGRhdGUgYWJvdXQgdGhpcyB1c2VyIHNwYWNlIGlzc3VlLCBJJ2xsIHVwZGF0ZQ0KdGhlIHNvbHV0 aW9uIHRvIHRoaXMgdGhyZWFkIGZvciBvdGhlciBkZXZlbG9wZXJzIHdobyBuZWVkIHRvIHNvbHZl IHRoaXMNCmlzc3VlLg0KDQpUaGFua3MhDQpNYWNwYXVsIExpbg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7A7C4BA3D for ; Thu, 27 Feb 2020 10:28:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D714724691 for ; Thu, 27 Feb 2020 10:28:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RkZ+bcwj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="hd69dLLI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D714724691 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KPjzmY1efNYBWl8ba723tjAhzE8ymq4yLclbKfy8Tos=; b=RkZ+bcwjoIddnJ uaxzUXbyhjGB0Ls8IRjviR+9HiXp5zNlJ2JFj2xFc6J4B2bKOpzBsciHYdOoiT1QP2K4rQwhkD57C GMYFDJ2LNWl5kgH+6a3fnea757KM7hKgK2d8YL/+V64qYlEDX4n5Il8vhMBUsBHqyZLJwW1Zza4BN vXdpoMntBJaS8vF1tfLI346h2UABck1yNIxb4deTzrId0bt8h1RxXolZWZHzTtxhiCMAJRXfX5W0Q KXM80+sBVpcDwW3lcPdXA+OLPL0/1otOaH4hPUxDZYg/9teePdjHdEwbhePljUYUHIoKc5KoYsWYY ggympjZNG1dYI/vaiN0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7GPF-0004Vh-39; Thu, 27 Feb 2020 10:28:37 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7GPA-0004UM-Ib; Thu, 27 Feb 2020 10:28:35 +0000 X-UUID: 2e029f293bd74d5f9b408351b56bf309-20200227 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=LEaZatPGQmSTfFljV7UsLw7F1kUhEvQfFkNEr7oUNNE=; b=hd69dLLIulXRKM4L8dzuOAO0bc1n/LqO4Bhzsq3RRc2lahOAQhpDH9w3rmsK11b6U8vR8PeQ4wr0qnSGQ/IKcO4CalqELPXGuEcAtu+YW1+8LXEs5WpjAm+mseCw5vP84MA+PGvooxwUv6wwQdiFalQUrJa3E2qi5KTTfwa+EYI=; X-UUID: 2e029f293bd74d5f9b408351b56bf309-20200227 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1969439318; Thu, 27 Feb 2020 02:28:29 -0800 Received: from MTKMBS06N1.mediatek.inc (172.21.101.129) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 27 Feb 2020 02:28:26 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 27 Feb 2020 18:28:25 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 27 Feb 2020 18:28:13 +0800 Message-ID: <1582799305.12083.12.camel@mtkswgap22> Subject: Re: [PATCH v4] usb: gadget: f_fs: try to fix AIO issue under ARM 64 bit TAGGED mode From: Macpaul Lin To: Catalin Marinas Date: Thu, 27 Feb 2020 18:28:25 +0800 In-Reply-To: <20200227095521.GA3281767@arrakis.emea.arm.com> References: <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> <1582718512-28923-1-git-send-email-macpaul.lin@mediatek.com> <20200227095521.GA3281767@arrakis.emea.arm.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200227_022832_625422_A9A97484 X-CRM114-Status: GOOD ( 27.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Shen Jing , CC Hwang , Peter Chen , Mediatek WSD Upstream , Jerry Zhang , andreyknvl@google.com, linux-usb@vger.kernel.org, Loda Chou , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andrzej Pietrasiewicz , Miles Chen , John Stultz , Al Viro , Vincent Pelletier , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-02-27 at 09:55 +0000, Catalin Marinas wrote: > On Wed, Feb 26, 2020 at 08:01:52PM +0800, Macpaul Lin wrote: > > This issue was found when adbd trying to open functionfs with AIO mode. > > Usually, we need to set "setprop sys.usb.ffs.aio_compat 0" to enable > > adbd with AIO mode on Android. > > > > When adbd is opening functionfs, it will try to read 24 bytes at the > > first read I/O control. If this reading has been failed, adbd will > > try to send FUNCTIONFS_CLEAR_HALT to functionfs. When adbd is in AIO > > mode, functionfs will be acted with asyncronized I/O path. After the > > successful read transfer has been completed by gadget hardware, the > > following series of functions will be called. > > ffs_epfile_async_io_complete() -> ffs_user_copy_worker() -> > > copy_to_iter() -> _copy_to_iter() -> copyout() -> > > iterate_and_advance() -> iterate_iovec() > > > > Adding debug trace to these functions, it has been found that in > > copyout(), access_ok() will check if the user space address is valid > > to write. However if CONFIG_ARM64_TAGGED_ADDR_ABI is enabled, adbd > > always passes user space address start with "0x3C" to gadget's AIO > > blocks. This tagged address will cause access_ok() check always fail. > > Which causes later calculation in iterate_iovec() turn zero. > > Copyout() won't copy data to user space since the length to be copied > > "v.iov_len" will be zero. Finally leads ffs_copy_to_iter() always return > > -EFAULT, causes adbd cannot open functionfs and send > > FUNCTIONFS_CLEAR_HALT. > > > > Signed-off-by: Macpaul Lin > > Cc: Peter Chen > > Cc: Catalin Marinas > > Cc: Miles Chen > > --- > > Changes for v4: > > - Abandon solution v3 by adding "TIF_TAGGED_ADDR" flag to gadget driver. > > According to Catalin's suggestion, change the solution by untagging > > user space address passed by AIO in gadget driver. > > Well, this was suggested in case you have a strong reason not to do the > untagging in adbd. As I said, tagged pointers in user space were > supported long before we introduced CONFIG_ARM64_TAGGED_ADDR_ABI. How > did adb cope with such tagged pointers before? It was not supposed to > pass them to the kernel. Thank for your explanation. Since adbd was developed by Google and we can only suggest (like, file an issue) to them. Here provides a temporary solution for other developer to solve there needs in a short period. Yes, I understood not supposed to pass those tagged pointers to kernel and will also explain this to Google adbd owners. > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > > index ce1d023..192935f 100644 > > --- a/drivers/usb/gadget/function/f_fs.c > > +++ b/drivers/usb/gadget/function/f_fs.c > > @@ -715,7 +715,20 @@ static void ffs_epfile_io_complete(struct usb_ep *_ep, struct usb_request *req) > > > > static ssize_t ffs_copy_to_iter(void *data, int data_len, struct iov_iter *iter) > > { > > - ssize_t ret = copy_to_iter(data, data_len, iter); > > + ssize_t ret; > > + > > +#if defined(CONFIG_ARM64) > > + /* > > + * Replace tagged address passed by user space application before > > + * copying. > > + */ > > + if (IS_ENABLED(CONFIG_ARM64_TAGGED_ADDR_ABI) && > > + (iter->type == ITER_IOVEC)) { > > + *(unsigned long *)&iter->iov->iov_base = > > + (unsigned long)untagged_addr(iter->iov->iov_base); > > + } > > +#endif > > + ret = copy_to_iter(data, data_len, iter); > > Here you should probably drop all the #ifdefs and IS_ENABLED checks > since untagged_addr() is defined globally as a no-op (and overridden by > arm64 and sparc). > > Please don't send another patch until we understand (a) whether this is > a user-space problem to fix or (b) if we fix it in the kernel, is this > the only/right place? If we settle for the in-kernel untagging, do we > explicitly untag the addresses in such kernel threads or we default to > TIF_TAGGED_ADDR for all kernel threads, in case they ever call use_mm() > (or we could even hook something in use_mm() to set this TIF flag > temporarily). > > Looking for feedback from the Android folk and a better analysis of the > possible solution. > If we have any further update about this user space issue, I'll update the solution to this thread for other developers who need to solve this issue. Thanks! Macpaul Lin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel