From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21830C3F2CE for ; Sat, 29 Feb 2020 13:50:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C92AF24650 for ; Sat, 29 Feb 2020 13:50:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bidQ7nw4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="UHRrEmGD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C92AF24650 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KJaVPPjADl8qc+PNs2Fj9pZk631T3lQNCf0t+KzKaP8=; b=bidQ7nw4JJEzeg rXVdq+NDOCodKlzPzJquHWuoZtvFKLBpLgk3/OT0kri0cBERO87qQw/ZwhHgQsmsKLu9+DAFvP7Tw Il6cHFTbTUKMGBbGAcX3XGnFbCfdQB1fguvVbHYAzHckBZomXChjBR2One2X1OeX6L2NclBP1bm6m ie8jddRF62Qa86hba5/Uj2BKdozXySZ5tfDk1UwqwTTKPxUHopmFFnCkaTQYZEkmrcW6rEfuLavNS 9zPu/IBjGqoOWM0uV7dEBuw//OCAd0QtcMY1bGh/FAD/p0r5WI66/o4A9ZYQ61dTxt9yhZ68KJKvI 6wyoSbjuBd03ufmid1JQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j82Vj-000339-QT; Sat, 29 Feb 2020 13:50:31 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j82Vg-00032A-Sg; Sat, 29 Feb 2020 13:50:30 +0000 X-UUID: 69a25268b4fc44db861965f91c233a25-20200229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=00XiYHa78TlbDkBS+pf5ukriX0Bv5XzT3h8NaBRlnxw=; b=UHRrEmGDqvZET0sOWozlhuWKz7X0Dtl1avHzFDJbyWkk5kRabbDglcbg0U/xoSF8enWhLPJAJcjpwrodljPMNRbMZtEptkFkckymxOOwgGDwNKNTuV7zXP4jGNVXS2YSVMmaeCOYC9/bYGH/z5yQw37O34AVBPXFW0jkyIn+EPI=; X-UUID: 69a25268b4fc44db861965f91c233a25-20200229 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2019321539; Sat, 29 Feb 2020 05:50:26 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 29 Feb 2020 05:42:36 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 29 Feb 2020 21:40:54 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 29 Feb 2020 21:41:25 +0800 Message-ID: <1582983708.21073.6.camel@mtkswgap22> Subject: Re: [PATCH v3 05/13] soc: mediatek: cmdq: return send msg error code From: Dennis-YC Hsieh To: CK Hu Date: Sat, 29 Feb 2020 21:41:48 +0800 In-Reply-To: <1582904349.14824.19.camel@mtksdaap41> References: <1582897461-15105-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1582897461-15105-7-git-send-email-dennis-yc.hsieh@mediatek.com> <1582904349.14824.19.camel@mtksdaap41> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200229_055028_938835_B1178DCD X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , Ming-Fan Chen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi CK, Thanks for your comment. On Fri, 2020-02-28 at 23:39 +0800, CK Hu wrote: > Hi, Dennis: > > On Fri, 2020-02-28 at 21:44 +0800, Dennis YC Hsieh wrote: > > Return error code to client if send message fail, > > so that client has chance to error handling. > > > > Fixes: 576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper") > > Signed-off-by: Dennis YC Hsieh > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index 2e1bc513569b..0698612de5ad 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -351,11 +351,11 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, > > spin_unlock_irqrestore(&client->lock, flags); > > } > > > > - mbox_send_message(client->chan, pkt); > > + err = mbox_send_message(client->chan, pkt); > > /* We can send next packet immediately, so just call txdone. */ > > mbox_client_txdone(client->chan, 0); > > If error happen, why tx is done? I think you should return immediately > when error happen. ok, I will return error code directly. Regards, Dennis > > Regards, > CK > > > > > - return 0; > > + return err; > > } > > EXPORT_SYMBOL(cmdq_pkt_flush_async); > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1D6C3F2C6 for ; Sat, 29 Feb 2020 13:50:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04ABC246A2 for ; Sat, 29 Feb 2020 13:50:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IqIWstsN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="UHRrEmGD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04ABC246A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7jMljN1UhWvvGYiRUt1L6mRybg0+5f81qqWjosNCpDk=; b=IqIWstsN3ZIWZp YanCARGQWUnehoJaOX3wQe9JHluEGgfwXYosc7SoeflVaMEoxONdTVz84RXLW3CgS6tKu2Uun3ika 5ZL57Orgqbv5l3Se12CZVcNE/ZkgphF7zYcBW9m0uCNCyOm+WvqK80eEqFGZvpPkSWwH+R8lUXBpD 6EhEauUWAG1rd/cqUTaXiwdehgQpFaTDMa+SPCjiGkk87fJ6XPbG2AWfE2bGWUxTQSF3A9Ea4P5lA jOMGUVHYilyFD/6v4KE3wsxefX23BPAn1aseclvmLujJhckmhGo1WqlDFjBCYlWSdl/zEpjKkKsro 1zQ9Opi6fmlvZg8rcXHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j82Vk-00033u-Jo; Sat, 29 Feb 2020 13:50:32 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j82Vg-00032A-Sg; Sat, 29 Feb 2020 13:50:30 +0000 X-UUID: 69a25268b4fc44db861965f91c233a25-20200229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=00XiYHa78TlbDkBS+pf5ukriX0Bv5XzT3h8NaBRlnxw=; b=UHRrEmGDqvZET0sOWozlhuWKz7X0Dtl1avHzFDJbyWkk5kRabbDglcbg0U/xoSF8enWhLPJAJcjpwrodljPMNRbMZtEptkFkckymxOOwgGDwNKNTuV7zXP4jGNVXS2YSVMmaeCOYC9/bYGH/z5yQw37O34AVBPXFW0jkyIn+EPI=; X-UUID: 69a25268b4fc44db861965f91c233a25-20200229 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2019321539; Sat, 29 Feb 2020 05:50:26 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 29 Feb 2020 05:42:36 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 29 Feb 2020 21:40:54 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 29 Feb 2020 21:41:25 +0800 Message-ID: <1582983708.21073.6.camel@mtkswgap22> Subject: Re: [PATCH v3 05/13] soc: mediatek: cmdq: return send msg error code From: Dennis-YC Hsieh To: CK Hu Date: Sat, 29 Feb 2020 21:41:48 +0800 In-Reply-To: <1582904349.14824.19.camel@mtksdaap41> References: <1582897461-15105-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1582897461-15105-7-git-send-email-dennis-yc.hsieh@mediatek.com> <1582904349.14824.19.camel@mtksdaap41> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200229_055028_938835_B1178DCD X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , Ming-Fan Chen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi CK, Thanks for your comment. On Fri, 2020-02-28 at 23:39 +0800, CK Hu wrote: > Hi, Dennis: > > On Fri, 2020-02-28 at 21:44 +0800, Dennis YC Hsieh wrote: > > Return error code to client if send message fail, > > so that client has chance to error handling. > > > > Fixes: 576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper") > > Signed-off-by: Dennis YC Hsieh > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index 2e1bc513569b..0698612de5ad 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -351,11 +351,11 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, > > spin_unlock_irqrestore(&client->lock, flags); > > } > > > > - mbox_send_message(client->chan, pkt); > > + err = mbox_send_message(client->chan, pkt); > > /* We can send next packet immediately, so just call txdone. */ > > mbox_client_txdone(client->chan, 0); > > If error happen, why tx is done? I think you should return immediately > when error happen. ok, I will return error code directly. Regards, Dennis > > Regards, > CK > > > > > - return 0; > > + return err; > > } > > EXPORT_SYMBOL(cmdq_pkt_flush_async); > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 740E6C3F2C6 for ; Sat, 29 Feb 2020 13:41:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44F91246A2 for ; Sat, 29 Feb 2020 13:41:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="bVIt5D97" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727000AbgB2Nl4 (ORCPT ); Sat, 29 Feb 2020 08:41:56 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:40725 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726998AbgB2Nl4 (ORCPT ); Sat, 29 Feb 2020 08:41:56 -0500 X-UUID: 0d24dc072c3d4486bb8c1466371f0837-20200229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=00XiYHa78TlbDkBS+pf5ukriX0Bv5XzT3h8NaBRlnxw=; b=bVIt5D97cIF1vOiGVa3JhpWmO0Z4Om8Yjyl7j71M5m7rba5r1EUnGEAy/hdI1AK3yIHWnkeCcHMVZX6r8oS/cItlmfQTfp8KNxtp546eNmLpignbvTd90QJI4d5muLGBWo6e7hejM3AGyZGaHb4T5en5ca56cJmFhoCv/QE1j7c=; X-UUID: 0d24dc072c3d4486bb8c1466371f0837-20200229 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 399571944; Sat, 29 Feb 2020 21:41:49 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 29 Feb 2020 21:40:54 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 29 Feb 2020 21:41:25 +0800 Message-ID: <1582983708.21073.6.camel@mtkswgap22> Subject: Re: [PATCH v3 05/13] soc: mediatek: cmdq: return send msg error code From: Dennis-YC Hsieh To: CK Hu CC: Rob Herring , Matthias Brugger , Jassi Brar , , , , , Bibby Hsieh , Houlong Wei , , , "Ming-Fan Chen" Date: Sat, 29 Feb 2020 21:41:48 +0800 In-Reply-To: <1582904349.14824.19.camel@mtksdaap41> References: <1582897461-15105-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1582897461-15105-7-git-send-email-dennis-yc.hsieh@mediatek.com> <1582904349.14824.19.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgQ0ssDQoNClRoYW5rcyBmb3IgeW91ciBjb21tZW50Lg0KDQpPbiBGcmksIDIwMjAtMDItMjgg YXQgMjM6MzkgKzA4MDAsIENLIEh1IHdyb3RlOg0KPiBIaSwgRGVubmlzOg0KPiANCj4gT24gRnJp LCAyMDIwLTAyLTI4IGF0IDIxOjQ0ICswODAwLCBEZW5uaXMgWUMgSHNpZWggd3JvdGU6DQo+ID4g UmV0dXJuIGVycm9yIGNvZGUgdG8gY2xpZW50IGlmIHNlbmQgbWVzc2FnZSBmYWlsLA0KPiA+IHNv IHRoYXQgY2xpZW50IGhhcyBjaGFuY2UgdG8gZXJyb3IgaGFuZGxpbmcuDQo+ID4gDQo+ID4gRml4 ZXM6IDU3NmYxYjRiYzgwMiAoInNvYzogbWVkaWF0ZWs6IEFkZCBNZWRpYXRlayBDTURRIGhlbHBl ciIpDQo+ID4gU2lnbmVkLW9mZi1ieTogRGVubmlzIFlDIEhzaWVoIDxkZW5uaXMteWMuaHNpZWhA bWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstY21k cS1oZWxwZXIuYyB8IDQgKystLQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9tZWRp YXRlay9tdGstY21kcS1oZWxwZXIuYyBiL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRxLWhl bHBlci5jDQo+ID4gaW5kZXggMmUxYmM1MTM1NjliLi4wNjk4NjEyZGU1YWQgMTAwNjQ0DQo+ID4g LS0tIGEvZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLWNtZHEtaGVscGVyLmMNCj4gPiArKysgYi9k cml2ZXJzL3NvYy9tZWRpYXRlay9tdGstY21kcS1oZWxwZXIuYw0KPiA+IEBAIC0zNTEsMTEgKzM1 MSwxMSBAQCBpbnQgY21kcV9wa3RfZmx1c2hfYXN5bmMoc3RydWN0IGNtZHFfcGt0ICpwa3QsIGNt ZHFfYXN5bmNfZmx1c2hfY2IgY2IsDQo+ID4gIAkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmY2xp ZW50LT5sb2NrLCBmbGFncyk7DQo+ID4gIAl9DQo+ID4gIA0KPiA+IC0JbWJveF9zZW5kX21lc3Nh Z2UoY2xpZW50LT5jaGFuLCBwa3QpOw0KPiA+ICsJZXJyID0gbWJveF9zZW5kX21lc3NhZ2UoY2xp ZW50LT5jaGFuLCBwa3QpOw0KPiA+ICAJLyogV2UgY2FuIHNlbmQgbmV4dCBwYWNrZXQgaW1tZWRp YXRlbHksIHNvIGp1c3QgY2FsbCB0eGRvbmUuICovDQo+ID4gIAltYm94X2NsaWVudF90eGRvbmUo Y2xpZW50LT5jaGFuLCAwKTsNCj4gDQo+IElmIGVycm9yIGhhcHBlbiwgd2h5IHR4IGlzIGRvbmU/ IEkgdGhpbmsgeW91IHNob3VsZCByZXR1cm4gaW1tZWRpYXRlbHkNCj4gd2hlbiBlcnJvciBoYXBw ZW4uDQoNCm9rLCBJIHdpbGwgcmV0dXJuIGVycm9yIGNvZGUgZGlyZWN0bHkuDQoNCg0KUmVnYXJk cywNCkRlbm5pcw0KDQo+IA0KPiBSZWdhcmRzLA0KPiBDSw0KPiANCj4gPiAgDQo+ID4gLQlyZXR1 cm4gMDsNCj4gPiArCXJldHVybiBlcnI7DQo+ID4gIH0NCj4gPiAgRVhQT1JUX1NZTUJPTChjbWRx X3BrdF9mbHVzaF9hc3luYyk7DQo+ID4gIA0KPiANCj4gDQoNCg==