From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qian Cai Subject: Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers Date: Mon, 02 Mar 2020 14:40:42 -0500 Message-ID: <1583178042.7365.146.camel@lca.pw> References: <1581909460-19148-1-git-send-email-anshuman.khandual@arm.com> <1582726182.7365.123.camel@lca.pw> <7c707b7f-ce3d-993b-8042-44fdc1ed28bf@c-s.fr> <1582732318.7365.129.camel@lca.pw> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1582732318.7365.129.camel@lca.pw> Sender: linux-kernel-owner@vger.kernel.org To: Christophe Leroy , Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , Mike Rapoport , Vineet Gupta , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Kirill A . Shutemov" , Paul Walmsley , Palmer Dabbelt , linux-snps-arc@lists.infradead.org, linux-arm-kern List-Id: linux-arch.vger.kernel.org On Wed, 2020-02-26 at 10:51 -0500, Qian Cai wrote: > On Wed, 2020-02-26 at 15:45 +0100, Christophe Leroy wrote: > > > > Le 26/02/2020 à 15:09, Qian Cai a écrit : > > > On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: > > > > This adds tests which will validate architecture page table helpers and > > > > other accessors in their compliance with expected generic MM semantics. > > > > This will help various architectures in validating changes to existing > > > > page table helpers or addition of new ones. > > > > > > > > This test covers basic page table entry transformations including but not > > > > limited to old, young, dirty, clean, write, write protect etc at various > > > > level along with populating intermediate entries with next page table page > > > > and validating them. > > > > > > > > Test page table pages are allocated from system memory with required size > > > > and alignments. The mapped pfns at page table levels are derived from a > > > > real pfn representing a valid kernel text symbol. This test gets called > > > > inside kernel_init() right after async_synchronize_full(). > > > > > > > > This test gets built and run when CONFIG_DEBUG_VM_PGTABLE is selected. Any > > > > architecture, which is willing to subscribe this test will need to select > > > > ARCH_HAS_DEBUG_VM_PGTABLE. For now this is limited to arc, arm64, x86, s390 > > > > and ppc32 platforms where the test is known to build and run successfully. > > > > Going forward, other architectures too can subscribe the test after fixing > > > > any build or runtime problems with their page table helpers. Meanwhile for > > > > better platform coverage, the test can also be enabled with CONFIG_EXPERT > > > > even without ARCH_HAS_DEBUG_VM_PGTABLE. > > > > > > > > Folks interested in making sure that a given platform's page table helpers > > > > conform to expected generic MM semantics should enable the above config > > > > which will just trigger this test during boot. Any non conformity here will > > > > be reported as an warning which would need to be fixed. This test will help > > > > catch any changes to the agreed upon semantics expected from generic MM and > > > > enable platforms to accommodate it thereafter. > > > > > > How useful is this that straightly crash the powerpc? > > > > > > [   23.263425][    T1] debug_vm_pgtable: debug_vm_pgtable: Validating > > > architecture page table helpers > > > [   23.263625][    T1] ------------[ cut here ]------------ > > > [   23.263649][    T1] kernel BUG at arch/powerpc/mm/pgtable.c:274! > > > > The problem on PPC64 is known and has to be investigated and fixed. > > It might be interesting to hear what powerpc64 maintainers would say about it > and if it is actually worth "fixing" in the arch code, but that BUG_ON() was > there since 2009 and had not been exposed until this patch comes alone? This patch below makes it works on powerpc64 in order to dodge the BUG_ON()s in assert_pte_locked() triggered by pte_clear_tests(). diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index 96dd7d574cef..50b385233971 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -55,6 +55,8 @@  #define RANDOM_ORVALUE GENMASK(BITS_PER_LONG - 1, S390_MASK_BITS)  #define RANDOM_NZVALUE GENMASK(7, 0)   +unsigned long vaddr; +  static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot)  {   pte_t pte = pfn_pte(pfn, prot); @@ -256,7 +258,7 @@ static void __init pte_clear_tests(struct mm_struct *mm, pte_t *ptep)     pte = __pte(pte_val(pte) | RANDOM_ORVALUE);   WRITE_ONCE(*ptep, pte); - pte_clear(mm, 0, ptep); + pte_clear(mm, vaddr, ptep);   pte = READ_ONCE(*ptep);   WARN_ON(!pte_none(pte));  } @@ -310,8 +312,9 @@ void __init debug_vm_pgtable(void)   pgtable_t saved_ptep;   pgprot_t prot;   phys_addr_t paddr; - unsigned long vaddr, pte_aligned, pmd_aligned; + unsigned long pte_aligned, pmd_aligned;   unsigned long pud_aligned, p4d_aligned, pgd_aligned; + spinlock_t *ptl;     pr_info("Validating architecture page table helpers\n");   prot = vm_get_page_prot(VMFLAGS); @@ -344,7 +347,7 @@ void __init debug_vm_pgtable(void)   p4dp = p4d_alloc(mm, pgdp, vaddr);   pudp = pud_alloc(mm, p4dp, vaddr);   pmdp = pmd_alloc(mm, pudp, vaddr); - ptep = pte_alloc_map(mm, pmdp, vaddr); + ptep = pte_alloc_map_lock(mm, pmdp, vaddr, &ptl);     /*    * Save all the page table page addresses as the page table @@ -370,7 +373,7 @@ void __init debug_vm_pgtable(void)   p4d_clear_tests(mm, p4dp);   pgd_clear_tests(mm, pgdp);   - pte_unmap(ptep); + pte_unmap_unlock(ptep, ptl);     pmd_populate_tests(mm, pmdp, saved_ptep);   pud_populate_tests(mm, pudp, saved_pmdp); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1583178042.7365.146.camel@lca.pw> Subject: Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers From: Qian Cai Date: Mon, 02 Mar 2020 14:40:42 -0500 In-Reply-To: <1582732318.7365.129.camel@lca.pw> References: <1581909460-19148-1-git-send-email-anshuman.khandual@arm.com> <1582726182.7365.123.camel@lca.pw> <7c707b7f-ce3d-993b-8042-44fdc1ed28bf@c-s.fr> <1582732318.7365.129.camel@lca.pw> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+rppt=linux.ibm.com@lists.infradead.org To: Christophe Leroy , Anshuman Khandual , linux-mm@kvack.org Cc: Catalin Marinas , Heiko Carstens , Paul Mackerras , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Will Deacon , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Mike Rapoport , Christian Borntraeger , Ingo Molnar , Benjamin Herrenschmidt , linux-snps-arc@lists.infradead.org, Vasily Gorbik , Borislav Petkov , Paul Walmsley , "Kirill A . Shutemov" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Vineet Gupta , linux-kernel@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org List-ID: Message-ID: <20200302194042.V2omhwXCFCPkTccpR9fjWtWp86bQtkWxR3CmZp6r68k@z> On Wed, 2020-02-26 at 10:51 -0500, Qian Cai wrote: > On Wed, 2020-02-26 at 15:45 +0100, Christophe Leroy wrote: > > > > Le 26/02/2020 à 15:09, Qian Cai a écrit : > > > On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: > > > > This adds tests which will validate architecture page table helpers and > > > > other accessors in their compliance with expected generic MM semantics. > > > > This will help various architectures in validating changes to existing > > > > page table helpers or addition of new ones. > > > > > > > > This test covers basic page table entry transformations including but not > > > > limited to old, young, dirty, clean, write, write protect etc at various > > > > level along with populating intermediate entries with next page table page > > > > and validating them. > > > > > > > > Test page table pages are allocated from system memory with required size > > > > and alignments. The mapped pfns at page table levels are derived from a > > > > real pfn representing a valid kernel text symbol. This test gets called > > > > inside kernel_init() right after async_synchronize_full(). > > > > > > > > This test gets built and run when CONFIG_DEBUG_VM_PGTABLE is selected. Any > > > > architecture, which is willing to subscribe this test will need to select > > > > ARCH_HAS_DEBUG_VM_PGTABLE. For now this is limited to arc, arm64, x86, s390 > > > > and ppc32 platforms where the test is known to build and run successfully. > > > > Going forward, other architectures too can subscribe the test after fixing > > > > any build or runtime problems with their page table helpers. Meanwhile for > > > > better platform coverage, the test can also be enabled with CONFIG_EXPERT > > > > even without ARCH_HAS_DEBUG_VM_PGTABLE. > > > > > > > > Folks interested in making sure that a given platform's page table helpers > > > > conform to expected generic MM semantics should enable the above config > > > > which will just trigger this test during boot. Any non conformity here will > > > > be reported as an warning which would need to be fixed. This test will help > > > > catch any changes to the agreed upon semantics expected from generic MM and > > > > enable platforms to accommodate it thereafter. > > > > > > How useful is this that straightly crash the powerpc? > > > > > > [   23.263425][    T1] debug_vm_pgtable: debug_vm_pgtable: Validating > > > architecture page table helpers > > > [   23.263625][    T1] ------------[ cut here ]------------ > > > [   23.263649][    T1] kernel BUG at arch/powerpc/mm/pgtable.c:274! > > > > The problem on PPC64 is known and has to be investigated and fixed. > > It might be interesting to hear what powerpc64 maintainers would say about it > and if it is actually worth "fixing" in the arch code, but that BUG_ON() was > there since 2009 and had not been exposed until this patch comes alone? This patch below makes it works on powerpc64 in order to dodge the BUG_ON()s in assert_pte_locked() triggered by pte_clear_tests(). diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index 96dd7d574cef..50b385233971 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -55,6 +55,8 @@  #define RANDOM_ORVALUE GENMASK(BITS_PER_LONG - 1, S390_MASK_BITS)  #define RANDOM_NZVALUE GENMASK(7, 0)   +unsigned long vaddr; +  static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot)  {   pte_t pte = pfn_pte(pfn, prot); @@ -256,7 +258,7 @@ static void __init pte_clear_tests(struct mm_struct *mm, pte_t *ptep)     pte = __pte(pte_val(pte) | RANDOM_ORVALUE);   WRITE_ONCE(*ptep, pte); - pte_clear(mm, 0, ptep); + pte_clear(mm, vaddr, ptep);   pte = READ_ONCE(*ptep);   WARN_ON(!pte_none(pte));  } @@ -310,8 +312,9 @@ void __init debug_vm_pgtable(void)   pgtable_t saved_ptep;   pgprot_t prot;   phys_addr_t paddr; - unsigned long vaddr, pte_aligned, pmd_aligned; + unsigned long pte_aligned, pmd_aligned;   unsigned long pud_aligned, p4d_aligned, pgd_aligned; + spinlock_t *ptl;     pr_info("Validating architecture page table helpers\n");   prot = vm_get_page_prot(VMFLAGS); @@ -344,7 +347,7 @@ void __init debug_vm_pgtable(void)   p4dp = p4d_alloc(mm, pgdp, vaddr);   pudp = pud_alloc(mm, p4dp, vaddr);   pmdp = pmd_alloc(mm, pudp, vaddr); - ptep = pte_alloc_map(mm, pmdp, vaddr); + ptep = pte_alloc_map_lock(mm, pmdp, vaddr, &ptl);     /*    * Save all the page table page addresses as the page table @@ -370,7 +373,7 @@ void __init debug_vm_pgtable(void)   p4d_clear_tests(mm, p4dp);   pgd_clear_tests(mm, pgdp);   - pte_unmap(ptep); + pte_unmap_unlock(ptep, ptl);     pmd_populate_tests(mm, pmdp, saved_ptep);   pud_populate_tests(mm, pudp, saved_pmdp); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f194.google.com ([209.85.222.194]:36439 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbgCBTks (ORCPT ); Mon, 2 Mar 2020 14:40:48 -0500 Received: by mail-qk1-f194.google.com with SMTP id f3so923187qkh.3 for ; Mon, 02 Mar 2020 11:40:48 -0800 (PST) Message-ID: <1583178042.7365.146.camel@lca.pw> Subject: Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers From: Qian Cai Date: Mon, 02 Mar 2020 14:40:42 -0500 In-Reply-To: <1582732318.7365.129.camel@lca.pw> References: <1581909460-19148-1-git-send-email-anshuman.khandual@arm.com> <1582726182.7365.123.camel@lca.pw> <7c707b7f-ce3d-993b-8042-44fdc1ed28bf@c-s.fr> <1582732318.7365.129.camel@lca.pw> Content-Type: text/plain; charset="utf-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Christophe Leroy , Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , Mike Rapoport , Vineet Gupta , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Kirill A . Shutemov" , Paul Walmsley , Palmer Dabbelt , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 2020-02-26 at 10:51 -0500, Qian Cai wrote: > On Wed, 2020-02-26 at 15:45 +0100, Christophe Leroy wrote: > > > > Le 26/02/2020 à 15:09, Qian Cai a écrit : > > > On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: > > > > This adds tests which will validate architecture page table helpers and > > > > other accessors in their compliance with expected generic MM semantics. > > > > This will help various architectures in validating changes to existing > > > > page table helpers or addition of new ones. > > > > > > > > This test covers basic page table entry transformations including but not > > > > limited to old, young, dirty, clean, write, write protect etc at various > > > > level along with populating intermediate entries with next page table page > > > > and validating them. > > > > > > > > Test page table pages are allocated from system memory with required size > > > > and alignments. The mapped pfns at page table levels are derived from a > > > > real pfn representing a valid kernel text symbol. This test gets called > > > > inside kernel_init() right after async_synchronize_full(). > > > > > > > > This test gets built and run when CONFIG_DEBUG_VM_PGTABLE is selected. Any > > > > architecture, which is willing to subscribe this test will need to select > > > > ARCH_HAS_DEBUG_VM_PGTABLE. For now this is limited to arc, arm64, x86, s390 > > > > and ppc32 platforms where the test is known to build and run successfully. > > > > Going forward, other architectures too can subscribe the test after fixing > > > > any build or runtime problems with their page table helpers. Meanwhile for > > > > better platform coverage, the test can also be enabled with CONFIG_EXPERT > > > > even without ARCH_HAS_DEBUG_VM_PGTABLE. > > > > > > > > Folks interested in making sure that a given platform's page table helpers > > > > conform to expected generic MM semantics should enable the above config > > > > which will just trigger this test during boot. Any non conformity here will > > > > be reported as an warning which would need to be fixed. This test will help > > > > catch any changes to the agreed upon semantics expected from generic MM and > > > > enable platforms to accommodate it thereafter. > > > > > > How useful is this that straightly crash the powerpc? > > > > > > [   23.263425][    T1] debug_vm_pgtable: debug_vm_pgtable: Validating > > > architecture page table helpers > > > [   23.263625][    T1] ------------[ cut here ]------------ > > > [   23.263649][    T1] kernel BUG at arch/powerpc/mm/pgtable.c:274! > > > > The problem on PPC64 is known and has to be investigated and fixed. > > It might be interesting to hear what powerpc64 maintainers would say about it > and if it is actually worth "fixing" in the arch code, but that BUG_ON() was > there since 2009 and had not been exposed until this patch comes alone? This patch below makes it works on powerpc64 in order to dodge the BUG_ON()s in assert_pte_locked() triggered by pte_clear_tests(). diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index 96dd7d574cef..50b385233971 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -55,6 +55,8 @@  #define RANDOM_ORVALUE GENMASK(BITS_PER_LONG - 1, S390_MASK_BITS)  #define RANDOM_NZVALUE GENMASK(7, 0)   +unsigned long vaddr; +  static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot)  {   pte_t pte = pfn_pte(pfn, prot); @@ -256,7 +258,7 @@ static void __init pte_clear_tests(struct mm_struct *mm, pte_t *ptep)     pte = __pte(pte_val(pte) | RANDOM_ORVALUE);   WRITE_ONCE(*ptep, pte); - pte_clear(mm, 0, ptep); + pte_clear(mm, vaddr, ptep);   pte = READ_ONCE(*ptep);   WARN_ON(!pte_none(pte));  } @@ -310,8 +312,9 @@ void __init debug_vm_pgtable(void)   pgtable_t saved_ptep;   pgprot_t prot;   phys_addr_t paddr; - unsigned long vaddr, pte_aligned, pmd_aligned; + unsigned long pte_aligned, pmd_aligned;   unsigned long pud_aligned, p4d_aligned, pgd_aligned; + spinlock_t *ptl;     pr_info("Validating architecture page table helpers\n");   prot = vm_get_page_prot(VMFLAGS); @@ -344,7 +347,7 @@ void __init debug_vm_pgtable(void)   p4dp = p4d_alloc(mm, pgdp, vaddr);   pudp = pud_alloc(mm, p4dp, vaddr);   pmdp = pmd_alloc(mm, pudp, vaddr); - ptep = pte_alloc_map(mm, pmdp, vaddr); + ptep = pte_alloc_map_lock(mm, pmdp, vaddr, &ptl);     /*    * Save all the page table page addresses as the page table @@ -370,7 +373,7 @@ void __init debug_vm_pgtable(void)   p4d_clear_tests(mm, p4dp);   pgd_clear_tests(mm, pgdp);   - pte_unmap(ptep); + pte_unmap_unlock(ptep, ptl);     pmd_populate_tests(mm, pmdp, saved_ptep);   pud_populate_tests(mm, pudp, saved_pmdp); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44EA5C3F2D1 for ; Mon, 2 Mar 2020 19:41:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C0B72468A for ; Mon, 2 Mar 2020 19:41:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LPy7xI38"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="dWCEq9Tb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C0B72468A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PM7TaO3J2jupdpIM2c0TjqBIPwTMpczbXNceXqPUKlc=; b=LPy7xI38gHOY0J bHHMDd3/R18kAy93eK4+kzj3koW7lNuZhYFxnXvrsEGm97KIHQ8whWYVO8YkxrXGDyGE/YoyfOXfQ QFoNKt2bJeURNoHJ8CDw8o1QTaaBkok54sijHydtesgROfuPHXbIAxrH353n/Mdrz9neQZ6mB6pCp c38v1yuMjad8UH94gQP6STxDrLZe2l2xBpakwz6CjIJjFmaZlnas5qKWNBO26bGR1Eeh8k1MKvOjw iBLsbfqTOnfrNLoArMwPD4E9vwiW60AmZY7BqKVN2V38SVU9qr3tPdmpwKbzNGZYPaB4rqzMLoe3d L7DvUZALOA7JwpKZolPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8qvz-00076b-Hc; Mon, 02 Mar 2020 19:40:59 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8qvq-0006wy-Qm for linux-snps-arc@lists.infradead.org; Mon, 02 Mar 2020 19:40:53 +0000 Received: by mail-qk1-x742.google.com with SMTP id e16so896196qkl.6 for ; Mon, 02 Mar 2020 11:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fpur9odzhdIzgZKAdXT5OufUWZiXDywyFJGHnsjLJuo=; b=dWCEq9TbdtlIn4IlSjT7wsgDMqKSoAKLzae3C569gQfG+p+Vk79gjYDp0p50OXn9hR Xm7x5cNfSGrA7pZOqbIyHB6YbB5olZ4ep8KMLse+bohRCUq99hLzFTyhfizQ0g1MVv9z PDB5fH+ahTLkKU8vUdes9sSXGelGjiIZoAKN6HTkKzUfig+h5pTHRYeWb9NP7s3wdS9t Tt4WNgQv8yFdtznernPNmQzDX+ip0C+UgbaM/+RzUP5kH1SCJgpVi8ZPrt/2QDdNj0Vc NTeqpeeYYjJCxNEWEDDoAqM078dLwnuNGGPGzRM4Bt0EmoCaK9xyew4usRNSVcQzIQqy 2SAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fpur9odzhdIzgZKAdXT5OufUWZiXDywyFJGHnsjLJuo=; b=Yn5kRxJURKwmtO0ta/1vZ0kdnXxjfamggWJs+o2DYVah3xlvn/2c8g3Qg09uq2lHgw KFANok6oAJEa3zrEJJasd5EIWPZEEHz8/UiuGjlO0LJomVmXsDHMG7yDDPJCpd6iLaro H3FDmOf2VY//5mSD1ZjjDpEvZHD6FBNT7Sk3MC9pI8osy0J+pOfOP2YClqHcz3yoBUOm HveRwQeJgObzXo3TAGSblWGA1mhHDwL8RvfheTO3VAEVmONJBSjKjpSV+aznn7MnnJQz DOqnGswD1c6iACL7LAPd6uxyD5KZtePF9tj6n/UBDv4AJQ/8lgMb5XBvOl/4fTUS2Ghu GCiw== X-Gm-Message-State: ANhLgQ0cY6LofMFI2rUIOVs8jO5MebSIrUkKFMVBVuufOXFsy7dU3mZG dkSeI7Qt5ZuOQmNHNSsDEy6++Q== X-Google-Smtp-Source: ADFU+vvIre6Pknx1npljKo6V/87YN9X3Pm++i6mQcGcNAIn71bgolvXPcuZTIRGu9NVtwEvKfxAUQw== X-Received: by 2002:ae9:f205:: with SMTP id m5mr857097qkg.152.1583178047563; Mon, 02 Mar 2020 11:40:47 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id s139sm6748558qke.70.2020.03.02.11.40.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Mar 2020 11:40:46 -0800 (PST) Message-ID: <1583178042.7365.146.camel@lca.pw> Subject: Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Christophe Leroy , Anshuman Khandual , linux-mm@kvack.org Date: Mon, 02 Mar 2020 14:40:42 -0500 In-Reply-To: <1582732318.7365.129.camel@lca.pw> References: <1581909460-19148-1-git-send-email-anshuman.khandual@arm.com> <1582726182.7365.123.camel@lca.pw> <7c707b7f-ce3d-993b-8042-44fdc1ed28bf@c-s.fr> <1582732318.7365.129.camel@lca.pw> X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200302_114050_867407_5F2269D4 X-CRM114-Status: GOOD ( 23.33 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Heiko Carstens , Paul Mackerras , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Will Deacon , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Mike Rapoport , Christian Borntraeger , Ingo Molnar , Benjamin Herrenschmidt , linux-snps-arc@lists.infradead.org, Vasily Gorbik , Borislav Petkov , Paul Walmsley , "Kirill A . Shutemov" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Vineet Gupta , linux-kernel@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyMDIwLTAyLTI2IGF0IDEwOjUxIC0wNTAwLCBRaWFuIENhaSB3cm90ZToKPiBPbiBX ZWQsIDIwMjAtMDItMjYgYXQgMTU6NDUgKzAxMDAsIENocmlzdG9waGUgTGVyb3kgd3JvdGU6Cj4g PiAKPiA+IExlIDI2LzAyLzIwMjAgw6AgMTU6MDksIFFpYW4gQ2FpIGEgw6ljcml0wqA6Cj4gPiA+ IE9uIE1vbiwgMjAyMC0wMi0xNyBhdCAwODo0NyArMDUzMCwgQW5zaHVtYW4gS2hhbmR1YWwgd3Jv dGU6Cj4gPiA+ID4gVGhpcyBhZGRzIHRlc3RzIHdoaWNoIHdpbGwgdmFsaWRhdGUgYXJjaGl0ZWN0 dXJlIHBhZ2UgdGFibGUgaGVscGVycyBhbmQKPiA+ID4gPiBvdGhlciBhY2Nlc3NvcnMgaW4gdGhl aXIgY29tcGxpYW5jZSB3aXRoIGV4cGVjdGVkIGdlbmVyaWMgTU0gc2VtYW50aWNzLgo+ID4gPiA+ IFRoaXMgd2lsbCBoZWxwIHZhcmlvdXMgYXJjaGl0ZWN0dXJlcyBpbiB2YWxpZGF0aW5nIGNoYW5n ZXMgdG8gZXhpc3RpbmcKPiA+ID4gPiBwYWdlIHRhYmxlIGhlbHBlcnMgb3IgYWRkaXRpb24gb2Yg bmV3IG9uZXMuCj4gPiA+ID4gCj4gPiA+ID4gVGhpcyB0ZXN0IGNvdmVycyBiYXNpYyBwYWdlIHRh YmxlIGVudHJ5IHRyYW5zZm9ybWF0aW9ucyBpbmNsdWRpbmcgYnV0IG5vdAo+ID4gPiA+IGxpbWl0 ZWQgdG8gb2xkLCB5b3VuZywgZGlydHksIGNsZWFuLCB3cml0ZSwgd3JpdGUgcHJvdGVjdCBldGMg YXQgdmFyaW91cwo+ID4gPiA+IGxldmVsIGFsb25nIHdpdGggcG9wdWxhdGluZyBpbnRlcm1lZGlh dGUgZW50cmllcyB3aXRoIG5leHQgcGFnZSB0YWJsZSBwYWdlCj4gPiA+ID4gYW5kIHZhbGlkYXRp bmcgdGhlbS4KPiA+ID4gPiAKPiA+ID4gPiBUZXN0IHBhZ2UgdGFibGUgcGFnZXMgYXJlIGFsbG9j YXRlZCBmcm9tIHN5c3RlbSBtZW1vcnkgd2l0aCByZXF1aXJlZCBzaXplCj4gPiA+ID4gYW5kIGFs aWdubWVudHMuIFRoZSBtYXBwZWQgcGZucyBhdCBwYWdlIHRhYmxlIGxldmVscyBhcmUgZGVyaXZl ZCBmcm9tIGEKPiA+ID4gPiByZWFsIHBmbiByZXByZXNlbnRpbmcgYSB2YWxpZCBrZXJuZWwgdGV4 dCBzeW1ib2wuIFRoaXMgdGVzdCBnZXRzIGNhbGxlZAo+ID4gPiA+IGluc2lkZSBrZXJuZWxfaW5p dCgpIHJpZ2h0IGFmdGVyIGFzeW5jX3N5bmNocm9uaXplX2Z1bGwoKS4KPiA+ID4gPiAKPiA+ID4g PiBUaGlzIHRlc3QgZ2V0cyBidWlsdCBhbmQgcnVuIHdoZW4gQ09ORklHX0RFQlVHX1ZNX1BHVEFC TEUgaXMgc2VsZWN0ZWQuIEFueQo+ID4gPiA+IGFyY2hpdGVjdHVyZSwgd2hpY2ggaXMgd2lsbGlu ZyB0byBzdWJzY3JpYmUgdGhpcyB0ZXN0IHdpbGwgbmVlZCB0byBzZWxlY3QKPiA+ID4gPiBBUkNI X0hBU19ERUJVR19WTV9QR1RBQkxFLiBGb3Igbm93IHRoaXMgaXMgbGltaXRlZCB0byBhcmMsIGFy bTY0LCB4ODYsIHMzOTAKPiA+ID4gPiBhbmQgcHBjMzIgcGxhdGZvcm1zIHdoZXJlIHRoZSB0ZXN0 IGlzIGtub3duIHRvIGJ1aWxkIGFuZCBydW4gc3VjY2Vzc2Z1bGx5Lgo+ID4gPiA+IEdvaW5nIGZv cndhcmQsIG90aGVyIGFyY2hpdGVjdHVyZXMgdG9vIGNhbiBzdWJzY3JpYmUgdGhlIHRlc3QgYWZ0 ZXIgZml4aW5nCj4gPiA+ID4gYW55IGJ1aWxkIG9yIHJ1bnRpbWUgcHJvYmxlbXMgd2l0aCB0aGVp ciBwYWdlIHRhYmxlIGhlbHBlcnMuIE1lYW53aGlsZSBmb3IKPiA+ID4gPiBiZXR0ZXIgcGxhdGZv cm0gY292ZXJhZ2UsIHRoZSB0ZXN0IGNhbiBhbHNvIGJlIGVuYWJsZWQgd2l0aCBDT05GSUdfRVhQ RVJUCj4gPiA+ID4gZXZlbiB3aXRob3V0IEFSQ0hfSEFTX0RFQlVHX1ZNX1BHVEFCTEUuCj4gPiA+ ID4gCj4gPiA+ID4gRm9sa3MgaW50ZXJlc3RlZCBpbiBtYWtpbmcgc3VyZSB0aGF0IGEgZ2l2ZW4g cGxhdGZvcm0ncyBwYWdlIHRhYmxlIGhlbHBlcnMKPiA+ID4gPiBjb25mb3JtIHRvIGV4cGVjdGVk IGdlbmVyaWMgTU0gc2VtYW50aWNzIHNob3VsZCBlbmFibGUgdGhlIGFib3ZlIGNvbmZpZwo+ID4g PiA+IHdoaWNoIHdpbGwganVzdCB0cmlnZ2VyIHRoaXMgdGVzdCBkdXJpbmcgYm9vdC4gQW55IG5v biBjb25mb3JtaXR5IGhlcmUgd2lsbAo+ID4gPiA+IGJlIHJlcG9ydGVkIGFzIGFuIHdhcm5pbmcg d2hpY2ggd291bGQgbmVlZCB0byBiZSBmaXhlZC4gVGhpcyB0ZXN0IHdpbGwgaGVscAo+ID4gPiA+ IGNhdGNoIGFueSBjaGFuZ2VzIHRvIHRoZSBhZ3JlZWQgdXBvbiBzZW1hbnRpY3MgZXhwZWN0ZWQg ZnJvbSBnZW5lcmljIE1NIGFuZAo+ID4gPiA+IGVuYWJsZSBwbGF0Zm9ybXMgdG8gYWNjb21tb2Rh dGUgaXQgdGhlcmVhZnRlci4KPiA+ID4gCj4gPiA+IEhvdyB1c2VmdWwgaXMgdGhpcyB0aGF0IHN0 cmFpZ2h0bHkgY3Jhc2ggdGhlIHBvd2VycGM/Cj4gPiA+IAo+ID4gPiBbwqDCoMKgMjMuMjYzNDI1 XVvCoMKgwqDCoFQxXSBkZWJ1Z192bV9wZ3RhYmxlOiBkZWJ1Z192bV9wZ3RhYmxlOiBWYWxpZGF0 aW5nCj4gPiA+IGFyY2hpdGVjdHVyZSBwYWdlIHRhYmxlIGhlbHBlcnMKPiA+ID4gW8KgwqDCoDIz LjI2MzYyNV1bwqDCoMKgwqBUMV0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0t Cj4gPiA+IFvCoMKgwqAyMy4yNjM2NDldW8KgwqDCoMKgVDFdIGtlcm5lbCBCVUcgYXQgYXJjaC9w b3dlcnBjL21tL3BndGFibGUuYzoyNzQhCj4gPiAKPiA+IFRoZSBwcm9ibGVtIG9uIFBQQzY0IGlz IGtub3duIGFuZCBoYXMgdG8gYmUgaW52ZXN0aWdhdGVkIGFuZCBmaXhlZC4KPiAKPiBJdCBtaWdo dCBiZSBpbnRlcmVzdGluZyB0byBoZWFyIHdoYXQgcG93ZXJwYzY0IG1haW50YWluZXJzIHdvdWxk IHNheSBhYm91dCBpdAo+IGFuZCBpZiBpdCBpcyBhY3R1YWxseSB3b3J0aCAiZml4aW5nIiBpbiB0 aGUgYXJjaCBjb2RlLCBidXQgdGhhdCBCVUdfT04oKSB3YXMKPiB0aGVyZSBzaW5jZSAyMDA5IGFu ZCBoYWQgbm90IGJlZW4gZXhwb3NlZCB1bnRpbCB0aGlzIHBhdGNoIGNvbWVzIGFsb25lPwoKVGhp cyBwYXRjaCBiZWxvdyBtYWtlcyBpdCB3b3JrcyBvbiBwb3dlcnBjNjQgaW4gb3JkZXIgdG8gZG9k Z2UgdGhlIEJVR19PTigpcyBpbiAKYXNzZXJ0X3B0ZV9sb2NrZWQoKSB0cmlnZ2VyZWQgYnkgcHRl X2NsZWFyX3Rlc3RzKCkuCgoKZGlmZiAtLWdpdCBhL21tL2RlYnVnX3ZtX3BndGFibGUuYyBiL21t L2RlYnVnX3ZtX3BndGFibGUuYwppbmRleCA5NmRkN2Q1NzRjZWYuLjUwYjM4NTIzMzk3MSAxMDA2 NDQKLS0tIGEvbW0vZGVidWdfdm1fcGd0YWJsZS5jCisrKyBiL21tL2RlYnVnX3ZtX3BndGFibGUu YwpAQCAtNTUsNiArNTUsOCBAQArCoCNkZWZpbmUgUkFORE9NX09SVkFMVUUJR0VOTUFTSyhCSVRT X1BFUl9MT05HIC0gMSwgUzM5MF9NQVNLX0JJVFMpCsKgI2RlZmluZSBSQU5ET01fTlpWQUxVRQlH RU5NQVNLKDcsIDApCsKgCit1bnNpZ25lZCBsb25nIHZhZGRyOworCsKgc3RhdGljIHZvaWQgX19p bml0IHB0ZV9iYXNpY190ZXN0cyh1bnNpZ25lZCBsb25nIHBmbiwgcGdwcm90X3QgcHJvdCkKwqB7 CsKgCXB0ZV90IHB0ZSA9IHBmbl9wdGUocGZuLCBwcm90KTsKQEAgLTI1Niw3ICsyNTgsNyBAQCBz dGF0aWMgdm9pZCBfX2luaXQgcHRlX2NsZWFyX3Rlc3RzKHN0cnVjdCBtbV9zdHJ1Y3QgKm1tLApw dGVfdCAqcHRlcCkKwqAKwqAJcHRlID0gX19wdGUocHRlX3ZhbChwdGUpIHwgUkFORE9NX09SVkFM VUUpOwrCoAlXUklURV9PTkNFKCpwdGVwLCBwdGUpOwotCXB0ZV9jbGVhcihtbSwgMCwgcHRlcCk7 CisJcHRlX2NsZWFyKG1tLCB2YWRkciwgcHRlcCk7CsKgCXB0ZSA9IFJFQURfT05DRSgqcHRlcCk7 CsKgCVdBUk5fT04oIXB0ZV9ub25lKHB0ZSkpOwrCoH0KQEAgLTMxMCw4ICszMTIsOSBAQCB2b2lk IF9faW5pdCBkZWJ1Z192bV9wZ3RhYmxlKHZvaWQpCsKgCXBndGFibGVfdCBzYXZlZF9wdGVwOwrC oAlwZ3Byb3RfdCBwcm90OwrCoAlwaHlzX2FkZHJfdCBwYWRkcjsKLQl1bnNpZ25lZCBsb25nIHZh ZGRyLCBwdGVfYWxpZ25lZCwgcG1kX2FsaWduZWQ7CisJdW5zaWduZWQgbG9uZyBwdGVfYWxpZ25l ZCwgcG1kX2FsaWduZWQ7CsKgCXVuc2lnbmVkIGxvbmcgcHVkX2FsaWduZWQsIHA0ZF9hbGlnbmVk LCBwZ2RfYWxpZ25lZDsKKwlzcGlubG9ja190ICpwdGw7CsKgCsKgCXByX2luZm8oIlZhbGlkYXRp bmcgYXJjaGl0ZWN0dXJlIHBhZ2UgdGFibGUgaGVscGVyc1xuIik7CsKgCXByb3QgPSB2bV9nZXRf cGFnZV9wcm90KFZNRkxBR1MpOwpAQCAtMzQ0LDcgKzM0Nyw3IEBAIHZvaWQgX19pbml0IGRlYnVn X3ZtX3BndGFibGUodm9pZCkKwqAJcDRkcCA9IHA0ZF9hbGxvYyhtbSwgcGdkcCwgdmFkZHIpOwrC oAlwdWRwID0gcHVkX2FsbG9jKG1tLCBwNGRwLCB2YWRkcik7CsKgCXBtZHAgPSBwbWRfYWxsb2Mo bW0sIHB1ZHAsIHZhZGRyKTsKLQlwdGVwID0gcHRlX2FsbG9jX21hcChtbSwgcG1kcCwgdmFkZHIp OworCXB0ZXAgPSBwdGVfYWxsb2NfbWFwX2xvY2sobW0sIHBtZHAsIHZhZGRyLCAmcHRsKTsKwqAK wqAJLyoKwqAJwqAqIFNhdmUgYWxsIHRoZSBwYWdlIHRhYmxlIHBhZ2UgYWRkcmVzc2VzIGFzIHRo ZSBwYWdlIHRhYmxlCkBAIC0zNzAsNyArMzczLDcgQEAgdm9pZCBfX2luaXQgZGVidWdfdm1fcGd0 YWJsZSh2b2lkKQrCoAlwNGRfY2xlYXJfdGVzdHMobW0sIHA0ZHApOwrCoAlwZ2RfY2xlYXJfdGVz dHMobW0sIHBnZHApOwrCoAotCXB0ZV91bm1hcChwdGVwKTsKKwlwdGVfdW5tYXBfdW5sb2NrKHB0 ZXAsIHB0bCk7CsKgCsKgCXBtZF9wb3B1bGF0ZV90ZXN0cyhtbSwgcG1kcCwgc2F2ZWRfcHRlcCk7 CsKgCXB1ZF9wb3B1bGF0ZV90ZXN0cyhtbSwgcHVkcCwgc2F2ZWRfcG1kcCk7CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1zbnBzLWFyYyBtYWls aW5nIGxpc3QKbGludXgtc25wcy1hcmNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXNucHMtYXJjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A855C3F2D1 for ; Mon, 2 Mar 2020 19:42:48 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87F5D24686 for ; Mon, 2 Mar 2020 19:42:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="dWCEq9Tb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87F5D24686 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48WVsx2N20zDqZT for ; Tue, 3 Mar 2020 06:42:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lca.pw (client-ip=2607:f8b0:4864:20::744; helo=mail-qk1-x744.google.com; envelope-from=cai@lca.pw; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lca.pw header.i=@lca.pw header.a=rsa-sha256 header.s=google header.b=dWCEq9Tb; dkim-atps=neutral Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48WVqm0NVqzDqQy for ; Tue, 3 Mar 2020 06:40:51 +1100 (AEDT) Received: by mail-qk1-x744.google.com with SMTP id m9so912605qke.4 for ; Mon, 02 Mar 2020 11:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fpur9odzhdIzgZKAdXT5OufUWZiXDywyFJGHnsjLJuo=; b=dWCEq9TbdtlIn4IlSjT7wsgDMqKSoAKLzae3C569gQfG+p+Vk79gjYDp0p50OXn9hR Xm7x5cNfSGrA7pZOqbIyHB6YbB5olZ4ep8KMLse+bohRCUq99hLzFTyhfizQ0g1MVv9z PDB5fH+ahTLkKU8vUdes9sSXGelGjiIZoAKN6HTkKzUfig+h5pTHRYeWb9NP7s3wdS9t Tt4WNgQv8yFdtznernPNmQzDX+ip0C+UgbaM/+RzUP5kH1SCJgpVi8ZPrt/2QDdNj0Vc NTeqpeeYYjJCxNEWEDDoAqM078dLwnuNGGPGzRM4Bt0EmoCaK9xyew4usRNSVcQzIQqy 2SAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fpur9odzhdIzgZKAdXT5OufUWZiXDywyFJGHnsjLJuo=; b=UhfNMl31XszR/LljOE42mDn5qn9ldkll0fRGUr1ulSJluQbvCNPQbJzLY3l00Df00g 4rv7zar1bvM53gfYNMR2UXkWp7PyVgXSyYKiLP3X5LVY78IqCqUQgVFpAGpIM3MeQYif 8F4sAxu2GKneY5BkqWIWvak4Q/fs+IUUQ5rnCGMAnItWp2ucci1LR8pIKilw2rC0WYlj oQnsZ3+bZllKNWfepDXHkH1UNZx9C14I+rU5paIE2ME8A67mxMIBAfn416w7XtXw5wha o1xKJTlqlnOPkIpnoR/bHRIJdd/mE2Iulx5fg4WeKBHdjTxhTNcosht2yc8Nw74fXTOH cREg== X-Gm-Message-State: ANhLgQ0npRjbr9bhvpZnonUMC6f+dNgHUXWY8G1KgvvUklGNPCKxw3Z1 cMQDCkoYDKeTCUVrXegTi0FLEA== X-Google-Smtp-Source: ADFU+vvIre6Pknx1npljKo6V/87YN9X3Pm++i6mQcGcNAIn71bgolvXPcuZTIRGu9NVtwEvKfxAUQw== X-Received: by 2002:ae9:f205:: with SMTP id m5mr857097qkg.152.1583178047563; Mon, 02 Mar 2020 11:40:47 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id s139sm6748558qke.70.2020.03.02.11.40.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Mar 2020 11:40:46 -0800 (PST) Message-ID: <1583178042.7365.146.camel@lca.pw> Subject: Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Christophe Leroy , Anshuman Khandual , linux-mm@kvack.org Date: Mon, 02 Mar 2020 14:40:42 -0500 In-Reply-To: <1582732318.7365.129.camel@lca.pw> References: <1581909460-19148-1-git-send-email-anshuman.khandual@arm.com> <1582726182.7365.123.camel@lca.pw> <7c707b7f-ce3d-993b-8042-44fdc1ed28bf@c-s.fr> <1582732318.7365.129.camel@lca.pw> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Heiko Carstens , Paul Mackerras , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Will Deacon , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, Mike Rapoport , Christian Borntraeger , Ingo Molnar , linux-snps-arc@lists.infradead.org, Vasily Gorbik , Borislav Petkov , Paul Walmsley , "Kirill A . Shutemov" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Vineet Gupta , linux-kernel@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 2020-02-26 at 10:51 -0500, Qian Cai wrote: > On Wed, 2020-02-26 at 15:45 +0100, Christophe Leroy wrote: > > > > Le 26/02/2020 à 15:09, Qian Cai a écrit : > > > On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: > > > > This adds tests which will validate architecture page table helpers and > > > > other accessors in their compliance with expected generic MM semantics. > > > > This will help various architectures in validating changes to existing > > > > page table helpers or addition of new ones. > > > > > > > > This test covers basic page table entry transformations including but not > > > > limited to old, young, dirty, clean, write, write protect etc at various > > > > level along with populating intermediate entries with next page table page > > > > and validating them. > > > > > > > > Test page table pages are allocated from system memory with required size > > > > and alignments. The mapped pfns at page table levels are derived from a > > > > real pfn representing a valid kernel text symbol. This test gets called > > > > inside kernel_init() right after async_synchronize_full(). > > > > > > > > This test gets built and run when CONFIG_DEBUG_VM_PGTABLE is selected. Any > > > > architecture, which is willing to subscribe this test will need to select > > > > ARCH_HAS_DEBUG_VM_PGTABLE. For now this is limited to arc, arm64, x86, s390 > > > > and ppc32 platforms where the test is known to build and run successfully. > > > > Going forward, other architectures too can subscribe the test after fixing > > > > any build or runtime problems with their page table helpers. Meanwhile for > > > > better platform coverage, the test can also be enabled with CONFIG_EXPERT > > > > even without ARCH_HAS_DEBUG_VM_PGTABLE. > > > > > > > > Folks interested in making sure that a given platform's page table helpers > > > > conform to expected generic MM semantics should enable the above config > > > > which will just trigger this test during boot. Any non conformity here will > > > > be reported as an warning which would need to be fixed. This test will help > > > > catch any changes to the agreed upon semantics expected from generic MM and > > > > enable platforms to accommodate it thereafter. > > > > > > How useful is this that straightly crash the powerpc? > > > > > > [   23.263425][    T1] debug_vm_pgtable: debug_vm_pgtable: Validating > > > architecture page table helpers > > > [   23.263625][    T1] ------------[ cut here ]------------ > > > [   23.263649][    T1] kernel BUG at arch/powerpc/mm/pgtable.c:274! > > > > The problem on PPC64 is known and has to be investigated and fixed. > > It might be interesting to hear what powerpc64 maintainers would say about it > and if it is actually worth "fixing" in the arch code, but that BUG_ON() was > there since 2009 and had not been exposed until this patch comes alone? This patch below makes it works on powerpc64 in order to dodge the BUG_ON()s in assert_pte_locked() triggered by pte_clear_tests(). diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index 96dd7d574cef..50b385233971 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -55,6 +55,8 @@  #define RANDOM_ORVALUE GENMASK(BITS_PER_LONG - 1, S390_MASK_BITS)  #define RANDOM_NZVALUE GENMASK(7, 0)   +unsigned long vaddr; +  static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot)  {   pte_t pte = pfn_pte(pfn, prot); @@ -256,7 +258,7 @@ static void __init pte_clear_tests(struct mm_struct *mm, pte_t *ptep)     pte = __pte(pte_val(pte) | RANDOM_ORVALUE);   WRITE_ONCE(*ptep, pte); - pte_clear(mm, 0, ptep); + pte_clear(mm, vaddr, ptep);   pte = READ_ONCE(*ptep);   WARN_ON(!pte_none(pte));  } @@ -310,8 +312,9 @@ void __init debug_vm_pgtable(void)   pgtable_t saved_ptep;   pgprot_t prot;   phys_addr_t paddr; - unsigned long vaddr, pte_aligned, pmd_aligned; + unsigned long pte_aligned, pmd_aligned;   unsigned long pud_aligned, p4d_aligned, pgd_aligned; + spinlock_t *ptl;     pr_info("Validating architecture page table helpers\n");   prot = vm_get_page_prot(VMFLAGS); @@ -344,7 +347,7 @@ void __init debug_vm_pgtable(void)   p4dp = p4d_alloc(mm, pgdp, vaddr);   pudp = pud_alloc(mm, p4dp, vaddr);   pmdp = pmd_alloc(mm, pudp, vaddr); - ptep = pte_alloc_map(mm, pmdp, vaddr); + ptep = pte_alloc_map_lock(mm, pmdp, vaddr, &ptl);     /*    * Save all the page table page addresses as the page table @@ -370,7 +373,7 @@ void __init debug_vm_pgtable(void)   p4d_clear_tests(mm, p4dp);   pgd_clear_tests(mm, pgdp);   - pte_unmap(ptep); + pte_unmap_unlock(ptep, ptl);     pmd_populate_tests(mm, pmdp, saved_ptep);   pud_populate_tests(mm, pudp, saved_pmdp); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9662CC3F2D8 for ; Mon, 2 Mar 2020 19:40:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EFAE24686 for ; Mon, 2 Mar 2020 19:40:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OM9UdHJu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="dWCEq9Tb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EFAE24686 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6KXcJxmnzU70qsAymyKYIJpzju3n56DgDJJXNdkLBJw=; b=OM9UdHJuo/DuzC yVXFLYkgvrNywy1LMJvY/Lmq/2dXFoaTRApkOqtgguFIcW6TFYjOjG7pqjJ5e3X7Jkzz+G+Q8R3Oz HzJ1DmHo78VA7v8g5+j9HKdE9r476x0YlnZ0m3iknolPxqX5nrVfcJLh8MYqwwvB8+X9FSKulfV4k JAaBLbOUiv9ezJ8lP3a1hlpfa9p4Bz9fW2TR2A28dOZPTvp0zeME5uvTw0aL9kp+Y28LjC3C7fYJb OgyrwAcP1nAiQe15E5D/WF93QiooCXfz6iAf5cJdZrhSloeeWPJniuAt1jJwjwxYv5SOLWAG2br06 75o0w+sT/7nIzQyeH+2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8qvt-0006yF-Up; Mon, 02 Mar 2020 19:40:53 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8qvq-0006wx-QF for linux-arm-kernel@lists.infradead.org; Mon, 02 Mar 2020 19:40:52 +0000 Received: by mail-qk1-x741.google.com with SMTP id m2so890611qka.7 for ; Mon, 02 Mar 2020 11:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fpur9odzhdIzgZKAdXT5OufUWZiXDywyFJGHnsjLJuo=; b=dWCEq9TbdtlIn4IlSjT7wsgDMqKSoAKLzae3C569gQfG+p+Vk79gjYDp0p50OXn9hR Xm7x5cNfSGrA7pZOqbIyHB6YbB5olZ4ep8KMLse+bohRCUq99hLzFTyhfizQ0g1MVv9z PDB5fH+ahTLkKU8vUdes9sSXGelGjiIZoAKN6HTkKzUfig+h5pTHRYeWb9NP7s3wdS9t Tt4WNgQv8yFdtznernPNmQzDX+ip0C+UgbaM/+RzUP5kH1SCJgpVi8ZPrt/2QDdNj0Vc NTeqpeeYYjJCxNEWEDDoAqM078dLwnuNGGPGzRM4Bt0EmoCaK9xyew4usRNSVcQzIQqy 2SAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fpur9odzhdIzgZKAdXT5OufUWZiXDywyFJGHnsjLJuo=; b=m16acoU6/EQeIbDsNwhoMhwt+UB6lCRfeQ/4Q2KTHw+2ckx/qmZPsIM0sKubFiKtH+ KwTGep3U77BVR8556dOPIVG3LYedJdwH3huPZEQXcXkEcGbJmqNja7I8dqWZRVHPu7YF PkRor+Nd4ZMFxBOBGnpoonatPp+gEbHrj78c4PB7Pon3cNf9DzyUtKdzy1jZpohvrVai jZgxbU4src1iKgHCyLBkFZ4OQvPwEmfTrbvQeMSLQoe4J8kTC95CBhiV9vVstyXpCl91 Rbksz9lor2j0RECuvCspox4fJtEH9mEPRmUbtoN442NLrC2gDmesFgfT8s8TgjPWqx3X PHJQ== X-Gm-Message-State: ANhLgQ1BkjgttsVX6Dx/rfwjcsvXxTKwXBBmL+WHcvI4f6r6z0pu0imP Iqx5IIQ4To7BdUcAS3zTM1O/XQ== X-Google-Smtp-Source: ADFU+vvIre6Pknx1npljKo6V/87YN9X3Pm++i6mQcGcNAIn71bgolvXPcuZTIRGu9NVtwEvKfxAUQw== X-Received: by 2002:ae9:f205:: with SMTP id m5mr857097qkg.152.1583178047563; Mon, 02 Mar 2020 11:40:47 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id s139sm6748558qke.70.2020.03.02.11.40.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Mar 2020 11:40:46 -0800 (PST) Message-ID: <1583178042.7365.146.camel@lca.pw> Subject: Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Christophe Leroy , Anshuman Khandual , linux-mm@kvack.org Date: Mon, 02 Mar 2020 14:40:42 -0500 In-Reply-To: <1582732318.7365.129.camel@lca.pw> References: <1581909460-19148-1-git-send-email-anshuman.khandual@arm.com> <1582726182.7365.123.camel@lca.pw> <7c707b7f-ce3d-993b-8042-44fdc1ed28bf@c-s.fr> <1582732318.7365.129.camel@lca.pw> X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200302_114050_859113_0BE78165 X-CRM114-Status: GOOD ( 24.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Heiko Carstens , Paul Mackerras , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Will Deacon , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Mike Rapoport , Christian Borntraeger , Ingo Molnar , Benjamin Herrenschmidt , linux-snps-arc@lists.infradead.org, Vasily Gorbik , Borislav Petkov , Paul Walmsley , "Kirill A . Shutemov" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Vineet Gupta , linux-kernel@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyMDIwLTAyLTI2IGF0IDEwOjUxIC0wNTAwLCBRaWFuIENhaSB3cm90ZToKPiBPbiBX ZWQsIDIwMjAtMDItMjYgYXQgMTU6NDUgKzAxMDAsIENocmlzdG9waGUgTGVyb3kgd3JvdGU6Cj4g PiAKPiA+IExlIDI2LzAyLzIwMjAgw6AgMTU6MDksIFFpYW4gQ2FpIGEgw6ljcml0wqA6Cj4gPiA+ IE9uIE1vbiwgMjAyMC0wMi0xNyBhdCAwODo0NyArMDUzMCwgQW5zaHVtYW4gS2hhbmR1YWwgd3Jv dGU6Cj4gPiA+ID4gVGhpcyBhZGRzIHRlc3RzIHdoaWNoIHdpbGwgdmFsaWRhdGUgYXJjaGl0ZWN0 dXJlIHBhZ2UgdGFibGUgaGVscGVycyBhbmQKPiA+ID4gPiBvdGhlciBhY2Nlc3NvcnMgaW4gdGhl aXIgY29tcGxpYW5jZSB3aXRoIGV4cGVjdGVkIGdlbmVyaWMgTU0gc2VtYW50aWNzLgo+ID4gPiA+ IFRoaXMgd2lsbCBoZWxwIHZhcmlvdXMgYXJjaGl0ZWN0dXJlcyBpbiB2YWxpZGF0aW5nIGNoYW5n ZXMgdG8gZXhpc3RpbmcKPiA+ID4gPiBwYWdlIHRhYmxlIGhlbHBlcnMgb3IgYWRkaXRpb24gb2Yg bmV3IG9uZXMuCj4gPiA+ID4gCj4gPiA+ID4gVGhpcyB0ZXN0IGNvdmVycyBiYXNpYyBwYWdlIHRh YmxlIGVudHJ5IHRyYW5zZm9ybWF0aW9ucyBpbmNsdWRpbmcgYnV0IG5vdAo+ID4gPiA+IGxpbWl0 ZWQgdG8gb2xkLCB5b3VuZywgZGlydHksIGNsZWFuLCB3cml0ZSwgd3JpdGUgcHJvdGVjdCBldGMg YXQgdmFyaW91cwo+ID4gPiA+IGxldmVsIGFsb25nIHdpdGggcG9wdWxhdGluZyBpbnRlcm1lZGlh dGUgZW50cmllcyB3aXRoIG5leHQgcGFnZSB0YWJsZSBwYWdlCj4gPiA+ID4gYW5kIHZhbGlkYXRp bmcgdGhlbS4KPiA+ID4gPiAKPiA+ID4gPiBUZXN0IHBhZ2UgdGFibGUgcGFnZXMgYXJlIGFsbG9j YXRlZCBmcm9tIHN5c3RlbSBtZW1vcnkgd2l0aCByZXF1aXJlZCBzaXplCj4gPiA+ID4gYW5kIGFs aWdubWVudHMuIFRoZSBtYXBwZWQgcGZucyBhdCBwYWdlIHRhYmxlIGxldmVscyBhcmUgZGVyaXZl ZCBmcm9tIGEKPiA+ID4gPiByZWFsIHBmbiByZXByZXNlbnRpbmcgYSB2YWxpZCBrZXJuZWwgdGV4 dCBzeW1ib2wuIFRoaXMgdGVzdCBnZXRzIGNhbGxlZAo+ID4gPiA+IGluc2lkZSBrZXJuZWxfaW5p dCgpIHJpZ2h0IGFmdGVyIGFzeW5jX3N5bmNocm9uaXplX2Z1bGwoKS4KPiA+ID4gPiAKPiA+ID4g PiBUaGlzIHRlc3QgZ2V0cyBidWlsdCBhbmQgcnVuIHdoZW4gQ09ORklHX0RFQlVHX1ZNX1BHVEFC TEUgaXMgc2VsZWN0ZWQuIEFueQo+ID4gPiA+IGFyY2hpdGVjdHVyZSwgd2hpY2ggaXMgd2lsbGlu ZyB0byBzdWJzY3JpYmUgdGhpcyB0ZXN0IHdpbGwgbmVlZCB0byBzZWxlY3QKPiA+ID4gPiBBUkNI X0hBU19ERUJVR19WTV9QR1RBQkxFLiBGb3Igbm93IHRoaXMgaXMgbGltaXRlZCB0byBhcmMsIGFy bTY0LCB4ODYsIHMzOTAKPiA+ID4gPiBhbmQgcHBjMzIgcGxhdGZvcm1zIHdoZXJlIHRoZSB0ZXN0 IGlzIGtub3duIHRvIGJ1aWxkIGFuZCBydW4gc3VjY2Vzc2Z1bGx5Lgo+ID4gPiA+IEdvaW5nIGZv cndhcmQsIG90aGVyIGFyY2hpdGVjdHVyZXMgdG9vIGNhbiBzdWJzY3JpYmUgdGhlIHRlc3QgYWZ0 ZXIgZml4aW5nCj4gPiA+ID4gYW55IGJ1aWxkIG9yIHJ1bnRpbWUgcHJvYmxlbXMgd2l0aCB0aGVp ciBwYWdlIHRhYmxlIGhlbHBlcnMuIE1lYW53aGlsZSBmb3IKPiA+ID4gPiBiZXR0ZXIgcGxhdGZv cm0gY292ZXJhZ2UsIHRoZSB0ZXN0IGNhbiBhbHNvIGJlIGVuYWJsZWQgd2l0aCBDT05GSUdfRVhQ RVJUCj4gPiA+ID4gZXZlbiB3aXRob3V0IEFSQ0hfSEFTX0RFQlVHX1ZNX1BHVEFCTEUuCj4gPiA+ ID4gCj4gPiA+ID4gRm9sa3MgaW50ZXJlc3RlZCBpbiBtYWtpbmcgc3VyZSB0aGF0IGEgZ2l2ZW4g cGxhdGZvcm0ncyBwYWdlIHRhYmxlIGhlbHBlcnMKPiA+ID4gPiBjb25mb3JtIHRvIGV4cGVjdGVk IGdlbmVyaWMgTU0gc2VtYW50aWNzIHNob3VsZCBlbmFibGUgdGhlIGFib3ZlIGNvbmZpZwo+ID4g PiA+IHdoaWNoIHdpbGwganVzdCB0cmlnZ2VyIHRoaXMgdGVzdCBkdXJpbmcgYm9vdC4gQW55IG5v biBjb25mb3JtaXR5IGhlcmUgd2lsbAo+ID4gPiA+IGJlIHJlcG9ydGVkIGFzIGFuIHdhcm5pbmcg d2hpY2ggd291bGQgbmVlZCB0byBiZSBmaXhlZC4gVGhpcyB0ZXN0IHdpbGwgaGVscAo+ID4gPiA+ IGNhdGNoIGFueSBjaGFuZ2VzIHRvIHRoZSBhZ3JlZWQgdXBvbiBzZW1hbnRpY3MgZXhwZWN0ZWQg ZnJvbSBnZW5lcmljIE1NIGFuZAo+ID4gPiA+IGVuYWJsZSBwbGF0Zm9ybXMgdG8gYWNjb21tb2Rh dGUgaXQgdGhlcmVhZnRlci4KPiA+ID4gCj4gPiA+IEhvdyB1c2VmdWwgaXMgdGhpcyB0aGF0IHN0 cmFpZ2h0bHkgY3Jhc2ggdGhlIHBvd2VycGM/Cj4gPiA+IAo+ID4gPiBbwqDCoMKgMjMuMjYzNDI1 XVvCoMKgwqDCoFQxXSBkZWJ1Z192bV9wZ3RhYmxlOiBkZWJ1Z192bV9wZ3RhYmxlOiBWYWxpZGF0 aW5nCj4gPiA+IGFyY2hpdGVjdHVyZSBwYWdlIHRhYmxlIGhlbHBlcnMKPiA+ID4gW8KgwqDCoDIz LjI2MzYyNV1bwqDCoMKgwqBUMV0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0t Cj4gPiA+IFvCoMKgwqAyMy4yNjM2NDldW8KgwqDCoMKgVDFdIGtlcm5lbCBCVUcgYXQgYXJjaC9w b3dlcnBjL21tL3BndGFibGUuYzoyNzQhCj4gPiAKPiA+IFRoZSBwcm9ibGVtIG9uIFBQQzY0IGlz IGtub3duIGFuZCBoYXMgdG8gYmUgaW52ZXN0aWdhdGVkIGFuZCBmaXhlZC4KPiAKPiBJdCBtaWdo dCBiZSBpbnRlcmVzdGluZyB0byBoZWFyIHdoYXQgcG93ZXJwYzY0IG1haW50YWluZXJzIHdvdWxk IHNheSBhYm91dCBpdAo+IGFuZCBpZiBpdCBpcyBhY3R1YWxseSB3b3J0aCAiZml4aW5nIiBpbiB0 aGUgYXJjaCBjb2RlLCBidXQgdGhhdCBCVUdfT04oKSB3YXMKPiB0aGVyZSBzaW5jZSAyMDA5IGFu ZCBoYWQgbm90IGJlZW4gZXhwb3NlZCB1bnRpbCB0aGlzIHBhdGNoIGNvbWVzIGFsb25lPwoKVGhp cyBwYXRjaCBiZWxvdyBtYWtlcyBpdCB3b3JrcyBvbiBwb3dlcnBjNjQgaW4gb3JkZXIgdG8gZG9k Z2UgdGhlIEJVR19PTigpcyBpbiAKYXNzZXJ0X3B0ZV9sb2NrZWQoKSB0cmlnZ2VyZWQgYnkgcHRl X2NsZWFyX3Rlc3RzKCkuCgoKZGlmZiAtLWdpdCBhL21tL2RlYnVnX3ZtX3BndGFibGUuYyBiL21t L2RlYnVnX3ZtX3BndGFibGUuYwppbmRleCA5NmRkN2Q1NzRjZWYuLjUwYjM4NTIzMzk3MSAxMDA2 NDQKLS0tIGEvbW0vZGVidWdfdm1fcGd0YWJsZS5jCisrKyBiL21tL2RlYnVnX3ZtX3BndGFibGUu YwpAQCAtNTUsNiArNTUsOCBAQArCoCNkZWZpbmUgUkFORE9NX09SVkFMVUUJR0VOTUFTSyhCSVRT X1BFUl9MT05HIC0gMSwgUzM5MF9NQVNLX0JJVFMpCsKgI2RlZmluZSBSQU5ET01fTlpWQUxVRQlH RU5NQVNLKDcsIDApCsKgCit1bnNpZ25lZCBsb25nIHZhZGRyOworCsKgc3RhdGljIHZvaWQgX19p bml0IHB0ZV9iYXNpY190ZXN0cyh1bnNpZ25lZCBsb25nIHBmbiwgcGdwcm90X3QgcHJvdCkKwqB7 CsKgCXB0ZV90IHB0ZSA9IHBmbl9wdGUocGZuLCBwcm90KTsKQEAgLTI1Niw3ICsyNTgsNyBAQCBz dGF0aWMgdm9pZCBfX2luaXQgcHRlX2NsZWFyX3Rlc3RzKHN0cnVjdCBtbV9zdHJ1Y3QgKm1tLApw dGVfdCAqcHRlcCkKwqAKwqAJcHRlID0gX19wdGUocHRlX3ZhbChwdGUpIHwgUkFORE9NX09SVkFM VUUpOwrCoAlXUklURV9PTkNFKCpwdGVwLCBwdGUpOwotCXB0ZV9jbGVhcihtbSwgMCwgcHRlcCk7 CisJcHRlX2NsZWFyKG1tLCB2YWRkciwgcHRlcCk7CsKgCXB0ZSA9IFJFQURfT05DRSgqcHRlcCk7 CsKgCVdBUk5fT04oIXB0ZV9ub25lKHB0ZSkpOwrCoH0KQEAgLTMxMCw4ICszMTIsOSBAQCB2b2lk IF9faW5pdCBkZWJ1Z192bV9wZ3RhYmxlKHZvaWQpCsKgCXBndGFibGVfdCBzYXZlZF9wdGVwOwrC oAlwZ3Byb3RfdCBwcm90OwrCoAlwaHlzX2FkZHJfdCBwYWRkcjsKLQl1bnNpZ25lZCBsb25nIHZh ZGRyLCBwdGVfYWxpZ25lZCwgcG1kX2FsaWduZWQ7CisJdW5zaWduZWQgbG9uZyBwdGVfYWxpZ25l ZCwgcG1kX2FsaWduZWQ7CsKgCXVuc2lnbmVkIGxvbmcgcHVkX2FsaWduZWQsIHA0ZF9hbGlnbmVk LCBwZ2RfYWxpZ25lZDsKKwlzcGlubG9ja190ICpwdGw7CsKgCsKgCXByX2luZm8oIlZhbGlkYXRp bmcgYXJjaGl0ZWN0dXJlIHBhZ2UgdGFibGUgaGVscGVyc1xuIik7CsKgCXByb3QgPSB2bV9nZXRf cGFnZV9wcm90KFZNRkxBR1MpOwpAQCAtMzQ0LDcgKzM0Nyw3IEBAIHZvaWQgX19pbml0IGRlYnVn X3ZtX3BndGFibGUodm9pZCkKwqAJcDRkcCA9IHA0ZF9hbGxvYyhtbSwgcGdkcCwgdmFkZHIpOwrC oAlwdWRwID0gcHVkX2FsbG9jKG1tLCBwNGRwLCB2YWRkcik7CsKgCXBtZHAgPSBwbWRfYWxsb2Mo bW0sIHB1ZHAsIHZhZGRyKTsKLQlwdGVwID0gcHRlX2FsbG9jX21hcChtbSwgcG1kcCwgdmFkZHIp OworCXB0ZXAgPSBwdGVfYWxsb2NfbWFwX2xvY2sobW0sIHBtZHAsIHZhZGRyLCAmcHRsKTsKwqAK wqAJLyoKwqAJwqAqIFNhdmUgYWxsIHRoZSBwYWdlIHRhYmxlIHBhZ2UgYWRkcmVzc2VzIGFzIHRo ZSBwYWdlIHRhYmxlCkBAIC0zNzAsNyArMzczLDcgQEAgdm9pZCBfX2luaXQgZGVidWdfdm1fcGd0 YWJsZSh2b2lkKQrCoAlwNGRfY2xlYXJfdGVzdHMobW0sIHA0ZHApOwrCoAlwZ2RfY2xlYXJfdGVz dHMobW0sIHBnZHApOwrCoAotCXB0ZV91bm1hcChwdGVwKTsKKwlwdGVfdW5tYXBfdW5sb2NrKHB0 ZXAsIHB0bCk7CsKgCsKgCXBtZF9wb3B1bGF0ZV90ZXN0cyhtbSwgcG1kcCwgc2F2ZWRfcHRlcCk7 CsKgCXB1ZF9wb3B1bGF0ZV90ZXN0cyhtbSwgcHVkcCwgc2F2ZWRfcG1kcCk7CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==