All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Borislav Petkov <bp@alien8.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>
Subject: [BUGFIX PATCH] tools: Let O= makes handle a relative path with -C option
Date: Thu,  5 Mar 2020 15:03:03 +0900	[thread overview]
Message-ID: <158338818292.25448.7161196505598269976.stgit@devnote2> (raw)
In-Reply-To: <9e7beb31-b41f-9e95-c92b-1829e420af77@infradead.org>

When I compiled tools/bootconfig from top directory with
-C option, the O= option didn't work correctly if I passed
a relative path.

  $ make O=./builddir/ -C tools/bootconfig/
  make: Entering directory '/home/mhiramat/ksrc/linux/tools/bootconfig'
  ../scripts/Makefile.include:4: *** O=./builddir/ does not exist.  Stop.
  make: Leaving directory '/home/mhiramat/ksrc/linux/tools/bootconfig'

The O= directory existence check failed because the check
script ran in the build target directory instead of the
directory where I ran the make command.

To fix that, once change directory to $(PWD) and check O=
directory, since the PWD is set to where the make command
runs.

Fixes: c883122acc0d ("perf tools: Let O= makes handle relative paths")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
 tools/scripts/Makefile.include |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include
index ded7a950dc40..6d2f3a1b2249 100644
--- a/tools/scripts/Makefile.include
+++ b/tools/scripts/Makefile.include
@@ -1,8 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 ifneq ($(O),)
 ifeq ($(origin O), command line)
-	dummy := $(if $(shell test -d $(O) || echo $(O)),$(error O=$(O) does not exist),)
-	ABSOLUTE_O := $(shell cd $(O) ; pwd)
+	dummy := $(if $(shell cd $(PWD); test -d $(O) || echo $(O)),$(error O=$(O) does not exist),)
+	ABSOLUTE_O := $(shell cd $(PWD); cd $(O) ; pwd)
 	OUTPUT := $(ABSOLUTE_O)/$(if $(subdir),$(subdir)/)
 	COMMAND_O := O=$(ABSOLUTE_O)
 ifeq ($(objtree),)


  reply	other threads:[~2020-03-05  6:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 11:24 [PATCH 0/2] tools/bootconfig: Add O= option and enhance error message Masami Hiramatsu
2020-03-03 11:24 ` [PATCH 1/2] bootconfig: Support O=<builddir> option Masami Hiramatsu
2020-03-04 23:04   ` Randy Dunlap
2020-03-05  2:05     ` Masami Hiramatsu
2020-03-05  3:17     ` Steven Rostedt
2020-03-05  4:52       ` Randy Dunlap
2020-03-05  6:03         ` Masami Hiramatsu [this message]
2020-03-05 14:51           ` [BUGFIX PATCH] tools: Let O= makes handle a relative path with -C option Greg KH
2020-03-05 18:50           ` Randy Dunlap
2020-03-06  1:39             ` Masami Hiramatsu
2020-03-06  5:17               ` Randy Dunlap
2020-03-06  7:52           ` Geert Uytterhoeven
2020-03-06 15:07             ` Masami Hiramatsu
2020-03-06 16:26               ` Randy Dunlap
2020-03-06 18:10                 ` Masami Hiramatsu
2020-03-06 18:26                   ` Randy Dunlap
2020-03-06 16:45             ` Steven Rostedt
2020-03-05  7:41         ` [PATCH 1/2] bootconfig: Support O=<builddir> option Geert Uytterhoeven
2020-03-05 18:51           ` Randy Dunlap
2020-03-03 11:24 ` [PATCH 2/2] tools/bootconfig: Show line and column in parse error Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158338818292.25448.7161196505598269976.stgit@devnote2 \
    --to=mhiramat@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.