From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A454DC18E5B for ; Wed, 11 Mar 2020 13:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77F7B22525 for ; Wed, 11 Mar 2020 13:35:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="dCca50A2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729531AbgCKNfK (ORCPT ); Wed, 11 Mar 2020 09:35:10 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:40066 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729351AbgCKNfK (ORCPT ); Wed, 11 Mar 2020 09:35:10 -0400 X-UUID: 108a54581c49486ca1be2f781fa40ef6-20200311 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=aPE7C1DToCF06kD0ZOb8rAXB9DZEZ5xKdvZNq0Iup4g=; b=dCca50A23pdM+oPmMojPZZSSssbCgzg2ECfXYEOilVKVUoiKBB774a+SYABGgK7jqrkC/GUpTHtEIjT6tnxmvWHgSV5zLAGRFoeO4NJ6FTPAvjjEWt5+VzYGLWyPdrzLuNBSfbN+DtcaFWWzLNJZ/C3WgDkiU4QIJIsflgfPrS4=; X-UUID: 108a54581c49486ca1be2f781fa40ef6-20200311 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 31662184; Wed, 11 Mar 2020 21:35:03 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 21:33:23 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 11 Mar 2020 21:34:39 +0800 Message-ID: <1583933694.1550.0.camel@mtksdaap41> Subject: Re: [PATCH v11 4/5] soc / drm: mediatek: Move routing control to mmsys device From: CK Hu To: Matthias Brugger CC: Enric Balletbo i Serra , , Kate Stewart , "Minghsiu Tsai" , Andrew-CT Chen , , , , Richard Fontana , , , Collabora Kernel ML , , Weiyi Lu , , , mtk01761 , , , , , Seiya Wang , , Houlong Wei , , , , Matthias Brugger , Thomas Gleixner , "Mauro Carvalho Chehab" , Allison Randal , , Greg Kroah-Hartman , , , Daniel Vetter , Date: Wed, 11 Mar 2020 21:34:54 +0800 In-Reply-To: References: <20200311115614.1425528-1-enric.balletbo@collabora.com> <20200311115614.1425528-5-enric.balletbo@collabora.com> <1583932064.29614.6.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: FEED9D50E1FD1D5B5973048C686B2F8561908BC0A65B8DDC33BB0FC3950D5EFA2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org T24gV2VkLCAyMDIwLTAzLTExIGF0IDE0OjI1ICswMTAwLCBNYXR0aGlhcyBCcnVnZ2VyIHdyb3Rl Og0KPiANCj4gT24gMTEvMDMvMjAyMCAxNDowNywgQ0sgSHUgd3JvdGU6DQo+ID4gSGksIEVucmlj Og0KPiA+IA0KPiA+IE9uIFdlZCwgMjAyMC0wMy0xMSBhdCAxMjo1NiArMDEwMCwgRW5yaWMgQmFs bGV0Ym8gaSBTZXJyYSB3cm90ZToNCj4gPj4gUHJvdmlkZSBhIG10a19tbXN5c19kZHBfY29ubmVj dCgpIGFuZCBtdGtfbW1zeXNfZGlzY29ubmVjdCgpIGZ1bmN0aW9ucyB0bw0KPiA+PiByZXBsYWNl IG10a19kZHBfYWRkX2NvbXBfdG9fcGF0aCgpIGFuZCBtdGtfZGRwX3JlbW92ZV9jb21wX2Zyb21f cGF0aCgpLg0KPiA+PiBUaG9zZSBmdW5jdGlvbnMgd2lsbCBhbGxvdyBEUk0gZHJpdmVyIGFuZCBv dGhlcnMgdG8gY29udHJvbCB0aGUgZGF0YQ0KPiA+PiBwYXRoIHJvdXRpbmcuDQo+ID4+DQo+ID4g DQo+ID4gUmV2aWV3ZWQtYnk6IENLIEh1IDxjay5odUBtZWRpYXRlay5jb20+DQo+ID4gDQo+IA0K PiBJZiBJIHJlbWVtYmVyIGNvcnJlY3RseSB5b3UgYXJlIE9LIG1lIHRha2luZyB0aGUgcGF0Y2gg dGhyb3VnaCB0aGUgU29DIHRyZWUsIHJpZ2h0Pw0KPiANCj4gSW4gdGhpcyBjYXNlIEknZCBuZWVk IGEgQWNrZWQtYnkgdGFnLiBOb3QgYSBiaWcgZGVhbCwganVzdCB0cnlpbmcgdG8gcmVtZWJlciB0 aGUNCj4gdGFnIHBvbGljeSBpbiB0aGUgbGludXgga2VybmVsIDopDQo+IA0KPiBSZWdhcmRzLA0K PiBNYXR0aGlhcw0KPiANCg0KQWNrZWQtYnk6IENLIEh1IDxjay5odUBtZWRpYXRlay5jb20+DQoN Cj4gPj4gU2lnbmVkLW9mZi1ieTogRW5yaWMgQmFsbGV0Ym8gaSBTZXJyYSA8ZW5yaWMuYmFsbGV0 Ym9AY29sbGFib3JhLmNvbT4NCj4gPj4gUmV2aWV3ZWQtYnk6IE1hdHRoaWFzIEJydWdnZXIgPG1h dHRoaWFzLmJnZ0BnbWFpbC5jb20+DQo+ID4+IC0tLQ0KPiA+Pg0KPiA+PiBDaGFuZ2VzIGluIHYx MTogTm9uZQ0KPiA+PiBDaGFuZ2VzIGluIHYxMDoNCj4gPj4gLSBTZWxlY3QgQ09ORklHX01US19N TVNZUyAoQ0spDQo+ID4+IC0gUGFzcyBkZXZpY2UgcG9pbnRlciBvZiBtbXN5cyBkZXZpY2UgaW5z dGVhZCBvZiBjb25maWcgcmVncyAoQ0spDQo+ID4+DQo+ID4+IENoYW5nZXMgaW4gdjk6DQo+ID4+ IC0gSW50cm9kdWNlZCBhIG5ldyBwYXRjaCB0byBtb3ZlIHJvdXRpbmcgY29udHJvbCBpbnRvIG1t c3lzIGRyaXZlci4NCj4gPj4gLSBSZW1vdmVkIHRoZSBwYXRjaCB0byB1c2UgcmVnbWFwIGFzIGlz IG5vdCBuZWVkZWQgYW55bW9yZS4NCj4gPj4NCj4gPj4gQ2hhbmdlcyBpbiB2ODogTm9uZQ0KPiA+ PiBDaGFuZ2VzIGluIHY3OiBOb25lDQo+ID4+DQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0 ZWsvS2NvbmZpZyAgICAgICAgfCAgIDEgKw0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVr L210a19kcm1fY3J0Yy5jIHwgIDE5ICstDQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsv bXRrX2RybV9kZHAuYyAgfCAyNTYgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+PiAgZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmggIHwgICA3IC0NCj4gPj4gIGRyaXZlcnMv Z3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5jICB8ICAxNCArLQ0KPiA+PiAgZHJpdmVycy9n cHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmggIHwgICAyICstDQo+ID4+ICBkcml2ZXJzL3Nv Yy9tZWRpYXRlay9tdGstbW1zeXMuYyAgICAgICAgfCAyNzkgKysrKysrKysrKysrKysrKysrKysr KysrDQo+ID4+ICBpbmNsdWRlL2xpbnV4L3NvYy9tZWRpYXRlay9tdGstbW1zeXMuaCAgfCAgMjAg KysNCj4gPj4gIDggZmlsZXMgY2hhbmdlZCwgMzE2IGluc2VydGlvbnMoKyksIDI4MiBkZWxldGlv bnMoLSkNCj4gPj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2xpbnV4L3NvYy9tZWRpYXRl ay9tdGstbW1zeXMuaA0KPiA+Pg0KPiA+IA0KPiANCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18NCj4gTGludXgtbWVkaWF0ZWsgbWFpbGluZyBsaXN0DQo+ IExpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4gaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlaw0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F77C18E5A for ; Wed, 11 Mar 2020 13:35:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 500EB20873 for ; Wed, 11 Mar 2020 13:35:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g24ptMgi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="jxcyz81u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 500EB20873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zVDdoDSNUllvjo1Tr552h5e0ASLKxS1a0iPXw87lhKA=; b=g24ptMgiRyqaZ9 OQdGXfhpWDfbB3VAOv73yt47K9erVweu1u0I3i/lsWBuHPlIiUMFoUAhN+O6XobAl4f3KYcTqrVMI 7ZaPKbOhACknxBbvwXdha/n43XvLE9VI+O3MEDYsVd9UJ747usiZHnKkum7QbmoN1Ea1o0IQtDNbc t0gbVHliR18R+wpsUNmDZCTT62OPY0WQh4fQb5B2KIPivgjggv3+Q7kiyuERaHM5csO2qT2857NWg hDsPd9uUwD+q4TustV7zIFN0XB/up9eIoefyOzsQQvbl2eJEg6IS/xQVgTKpFMvz1JaytyvMScZpa Br+UchHy2RM/mcOHbBNA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC1W5-0008Nm-K9; Wed, 11 Mar 2020 13:35:21 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC1W1-0008Mj-UH; Wed, 11 Mar 2020 13:35:19 +0000 X-UUID: 99e51e58aab14518b7b59e90e546f499-20200311 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=aPE7C1DToCF06kD0ZOb8rAXB9DZEZ5xKdvZNq0Iup4g=; b=jxcyz81un/6Novry9rPZmgcoZbpA27/olfviVY5rtF4Gcsw4IIZf0dpSPuQgv6Zkgo3LvLMW6L55PDtazzh+r70bsISnwB1UmpbuKBvQxsZlrL2Pc3RE1AtY73SdxxZHP2R0rrnIA2gmUCCcWEzbWsxJTjI8kfMm6eTt3qsy9tk=; X-UUID: 99e51e58aab14518b7b59e90e546f499-20200311 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 205890951; Wed, 11 Mar 2020 05:35:11 -0800 Received: from MTKMBS01N2.mediatek.inc (172.21.101.79) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 06:35:10 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 21:33:23 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 11 Mar 2020 21:34:39 +0800 Message-ID: <1583933694.1550.0.camel@mtksdaap41> Subject: Re: [PATCH v11 4/5] soc / drm: mediatek: Move routing control to mmsys device From: CK Hu To: Matthias Brugger Date: Wed, 11 Mar 2020 21:34:54 +0800 In-Reply-To: References: <20200311115614.1425528-1-enric.balletbo@collabora.com> <20200311115614.1425528-5-enric.balletbo@collabora.com> <1583932064.29614.6.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: FEED9D50E1FD1D5B5973048C686B2F8561908BC0A65B8DDC33BB0FC3950D5EFA2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_063517_987576_31237E9E X-CRM114-Status: GOOD ( 17.41 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Kate Stewart , Minghsiu Tsai , Andrew-CT Chen , airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, Richard Fontana , laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, Collabora Kernel ML , linux-clk@vger.kernel.org, Weiyi Lu , wens@csie.org, Allison Randal , mtk01761 , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Daniel Vetter , frank-w@public-files.de, Seiya Wang , sean.wang@mediatek.com, Houlong Wei , robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, Greg Kroah-Hartman , rdunlap@infradead.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, matthias.bgg@kernel.org, Enric Balletbo i Serra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2020-03-11 at 14:25 +0100, Matthias Brugger wrote: > > On 11/03/2020 14:07, CK Hu wrote: > > Hi, Enric: > > > > On Wed, 2020-03-11 at 12:56 +0100, Enric Balletbo i Serra wrote: > >> Provide a mtk_mmsys_ddp_connect() and mtk_mmsys_disconnect() functions to > >> replace mtk_ddp_add_comp_to_path() and mtk_ddp_remove_comp_from_path(). > >> Those functions will allow DRM driver and others to control the data > >> path routing. > >> > > > > Reviewed-by: CK Hu > > > > If I remember correctly you are OK me taking the patch through the SoC tree, right? > > In this case I'd need a Acked-by tag. Not a big deal, just trying to remeber the > tag policy in the linux kernel :) > > Regards, > Matthias > Acked-by: CK Hu > >> Signed-off-by: Enric Balletbo i Serra > >> Reviewed-by: Matthias Brugger > >> --- > >> > >> Changes in v11: None > >> Changes in v10: > >> - Select CONFIG_MTK_MMSYS (CK) > >> - Pass device pointer of mmsys device instead of config regs (CK) > >> > >> Changes in v9: > >> - Introduced a new patch to move routing control into mmsys driver. > >> - Removed the patch to use regmap as is not needed anymore. > >> > >> Changes in v8: None > >> Changes in v7: None > >> > >> drivers/gpu/drm/mediatek/Kconfig | 1 + > >> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 19 +- > >> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 256 ---------------------- > >> drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 7 - > >> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 14 +- > >> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 +- > >> drivers/soc/mediatek/mtk-mmsys.c | 279 ++++++++++++++++++++++++ > >> include/linux/soc/mediatek/mtk-mmsys.h | 20 ++ > >> 8 files changed, 316 insertions(+), 282 deletions(-) > >> create mode 100644 include/linux/soc/mediatek/mtk-mmsys.h > >> > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1EBFC10F27 for ; Wed, 11 Mar 2020 13:35:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97A7E20873 for ; Wed, 11 Mar 2020 13:35:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ftMBkc7K"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="jxcyz81u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97A7E20873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=doT5t9WpMfBY4r/5fichUb3uBg4wAHl9UgwBVgQ13Pk=; b=ftMBkc7KMAjc7C uo6YGtzxPAohMSQYNTBTdJMhgZSqH6vTrA8yni+5WZgsuNf2ApeGo07qtr7ggdigyuMDUuWg0i1vK QWYFFi/815jretEsCcp3tHrfJRtWRajrdO2cGC282sddWel0n3foYO1Vwqo9zWvJplxUc6sK9OY3H nODSsn3vrYMMONwyzSuodoqHnk1pSbQI8e/yENoInDHbRmp2sWIp4DOdCn//vi9q6OtDujDHCa8Pk bUmi71a8fkVNxVgADUSH0cfMldGKPtyXgJTKXh5Co45pC0Gemmwsojwr6GShKxNsJnv88Hdjve5Q7 +weIFNpOHgflwe6+EB/g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC1W6-0008OV-Tr; Wed, 11 Mar 2020 13:35:22 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC1W1-0008Mj-UH; Wed, 11 Mar 2020 13:35:19 +0000 X-UUID: 99e51e58aab14518b7b59e90e546f499-20200311 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=aPE7C1DToCF06kD0ZOb8rAXB9DZEZ5xKdvZNq0Iup4g=; b=jxcyz81un/6Novry9rPZmgcoZbpA27/olfviVY5rtF4Gcsw4IIZf0dpSPuQgv6Zkgo3LvLMW6L55PDtazzh+r70bsISnwB1UmpbuKBvQxsZlrL2Pc3RE1AtY73SdxxZHP2R0rrnIA2gmUCCcWEzbWsxJTjI8kfMm6eTt3qsy9tk=; X-UUID: 99e51e58aab14518b7b59e90e546f499-20200311 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 205890951; Wed, 11 Mar 2020 05:35:11 -0800 Received: from MTKMBS01N2.mediatek.inc (172.21.101.79) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 06:35:10 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 21:33:23 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 11 Mar 2020 21:34:39 +0800 Message-ID: <1583933694.1550.0.camel@mtksdaap41> Subject: Re: [PATCH v11 4/5] soc / drm: mediatek: Move routing control to mmsys device From: CK Hu To: Matthias Brugger Date: Wed, 11 Mar 2020 21:34:54 +0800 In-Reply-To: References: <20200311115614.1425528-1-enric.balletbo@collabora.com> <20200311115614.1425528-5-enric.balletbo@collabora.com> <1583932064.29614.6.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: FEED9D50E1FD1D5B5973048C686B2F8561908BC0A65B8DDC33BB0FC3950D5EFA2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_063517_987576_31237E9E X-CRM114-Status: GOOD ( 17.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Kate Stewart , Minghsiu Tsai , Andrew-CT Chen , airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, Richard Fontana , laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, Collabora Kernel ML , linux-clk@vger.kernel.org, Weiyi Lu , wens@csie.org, Allison Randal , mtk01761 , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Daniel Vetter , frank-w@public-files.de, Seiya Wang , sean.wang@mediatek.com, Houlong Wei , robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, Greg Kroah-Hartman , rdunlap@infradead.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, matthias.bgg@kernel.org, Enric Balletbo i Serra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-03-11 at 14:25 +0100, Matthias Brugger wrote: > > On 11/03/2020 14:07, CK Hu wrote: > > Hi, Enric: > > > > On Wed, 2020-03-11 at 12:56 +0100, Enric Balletbo i Serra wrote: > >> Provide a mtk_mmsys_ddp_connect() and mtk_mmsys_disconnect() functions to > >> replace mtk_ddp_add_comp_to_path() and mtk_ddp_remove_comp_from_path(). > >> Those functions will allow DRM driver and others to control the data > >> path routing. > >> > > > > Reviewed-by: CK Hu > > > > If I remember correctly you are OK me taking the patch through the SoC tree, right? > > In this case I'd need a Acked-by tag. Not a big deal, just trying to remeber the > tag policy in the linux kernel :) > > Regards, > Matthias > Acked-by: CK Hu > >> Signed-off-by: Enric Balletbo i Serra > >> Reviewed-by: Matthias Brugger > >> --- > >> > >> Changes in v11: None > >> Changes in v10: > >> - Select CONFIG_MTK_MMSYS (CK) > >> - Pass device pointer of mmsys device instead of config regs (CK) > >> > >> Changes in v9: > >> - Introduced a new patch to move routing control into mmsys driver. > >> - Removed the patch to use regmap as is not needed anymore. > >> > >> Changes in v8: None > >> Changes in v7: None > >> > >> drivers/gpu/drm/mediatek/Kconfig | 1 + > >> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 19 +- > >> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 256 ---------------------- > >> drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 7 - > >> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 14 +- > >> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 +- > >> drivers/soc/mediatek/mtk-mmsys.c | 279 ++++++++++++++++++++++++ > >> include/linux/soc/mediatek/mtk-mmsys.h | 20 ++ > >> 8 files changed, 316 insertions(+), 282 deletions(-) > >> create mode 100644 include/linux/soc/mediatek/mtk-mmsys.h > >> > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65C54C10F27 for ; Wed, 11 Mar 2020 13:35:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39C0220873 for ; Wed, 11 Mar 2020 13:35:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="dCca50A2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39C0220873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9DDE589817; Wed, 11 Mar 2020 13:35:08 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 34A3489817 for ; Wed, 11 Mar 2020 13:35:07 +0000 (UTC) X-UUID: 108a54581c49486ca1be2f781fa40ef6-20200311 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=aPE7C1DToCF06kD0ZOb8rAXB9DZEZ5xKdvZNq0Iup4g=; b=dCca50A23pdM+oPmMojPZZSSssbCgzg2ECfXYEOilVKVUoiKBB774a+SYABGgK7jqrkC/GUpTHtEIjT6tnxmvWHgSV5zLAGRFoeO4NJ6FTPAvjjEWt5+VzYGLWyPdrzLuNBSfbN+DtcaFWWzLNJZ/C3WgDkiU4QIJIsflgfPrS4=; X-UUID: 108a54581c49486ca1be2f781fa40ef6-20200311 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 31662184; Wed, 11 Mar 2020 21:35:03 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 21:33:23 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 11 Mar 2020 21:34:39 +0800 Message-ID: <1583933694.1550.0.camel@mtksdaap41> Subject: Re: [PATCH v11 4/5] soc / drm: mediatek: Move routing control to mmsys device From: CK Hu To: Matthias Brugger Date: Wed, 11 Mar 2020 21:34:54 +0800 In-Reply-To: References: <20200311115614.1425528-1-enric.balletbo@collabora.com> <20200311115614.1425528-5-enric.balletbo@collabora.com> <1583932064.29614.6.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: FEED9D50E1FD1D5B5973048C686B2F8561908BC0A65B8DDC33BB0FC3950D5EFA2000:8 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Kate Stewart , Minghsiu Tsai , Andrew-CT Chen , airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, Richard Fontana , laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, Collabora Kernel ML , linux-clk@vger.kernel.org, Weiyi Lu , wens@csie.org, Allison Randal , mtk01761 , linux-media@vger.kernel.org, devicetree@vger.kernel.org, frank-w@public-files.de, Seiya Wang , sean.wang@mediatek.com, Houlong Wei , robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, Greg Kroah-Hartman , rdunlap@infradead.org, linux-kernel@vger.kernel.org, matthias.bgg@kernel.org, Enric Balletbo i Serra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 2020-03-11 at 14:25 +0100, Matthias Brugger wrote: > > On 11/03/2020 14:07, CK Hu wrote: > > Hi, Enric: > > > > On Wed, 2020-03-11 at 12:56 +0100, Enric Balletbo i Serra wrote: > >> Provide a mtk_mmsys_ddp_connect() and mtk_mmsys_disconnect() functions to > >> replace mtk_ddp_add_comp_to_path() and mtk_ddp_remove_comp_from_path(). > >> Those functions will allow DRM driver and others to control the data > >> path routing. > >> > > > > Reviewed-by: CK Hu > > > > If I remember correctly you are OK me taking the patch through the SoC tree, right? > > In this case I'd need a Acked-by tag. Not a big deal, just trying to remeber the > tag policy in the linux kernel :) > > Regards, > Matthias > Acked-by: CK Hu > >> Signed-off-by: Enric Balletbo i Serra > >> Reviewed-by: Matthias Brugger > >> --- > >> > >> Changes in v11: None > >> Changes in v10: > >> - Select CONFIG_MTK_MMSYS (CK) > >> - Pass device pointer of mmsys device instead of config regs (CK) > >> > >> Changes in v9: > >> - Introduced a new patch to move routing control into mmsys driver. > >> - Removed the patch to use regmap as is not needed anymore. > >> > >> Changes in v8: None > >> Changes in v7: None > >> > >> drivers/gpu/drm/mediatek/Kconfig | 1 + > >> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 19 +- > >> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 256 ---------------------- > >> drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 7 - > >> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 14 +- > >> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 +- > >> drivers/soc/mediatek/mtk-mmsys.c | 279 ++++++++++++++++++++++++ > >> include/linux/soc/mediatek/mtk-mmsys.h | 20 ++ > >> 8 files changed, 316 insertions(+), 282 deletions(-) > >> create mode 100644 include/linux/soc/mediatek/mtk-mmsys.h > >> > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel