From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A35DC10F27 for ; Wed, 11 Mar 2020 13:35:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D8A620873 for ; Wed, 11 Mar 2020 13:35:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Aq27vvjZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729631AbgCKNfc (ORCPT ); Wed, 11 Mar 2020 09:35:32 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:48343 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729551AbgCKNfc (ORCPT ); Wed, 11 Mar 2020 09:35:32 -0400 X-UUID: 1b2608dd0db04fff83e9cf39cfe30b47-20200311 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=McO5u8qL+2dJhFVvrj+B5fmGSNs+dJJtNOnC6DdTdJc=; b=Aq27vvjZcvPOEPPn1VNJtKGPz6WrJtnaFEyaa8jSyrsFfrILJyPzYOqgxePyAya8KC2mLT8/vgOfd6KPFoZSr+Y4pZ9gWMtNGzSiletX7KV/lmGONr6a2bmjO6WedI3oBdfT8+Ak1lf87cpENZBvc4592FWQK54VW8YlFht246c=; X-UUID: 1b2608dd0db04fff83e9cf39cfe30b47-20200311 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1823203278; Wed, 11 Mar 2020 21:35:27 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 21:35:26 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 11 Mar 2020 21:35:10 +0800 Message-ID: <1583933726.1550.1.camel@mtksdaap41> Subject: Re: [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing From: CK Hu To: Matthias Brugger CC: Enric Balletbo i Serra , , , , , , , , , Matthias Brugger , , Allison Randal , Greg Kroah-Hartman , , "Collabora Kernel ML" , , "Seiya Wang" , , , Daniel Vetter , , Mauro Carvalho Chehab , Kate Stewart , , Thomas Gleixner , , , , Richard Fontana , mtk01761 , Weiyi Lu , , , , Andrew-CT Chen , Houlong Wei , Minghsiu Tsai Date: Wed, 11 Mar 2020 21:35:26 +0800 In-Reply-To: <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com> References: <20200311115614.1425528-1-enric.balletbo@collabora.com> <20200311115614.1425528-6-enric.balletbo@collabora.com> <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org T24gV2VkLCAyMDIwLTAzLTExIGF0IDE0OjI2ICswMTAwLCBNYXR0aGlhcyBCcnVnZ2VyIHdyb3Rl Og0KPiANCj4gT24gMTEvMDMvMjAyMCAxMjo1NiwgRW5yaWMgQmFsbGV0Ym8gaSBTZXJyYSB3cm90 ZToNCj4gPiBJbiB0aGUgYWN0dWFsIGltcGxlbWVudGF0aW9uIHRoZSBzYW1lIGNvbXBhdGlibGUg c3RyaW5nDQo+ID4gIm1lZGlhdGVrLDxjaGlwPi1tbXN5cyIgaXMgdXNlZCB0byBiaW5kIHRoZSBj bG9jayBkcml2ZXJzDQo+ID4gKGRyaXZlcnMvc29jL21lZGlhdGVrKSBhcyB3ZWxsIGFzIHRvIHRo ZSBncHUgZHJpdmVyDQo+ID4gKGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5j KS4gVGhpcyBlbmRzIHdpdGggdGhlIHByb2JsZW0NCj4gPiB0aGF0IHRoZSBvbmx5IHByb2JlZCBk cml2ZXIgaXMgdGhlIGNsb2NrIGRyaXZlciBhbmQgdGhlcmUgaXMgbm8gZGlzcGxheQ0KPiA+IGF0 IGFsbC4NCj4gPiANCj4gPiBJbiBhbnkgY2FzZSBoYXZpbmcgdGhlIHNhbWUgY29tcGF0aWJsZSBz dHJpbmcgZm9yIHR3byBkcml2ZXJzIGlzIG5vdA0KPiA+IGNvcnJlY3QgYW5kIHNob3VsZCBiZSBm aXhlZC4gVG8gZml4IHRoaXMsIGFuZCBtYWludGFpbiBiYWNrd2FyZA0KPiA+IGNvbXBhdGliaWxp dHksIHdlIGNhbiBjb25zaWRlciB0aGF0IHRoZSBtbXN5cyBkcml2ZXIgaXMgdGhlIHRvcC1sZXZl bA0KPiA+IGVudHJ5IHBvaW50IGZvciB0aGUgbXVsdGltZWRpYSBzdWJzeXN0ZW0sIHNvIGlzIG5v dCBhIHB1cmUgY2xvY2sNCj4gPiBjb250cm9sbGVyIGJ1dCBhIHN5c3RlbSBjb250cm9sbGVyLCBh bmQgdGhlIGRybSBkcml2ZXIgaXMgaW5zdGFudGlhdGVkDQo+ID4gYnkgdGhhdCBNTVNZUyBkcml2 ZXIuDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogRW5yaWMgQmFsbGV0Ym8gaSBTZXJyYSA8ZW5y aWMuYmFsbGV0Ym9AY29sbGFib3JhLmNvbT4NCj4gPiBSZXZpZXdlZC1ieTogQ0sgSHUgPGNrLmh1 QG1lZGlhdGVrLmNvbT4NCj4gDQo+IFNhbWUgaGVyZS4NCg0KQWNrZWQtYnk6IENLIEh1IDxjay5o dUBtZWRpYXRlay5jb20+DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FAF3C10F27 for ; Wed, 11 Mar 2020 13:36:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41C1B20873 for ; Wed, 11 Mar 2020 13:36:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sKtwZKmS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Q7F2/kHw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41C1B20873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iKRzY8sc6865oXy1h2XsrQ5WpOrOmgXIgWzQek5mhT8=; b=sKtwZKmSw5Feir Q6btBhwougJoMs+2HsKBUZ6I4Ya7jrBJM0eJmHpWUaBnX+f9roPhq0ZrQV04KJPXJJ+jHQp+6nUvr vKA1Y9Rq4Smtb3KZ8Jnd3fVBfGzNOadBujViDYm+x2SdIShvztmEVyPo3anvczmwjHjitK55AiZdu 0CxxK/ACZoAHH+dPnK/IB7F9eUsUokUXYRV161Zk3NdYr36Qf3gVX+cW7VlgPNO8r22txpsujCXaO 4Cvi9my08FMxj/lKosEWWA6GClSaIjdQTTKcYwwAnMaYdIDBorp87Iy2VCR//qJTu4anOLs6st+dx 52ZGKH4EQWC2sJ4Bj99w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC1WZ-0000Mh-4S; Wed, 11 Mar 2020 13:35:51 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC1WI-00007g-2p; Wed, 11 Mar 2020 13:35:35 +0000 X-UUID: e56f0075960d49c5a2992a60b3ab4135-20200311 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=McO5u8qL+2dJhFVvrj+B5fmGSNs+dJJtNOnC6DdTdJc=; b=Q7F2/kHwommk2mz09pXfwLp7xVMeNpjJtHnnQuSsY8y3FL7SRMEmMszyIIh1OfI6DCofaMjxggnOXg9SUePwRdan+GDZFoZ5XaQac+rmB3Pq7Dqx6jZFCph6UtpdcGXB6XvPtBCq7HAwfw93VOqGTuXl6lnYYpT+YKeDE4ryRX8=; X-UUID: e56f0075960d49c5a2992a60b3ab4135-20200311 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1973424822; Wed, 11 Mar 2020 05:35:29 -0800 Received: from MTKMBS06N1.mediatek.inc (172.21.101.129) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 06:35:27 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 21:35:26 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 11 Mar 2020 21:35:10 +0800 Message-ID: <1583933726.1550.1.camel@mtksdaap41> Subject: Re: [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing From: CK Hu To: Matthias Brugger Date: Wed, 11 Mar 2020 21:35:26 +0800 In-Reply-To: <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com> References: <20200311115614.1425528-1-enric.balletbo@collabora.com> <20200311115614.1425528-6-enric.balletbo@collabora.com> <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_063534_136143_B3B56045 X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Kate Stewart , Minghsiu Tsai , Andrew-CT Chen , airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, Richard Fontana , laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, Collabora Kernel ML , linux-clk@vger.kernel.org, Weiyi Lu , wens@csie.org, linux-arm-kernel@lists.infradead.org, mtk01761 , linux-media@vger.kernel.org, devicetree@vger.kernel.org, p.zabel@pengutronix.de, frank-w@public-files.de, Seiya Wang , sean.wang@mediatek.com, Houlong Wei , robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , Thomas Gleixner , Mauro Carvalho Chehab , Allison Randal , sboyd@kernel.org, Greg Kroah-Hartman , rdunlap@infradead.org, linux-kernel@vger.kernel.org, Daniel Vetter , matthias.bgg@kernel.org, Enric Balletbo i Serra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2020-03-11 at 14:26 +0100, Matthias Brugger wrote: > > On 11/03/2020 12:56, Enric Balletbo i Serra wrote: > > In the actual implementation the same compatible string > > "mediatek,-mmsys" is used to bind the clock drivers > > (drivers/soc/mediatek) as well as to the gpu driver > > (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends with the problem > > that the only probed driver is the clock driver and there is no display > > at all. > > > > In any case having the same compatible string for two drivers is not > > correct and should be fixed. To fix this, and maintain backward > > compatibility, we can consider that the mmsys driver is the top-level > > entry point for the multimedia subsystem, so is not a pure clock > > controller but a system controller, and the drm driver is instantiated > > by that MMSYS driver. > > > > Signed-off-by: Enric Balletbo i Serra > > Reviewed-by: CK Hu > > Same here. Acked-by: CK Hu _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7418BC10F27 for ; Wed, 11 Mar 2020 13:35:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40E4A20873 for ; Wed, 11 Mar 2020 13:35:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oI43MJBu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Q7F2/kHw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40E4A20873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0+4z0Kz4XGliW9XC9ZobyFBxwVsIB8s6wEbWh7Z/JC4=; b=oI43MJBucV9Ry8 IG+HEkK/qKwNECBEZuQzGCphmB92RjuFgT4iMRRB9XS3RipfbAtJCR9Yt6E35gyhR9YDPgTxzh1C1 +u1+2cP7d4nSaGSsdKrYYcj76OuQ/P/7WnJcRWpRuzt1iXydJJMXvItATnB9nQre/Mn7Qi1gmo7AJ 8MpfBJMpZflYMgoa0K0SmGzjSDJTy1dOspICQ2v0jbTjAcxM1piUJHFFXZIb6OYb665/+kDIepqKA d3IsAiZd5ByHPXH/l6xYfBwyOP6o/gHe9vnIl9IN5EEr5A/AzMHprcNHYkfOpgeGT0gLIklJiM84a t86pBk7EXkXeyJ7eWJ3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC1WN-0000Bc-VH; Wed, 11 Mar 2020 13:35:40 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC1WI-00007g-2p; Wed, 11 Mar 2020 13:35:35 +0000 X-UUID: e56f0075960d49c5a2992a60b3ab4135-20200311 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=McO5u8qL+2dJhFVvrj+B5fmGSNs+dJJtNOnC6DdTdJc=; b=Q7F2/kHwommk2mz09pXfwLp7xVMeNpjJtHnnQuSsY8y3FL7SRMEmMszyIIh1OfI6DCofaMjxggnOXg9SUePwRdan+GDZFoZ5XaQac+rmB3Pq7Dqx6jZFCph6UtpdcGXB6XvPtBCq7HAwfw93VOqGTuXl6lnYYpT+YKeDE4ryRX8=; X-UUID: e56f0075960d49c5a2992a60b3ab4135-20200311 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1973424822; Wed, 11 Mar 2020 05:35:29 -0800 Received: from MTKMBS06N1.mediatek.inc (172.21.101.129) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 06:35:27 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 21:35:26 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 11 Mar 2020 21:35:10 +0800 Message-ID: <1583933726.1550.1.camel@mtksdaap41> Subject: Re: [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing From: CK Hu To: Matthias Brugger Date: Wed, 11 Mar 2020 21:35:26 +0800 In-Reply-To: <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com> References: <20200311115614.1425528-1-enric.balletbo@collabora.com> <20200311115614.1425528-6-enric.balletbo@collabora.com> <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_063534_136143_B3B56045 X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Kate Stewart , Minghsiu Tsai , Andrew-CT Chen , airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, Richard Fontana , laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, Collabora Kernel ML , linux-clk@vger.kernel.org, Weiyi Lu , wens@csie.org, linux-arm-kernel@lists.infradead.org, mtk01761 , linux-media@vger.kernel.org, devicetree@vger.kernel.org, p.zabel@pengutronix.de, frank-w@public-files.de, Seiya Wang , sean.wang@mediatek.com, Houlong Wei , robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , Thomas Gleixner , Mauro Carvalho Chehab , Allison Randal , sboyd@kernel.org, Greg Kroah-Hartman , rdunlap@infradead.org, linux-kernel@vger.kernel.org, Daniel Vetter , matthias.bgg@kernel.org, Enric Balletbo i Serra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-03-11 at 14:26 +0100, Matthias Brugger wrote: > > On 11/03/2020 12:56, Enric Balletbo i Serra wrote: > > In the actual implementation the same compatible string > > "mediatek,-mmsys" is used to bind the clock drivers > > (drivers/soc/mediatek) as well as to the gpu driver > > (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends with the problem > > that the only probed driver is the clock driver and there is no display > > at all. > > > > In any case having the same compatible string for two drivers is not > > correct and should be fixed. To fix this, and maintain backward > > compatibility, we can consider that the mmsys driver is the top-level > > entry point for the multimedia subsystem, so is not a pure clock > > controller but a system controller, and the drm driver is instantiated > > by that MMSYS driver. > > > > Signed-off-by: Enric Balletbo i Serra > > Reviewed-by: CK Hu > > Same here. Acked-by: CK Hu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 603C3C3F2D0 for ; Wed, 11 Mar 2020 13:35:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34F0321D56 for ; Wed, 11 Mar 2020 13:35:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Aq27vvjZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34F0321D56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 854C16E98A; Wed, 11 Mar 2020 13:35:32 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E5FD89C6C for ; Wed, 11 Mar 2020 13:35:30 +0000 (UTC) X-UUID: 1b2608dd0db04fff83e9cf39cfe30b47-20200311 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=McO5u8qL+2dJhFVvrj+B5fmGSNs+dJJtNOnC6DdTdJc=; b=Aq27vvjZcvPOEPPn1VNJtKGPz6WrJtnaFEyaa8jSyrsFfrILJyPzYOqgxePyAya8KC2mLT8/vgOfd6KPFoZSr+Y4pZ9gWMtNGzSiletX7KV/lmGONr6a2bmjO6WedI3oBdfT8+Ak1lf87cpENZBvc4592FWQK54VW8YlFht246c=; X-UUID: 1b2608dd0db04fff83e9cf39cfe30b47-20200311 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1823203278; Wed, 11 Mar 2020 21:35:27 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Mar 2020 21:35:26 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 11 Mar 2020 21:35:10 +0800 Message-ID: <1583933726.1550.1.camel@mtksdaap41> Subject: Re: [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing From: CK Hu To: Matthias Brugger Date: Wed, 11 Mar 2020 21:35:26 +0800 In-Reply-To: <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com> References: <20200311115614.1425528-1-enric.balletbo@collabora.com> <20200311115614.1425528-6-enric.balletbo@collabora.com> <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Kate Stewart , Minghsiu Tsai , Andrew-CT Chen , airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, Richard Fontana , laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, Collabora Kernel ML , linux-clk@vger.kernel.org, Weiyi Lu , wens@csie.org, linux-arm-kernel@lists.infradead.org, mtk01761 , linux-media@vger.kernel.org, devicetree@vger.kernel.org, frank-w@public-files.de, Seiya Wang , sean.wang@mediatek.com, Houlong Wei , robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , Thomas Gleixner , Mauro Carvalho Chehab , Allison Randal , sboyd@kernel.org, Greg Kroah-Hartman , rdunlap@infradead.org, linux-kernel@vger.kernel.org, matthias.bgg@kernel.org, Enric Balletbo i Serra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 2020-03-11 at 14:26 +0100, Matthias Brugger wrote: > > On 11/03/2020 12:56, Enric Balletbo i Serra wrote: > > In the actual implementation the same compatible string > > "mediatek,-mmsys" is used to bind the clock drivers > > (drivers/soc/mediatek) as well as to the gpu driver > > (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends with the problem > > that the only probed driver is the clock driver and there is no display > > at all. > > > > In any case having the same compatible string for two drivers is not > > correct and should be fixed. To fix this, and maintain backward > > compatibility, we can consider that the mmsys driver is the top-level > > entry point for the multimedia subsystem, so is not a pure clock > > controller but a system controller, and the drm driver is instantiated > > by that MMSYS driver. > > > > Signed-off-by: Enric Balletbo i Serra > > Reviewed-by: CK Hu > > Same here. Acked-by: CK Hu _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel