From: Oliver Neukum <oneukum@suse.com>
To: Jonas Karlsson <jonas.karlsson@actia.se>,
Fabio Estevam <festevam@gmail.com>
Cc: Peter Chen <peter.chen@nxp.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: USB transaction errors causing RCU stalls and kernel panics
Date: Thu, 12 Mar 2020 14:45:39 +0100 [thread overview]
Message-ID: <1584020739.20566.10.camel@suse.com> (raw)
In-Reply-To: <ad6b4f2d72f84726a398b41007839f77@actia.se>
Am Mittwoch, den 11.03.2020, 14:59 +0000 schrieb Jonas Karlsson:
> Hi Oliver,
>
> > Hi,
> >
> > it is good that we have something that works.
> > It would be even better if we understood exactly how it works. In fact that
> > these patches work and are needed may very well indicate that error
> > handling on at least some XHCs does not work as expected.
> >
> > So a question and a request, if I may.
> > Did you run the test with autosuspend disabled? If so could you retest with it
> > enabled?
>
> I have only tested with autosuspend enabled.
>
> > Secondly could you run tests with
> >
> > commit 7c8f7af078a4eda73f347667d12584736e613062
> > Author: Oliver Neukum <oneukum@suse.com>
> > Date: Thu Mar 5 11:16:02 2020 +0100
> >
> > cdc-acm: close race betrween suspend() and acm_softint
> >
> > not applied (respectively reverted) with and without autosuspend?
>
> I ran a test with this commit reverted and saw no difference in behavior.
> i.e we do not get event spam with this commit reverted.
> I tested with enabled and disabled autosuspend.
>
> >
> > Regards
> > Oliver
> >
> > PS: When I submit upstream, may I add your 'Tested-by'?
>
> Sure, you can add me, but I have only tested that this specific problem
> seems to be solved. The normal functionality has not been tested properly yet
> on our side.
Hi,
thank you. In this case it looks like the wisest course is to wait
a few days then. Thank you for thorough testing.
Regards
Oliver
next prev parent reply other threads:[~2020-03-12 13:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 15:05 USB transaction errors causing RCU stalls and kernel panics Jonas Karlsson
2020-03-03 16:39 ` Greg KH
2020-03-03 20:08 ` Jonas Karlsson
2020-03-04 6:37 ` Greg KH
2020-03-04 10:29 ` Oliver Neukum
2020-03-04 12:11 ` Mathias Nyman
2020-03-04 14:12 ` Oliver Neukum
2020-03-04 16:21 ` Mathias Nyman
2020-03-06 1:31 ` Peter Chen
2020-03-09 14:21 ` Jonas Karlsson
2020-03-10 8:14 ` Peter Chen
2020-03-10 10:04 ` Jonas Karlsson
2020-03-10 11:04 ` Oliver Neukum
2020-03-10 11:21 ` Oliver Neukum
2020-03-10 12:26 ` Jonas Karlsson
2020-03-10 16:04 ` Jonas Karlsson
2020-03-10 16:11 ` Fabio Estevam
2020-03-11 6:25 ` Jonas Karlsson
2020-03-11 10:28 ` Oliver Neukum
2020-03-11 14:59 ` Jonas Karlsson
2020-03-12 13:45 ` Oliver Neukum [this message]
2020-03-12 15:37 ` Jonas Karlsson
2020-03-13 9:27 ` Oliver Neukum
2020-03-16 7:07 ` Jonas Karlsson
2020-03-23 11:37 ` Jonas Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584020739.20566.10.camel@suse.com \
--to=oneukum@suse.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonas.karlsson@actia.se \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.