From: James Bottomley <James.Bottomley@hansenpartnership.com>
To: Sami Tolvanen <samitolvanen@google.com>,
"Shetty,
Harshini X (EXT-Sony Mobile)" <Harshini.X.Shetty@sony.com>
Cc: "snitzer@redhat.com" <snitzer@redhat.com>,
"Takeuchi, Shingo (SOMC)" <Shingo.Takeuchi@sony.com>,
"Nagaraju, Srinavasa (SOMC)" <Srinavasa.Nagaraju@sony.com>,
"Khasnis, Soumya X (EXT-Sony Mobile)" <Soumya.Khasnis@sony.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"Takahashi, Masaya (SOMC)" <Masaya.Takahashi@sony.com>,
"agk@redhat.com" <agk@redhat.com>
Subject: Re: [PATCH] dm verity fec: Fix memory leak in verity_fec_ctr
Date: Tue, 17 Mar 2020 10:04:16 -0700 [thread overview]
Message-ID: <1584464656.4545.15.camel@HansenPartnership.com> (raw)
In-Reply-To: <CABCJKuf6X6fi8fqF_z0HYX0rnD8b98=L-8Y31=OiPEVzw0d1_Q@mail.gmail.com>
You two broke threading on this for what looks like non-trivial
reasons. Threading is becoming very important to us with the mbox
tools, so it's important to get right.
The original problem is that the first message id is illegal under RFC
2822:
> Message-Id: <20200317091212.GA18241@harshini.x.shetty@sony.com>
You can't have two @ signs in a Message-id. However, your emailer
completely made up the in-repy-to id which should quote the original
message id:
> References: <5e70da92.1c69fb81.c30ac.5d5cSMTPIN_ADDED_BROKEN@mx.google.com>
> In-Reply-To: <5e70da92.1c69fb81.c30ac.5d5cSMTPIN_ADDED_BROKEN@mx.google.com>
Which is why threading broke.
Can you both try to fix this? The google problem looks to be atypical
because if I look at any other mailer behaviour it will simply quote a message-id back in the In-Reply-To without checking for legality.
James
next prev parent reply other threads:[~2020-03-17 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5e70da92.1c69fb81.c30ac.5d5cSMTPIN_ADDED_BROKEN@mx.google.com>
2020-03-17 16:09 ` [PATCH] dm verity fec: Fix memory leak in verity_fec_ctr Sami Tolvanen
2020-03-17 17:04 ` James Bottomley [this message]
[not found] <20200317091212.GA18241@harshini.x.shetty@sony.com>
2020-03-18 15:44 ` Heinz Mauelshagen
2020-03-17 9:15 Shetty, Harshini X (EXT-Sony Mobile)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584464656.4545.15.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=Harshini.X.Shetty@sony.com \
--cc=Masaya.Takahashi@sony.com \
--cc=Shingo.Takeuchi@sony.com \
--cc=Soumya.Khasnis@sony.com \
--cc=Srinavasa.Nagaraju@sony.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=samitolvanen@google.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.