From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1DA0C10DCE for ; Wed, 18 Mar 2020 06:07:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8827820773 for ; Wed, 18 Mar 2020 06:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584511628; bh=rHPn9XeAZQ2kzK5ayrYf919Ma7gG/YgUKIC5TPoXMbY=; h=Subject:To:From:Date:List-ID:From; b=Zvr6Il3LQzIa2AXH3EVieqaOZBVYehxoQ5ht1YYm515s/bRUFXzJlF1zpES9hlqUX rgl0Vfm6gk3qmSwymk63NSQ6CRiiL08kzk9Fr5ctQZ3FOnmPpSfZRjvpuv7W1v3CC2 UANf/9Nr7Zfp3RJ1Bf58D4ERUfYtBH3udT5FE7js= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726553AbgCRGHI (ORCPT ); Wed, 18 Mar 2020 02:07:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:38272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbgCRGHI (ORCPT ); Wed, 18 Mar 2020 02:07:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2A4320772; Wed, 18 Mar 2020 06:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584511627; bh=rHPn9XeAZQ2kzK5ayrYf919Ma7gG/YgUKIC5TPoXMbY=; h=Subject:To:From:Date:From; b=nJJFft+zwmAZLMMEv9DGypQicvYgA8FgIvtDfljq+GQJlxjLdVX54XQc/Sww9tMZ4 C12LJZ2IcitBNiHnhHrAtlEohx24nF4Ji5EcvPicZnjF3/TpNS2wu4dTbpnOcRrgdA Fcq+2mU/GkWGqJyS8Yh3KjIbTf0elk2kObgDl7kU= Subject: patch "serial: sprd: Fix a dereference warning" added to tty-next To: liuhhome@gmail.com, dan.carpenter@oracle.com, gregkh@linuxfoundation.org, stable@vger.kernel.org From: Date: Wed, 18 Mar 2020 07:06:39 +0100 Message-ID: <15845115997854@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This is a note to let you know that I've just added the patch titled serial: sprd: Fix a dereference warning to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. >From efc176929a3505a30c3993ddd393b40893649bd2 Mon Sep 17 00:00:00 2001 From: Lanqing Liu Date: Mon, 16 Mar 2020 11:13:33 +0800 Subject: serial: sprd: Fix a dereference warning We should validate if the 'sup' is NULL or not before freeing DMA memory, to fix below warning. "drivers/tty/serial/sprd_serial.c:1141 sprd_remove() error: we previously assumed 'sup' could be null (see line 1132)" Fixes: f4487db58eb7 ("serial: sprd: Add DMA mode support") Reported-by: Dan Carpenter Signed-off-by: Lanqing Liu Cc: stable Link: https://lore.kernel.org/r/e2bd92691538e95b04a2c2a728f3292e1617018f.1584325957.git.liuhhome@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/sprd_serial.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c index 914862844790..509781ee26bf 100644 --- a/drivers/tty/serial/sprd_serial.c +++ b/drivers/tty/serial/sprd_serial.c @@ -1132,14 +1132,13 @@ static int sprd_remove(struct platform_device *dev) if (sup) { uart_remove_one_port(&sprd_uart_driver, &sup->port); sprd_port[sup->port.line] = NULL; + sprd_rx_free_buf(sup); sprd_ports_num--; } if (!sprd_ports_num) uart_unregister_driver(&sprd_uart_driver); - sprd_rx_free_buf(sup); - return 0; } -- 2.25.1