From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Date: Thu, 19 Mar 2020 18:59:06 +0000 Subject: Re: [PATCH v8 6/8] security: keys: trusted: add PCR policy to TPM2 keys Message-Id: <1584644346.3610.31.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20200310051607.30334-7-James.Bottomley@HansenPartnership.com> <20200310051607.30334-1-James.Bottomley@HansenPartnership.com> <3180901.1584637023@warthog.procyon.org.uk> In-Reply-To: <3180901.1584637023@warthog.procyon.org.uk> To: David Howells Cc: linux-integrity@vger.kernel.org, Mimi Zohar , Jarkko Sakkinen , David Woodhouse , keyrings@vger.kernel.org On Thu, 2020-03-19 at 16:57 +0000, David Howells wrote: > James Bottomley wrote: > > > keyctl new 32 keyhandle=0x81000001 hash=sha1 > > pcrinfo0000016768033e216468247bd > > 031a0a2d9876d79818f8f" @u > > I think part of this got lost. There's only one '"' for a start. Yes, it's a cut and paste error in the change log. It was cut out of the additions to Documentation/security/keys/trusted-encrypted.rst and should read keyctl add trusted kmk "new 32 keyhandle=0x81000001 hash=sha1 pcrinfo0000016768033e216468247bd031a0a2d9876d79818f8f" @u James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A46DC4332D for ; Thu, 19 Mar 2020 18:59:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E70A020789 for ; Thu, 19 Mar 2020 18:59:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="SwlHbIg5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="SwlHbIg5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726934AbgCSS7I (ORCPT ); Thu, 19 Mar 2020 14:59:08 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:40748 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726867AbgCSS7I (ORCPT ); Thu, 19 Mar 2020 14:59:08 -0400 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id C5B888EE369; Thu, 19 Mar 2020 11:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1584644347; bh=uJIoh2jx98mn2qGVUnljTbvG6mLwo6Kq7M1zlhK7W78=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SwlHbIg5v998+4QyMTTcjA7b50KVIb1mWwL2Z3qC0eZ3ouzI3tmXWO0zV0mhQH+01 2LZdx6QbZe38uyJcRjyzG0QdZjZzuIJpCA+Odocb3J/xb+Z+4mFx8ry2C3L95nno2J kh2r+tPcDYCyP7KhkB9TrBQ94/lba6Pe/7WPA9IE= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6zgk8J_46sTZ; Thu, 19 Mar 2020 11:59:07 -0700 (PDT) Received: from [153.66.254.194] (unknown [50.35.76.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 29E088EE182; Thu, 19 Mar 2020 11:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1584644347; bh=uJIoh2jx98mn2qGVUnljTbvG6mLwo6Kq7M1zlhK7W78=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SwlHbIg5v998+4QyMTTcjA7b50KVIb1mWwL2Z3qC0eZ3ouzI3tmXWO0zV0mhQH+01 2LZdx6QbZe38uyJcRjyzG0QdZjZzuIJpCA+Odocb3J/xb+Z+4mFx8ry2C3L95nno2J kh2r+tPcDYCyP7KhkB9TrBQ94/lba6Pe/7WPA9IE= Message-ID: <1584644346.3610.31.camel@HansenPartnership.com> Subject: Re: [PATCH v8 6/8] security: keys: trusted: add PCR policy to TPM2 keys From: James Bottomley To: David Howells Cc: linux-integrity@vger.kernel.org, Mimi Zohar , Jarkko Sakkinen , David Woodhouse , keyrings@vger.kernel.org Date: Thu, 19 Mar 2020 11:59:06 -0700 In-Reply-To: <3180901.1584637023@warthog.procyon.org.uk> References: <20200310051607.30334-7-James.Bottomley@HansenPartnership.com> <20200310051607.30334-1-James.Bottomley@HansenPartnership.com> <3180901.1584637023@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, 2020-03-19 at 16:57 +0000, David Howells wrote: > James Bottomley wrote: > > > keyctl new 32 keyhandle=0x81000001 hash=sha1 > > pcrinfo=030000016768033e216468247bd > > 031a0a2d9876d79818f8f" @u > > I think part of this got lost. There's only one '"' for a start. Yes, it's a cut and paste error in the change log. It was cut out of the additions to Documentation/security/keys/trusted-encrypted.rst and should read keyctl add trusted kmk "new 32 keyhandle=0x81000001 hash=sha1 pcrinfo=030000016768033e216468247bd031a0a2d9876d79818f8f" @u James