From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v5 0/7] drm/panel: simple: Add mode support to devicetree Date: Fri, 14 Jun 2019 12:39:31 +0200 Message-ID: <1584725.WvTV0KElQL@phil> References: <20190401171724.215780-1-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190401171724.215780-1-dianders@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Douglas Anderson , Thierry Reding Cc: Mark Rutland , devicetree@vger.kernel.org, Dmitry Torokhov , Rob Herring , David Airlie , Viresh Kumar , Brian Norris , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Sean Paul , Laurent Pinchart , Enric =?ISO-8859-1?Q?Balletb=F2?= , Klaus Goger , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org QW0gTW9udGFnLCAxLiBBcHJpbCAyMDE5LCAxOToxNzoxNyBDRVNUIHNjaHJpZWIgRG91Z2xhcyBB bmRlcnNvbjoKPiBJJ20gcmV2aXZpbmcgU2VhbiBQYXVsJ3Mgb2xkIHBhdGNoc2V0IHRvIGdldCBt b2RlIHN1cHBvcnQgaW4gZGV2aWNlCj4gdHJlZS4gIFRoZSBjb3ZlciBsZXR0ZXIgZm9yIGhpcyB2 MyBpcyBhdDoKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2 ZWwvMjAxOC1GZWJydWFyeS8xNjUxNjIuaHRtbAo+IAo+IE5vIGNvZGUgaXMgZGlmZmVyZW50IGJl dHdlZW4gdjQgYW5kIHY1LCBqdXN0IGNvbW1pdCBtZXNzYWdlcyBhbmQgdGV4dAo+IGluIHRoZSBi aW5kaW5ncy4KPiAKPiBJJ3ZlIHB1bGxlZCB0b2dldGhlciB0aGUgcGF0Y2hlcyB0aGF0IGRpZG4n dCBsYW5kIGluIHYzLCBhZGRyZXNzZWQKPiBvdXRzdGFuZGluZyBmZWVkYmFjaywgYW5kIHJlcG9z dGVkLiAgQXRvcCB0aGVtIEkndmUgYWRkZWQgcGF0Y2hlcyBmb3IKPiByazMyODgtdmV5cm9uLWNo cm9tZWJvb2sgKHVzZWQgZm9yIGphcSwgamVycnksIG1pZ2h0eSwgc3BlZWR5KSBhbmQKPiByazMy ODgtdmVyeW9uLW1pbm5pZS4KPiAKPiBQbGVhc2UgbGV0IG1lIGtub3cgaG93IHRoZXkgbG9vay4K PiAKPiBJbiBnZW5lcmFsIEkgaGF2ZSBhZGRlZCBwZW9wbGUgdG8gdGhlIHdob2xlIHNlcmllcyB3 aG8gSSB0aGluayB3b3VsZAo+IGxpa2UgdGhlIHdob2xlIHNlcmllcyBhbmQgdGhlbiBsZXQgZ2V0 X21haW50YWluZXIgcGljayBleHRyYSBwZW9wbGUgaXQKPiB0aGlua3MgYXJlIHJlbGV2YW50IHRv IGVhY2ggaW5kaXZpZHVhbCBwYXRjaC4gIElmIEkgc2VlIHlvdSByZXNwb25kIHRvCj4gYW55IG9m IHRoZSBwYXRjaGVzIGluIHRoZSBzZXJpZXMsIHRob3VnaCwgSSdsbCBhZGQgeW91IHRvIHRoZSB3 aG9sZQo+IHNlcmllcyBDYyBsaXN0IG5leHQgdGltZS4KCnNhZGx5IGl0IGxvb2tzIGxpa2UgdGhl IHBhbmVsLXNpbXBsZSBwYXJ0cyBoYXZlbid0IG1hZGUgaXQgaW50bwpkcm0tbWlzYyB5ZXQgYW5k IHRoZSBjb252ZXJzYXRpb24gb24gcGF0Y2ggMS83IHNlZW1zIHRvIGhhdmUgc3RhbGxlZAphZnRl ciBEb3VnJ3MgcmVwbGllcy4KClRoaWVycnksIGRvIHlvdSBoYXZlIGFuIG9waW5pb24gb24gdGhl c2U/CgoKVGhhbmtzCkhlaWtvCgo+IENoYW5nZXMgaW4gdjU6Cj4gLSBSZW1vdmVkIGJpdCBhYm91 dCBPUyBtYXkgaWdub3JlIChSb2IvRXplcXVpZWwpCj4gLSBBZGRlZCBIZWlrbydzIFRlc3RlZC1i eQo+IC0gSXQncyBub3QganVzdCBqZXJyeSwgaXQncyBtb3N0IHJrMzI4OCBDaHJvbWVib29rcyAo SGVpa28pCj4gCj4gQ2hhbmdlcyBpbiB2NDoKPiAtIFNpbXBsaWZ5IGRlc2MuIGZvciB3aGVuIG92 ZXJyaWRlIHNob3VsZCBiZSB1c2VkIChUaGllcnJ5L0xhdXJlbnQpCj4gLSBSZW1vdmVkIFJvYiBI IHJldmlldyBzaW5jZSBpdCdzIGJlZW4gYSB5ZWFyIGFuZCB3b3JkaW5nIGNoYW5nZWQKPiAtIERv bid0IGFkZCBtb2RlIGZyb20gdGltaW5nIGlmIG92ZXJyaWRlIHdhcyBzcGVjaWZpZWQgKFRoaWVy cnkpCj4gLSBBZGQgd2FybmluZyBpZiB0aW1pbmcgYW5kIGZpeGVkIG1vZGUgd2FzIHNwZWNpZmll ZCAoVGhpZXJyeSkKPiAtIERvbid0IGFkZCBmaXhlZCBtb2RlIGlmIHRpbWluZyB3YXMgc3BlY2lm aWVkIChUaGllcnJ5KQo+IC0gUmVmYWN0b3IvcmVuYW1lIGEgYml0IHRvIGF2b2lkIGV4dHJhIGlu ZGVudGF0aW9uIGZyb20gImlmIiB0ZXN0cwo+IC0gaSBzaG91bGQgYmUgdW5zaWduZWQgKFRoaWVy cnkpCj4gLSBBZGQgYW5ub3lpbmcgV0FSTl9PTnMgZm9yIHNvbWUgY2FzZXMgKFRoaWVycnkpCj4g LSBTaW1wbGlmeSAnTm8gZGlzcGxheV90aW1pbmcgZm91bmQnIGhhbmRsaW5nIChUaGllcnJ5KQo+ IC0gUmVuYW1lIHRvIHBhbmVsX3NpbXBsZV9wYXJzZV9vdmVycmlkZV9tb2RlKCkgKFRoaWVycnkp Cj4gLSBSZWJhc2UgdG8gdG9wIG9mIEhlaWtvJ3MgdHJlZQo+IC0gQ29udmVydGVkIGNoYW5nZWxv ZyB0byBhZnRlci10aGUtY3V0IGZvciBub24tRFJNIGNoYW5nZS4KPiAtIGRpc3BsYXlfdGltaW5n IGZvciBJbm5vbHV4IG4xMTZiZ2UgbmV3IGZvciB2NC4KPiAtIGRpc3BsYXlfdGltaW5nIGZvciBB VU8gYjEwMWVhbjAxIG5ldyBmb3IgdjQuCj4gLSByazMyODgtdmV5cm9uLWplcnJ5IHBhdGNoIG5l dyBmb3IgdjQuCj4gLSByazMyODgtdmV5cm9uLW1pbm5pZSBwYXRjaCBuZXcgZm9yIHY0Lgo+IAo+ IENoYW5nZXMgaW4gdjM6Cj4gLSBHbyBiYWNrIHRvIHVzaW5nIHRoZSB0aW1pbmcgc3Vibm9kZSBk aXJlY3RseSwgYnV0IHJlbmFtZSB0bwo+ICAgcGFuZWwtdGltaW5nIChSb2IpCj4gLSBObyBsb25n ZXIgcGFyc2UgZGlzcGxheS10aW1pbmdzIHN1Ym5vZGUsIHVzZSBwYW5lbC10aW1pbmcgKFJvYikK PiAtIFVud3JhcCB0aGUgdGltaW5nIGZyb20gZGlzcGxheS10aW1pbmdzIGFuZCByZW5hbWUgcGFu ZWwtdGltaW5nIChSb2IpCj4gCj4gQ2hhbmdlcyBpbiB2MjoKPiAtIFNwbGl0IG91dCB0aGUgYmlu ZGluZyBpbnRvIGEgbmV3IHBhdGNoIChSb2IpCj4gLSBkaXNwbGF5LXRpbWluZ3MgaXMgYSBuZXcg c2VjdGlvbiAoUm9iKQo+IC0gVXNlIHRoZSBmdWxsIGRpc3BsYXktdGltaW5ncyBzdWJub2RlIGlu c3RlYWQgb2YgcGlja2luZyB0aGUgdGltaW5nCj4gICBvdXQgKFJvYi9UaGllcnJ5KQo+IC0gUGFy c2UgdGhlIGZ1bGwgZGlzcGxheS10aW1pbmdzIG5vZGUgKHVzaW5nIHRoZSBuYXRpdmUtbW9kZSkg KFJvYikKPiAtIFdyYXAgdGhlIHRpbWluZyBpbiBkaXNwbGF5LXRpbWluZ3Mgbm9kZSB0byBtYXRj aCBiaW5kaW5nIChSb2IvVGhpZXJyeSkKPiAKPiBEb3VnbGFzIEFuZGVyc29uICg0KToKPiAgIGRy bS9wYW5lbDogc2ltcGxlOiBVc2UgZGlzcGxheV90aW1pbmcgZm9yIElubm9sdXggbjExNmJnZQo+ ICAgZHJtL3BhbmVsOiBzaW1wbGU6IFVzZSBkaXNwbGF5X3RpbWluZyBmb3IgQVVPIGIxMDFlYW4w MQo+ICAgQVJNOiBkdHM6IHJvY2tjaGlwOiBTcGVjaWZ5IHJrMzI4OC12ZXlyb24tY2hyb21lYm9v aydzIGRpc3BsYXkgdGltaW5ncwo+ICAgQVJNOiBkdHM6IHJvY2tjaGlwOiBTcGVjaWZ5IHJrMzI4 OC12ZXlyb24tbWlubmllJ3MgZGlzcGxheSB0aW1pbmdzCj4gCj4gU2VhbiBQYXVsICgzKToKPiAg IGR0LWJpbmRpbmdzOiBBZGQgcGFuZWwtdGltaW5nIHN1Ym5vZGUgdG8gc2ltcGxlLXBhbmVsCj4g ICBkcm0vcGFuZWw6IHNpbXBsZTogQWRkIGFiaWxpdHkgdG8gb3ZlcnJpZGUgdHlwaWNhbCB0aW1p bmcKPiAgIGFybTY0OiBkdHM6IHJvY2tjaGlwOiBTcGVjaWZ5IG92ZXJyaWRlIG1vZGUgZm9yIGtl dmluIHBhbmVsCj4gCj4gIC4uLi9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL3NpbXBsZS1wYW5lbC50 eHQgICB8ICAyMiArKysKPiAgLi4uL2Jvb3QvZHRzL3JrMzI4OC12ZXlyb24tY2hyb21lYm9vay5k dHNpICAgIHwgIDE0ICsrCj4gIGFyY2gvYXJtL2Jvb3QvZHRzL3JrMzI4OC12ZXlyb24tbWlubmll LmR0cyAgICB8ICAxNCArKwo+ICAuLi4vYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LWdydS1rZXZp bi5kdHMgICAgfCAgMTQgKysKPiAgZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5j ICAgICAgICAgIHwgMTcxICsrKysrKysrKysrKysrLS0tLQo+ICA1IGZpbGVzIGNoYW5nZWQsIDIw MyBpbnNlcnRpb25zKCspLCAzMiBkZWxldGlvbnMoLSkKPiAKPiAKCgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7CCC31E44 for ; Fri, 14 Jun 2019 10:42:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBF8E208CA for ; Fri, 14 Jun 2019 10:42:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H1eXMkSr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBF8E208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2hw6mWB4O2WWhab6KiVxmdgoT1coqGelXY+W9YwxNJE=; b=H1eXMkSr2EDb1B KoRXtL+K1l3vImsrUem6FXt5pK7GDR+jco5gMIywZdGpyaE7M7jgKsZ5ChZsxt0JFATD2Angq9zh+ wADfxJ7it+f3izlH9uMK0zVPAFKu9t2dCatZfzjI9GcKJcXDvXb0SqVTAWRDY8VmZjaYwzi1zXYms aa/QWltZo8D37PfyDpU68+2AkGBvP2KDl6CyptgOoVhJ1SqzufIaSiG997RvcN7/cKnizGhrDbuO8 eWld8hAplb0RRzhG8rY91szES9WAmNw7bKkHi3N6l2pl8lLA8t9PFnZrBBQ0ZHP5O8Rg8d8A/LmDw ze6HVJ917VVYkCH8Ll7Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbjeh-0000Hb-0L; Fri, 14 Jun 2019 10:41:59 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbjcV-0005w9-Ph; Fri, 14 Jun 2019 10:39:48 +0000 Received: from we0305.dip.tu-dresden.de ([141.76.177.49] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbjcK-0004XL-Mp; Fri, 14 Jun 2019 12:39:32 +0200 From: Heiko Stuebner To: Douglas Anderson , Thierry Reding Subject: Re: [PATCH v5 0/7] drm/panel: simple: Add mode support to devicetree Date: Fri, 14 Jun 2019 12:39:31 +0200 Message-ID: <1584725.WvTV0KElQL@phil> In-Reply-To: <20190401171724.215780-1-dianders@chromium.org> References: <20190401171724.215780-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190614_033944_020460_F994FC8A X-CRM114-Status: GOOD ( 23.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Dmitry Torokhov , Rob Herring , David Airlie , Viresh Kumar , Brian Norris , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Sean Paul , Laurent Pinchart , Daniel Vetter , Enric =?ISO-8859-1?Q?Balletb=F2?= , Klaus Goger , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 1. April 2019, 19:17:17 CEST schrieb Douglas Anderson: > I'm reviving Sean Paul's old patchset to get mode support in device > tree. The cover letter for his v3 is at: > https://lists.freedesktop.org/archives/dri-devel/2018-February/165162.html > > No code is different between v4 and v5, just commit messages and text > in the bindings. > > I've pulled together the patches that didn't land in v3, addressed > outstanding feedback, and reposted. Atop them I've added patches for > rk3288-veyron-chromebook (used for jaq, jerry, mighty, speedy) and > rk3288-veryon-minnie. > > Please let me know how they look. > > In general I have added people to the whole series who I think would > like the whole series and then let get_maintainer pick extra people it > thinks are relevant to each individual patch. If I see you respond to > any of the patches in the series, though, I'll add you to the whole > series Cc list next time. sadly it looks like the panel-simple parts haven't made it into drm-misc yet and the conversation on patch 1/7 seems to have stalled after Doug's replies. Thierry, do you have an opinion on these? Thanks Heiko > Changes in v5: > - Removed bit about OS may ignore (Rob/Ezequiel) > - Added Heiko's Tested-by > - It's not just jerry, it's most rk3288 Chromebooks (Heiko) > > Changes in v4: > - Simplify desc. for when override should be used (Thierry/Laurent) > - Removed Rob H review since it's been a year and wording changed > - Don't add mode from timing if override was specified (Thierry) > - Add warning if timing and fixed mode was specified (Thierry) > - Don't add fixed mode if timing was specified (Thierry) > - Refactor/rename a bit to avoid extra indentation from "if" tests > - i should be unsigned (Thierry) > - Add annoying WARN_ONs for some cases (Thierry) > - Simplify 'No display_timing found' handling (Thierry) > - Rename to panel_simple_parse_override_mode() (Thierry) > - Rebase to top of Heiko's tree > - Converted changelog to after-the-cut for non-DRM change. > - display_timing for Innolux n116bge new for v4. > - display_timing for AUO b101ean01 new for v4. > - rk3288-veyron-jerry patch new for v4. > - rk3288-veyron-minnie patch new for v4. > > Changes in v3: > - Go back to using the timing subnode directly, but rename to > panel-timing (Rob) > - No longer parse display-timings subnode, use panel-timing (Rob) > - Unwrap the timing from display-timings and rename panel-timing (Rob) > > Changes in v2: > - Split out the binding into a new patch (Rob) > - display-timings is a new section (Rob) > - Use the full display-timings subnode instead of picking the timing > out (Rob/Thierry) > - Parse the full display-timings node (using the native-mode) (Rob) > - Wrap the timing in display-timings node to match binding (Rob/Thierry) > > Douglas Anderson (4): > drm/panel: simple: Use display_timing for Innolux n116bge > drm/panel: simple: Use display_timing for AUO b101ean01 > ARM: dts: rockchip: Specify rk3288-veyron-chromebook's display timings > ARM: dts: rockchip: Specify rk3288-veyron-minnie's display timings > > Sean Paul (3): > dt-bindings: Add panel-timing subnode to simple-panel > drm/panel: simple: Add ability to override typical timing > arm64: dts: rockchip: Specify override mode for kevin panel > > .../bindings/display/panel/simple-panel.txt | 22 +++ > .../boot/dts/rk3288-veyron-chromebook.dtsi | 14 ++ > arch/arm/boot/dts/rk3288-veyron-minnie.dts | 14 ++ > .../boot/dts/rockchip/rk3399-gru-kevin.dts | 14 ++ > drivers/gpu/drm/panel/panel-simple.c | 171 ++++++++++++++---- > 5 files changed, 203 insertions(+), 32 deletions(-) > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B06C31E44 for ; Fri, 14 Jun 2019 10:39:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 327CC2133D for ; Fri, 14 Jun 2019 10:39:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727552AbfFNKjn (ORCPT ); Fri, 14 Jun 2019 06:39:43 -0400 Received: from gloria.sntech.de ([185.11.138.130]:39200 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727315AbfFNKjl (ORCPT ); Fri, 14 Jun 2019 06:39:41 -0400 Received: from we0305.dip.tu-dresden.de ([141.76.177.49] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbjcK-0004XL-Mp; Fri, 14 Jun 2019 12:39:32 +0200 From: Heiko Stuebner To: Douglas Anderson , Thierry Reding Cc: Sean Paul , linux-rockchip@lists.infradead.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, Boris Brezillon , Ezequiel Garcia , Enric =?ISO-8859-1?Q?Balletb=F2?= , Rob Herring , mka@chromium.org, devicetree@vger.kernel.org, Brian Norris , Klaus Goger , linux-kernel@vger.kernel.org, David Airlie , Dmitry Torokhov , Mark Rutland , Viresh Kumar , linux-arm-kernel@lists.infradead.org, Daniel Vetter Subject: Re: [PATCH v5 0/7] drm/panel: simple: Add mode support to devicetree Date: Fri, 14 Jun 2019 12:39:31 +0200 Message-ID: <1584725.WvTV0KElQL@phil> In-Reply-To: <20190401171724.215780-1-dianders@chromium.org> References: <20190401171724.215780-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 1. April 2019, 19:17:17 CEST schrieb Douglas Anderson: > I'm reviving Sean Paul's old patchset to get mode support in device > tree. The cover letter for his v3 is at: > https://lists.freedesktop.org/archives/dri-devel/2018-February/165162.html > > No code is different between v4 and v5, just commit messages and text > in the bindings. > > I've pulled together the patches that didn't land in v3, addressed > outstanding feedback, and reposted. Atop them I've added patches for > rk3288-veyron-chromebook (used for jaq, jerry, mighty, speedy) and > rk3288-veryon-minnie. > > Please let me know how they look. > > In general I have added people to the whole series who I think would > like the whole series and then let get_maintainer pick extra people it > thinks are relevant to each individual patch. If I see you respond to > any of the patches in the series, though, I'll add you to the whole > series Cc list next time. sadly it looks like the panel-simple parts haven't made it into drm-misc yet and the conversation on patch 1/7 seems to have stalled after Doug's replies. Thierry, do you have an opinion on these? Thanks Heiko > Changes in v5: > - Removed bit about OS may ignore (Rob/Ezequiel) > - Added Heiko's Tested-by > - It's not just jerry, it's most rk3288 Chromebooks (Heiko) > > Changes in v4: > - Simplify desc. for when override should be used (Thierry/Laurent) > - Removed Rob H review since it's been a year and wording changed > - Don't add mode from timing if override was specified (Thierry) > - Add warning if timing and fixed mode was specified (Thierry) > - Don't add fixed mode if timing was specified (Thierry) > - Refactor/rename a bit to avoid extra indentation from "if" tests > - i should be unsigned (Thierry) > - Add annoying WARN_ONs for some cases (Thierry) > - Simplify 'No display_timing found' handling (Thierry) > - Rename to panel_simple_parse_override_mode() (Thierry) > - Rebase to top of Heiko's tree > - Converted changelog to after-the-cut for non-DRM change. > - display_timing for Innolux n116bge new for v4. > - display_timing for AUO b101ean01 new for v4. > - rk3288-veyron-jerry patch new for v4. > - rk3288-veyron-minnie patch new for v4. > > Changes in v3: > - Go back to using the timing subnode directly, but rename to > panel-timing (Rob) > - No longer parse display-timings subnode, use panel-timing (Rob) > - Unwrap the timing from display-timings and rename panel-timing (Rob) > > Changes in v2: > - Split out the binding into a new patch (Rob) > - display-timings is a new section (Rob) > - Use the full display-timings subnode instead of picking the timing > out (Rob/Thierry) > - Parse the full display-timings node (using the native-mode) (Rob) > - Wrap the timing in display-timings node to match binding (Rob/Thierry) > > Douglas Anderson (4): > drm/panel: simple: Use display_timing for Innolux n116bge > drm/panel: simple: Use display_timing for AUO b101ean01 > ARM: dts: rockchip: Specify rk3288-veyron-chromebook's display timings > ARM: dts: rockchip: Specify rk3288-veyron-minnie's display timings > > Sean Paul (3): > dt-bindings: Add panel-timing subnode to simple-panel > drm/panel: simple: Add ability to override typical timing > arm64: dts: rockchip: Specify override mode for kevin panel > > .../bindings/display/panel/simple-panel.txt | 22 +++ > .../boot/dts/rk3288-veyron-chromebook.dtsi | 14 ++ > arch/arm/boot/dts/rk3288-veyron-minnie.dts | 14 ++ > .../boot/dts/rockchip/rk3399-gru-kevin.dts | 14 ++ > drivers/gpu/drm/panel/panel-simple.c | 171 ++++++++++++++---- > 5 files changed, 203 insertions(+), 32 deletions(-) > >