From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
Date: Sat, 21 Mar 2020 16:53:47 +0800
Subject: [PATCH 5/8] xhci: mediatek: Add support for MTK xHCI host
 controller
In-Reply-To: <2a096d71-d4a3-a693-8822-791448f64f99@denx.de>
References: <1583909445-27444-1-git-send-email-chunfeng.yun@mediatek.com>
 <1583909445-27444-6-git-send-email-chunfeng.yun@mediatek.com>
 <2a096d71-d4a3-a693-8822-791448f64f99@denx.de>
Message-ID: <1584780827.28859.3.camel@mhfsdcap03>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, 2020-03-11 at 08:11 +0100, Marek Vasut wrote:
> On 3/11/20 7:50 AM, Chunfeng Yun wrote:
> [...]
> > + * @u3_ctrl_p[x]: ip usb3 port x control register, only low 4bytes are used
> > + * @u2_ctrl_p[x]: ip usb2 port x control register, only low 4bytes are used
> > + * @u2_phy_pll: usb2 phy pll control register
> > + */
> > +struct mtk_ippc_regs {
> > +	__le32 ip_pw_ctr0;
> > +	__le32 ip_pw_ctr1;
> > +	__le32 ip_pw_ctr2;
> 
> Please define the registers with #define macros , this struct-based
> approach doesn't scale.

When I prepare for v2, and find that if define registers as macros, it do not keep
the same style with the xhci core, so I leave it unchanged in v2, if you
still suggest to avoid struct-based approach, I will change it in v3
version, thanks

> [..]
>