All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanley Chu <stanley.chu@mediatek.com>
To: Can Guo <cang@codeaurora.org>
Cc: <asutoshd@codeaurora.org>, <nguyenb@codeaurora.org>,
	<hongwus@codeaurora.org>, <rnayak@codeaurora.org>,
	<linux-scsi@vger.kernel.org>, <kernel-team@android.com>,
	<saravanak@google.com>, <salyzyn@google.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Bean Huo <beanhuo@micron.com>,
	"Bart Van Assche" <bvanassche@acm.org>,
	Venkat Gopalakrishnan <venkatg@codeaurora.org>,
	Tomas Winkler <tomas.winkler@intel.com>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/1] scsi: ufs: Enable block layer runtime PM for well-known logical units
Date: Thu, 26 Mar 2020 16:17:14 +0800	[thread overview]
Message-ID: <1585210634.4609.1.camel@mtksdccf07> (raw)
In-Reply-To: <1585185003-31156-1-git-send-email-cang@codeaurora.org>

Hi Can,

On Wed, 2020-03-25 at 18:09 -0700, Can Guo wrote:
> Block layer RPM is enabled for the genernal UFS SCSI devices when they are
> probed by their driver. However block layer RPM is not enabled for UFS
> well-known SCSI devices.
> 
> As UFS SCSI devices have their corresponding BSG char devices, accessing
> a BSG char device via IOCTL may send requests to its corresponding SCSI
> device through its request queue. If BSG IOCTL sends a request to a
> well-known SCSI device when hba is not runtime active, due to block layer
> RPM is not eanbled for the well-known SCSI devices, hba, which is at the
> top of a scsi device's parent chain, shall not be resumed, then unexpected
> error would happen.
> 
> This change enables block layer RPM for the well-known SCSI devices, so
> that block layer can handle RPM for the well-known SCSI devices just like
> for the general SCSI devices.
> 
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Reviewed-by: Avri Altman <avri.altman@wdc.com>

Looks good!
Thanks to make RPM for UFS completed!

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>


       reply	other threads:[~2020-03-26  8:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1585185003-31156-1-git-send-email-cang@codeaurora.org>
2020-03-26  8:17 ` Stanley Chu [this message]
2020-03-27  2:31 ` [PATCH v4 1/1] scsi: ufs: Enable block layer runtime PM for well-known logical units Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1585210634.4609.1.camel@mtksdccf07 \
    --to=stanley.chu@mediatek.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=hongwus@codeaurora.org \
    --cc=jejb@linux.ibm.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nguyenb@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=salyzyn@google.com \
    --cc=saravanak@google.com \
    --cc=tomas.winkler@intel.com \
    --cc=venkatg@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.