From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/6] drm: include idr.h from drm_file.h
Date: Sun, 30 Dec 2018 21:03:15 +0200 [thread overview]
Message-ID: <1585922.IciDZ5ZTA4@avalon> (raw)
In-Reply-To: <2818b15332ab562722dfc324cf977b7eb4a04401.1545915059.git.jani.nikula@intel.com>
Hi Jani,
Thank you for the patch.
On Thursday, 27 December 2018 14:56:38 EET Jani Nikula wrote:
> Make it easier to drop drmP.h includes.
How about explaining why idr.h is needed ?
"drm_file.h embeds idr structures in DRM-specific structures. Include the
corresponding header to make drm_file.h self-contained."
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> include/drm/drm_file.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
> index 84ac79219e4c..6710b612e2f6 100644
> --- a/include/drm/drm_file.h
> +++ b/include/drm/drm_file.h
> @@ -32,6 +32,7 @@
>
> #include <linux/types.h>
> #include <linux/completion.h>
> +#include <linux/idr.h>
>
> #include <uapi/drm/drm.h>
--
Regards,
Laurent Pinchart
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-30 19:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 12:56 [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work Jani Nikula
2018-12-27 12:56 ` [PATCH 1/6] drm: include drm_device.h from drm_legacy.h Jani Nikula
2018-12-27 16:04 ` Daniel Vetter
2018-12-27 16:08 ` Daniel Vetter
2018-12-28 8:23 ` Jani Nikula
2018-12-28 12:10 ` Daniel Vetter
2018-12-28 13:05 ` Jani Nikula
2018-12-28 13:04 ` [PATCH v2] drm: un-inline drm_legacy_findmap() Jani Nikula
2018-12-28 14:11 ` Daniel Vetter
2018-12-30 18:57 ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 2/6] drm: include kernel.h and agp_backend.h from intel-gtt.h Jani Nikula
2018-12-27 16:04 ` Daniel Vetter
2018-12-27 12:56 ` [PATCH 3/6] drm: include idr.h from drm_file.h Jani Nikula
2018-12-27 16:05 ` Daniel Vetter
2018-12-30 19:03 ` Laurent Pinchart [this message]
2018-12-27 12:56 ` [PATCH 4/6] drm: include types.h from drm_hdcp.h Jani Nikula
2018-12-27 16:07 ` Daniel Vetter
2018-12-30 19:12 ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 5/6] drm: include drm_file.h from drm_syncobj.h Jani Nikula
2018-12-27 16:08 ` Daniel Vetter
2018-12-28 8:28 ` [PATCH v2] drm: forward declare struct drm_file in drm_syncobj.h Jani Nikula
2018-12-30 19:16 ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 6/6] drm/i915: drop all drmP.h includes Jani Nikula
2018-12-27 16:12 ` Daniel Vetter
2018-12-27 16:27 ` Jani Nikula
2018-12-28 11:59 ` Daniel Vetter
2018-12-27 12:59 ` [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work Jani Nikula
2018-12-27 15:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-12-27 16:01 ` [PATCH 0/6] " Daniel Vetter
2018-12-28 15:01 ` Jani Nikula
2019-01-02 7:47 ` Jani Nikula
2019-01-02 8:25 ` Laurent Pinchart
2019-01-02 9:45 ` Jani Nikula
2018-12-27 17:26 ` ✓ Fi.CI.IGT: success for " Patchwork
2018-12-28 8:56 ` ✓ Fi.CI.BAT: success for drm/i915: drmP.h include removal w/ drm prep work (rev2) Patchwork
2018-12-28 10:12 ` ✓ Fi.CI.IGT: " Patchwork
2018-12-28 12:33 ` [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work Sam Ravnborg
2018-12-28 13:20 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: drmP.h include removal w/ drm prep work (rev3) Patchwork
2018-12-28 13:39 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-28 14:49 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1585922.IciDZ5ZTA4@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.