From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Ben Walker <benjamin.walker@intel.com>
Subject: Re: [PATCH v4] eal: Support running as unprivileged user
Date: Thu, 09 Mar 2017 17:11:24 +0100 [thread overview]
Message-ID: <1586546.FPT1ddaDYK@xps13> (raw)
In-Reply-To: <20170217112832.1099e809@plumbers-lap.home.lan>
2017-02-17 11:28, Stephen Hemminger:
> On Tue, 31 Jan 2017 10:44:53 -0700
> Ben Walker <benjamin.walker@intel.com> wrote:
>
> > + if (physaddr == RTE_BAD_PHYS_ADDR) {
> > RTE_LOG(ERR, EAL,
> > - "Cannot open /proc/self/pagemap: %s. "
> > - "virt2phys address translation will not work\n",
> > + "Cannot obtain physical addresses: %s. "
> > + "Only vfio will function.\n",
>
> Please don't split a single error message across multiple lines. It makes
> it harder for user to find the source code lines with simple grep.
> Better to just have one long line for format string, or better yet be less wordy.
>
> Yes, the existing DPDK code has lots of these issues.
You're right.
Here the split is acceptable as there is strerror(errno) in the middle.
prev parent reply other threads:[~2017-03-09 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 22:30 [PATCH] eal: Support running as unprivileged user Ben Walker
2017-01-03 22:56 ` [PATCH v2] " Ben Walker
2017-01-18 17:05 ` Sergio Gonzalez Monroy
2017-01-31 17:40 ` [PATCH v3] " Ben Walker
2017-01-31 17:44 ` [PATCH v4] " Ben Walker
2017-02-17 14:59 ` Sergio Gonzalez Monroy
2017-03-09 16:10 ` Thomas Monjalon
2017-02-17 19:28 ` Stephen Hemminger
2017-03-09 16:11 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1586546.FPT1ddaDYK@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=benjamin.walker@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.