Re: oops in the 2.4.20-NFSALL sunrpc code

[Trond Myklebust <trond.myklebust@fys.uio.no>]

>>>>> " " == Ion Badulescu <ionut@badula.org> writes:

     > Hmm... I can see two places where the NULL could be coming
     > from. One is calling rpc_init_task() with clnt==NULL, which
     > appears to be legal since the function checks clnt for NULL:

That would indeed be very borken behaviour, and would blow up in all
sorts of strange places. Feel free to put a BUG_ON() in there.

     > The other one would be rpc_release_task() if somehow an
     > xprt_timer is fired up, spins for a while on xprt->sock_lock,
     > and in the meantime rpc_release_task() is called and it
     > releases the client:

Should be impossible. See 11 lines further up:

        /* Synchronously delete any running timer */
        rpc_delete_timer(task);

Cheers,
  Trond


-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility 
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs