diff for duplicates of <1586880.7NXXgpct7p@avalon> diff --git a/a/1.txt b/N1/1.txt index ec832be..0d93afa 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,30 +1,28 @@ Hello, -On Tuesday, 9 January 2018 17:58:46 EET Jernej =C5=A0krabec wrote: +On Tuesday, 9 January 2018 17:58:46 EET Jernej ?krabec wrote: > Dne torek, 09. januar 2018 ob 11:43:08 CET je Archit Taneja napisal(a): > > On 12/31/2017 02:31 AM, Jernej Skrabec wrote: > >> Parts of PHY code could be useful also for custom PHYs. For example, > >> Allwinner A83T has custom PHY which is probably Synopsys gen2 PHY -> >> with few additional memory mapped registers, so most of the Synopsys P= -HY +> >> with few additional memory mapped registers, so most of the Synopsys PHY > >> related code could be reused. -> >>=20 +> >> > >> It turns out that even completely custom HDMI PHYs, such as the one > >> found in Allwinner H3, can reuse some of those functions. This would -> >> suggest that (some?) functions exported in this commit are actually pa= -rt +> >> suggest that (some?) functions exported in this commit are actually part > >> of generic PHY interface and not really specific to Synopsys PHYs. -> >>=20 +> >> > >> Export useful PHY functions. -> >>=20 +> >> > >> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > >> --- -> >>=20 +> >> > >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 45 +++++++++++++++++------- > >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 2 ++ > >> include/drm/bridge/dw_hdmi.h | 10 +++++++ > >> 3 files changed, 44 insertions(+), 13 deletions(-) -> >>=20 +> >> > >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > >> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index > >> 7ca14d7325b5..67467d0b683a 100644 @@ -37,7 +35,7 @@ rt > >> dw_hdmi_phy_sel_interface_control(struct dw_hdmi *hdmi, u8 enable) > >> HDMI_PHY_CONF0_SELDIPIF_MASK); > >> } -> >>=20 +> >> > >> +void dw_hdmi_phy_gen2_reset(struct dw_hdmi *hdmi, u8 enable) > >> +{ > >> + hdmi_mask_writeb(hdmi, enable, HDMI_MC_PHYRSTZ, @@ -48,8 +46,7 @@ rt I don't remember the details, is the reset signal Gen2-specific ? -How about asserting and deasserting the reset signal in the same call inste= -ad=20 +How about asserting and deasserting the reset signal in the same call instead of having to call this function twice ? > >> +void dw_hdmi_phy_set_slave_addr(struct dw_hdmi *hdmi) @@ -60,33 +57,28 @@ of having to call this function twice ? > >> + hdmi_phy_test_clear(hdmi, 0); > >> +} > >> +EXPORT_SYMBOL_GPL(dw_hdmi_phy_set_slave_addr); -> >=20 +> > > > Should this be called dw_hdmi_phy_gen2_set_slave_addr? ->=20 -> Probably. I will rename it in v2 to be consistent with other phy function= -s. +> +> Probably. I will rename it in v2 to be consistent with other phy functions. -The I2C write function is called dw_hdmi_phy_i2c_write(). If we want to be= -=20 -conosistent we should either rename this one to dw_hdmi_phy_i2c_set_addr() = -or=20 -rename them both to dw_hdmi_phy_gen2_i2c_write() and=20 -dw_hdmi_phy_gen2_i2c_set_addr(). I think I'd prefer the former, and we coul= -d=20 -even drop gen2 from dw_hdmi_phy_gen2_pddq() and dw_hdmi_phy_gen2_txpwron() = -if=20 +The I2C write function is called dw_hdmi_phy_i2c_write(). If we want to be +conosistent we should either rename this one to dw_hdmi_phy_i2c_set_addr() or +rename them both to dw_hdmi_phy_gen2_i2c_write() and +dw_hdmi_phy_gen2_i2c_set_addr(). I think I'd prefer the former, and we could +even drop gen2 from dw_hdmi_phy_gen2_pddq() and dw_hdmi_phy_gen2_txpwron() if desired. > > Looks good otherwise. Same for patches 3 and 4 in this series. -> >=20 +> > > >> + > >> static void dw_hdmi_phy_power_off(struct dw_hdmi *hdmi) > >> { -> >> const struct dw_hdmi_phy_data *phy =3D hdmi->phy.data; +> >> const struct dw_hdmi_phy_data *phy = hdmi->phy.data; [snip] -=2D-=20 +-- Regards, Laurent Pinchart diff --git a/a/content_digest b/N1/content_digest index c204241..340a4e9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,56 +1,37 @@ "ref\020171230210203.24115-1-jernej.skrabec@siol.net\0" "ref\06b454804-e910-e8e8-6d2b-5bc25c7a4d4c@codeaurora.org\0" "ref\010903755.CJpSM8RM5e@jernej-laptop\0" - "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" - "Subject\0Re: [PATCH 04/11] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions\0" + "From\0laurent.pinchart@ideasonboard.com (Laurent Pinchart)\0" + "Subject\0[PATCH 04/11] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions\0" "Date\0Tue, 09 Jan 2018 18:08:55 +0200\0" - "To\0Jernej \305\240krabec <jernej.skrabec@siol.net>\0" - "Cc\0Archit Taneja <architt@codeaurora.org>" - maxime.ripard@free-electrons.com - airlied@linux.ie - robh+dt@kernel.org - mark.rutland@arm.com - wens@csie.org - a.hajda@samsung.com - mturquette@baylibre.com - sboyd@codeaurora.org - Jose.Abreu@synopsys.com - narmstrong@baylibre.com - dri-devel@lists.freedesktop.org - devicetree@vger.kernel.org - linux-arm-kernel@lists.infradead.org - linux-kernel@vger.kernel.org - linux-clk@vger.kernel.org - " linux-sunxi@googlegroups.com\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hello,\n" "\n" - "On Tuesday, 9 January 2018 17:58:46 EET Jernej =C5=A0krabec wrote:\n" + "On Tuesday, 9 January 2018 17:58:46 EET Jernej ?krabec wrote:\n" "> Dne torek, 09. januar 2018 ob 11:43:08 CET je Archit Taneja napisal(a):\n" "> > On 12/31/2017 02:31 AM, Jernej Skrabec wrote:\n" "> >> Parts of PHY code could be useful also for custom PHYs. For example,\n" "> >> Allwinner A83T has custom PHY which is probably Synopsys gen2 PHY\n" - "> >> with few additional memory mapped registers, so most of the Synopsys P=\n" - "HY\n" + "> >> with few additional memory mapped registers, so most of the Synopsys PHY\n" "> >> related code could be reused.\n" - "> >>=20\n" + "> >> \n" "> >> It turns out that even completely custom HDMI PHYs, such as the one\n" "> >> found in Allwinner H3, can reuse some of those functions. This would\n" - "> >> suggest that (some?) functions exported in this commit are actually pa=\n" - "rt\n" + "> >> suggest that (some?) functions exported in this commit are actually part\n" "> >> of generic PHY interface and not really specific to Synopsys PHYs.\n" - "> >>=20\n" + "> >> \n" "> >> Export useful PHY functions.\n" - "> >>=20\n" + "> >> \n" "> >> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>\n" "> >> ---\n" - "> >>=20\n" + "> >> \n" "> >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 45 +++++++++++++++++-------\n" "> >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 2 ++\n" "> >> include/drm/bridge/dw_hdmi.h | 10 +++++++\n" "> >> 3 files changed, 44 insertions(+), 13 deletions(-)\n" - "> >>=20\n" + "> >> \n" "> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c\n" "> >> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index\n" "> >> 7ca14d7325b5..67467d0b683a 100644\n" @@ -63,7 +44,7 @@ "> >> dw_hdmi_phy_sel_interface_control(struct dw_hdmi *hdmi, u8 enable)\n" "> >> \t\t\t HDMI_PHY_CONF0_SELDIPIF_MASK);\n" "> >> }\n" - "> >>=20\n" + "> >> \n" "> >> +void dw_hdmi_phy_gen2_reset(struct dw_hdmi *hdmi, u8 enable)\n" "> >> +{\n" "> >> +\thdmi_mask_writeb(hdmi, enable, HDMI_MC_PHYRSTZ,\n" @@ -74,8 +55,7 @@ "\n" "I don't remember the details, is the reset signal Gen2-specific ?\n" "\n" - "How about asserting and deasserting the reset signal in the same call inste=\n" - "ad=20\n" + "How about asserting and deasserting the reset signal in the same call instead \n" "of having to call this function twice ?\n" "\n" "> >> +void dw_hdmi_phy_set_slave_addr(struct dw_hdmi *hdmi)\n" @@ -86,35 +66,30 @@ "> >> +\thdmi_phy_test_clear(hdmi, 0);\n" "> >> +}\n" "> >> +EXPORT_SYMBOL_GPL(dw_hdmi_phy_set_slave_addr);\n" - "> >=20\n" + "> > \n" "> > Should this be called dw_hdmi_phy_gen2_set_slave_addr?\n" - ">=20\n" - "> Probably. I will rename it in v2 to be consistent with other phy function=\n" - "s.\n" + "> \n" + "> Probably. I will rename it in v2 to be consistent with other phy functions.\n" "\n" - "The I2C write function is called dw_hdmi_phy_i2c_write(). If we want to be=\n" - "=20\n" - "conosistent we should either rename this one to dw_hdmi_phy_i2c_set_addr() =\n" - "or=20\n" - "rename them both to dw_hdmi_phy_gen2_i2c_write() and=20\n" - "dw_hdmi_phy_gen2_i2c_set_addr(). I think I'd prefer the former, and we coul=\n" - "d=20\n" - "even drop gen2 from dw_hdmi_phy_gen2_pddq() and dw_hdmi_phy_gen2_txpwron() =\n" - "if=20\n" + "The I2C write function is called dw_hdmi_phy_i2c_write(). If we want to be \n" + "conosistent we should either rename this one to dw_hdmi_phy_i2c_set_addr() or \n" + "rename them both to dw_hdmi_phy_gen2_i2c_write() and \n" + "dw_hdmi_phy_gen2_i2c_set_addr(). I think I'd prefer the former, and we could \n" + "even drop gen2 from dw_hdmi_phy_gen2_pddq() and dw_hdmi_phy_gen2_txpwron() if \n" "desired.\n" "\n" "> > Looks good otherwise. Same for patches 3 and 4 in this series.\n" - "> >=20\n" + "> > \n" "> >> +\n" "> >> static void dw_hdmi_phy_power_off(struct dw_hdmi *hdmi)\n" "> >> {\n" - "> >> \tconst struct dw_hdmi_phy_data *phy =3D hdmi->phy.data;\n" + "> >> \tconst struct dw_hdmi_phy_data *phy = hdmi->phy.data;\n" "\n" "[snip]\n" "\n" - "=2D-=20\n" + "-- \n" "Regards,\n" "\n" Laurent Pinchart -e4f7959d92d2c333d89b5be8b505ac5820c009907a41fe23a8b4373ac5db4cd8 +b9ed8ec92424612cf639c9c6e5711212f5d3ee95d756fdd31d22a65d6b7cd08e
diff --git a/a/1.txt b/N2/1.txt index ec832be..d91e257 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,30 +1,28 @@ Hello, -On Tuesday, 9 January 2018 17:58:46 EET Jernej =C5=A0krabec wrote: +On Tuesday, 9 January 2018 17:58:46 EET Jernej Škrabec wrote: > Dne torek, 09. januar 2018 ob 11:43:08 CET je Archit Taneja napisal(a): > > On 12/31/2017 02:31 AM, Jernej Skrabec wrote: > >> Parts of PHY code could be useful also for custom PHYs. For example, > >> Allwinner A83T has custom PHY which is probably Synopsys gen2 PHY -> >> with few additional memory mapped registers, so most of the Synopsys P= -HY +> >> with few additional memory mapped registers, so most of the Synopsys PHY > >> related code could be reused. -> >>=20 +> >> > >> It turns out that even completely custom HDMI PHYs, such as the one > >> found in Allwinner H3, can reuse some of those functions. This would -> >> suggest that (some?) functions exported in this commit are actually pa= -rt +> >> suggest that (some?) functions exported in this commit are actually part > >> of generic PHY interface and not really specific to Synopsys PHYs. -> >>=20 +> >> > >> Export useful PHY functions. -> >>=20 +> >> > >> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > >> --- -> >>=20 +> >> > >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 45 +++++++++++++++++------- > >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 2 ++ > >> include/drm/bridge/dw_hdmi.h | 10 +++++++ > >> 3 files changed, 44 insertions(+), 13 deletions(-) -> >>=20 +> >> > >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > >> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index > >> 7ca14d7325b5..67467d0b683a 100644 @@ -37,7 +35,7 @@ rt > >> dw_hdmi_phy_sel_interface_control(struct dw_hdmi *hdmi, u8 enable) > >> HDMI_PHY_CONF0_SELDIPIF_MASK); > >> } -> >>=20 +> >> > >> +void dw_hdmi_phy_gen2_reset(struct dw_hdmi *hdmi, u8 enable) > >> +{ > >> + hdmi_mask_writeb(hdmi, enable, HDMI_MC_PHYRSTZ, @@ -48,8 +46,7 @@ rt I don't remember the details, is the reset signal Gen2-specific ? -How about asserting and deasserting the reset signal in the same call inste= -ad=20 +How about asserting and deasserting the reset signal in the same call instead of having to call this function twice ? > >> +void dw_hdmi_phy_set_slave_addr(struct dw_hdmi *hdmi) @@ -60,33 +57,28 @@ of having to call this function twice ? > >> + hdmi_phy_test_clear(hdmi, 0); > >> +} > >> +EXPORT_SYMBOL_GPL(dw_hdmi_phy_set_slave_addr); -> >=20 +> > > > Should this be called dw_hdmi_phy_gen2_set_slave_addr? ->=20 -> Probably. I will rename it in v2 to be consistent with other phy function= -s. +> +> Probably. I will rename it in v2 to be consistent with other phy functions. -The I2C write function is called dw_hdmi_phy_i2c_write(). If we want to be= -=20 -conosistent we should either rename this one to dw_hdmi_phy_i2c_set_addr() = -or=20 -rename them both to dw_hdmi_phy_gen2_i2c_write() and=20 -dw_hdmi_phy_gen2_i2c_set_addr(). I think I'd prefer the former, and we coul= -d=20 -even drop gen2 from dw_hdmi_phy_gen2_pddq() and dw_hdmi_phy_gen2_txpwron() = -if=20 +The I2C write function is called dw_hdmi_phy_i2c_write(). If we want to be +conosistent we should either rename this one to dw_hdmi_phy_i2c_set_addr() or +rename them both to dw_hdmi_phy_gen2_i2c_write() and +dw_hdmi_phy_gen2_i2c_set_addr(). I think I'd prefer the former, and we could +even drop gen2 from dw_hdmi_phy_gen2_pddq() and dw_hdmi_phy_gen2_txpwron() if desired. > > Looks good otherwise. Same for patches 3 and 4 in this series. -> >=20 +> > > >> + > >> static void dw_hdmi_phy_power_off(struct dw_hdmi *hdmi) > >> { -> >> const struct dw_hdmi_phy_data *phy =3D hdmi->phy.data; +> >> const struct dw_hdmi_phy_data *phy = hdmi->phy.data; [snip] -=2D-=20 +-- Regards, Laurent Pinchart diff --git a/a/content_digest b/N2/content_digest index c204241..36d3ec0 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -26,31 +26,29 @@ "b\0" "Hello,\n" "\n" - "On Tuesday, 9 January 2018 17:58:46 EET Jernej =C5=A0krabec wrote:\n" + "On Tuesday, 9 January 2018 17:58:46 EET Jernej \305\240krabec wrote:\n" "> Dne torek, 09. januar 2018 ob 11:43:08 CET je Archit Taneja napisal(a):\n" "> > On 12/31/2017 02:31 AM, Jernej Skrabec wrote:\n" "> >> Parts of PHY code could be useful also for custom PHYs. For example,\n" "> >> Allwinner A83T has custom PHY which is probably Synopsys gen2 PHY\n" - "> >> with few additional memory mapped registers, so most of the Synopsys P=\n" - "HY\n" + "> >> with few additional memory mapped registers, so most of the Synopsys PHY\n" "> >> related code could be reused.\n" - "> >>=20\n" + "> >> \n" "> >> It turns out that even completely custom HDMI PHYs, such as the one\n" "> >> found in Allwinner H3, can reuse some of those functions. This would\n" - "> >> suggest that (some?) functions exported in this commit are actually pa=\n" - "rt\n" + "> >> suggest that (some?) functions exported in this commit are actually part\n" "> >> of generic PHY interface and not really specific to Synopsys PHYs.\n" - "> >>=20\n" + "> >> \n" "> >> Export useful PHY functions.\n" - "> >>=20\n" + "> >> \n" "> >> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>\n" "> >> ---\n" - "> >>=20\n" + "> >> \n" "> >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 45 +++++++++++++++++-------\n" "> >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 2 ++\n" "> >> include/drm/bridge/dw_hdmi.h | 10 +++++++\n" "> >> 3 files changed, 44 insertions(+), 13 deletions(-)\n" - "> >>=20\n" + "> >> \n" "> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c\n" "> >> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index\n" "> >> 7ca14d7325b5..67467d0b683a 100644\n" @@ -63,7 +61,7 @@ "> >> dw_hdmi_phy_sel_interface_control(struct dw_hdmi *hdmi, u8 enable)\n" "> >> \t\t\t HDMI_PHY_CONF0_SELDIPIF_MASK);\n" "> >> }\n" - "> >>=20\n" + "> >> \n" "> >> +void dw_hdmi_phy_gen2_reset(struct dw_hdmi *hdmi, u8 enable)\n" "> >> +{\n" "> >> +\thdmi_mask_writeb(hdmi, enable, HDMI_MC_PHYRSTZ,\n" @@ -74,8 +72,7 @@ "\n" "I don't remember the details, is the reset signal Gen2-specific ?\n" "\n" - "How about asserting and deasserting the reset signal in the same call inste=\n" - "ad=20\n" + "How about asserting and deasserting the reset signal in the same call instead \n" "of having to call this function twice ?\n" "\n" "> >> +void dw_hdmi_phy_set_slave_addr(struct dw_hdmi *hdmi)\n" @@ -86,35 +83,30 @@ "> >> +\thdmi_phy_test_clear(hdmi, 0);\n" "> >> +}\n" "> >> +EXPORT_SYMBOL_GPL(dw_hdmi_phy_set_slave_addr);\n" - "> >=20\n" + "> > \n" "> > Should this be called dw_hdmi_phy_gen2_set_slave_addr?\n" - ">=20\n" - "> Probably. I will rename it in v2 to be consistent with other phy function=\n" - "s.\n" + "> \n" + "> Probably. I will rename it in v2 to be consistent with other phy functions.\n" "\n" - "The I2C write function is called dw_hdmi_phy_i2c_write(). If we want to be=\n" - "=20\n" - "conosistent we should either rename this one to dw_hdmi_phy_i2c_set_addr() =\n" - "or=20\n" - "rename them both to dw_hdmi_phy_gen2_i2c_write() and=20\n" - "dw_hdmi_phy_gen2_i2c_set_addr(). I think I'd prefer the former, and we coul=\n" - "d=20\n" - "even drop gen2 from dw_hdmi_phy_gen2_pddq() and dw_hdmi_phy_gen2_txpwron() =\n" - "if=20\n" + "The I2C write function is called dw_hdmi_phy_i2c_write(). If we want to be \n" + "conosistent we should either rename this one to dw_hdmi_phy_i2c_set_addr() or \n" + "rename them both to dw_hdmi_phy_gen2_i2c_write() and \n" + "dw_hdmi_phy_gen2_i2c_set_addr(). I think I'd prefer the former, and we could \n" + "even drop gen2 from dw_hdmi_phy_gen2_pddq() and dw_hdmi_phy_gen2_txpwron() if \n" "desired.\n" "\n" "> > Looks good otherwise. Same for patches 3 and 4 in this series.\n" - "> >=20\n" + "> > \n" "> >> +\n" "> >> static void dw_hdmi_phy_power_off(struct dw_hdmi *hdmi)\n" "> >> {\n" - "> >> \tconst struct dw_hdmi_phy_data *phy =3D hdmi->phy.data;\n" + "> >> \tconst struct dw_hdmi_phy_data *phy = hdmi->phy.data;\n" "\n" "[snip]\n" "\n" - "=2D-=20\n" + "-- \n" "Regards,\n" "\n" Laurent Pinchart -e4f7959d92d2c333d89b5be8b505ac5820c009907a41fe23a8b4373ac5db4cd8 +8fc22f5d812d5ba6d3dda41d7dbf277c4e900240c16d0f419a28444c8856a294
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.