From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations Date: Fri, 12 May 2017 14:38:38 +0300 Message-ID: <1587529.CdsjPgZMHu@avalon> References: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> <8c4e7dde-06d5-3f13-2322-f661e9d3dbf4@daenzer.net> <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Michel =?ISO-8859-1?Q?D=E4nzer?= , kernel-janitors@vger.kernel.org, LKML , amd-gfx@lists.freedesktop.org, SF Markus Elfring , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= List-Id: amd-gfx.lists.freedesktop.org SGkgQ2hyaXN0aWFuLAoKT24gV2VkbmVzZGF5IDEwIE1heSAyMDE3IDEzOjMwOjM3IENocmlzdGlh biBLw7ZuaWcgd3JvdGU6Cj4gQW0gMTAuMDUuMjAxNyB1bSAwMjoyMyBzY2hyaWViIE1pY2hlbCBE w6RuemVyOgo+ID4gT24gMDMvMDUvMTcgMDk6NDYgUE0sIENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6 Cj4gPj4gQW0gMDIuMDUuMjAxNyB1bSAyMjowNCBzY2hyaWViIFNGIE1hcmt1cyBFbGZyaW5nOgo+ ID4+PiBGcm9tOiBNYXJrdXMgRWxmcmluZyA8ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+ Cj4gPj4+IERhdGU6IFR1ZSwgMiBNYXkgMjAxNyAyMjowMDowMiArMDIwMAo+ID4+PiAKPiA+Pj4g VGhyZWUgdXBkYXRlIHN1Z2dlc3Rpb25zIHdlcmUgdGFrZW4gaW50byBhY2NvdW50Cj4gPj4+IGZy b20gc3RhdGljIHNvdXJjZSBjb2RlIGFuYWx5c2lzLgo+ID4+PiAKPiA+Pj4gTWFya3VzIEVsZnJp bmcgKDMpOgo+ID4+PiAgICAgVXNlIHNlcV9wdXRjKCkgaW4gcmFkZW9uX3NhX2JvX2R1bXBfZGVi dWdfaW5mbygpCj4gPj4+ICAgICBVc2Ugc2VxX3B1dHMoKSBpbiByYWRlb25fZGVidWdmc19wbV9p bmZvKCkKPiA+Pj4gICAgIFVzZSBzZXFfcHV0cygpIGluIHIxMDBfZGVidWdmc19jcF9jc3FfZmlm bygpCj4gPj4gCj4gPj4gUmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5r b2VuaWdAYW1kLmNvbT4KPiA+IAo+ID4gQmFzZWQgb24KPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE3LU1heS8xNDA4MzcuaHRtbAo+ID4gYW5k IGZvbGxvd3VwcywgSSdtIGFmcmFpZCB3ZSdsbCBoYXZlIHRvIG1ha2Ugc3VyZSBNYXJrdXMnIHBh dGNoZXMgaGF2ZQo+ID4gYmVlbiB0ZXN0ZWQgYWRlcXVhdGVseSBiZWZvcmUgYXBwbHlpbmcgdGhl bS4KPiAKPiBJIGNhbid0IGp1ZGdlIHRoZSBiYWNrZ3JvdW5kIG9mIHRoYXQgZGVjaXNpb24sIGJ1 dCBhdCBsZWFzdCB0aG9zZSB0cmVlCj4gcGF0Y2hlcyBmb3IgcmFkZW9uIGxvb2tlZCB0cml2aWFs IHRvIG1lLgo+IAo+IEkgZG9uJ3Qgc2VlIG11Y2ggd2hhdCBjb3VsZCBnbyB3cm9uZyB3aGVuIG1l cmdpbmcgdGhlbS4KCkZvciB3aGF0IGl0J3Mgd29ydGgsIEkndmUgb25jZSBhcHBsaWVkIGEgcGF0 Y2ggZnJvbSBNYXJrdXMgZm9yIHRoZSB1dmN2aWRlbyAKZHJpdmVyIHRoYXQgc2VlbWVkIHRyaXZp YWwgYnV0IGVuZGVkIHVwIGludHJvZHVjaW5nIGEgYnJlYWthZ2UgdGhhdCBJIGhhZG4ndCAKY2F1 Z2h0IGR1cmluZyByZXZpZXcuIEkgcmVjb21tZW5kIHJlamVjdGluZyBNYXJrdXMnIHBhdGNoZXMg dGhhdCBhcmUgbm90IGNsZWFyIAppbXByb3ZlbWVudHMsIGFuZCBjYXJlZnVsbHkgdGVzdGluZyB0 aGUgb3RoZXJzLgoKPiBPbiB0aGUgb3RoZXIgaGFuZCB5b3UgYXJlIHJpZ2h0IHRoYXQgdHJ5aW5n IHRvIGZpbmQgaGFyZHdhcmUgdG8gdGVzdCB0aGF0Cj4gc3R1ZmYgY291bGQgYmUgY2hhbGxlbmdp bmcuCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Fri, 12 May 2017 11:38:38 +0000 Subject: Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations Message-Id: <1587529.CdsjPgZMHu@avalon> List-Id: References: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> <8c4e7dde-06d5-3f13-2322-f661e9d3dbf4@daenzer.net> <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com> In-Reply-To: <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: dri-devel@lists.freedesktop.org Cc: Michel =?ISO-8859-1?Q?D=E4nzer?= , kernel-janitors@vger.kernel.org, LKML , amd-gfx@lists.freedesktop.org, SF Markus Elfring , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= Hi Christian, On Wednesday 10 May 2017 13:30:37 Christian K=F6nig wrote: > Am 10.05.2017 um 02:23 schrieb Michel D=E4nzer: > > On 03/05/17 09:46 PM, Christian K=F6nig wrote: > >> Am 02.05.2017 um 22:04 schrieb SF Markus Elfring: > >>> From: Markus Elfring > >>> Date: Tue, 2 May 2017 22:00:02 +0200 > >>>=20 > >>> Three update suggestions were taken into account > >>> from static source code analysis. > >>>=20 > >>> Markus Elfring (3): > >>> Use seq_putc() in radeon_sa_bo_dump_debug_info() > >>> Use seq_puts() in radeon_debugfs_pm_info() > >>> Use seq_puts() in r100_debugfs_cp_csq_fifo() > >>=20 > >> Reviewed-by: Christian K=F6nig > >=20 > > Based on > > https://lists.freedesktop.org/archives/dri-devel/2017-May/140837.html > > and followups, I'm afraid we'll have to make sure Markus' patches have > > been tested adequately before applying them. >=20 > I can't judge the background of that decision, but at least those tree > patches for radeon looked trivial to me. >=20 > I don't see much what could go wrong when merging them. For what it's worth, I've once applied a patch from Markus for the uvcvideo= =20 driver that seemed trivial but ended up introducing a breakage that I hadn'= t=20 caught during review. I recommend rejecting Markus' patches that are not cl= ear=20 improvements, and carefully testing the others. > On the other hand you are right that trying to find hardware to test that > stuff could be challenging. --=20 Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757461AbdELLii (ORCPT ); Fri, 12 May 2017 07:38:38 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:36726 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756248AbdELLih (ORCPT ); Fri, 12 May 2017 07:38:37 -0400 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Christian =?ISO-8859-1?Q?K=F6nig?= , Michel =?ISO-8859-1?Q?D=E4nzer?= , SF Markus Elfring , Alex Deucher , David Airlie , kernel-janitors@vger.kernel.org, amd-gfx@lists.freedesktop.org, LKML Subject: Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations Date: Fri, 12 May 2017 14:38:38 +0300 Message-ID: <1587529.CdsjPgZMHu@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.16-gentoo; KDE/4.14.29; x86_64; ; ) In-Reply-To: <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com> References: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> <8c4e7dde-06d5-3f13-2322-f661e9d3dbf4@daenzer.net> <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4CBcqPH012424 Hi Christian, On Wednesday 10 May 2017 13:30:37 Christian König wrote: > Am 10.05.2017 um 02:23 schrieb Michel Dänzer: > > On 03/05/17 09:46 PM, Christian König wrote: > >> Am 02.05.2017 um 22:04 schrieb SF Markus Elfring: > >>> From: Markus Elfring > >>> Date: Tue, 2 May 2017 22:00:02 +0200 > >>> > >>> Three update suggestions were taken into account > >>> from static source code analysis. > >>> > >>> Markus Elfring (3): > >>> Use seq_putc() in radeon_sa_bo_dump_debug_info() > >>> Use seq_puts() in radeon_debugfs_pm_info() > >>> Use seq_puts() in r100_debugfs_cp_csq_fifo() > >> > >> Reviewed-by: Christian König > > > > Based on > > https://lists.freedesktop.org/archives/dri-devel/2017-May/140837.html > > and followups, I'm afraid we'll have to make sure Markus' patches have > > been tested adequately before applying them. > > I can't judge the background of that decision, but at least those tree > patches for radeon looked trivial to me. > > I don't see much what could go wrong when merging them. For what it's worth, I've once applied a patch from Markus for the uvcvideo driver that seemed trivial but ended up introducing a breakage that I hadn't caught during review. I recommend rejecting Markus' patches that are not clear improvements, and carefully testing the others. > On the other hand you are right that trying to find hardware to test that > stuff could be challenging. -- Regards, Laurent Pinchart