Re: [Qemu-devel] [PATCHv3 3/3] seccomp: general fixes

[Paul Moore <pmoore@redhat.com>]

On Tuesday, October 08, 2013 09:42:26 PM Eduardo Otubo wrote:
>  1) On qemu-seccomp.c:255, the variable ctx was being used
> uninitialized; now it's initialized with NULL and it's being checked at
> the end of the function.
> 
>  2) Changed the name of the command line option from "enable" to
> "sandbox" for a better understanding from user side.
> 
> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
> ---
>  qemu-seccomp.c | 4 ++--
>  vl.c           | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index 84a42bc..fdd0de3 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -258,7 +258,7 @@ seccomp_return:
>  int seccomp_start(int list_type)
>  {
>      int rc = 0;
> -    scmp_filter_ctx ctx;
> +    scmp_filter_ctx ctx = NULL;
> 
>      switch (list_type) {
>      case WHITELIST:
> @@ -285,7 +285,7 @@ int seccomp_start(int list_type)
> 
>      rc = seccomp_load(ctx);
> 
> -  seccomp_return:
> +seccomp_return:
>      if (ctx)
>          seccomp_release(ctx);
>      return rc;

Any particular reason these changes weren't folded into patch 1/3?

-- 
paul moore
security and virtualization @ redhat