All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bhatia, Sumeet" <sumee@amazon.com>
To: "io-uring@vger.kernel.org" <io-uring@vger.kernel.org>
Cc: "Hegde, Pramod" <phegde@amazon.com>
Subject: Is it safe to submit and reap IOs in different threads?
Date: Wed, 6 May 2020 23:02:45 +0000	[thread overview]
Message-ID: <1588806165324.88604@amazon.com> (raw)

Hello,

My application has a thread per disk (aka producer_thread) that generates disk operations. I have io-uring context per disk to ensure iouring submissions are from a single thread.

producer_thread executes only if new disk operations are to be submitted else it yields. It'll be significant code change to modify this behavior. For this reason I spin up a new thread (aka consumer thread) per io-uring context to reap IO completions.

My reading of fs/io_uring.c suggests it is safe to submit IOs from producer_thread and reap IOs from consumer_thread. My prototype based on liburing (Ref: https://pastebin.com/6u2FZB0D) works fine too. 

I would like to get your thoughts on whether this approach is indeed safe or am I overlooking any race condition?

Thanks,
Sumeet

             reply	other threads:[~2020-05-06 23:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 23:02 Bhatia, Sumeet [this message]
2020-05-07  8:21 ` Is it safe to submit and reap IOs in different threads? Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1588806165324.88604@amazon.com \
    --to=sumee@amazon.com \
    --cc=io-uring@vger.kernel.org \
    --cc=phegde@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.