From: David Howells <dhowells@redhat.com>
To: James Morris <jmorris@namei.org>
Cc: dhowells@redhat.com, Dmitry Kasatkin <dmitry.kasatkin@intel.com>,
linux-security-module@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
zohar@linux.vnet.ibm.com, herbert@gondor.hengli.com.au
Subject: Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)
Date: Mon, 17 Oct 2011 16:50:51 +0100 [thread overview]
Message-ID: <15891.1318866651@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.00.1110151125280.24994@tundra.namei.org>
James Morris <jmorris@namei.org> wrote:
> > +MPI mpi_alloc(unsigned nlimbs)
> > +{
> > + MPI a;
> > +
> > + a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);
>
> Generally, typedef structs are frowned upon in the kernel. I'd prefer to
> see this (and any others) changed to a normal type.
In this case, however, it makes it easier to compare back to the original
code.
David
next prev parent reply other threads:[~2011-10-17 15:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 13:45 [PATCH v2.1 0/7] evm: digital signature verification extension Dmitry Kasatkin
2011-10-14 13:45 ` Dmitry Kasatkin
2011-10-14 13:45 ` [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1) Dmitry Kasatkin
2011-10-14 13:45 ` Dmitry Kasatkin
2011-10-15 0:28 ` James Morris
2011-10-17 9:11 ` Kasatkin, Dmitry
2011-10-17 9:11 ` Kasatkin, Dmitry
2011-10-17 11:07 ` Kasatkin, Dmitry
2011-10-17 11:07 ` Kasatkin, Dmitry
2011-10-17 16:22 ` Greg KH
2011-10-17 15:50 ` David Howells [this message]
2011-10-14 13:45 ` [PATCH v2.1 2/7] crypto: GnuPG based MPI lib - header files (part 2) Dmitry Kasatkin
2011-10-14 13:45 ` Dmitry Kasatkin
2011-10-14 13:45 ` [PATCH v2.1 3/7] crypto: GnuPG based MPI lib - make files (part 3) Dmitry Kasatkin
2011-10-14 13:45 ` Dmitry Kasatkin
2011-10-14 13:45 ` [PATCH v2.1 4/7] crypto: GnuPG based MPI lib - additional sources (part 4) Dmitry Kasatkin
2011-10-14 13:45 ` Dmitry Kasatkin
2011-10-15 0:34 ` James Morris
2011-10-17 9:09 ` Kasatkin, Dmitry
2011-10-18 6:46 ` James Morris
2011-10-14 13:45 ` [PATCH v2.1 5/7] crypto: digital signature verification support Dmitry Kasatkin
2011-10-14 13:45 ` Dmitry Kasatkin
2011-10-14 13:45 ` [PATCH v2.1 6/7] integrity: digital signature verification using multiple keyrings Dmitry Kasatkin
2011-10-14 13:45 ` Dmitry Kasatkin
2011-10-14 13:45 ` [PATCH v2.1 7/7] evm: digital signature verification support Dmitry Kasatkin
2011-10-14 13:45 ` Dmitry Kasatkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15891.1318866651@redhat.com \
--to=dhowells@redhat.com \
--cc=dmitry.kasatkin@intel.com \
--cc=herbert@gondor.hengli.com.au \
--cc=jmorris@namei.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.