diff for duplicates of <1589389.XrQdaPTFv2@jernej-laptop> diff --git a/a/1.txt b/N1/1.txt index 81d21cb..80d9367 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,37 +1,34 @@ Hi, Dne petek, 18. maj 2018 ob 17:26:51 CEST je Maxime Ripard napisal(a): -> On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej =C5=A0krabec wrote: -> > > And this is a bit sloppy, since if phy_clk_num =3D=3D 3, you won't tr= -y to +> On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej ?krabec wrote: +> > > And this is a bit sloppy, since if phy_clk_num == 3, you won't try to > > > lookup pll-2 either. -> >=20 +> > > > It is highly unlikely this will be higher than 2, at least for this HDMI > > PHY, since it has only 1 bit reserved for parent selection. But since I -> > have to fix it, I'll add ">=3D 2" ->=20 +> > have to fix it, I'll add ">= 2" +> > If we're only going to have two parents at most, ever, why don't we > had just a single other boolean. This would be less intrusive, and we > wouldn't have to check for those corner cases. -It seems that usage of "bool" data type in structures is not wanted anymore= -=20 +It seems that usage of "bool" data type in structures is not wanted anymore according to checkpatch and this: https://lkml.org/lkml/2017/11/21/384 -I guess I'll use "unsigned int" as recommended by Linus and named it=20 +I guess I'll use "unsigned int" as recommended by Linus and named it "has_second_parent" to be unambigous that it's boolean in reality. Best regards, Jernej ->=20 -> > BTW, I'll resend fixed version of this patch for my R40 HDMI series, si= -nce +> +> > BTW, I'll resend fixed version of this patch for my R40 HDMI series, since > > there is nothing to hold it back, unlike for this. ->=20 +> > Awesome, thanks! > Maxime ->=20 +> > -- > Maxime Ripard, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering diff --git a/a/content_digest b/N1/content_digest index 5163b39..203b089 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,66 +1,46 @@ "ref\020180518094536.17201-1-jagan@amarulasolutions.com\0" "ref\04909574.Q3IFWM0xt6@jernej-laptop\0" "ref\020180518152651.lfymc3kj7npj5tww@flea\0" - "From\0Jernej \305\240krabec <jernej.skrabec@siol.net>\0" - "Subject\0Re: [PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents\0" + "From\0jernej.skrabec@siol.net (Jernej \305\240krabec)\0" + "Subject\0[PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents\0" "Date\0Sat, 19 May 2018 09:11:15 +0200\0" - "To\0Maxime Ripard <maxime.ripard@bootlin.com>\0" - "Cc\0Jagan Teki <jagan@amarulasolutions.com>" - Chen-Yu Tsai <wens@csie.org> - Icenowy Zheng <icenowy@aosc.io> - Rob Herring <robh+dt@kernel.org> - Mark Rutland <mark.rutland@arm.com> - Catalin Marinas <catalin.marinas@arm.com> - Will Deacon <will.deacon@arm.com> - David Airlie <airlied@linux.ie> - dri-devel@lists.freedesktop.org - Michael Turquette <mturquette@baylibre.com> - Stephen Boyd <sboyd@kernel.org> - linux-clk@vger.kernel.org - Michael Trimarchi <michael@amarulasolutions.com> - linux-arm-kernel@lists.infradead.org - devicetree@vger.kernel.org - linux-kernel@vger.kernel.org - " linux-sunxi@googlegroups.com\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi,\n" "\n" "Dne petek, 18. maj 2018 ob 17:26:51 CEST je Maxime Ripard napisal(a):\n" - "> On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej =C5=A0krabec wrote:\n" - "> > > And this is a bit sloppy, since if phy_clk_num =3D=3D 3, you won't tr=\n" - "y to\n" + "> On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej ?krabec wrote:\n" + "> > > And this is a bit sloppy, since if phy_clk_num == 3, you won't try to\n" "> > > lookup pll-2 either.\n" - "> >=20\n" + "> > \n" "> > It is highly unlikely this will be higher than 2, at least for this HDMI\n" "> > PHY, since it has only 1 bit reserved for parent selection. But since I\n" - "> > have to fix it, I'll add \">=3D 2\"\n" - ">=20\n" + "> > have to fix it, I'll add \">= 2\"\n" + "> \n" "> If we're only going to have two parents at most, ever, why don't we\n" "> had just a single other boolean. This would be less intrusive, and we\n" "> wouldn't have to check for those corner cases.\n" "\n" - "It seems that usage of \"bool\" data type in structures is not wanted anymore=\n" - "=20\n" + "It seems that usage of \"bool\" data type in structures is not wanted anymore \n" "according to checkpatch and this: https://lkml.org/lkml/2017/11/21/384\n" "\n" - "I guess I'll use \"unsigned int\" as recommended by Linus and named it=20\n" + "I guess I'll use \"unsigned int\" as recommended by Linus and named it \n" "\"has_second_parent\" to be unambigous that it's boolean in reality.\n" "\n" "Best regards,\n" "Jernej\n" "\n" - ">=20\n" - "> > BTW, I'll resend fixed version of this patch for my R40 HDMI series, si=\n" - "nce\n" + "> \n" + "> > BTW, I'll resend fixed version of this patch for my R40 HDMI series, since\n" "> > there is nothing to hold it back, unlike for this.\n" - ">=20\n" + "> \n" "> Awesome, thanks!\n" "> Maxime\n" - ">=20\n" + "> \n" "> --\n" "> Maxime Ripard, Bootlin (formerly Free Electrons)\n" "> Embedded Linux and Kernel engineering\n" > https://bootlin.com -682b39224e91b9848ce0eea6b06733f748fc2bbfab1751a005d4c23fa94b036a +19bea696849472b6163d60f9e585bb90aa423332149a022c930ecef34c1da883
diff --git a/a/1.txt b/N2/1.txt index 81d21cb..423c5a6 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,37 +1,34 @@ Hi, Dne petek, 18. maj 2018 ob 17:26:51 CEST je Maxime Ripard napisal(a): -> On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej =C5=A0krabec wrote: -> > > And this is a bit sloppy, since if phy_clk_num =3D=3D 3, you won't tr= -y to +> On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej Škrabec wrote: +> > > And this is a bit sloppy, since if phy_clk_num == 3, you won't try to > > > lookup pll-2 either. -> >=20 +> > > > It is highly unlikely this will be higher than 2, at least for this HDMI > > PHY, since it has only 1 bit reserved for parent selection. But since I -> > have to fix it, I'll add ">=3D 2" ->=20 +> > have to fix it, I'll add ">= 2" +> > If we're only going to have two parents at most, ever, why don't we > had just a single other boolean. This would be less intrusive, and we > wouldn't have to check for those corner cases. -It seems that usage of "bool" data type in structures is not wanted anymore= -=20 +It seems that usage of "bool" data type in structures is not wanted anymore according to checkpatch and this: https://lkml.org/lkml/2017/11/21/384 -I guess I'll use "unsigned int" as recommended by Linus and named it=20 +I guess I'll use "unsigned int" as recommended by Linus and named it "has_second_parent" to be unambigous that it's boolean in reality. Best regards, Jernej ->=20 -> > BTW, I'll resend fixed version of this patch for my R40 HDMI series, si= -nce +> +> > BTW, I'll resend fixed version of this patch for my R40 HDMI series, since > > there is nothing to hold it back, unlike for this. ->=20 +> > Awesome, thanks! > Maxime ->=20 +> > -- > Maxime Ripard, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering diff --git a/a/content_digest b/N2/content_digest index 5163b39..65b9af7 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -27,40 +27,37 @@ "Hi,\n" "\n" "Dne petek, 18. maj 2018 ob 17:26:51 CEST je Maxime Ripard napisal(a):\n" - "> On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej =C5=A0krabec wrote:\n" - "> > > And this is a bit sloppy, since if phy_clk_num =3D=3D 3, you won't tr=\n" - "y to\n" + "> On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej \305\240krabec wrote:\n" + "> > > And this is a bit sloppy, since if phy_clk_num == 3, you won't try to\n" "> > > lookup pll-2 either.\n" - "> >=20\n" + "> > \n" "> > It is highly unlikely this will be higher than 2, at least for this HDMI\n" "> > PHY, since it has only 1 bit reserved for parent selection. But since I\n" - "> > have to fix it, I'll add \">=3D 2\"\n" - ">=20\n" + "> > have to fix it, I'll add \">= 2\"\n" + "> \n" "> If we're only going to have two parents at most, ever, why don't we\n" "> had just a single other boolean. This would be less intrusive, and we\n" "> wouldn't have to check for those corner cases.\n" "\n" - "It seems that usage of \"bool\" data type in structures is not wanted anymore=\n" - "=20\n" + "It seems that usage of \"bool\" data type in structures is not wanted anymore \n" "according to checkpatch and this: https://lkml.org/lkml/2017/11/21/384\n" "\n" - "I guess I'll use \"unsigned int\" as recommended by Linus and named it=20\n" + "I guess I'll use \"unsigned int\" as recommended by Linus and named it \n" "\"has_second_parent\" to be unambigous that it's boolean in reality.\n" "\n" "Best regards,\n" "Jernej\n" "\n" - ">=20\n" - "> > BTW, I'll resend fixed version of this patch for my R40 HDMI series, si=\n" - "nce\n" + "> \n" + "> > BTW, I'll resend fixed version of this patch for my R40 HDMI series, since\n" "> > there is nothing to hold it back, unlike for this.\n" - ">=20\n" + "> \n" "> Awesome, thanks!\n" "> Maxime\n" - ">=20\n" + "> \n" "> --\n" "> Maxime Ripard, Bootlin (formerly Free Electrons)\n" "> Embedded Linux and Kernel engineering\n" > https://bootlin.com -682b39224e91b9848ce0eea6b06733f748fc2bbfab1751a005d4c23fa94b036a +d304292da577e680c1bf84a7a5eab19a0c4190eaf514f05113d00dfb7974f737
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.