diff for duplicates of <1589502367.2500.2.camel@realtek.com> diff --git a/a/1.txt b/N1/1.txt index bf559d1..d7b9727 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,27 +1,40 @@ -T24gVGh1LCAyMDIwLTA1LTE0IGF0IDE4OjEzICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG -cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gQ3Vy -cmVudGx5IGxkb19wd3IgaGFzIHRoZSBMRE8yNSB2b2x0YWdlIGJpdHMgc2V0IHRvIHplcm8gYW5k -IHRoZW4NCj4gaXQgaXMgb3ZlcndyaXR0ZW4gd2l0aCB0aGUgbmV3IHZvbHRhZ2Ugc2V0dGluZy4g -VGhlIGFzc2lnbm1lbnQNCj4gbG9va3MgaW5jb3JyZWN0LCBpdCBzaG91bGQgYmUgYml0LXdpc2Ug -b3InaW5nIGluIHRoZSBuZXcgdm9sdGFnZQ0KPiBzZXR0aW5nIHJhdGhlciB0aGFuIGEgZGlyZWN0 -IGFzc2lnbm1lbnQuDQo+IA0KPiBBZGRyZXNzZXMtQ292ZXJpdHk6ICgiVW51c2VkIHZhbHVlIikN -Cj4gRml4ZXM6IDFhZmI1ZWI3YTAwZCAoInJ0dzg4OiA4NzIzZDogQWRkIGNmZ19sZG8yNSB0byBj -b250cm9sIExETzI1IikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtp -bmdAY2Fub25pY2FsLmNvbT4NCg0KVGhhbmsgeW91IGZvciB5b3VyIGZpeC4NCg0KQWNrZWQtYnk6 -IFBpbmctS2UgU2hpaCA8cGtzaGloQHJlYWx0ZWsuY29tPg0KDQo+IC0tLQ0KPiDCoGRyaXZlcnMv -bmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgvcnR3ODcyM2QuYyB8IDIgKy0NCj4gwqAxIGZpbGUg -Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQg -YS9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0dzg4L3J0dzg3MjNkLmMNCj4gYi9kcml2 -ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0dzg4L3J0dzg3MjNkLmMNCj4gaW5kZXggYjUxN2Fm -NDE3ZTBlLi4yYzZlNDE3YzViY2EgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNz -L3JlYWx0ZWsvcnR3ODgvcnR3ODcyM2QuYw0KPiArKysgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9y -ZWFsdGVrL3J0dzg4L3J0dzg3MjNkLmMNCj4gQEAgLTU2MSw3ICs1NjEsNyBAQCBzdGF0aWMgdm9p -ZCBydHc4NzIzZF9jZmdfbGRvMjUoc3RydWN0IHJ0d19kZXYgKnJ0d2RldiwNCj4gYm9vbCBlbmFi -bGUpDQo+IMKgCWxkb19wd3IgPSBydHdfcmVhZDgocnR3ZGV2LCBSRUdfTERPX0VGVVNFX0NUUkwg -KyAzKTsNCj4gwqAJaWYgKGVuYWJsZSkgew0KPiDCoAkJbGRvX3B3ciAmPSB+QklUX01BU0tfTERP -MjVfVk9MVEFHRTsNCj4gLQkJbGRvX3B3ciA9IChCSVRfTERPMjVfVk9MVEFHRV9WMjUgPDwgNCkg -fCBCSVRfTERPMjVfRU47DQo+ICsJCWxkb19wd3IgfD0gKEJJVF9MRE8yNV9WT0xUQUdFX1YyNSA8 -PCA0KSB8IEJJVF9MRE8yNV9FTjsNCj4gwqAJfSBlbHNlIHsNCj4gwqAJCWxkb19wd3IgJj0gfkJJ -VF9MRE8yNV9FTjsNCj4gwqAJfQ0KPiAtLcKgDQo+IDIuMjUuMQ0KPiANCj4gDQo+IC0tLS0tLVBs -ZWFzZSBjb25zaWRlciB0aGUgZW52aXJvbm1lbnQgYmVmb3JlIHByaW50aW5nIHRoaXMgZS1tYWls -Lg0KDQoNCg= +On Thu, 2020-05-14 at 18:13 +0000, Colin King wrote: +> From: Colin Ian King <colin.king@canonical.com> +> +> Currently ldo_pwr has the LDO25 voltage bits set to zero and then +> it is overwritten with the new voltage setting. The assignment +> looks incorrect, it should be bit-wise or'ing in the new voltage +> setting rather than a direct assignment. +> +> Addresses-Coverity: ("Unused value") +> Fixes: 1afb5eb7a00d ("rtw88: 8723d: Add cfg_ldo25 to control LDO25") +> Signed-off-by: Colin Ian King <colin.king@canonical.com> + +Thank you for your fix. + +Acked-by: Ping-Ke Shih <pkshih@realtek.com> + +> --- +> drivers/net/wireless/realtek/rtw88/rtw8723d.c | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.c +> b/drivers/net/wireless/realtek/rtw88/rtw8723d.c +> index b517af417e0e..2c6e417c5bca 100644 +> --- a/drivers/net/wireless/realtek/rtw88/rtw8723d.c +> +++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.c +> @@ -561,7 +561,7 @@ static void rtw8723d_cfg_ldo25(struct rtw_dev *rtwdev, +> bool enable) +> ldo_pwr = rtw_read8(rtwdev, REG_LDO_EFUSE_CTRL + 3); +> if (enable) { +> ldo_pwr &= ~BIT_MASK_LDO25_VOLTAGE; +> - ldo_pwr = (BIT_LDO25_VOLTAGE_V25 << 4) | BIT_LDO25_EN; +> + ldo_pwr |= (BIT_LDO25_VOLTAGE_V25 << 4) | BIT_LDO25_EN; +> } else { +> ldo_pwr &= ~BIT_LDO25_EN; +> } +> -- +> 2.25.1 +> +> +> ------Please consider the environment before printing this e-mail. diff --git a/a/content_digest b/N1/content_digest index fbc39c6..d70d598 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -12,32 +12,45 @@ " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gVGh1LCAyMDIwLTA1LTE0IGF0IDE4OjEzICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG\n" - "cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gQ3Vy\n" - "cmVudGx5IGxkb19wd3IgaGFzIHRoZSBMRE8yNSB2b2x0YWdlIGJpdHMgc2V0IHRvIHplcm8gYW5k\n" - "IHRoZW4NCj4gaXQgaXMgb3ZlcndyaXR0ZW4gd2l0aCB0aGUgbmV3IHZvbHRhZ2Ugc2V0dGluZy4g\n" - "VGhlIGFzc2lnbm1lbnQNCj4gbG9va3MgaW5jb3JyZWN0LCBpdCBzaG91bGQgYmUgYml0LXdpc2Ug\n" - "b3InaW5nIGluIHRoZSBuZXcgdm9sdGFnZQ0KPiBzZXR0aW5nIHJhdGhlciB0aGFuIGEgZGlyZWN0\n" - "IGFzc2lnbm1lbnQuDQo+IA0KPiBBZGRyZXNzZXMtQ292ZXJpdHk6ICgiVW51c2VkIHZhbHVlIikN\n" - "Cj4gRml4ZXM6IDFhZmI1ZWI3YTAwZCAoInJ0dzg4OiA4NzIzZDogQWRkIGNmZ19sZG8yNSB0byBj\n" - "b250cm9sIExETzI1IikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtp\n" - "bmdAY2Fub25pY2FsLmNvbT4NCg0KVGhhbmsgeW91IGZvciB5b3VyIGZpeC4NCg0KQWNrZWQtYnk6\n" - "IFBpbmctS2UgU2hpaCA8cGtzaGloQHJlYWx0ZWsuY29tPg0KDQo+IC0tLQ0KPiDCoGRyaXZlcnMv\n" - "bmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgvcnR3ODcyM2QuYyB8IDIgKy0NCj4gwqAxIGZpbGUg\n" - "Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQg\n" - "YS9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0dzg4L3J0dzg3MjNkLmMNCj4gYi9kcml2\n" - "ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0dzg4L3J0dzg3MjNkLmMNCj4gaW5kZXggYjUxN2Fm\n" - "NDE3ZTBlLi4yYzZlNDE3YzViY2EgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNz\n" - "L3JlYWx0ZWsvcnR3ODgvcnR3ODcyM2QuYw0KPiArKysgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9y\n" - "ZWFsdGVrL3J0dzg4L3J0dzg3MjNkLmMNCj4gQEAgLTU2MSw3ICs1NjEsNyBAQCBzdGF0aWMgdm9p\n" - "ZCBydHc4NzIzZF9jZmdfbGRvMjUoc3RydWN0IHJ0d19kZXYgKnJ0d2RldiwNCj4gYm9vbCBlbmFi\n" - "bGUpDQo+IMKgCWxkb19wd3IgPSBydHdfcmVhZDgocnR3ZGV2LCBSRUdfTERPX0VGVVNFX0NUUkwg\n" - "KyAzKTsNCj4gwqAJaWYgKGVuYWJsZSkgew0KPiDCoAkJbGRvX3B3ciAmPSB+QklUX01BU0tfTERP\n" - "MjVfVk9MVEFHRTsNCj4gLQkJbGRvX3B3ciA9IChCSVRfTERPMjVfVk9MVEFHRV9WMjUgPDwgNCkg\n" - "fCBCSVRfTERPMjVfRU47DQo+ICsJCWxkb19wd3IgfD0gKEJJVF9MRE8yNV9WT0xUQUdFX1YyNSA8\n" - "PCA0KSB8IEJJVF9MRE8yNV9FTjsNCj4gwqAJfSBlbHNlIHsNCj4gwqAJCWxkb19wd3IgJj0gfkJJ\n" - "VF9MRE8yNV9FTjsNCj4gwqAJfQ0KPiAtLcKgDQo+IDIuMjUuMQ0KPiANCj4gDQo+IC0tLS0tLVBs\n" - "ZWFzZSBjb25zaWRlciB0aGUgZW52aXJvbm1lbnQgYmVmb3JlIHByaW50aW5nIHRoaXMgZS1tYWls\n" - Lg0KDQoNCg= + "On Thu, 2020-05-14 at 18:13 +0000, Colin King wrote:\n" + "> From: Colin Ian King <colin.king@canonical.com>\n" + "> \n" + "> Currently ldo_pwr has the LDO25 voltage bits set to zero and then\n" + "> it is overwritten with the new voltage setting. The assignment\n" + "> looks incorrect, it should be bit-wise or'ing in the new voltage\n" + "> setting rather than a direct assignment.\n" + "> \n" + "> Addresses-Coverity: (\"Unused value\")\n" + "> Fixes: 1afb5eb7a00d (\"rtw88: 8723d: Add cfg_ldo25 to control LDO25\")\n" + "> Signed-off-by: Colin Ian King <colin.king@canonical.com>\n" + "\n" + "Thank you for your fix.\n" + "\n" + "Acked-by: Ping-Ke Shih <pkshih@realtek.com>\n" + "\n" + "> ---\n" + "> \302\240drivers/net/wireless/realtek/rtw88/rtw8723d.c | 2 +-\n" + "> \302\2401 file changed, 1 insertion(+), 1 deletion(-)\n" + "> \n" + "> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.c\n" + "> b/drivers/net/wireless/realtek/rtw88/rtw8723d.c\n" + "> index b517af417e0e..2c6e417c5bca 100644\n" + "> --- a/drivers/net/wireless/realtek/rtw88/rtw8723d.c\n" + "> +++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.c\n" + "> @@ -561,7 +561,7 @@ static void rtw8723d_cfg_ldo25(struct rtw_dev *rtwdev,\n" + "> bool enable)\n" + "> \302\240\tldo_pwr = rtw_read8(rtwdev, REG_LDO_EFUSE_CTRL + 3);\n" + "> \302\240\tif (enable) {\n" + "> \302\240\t\tldo_pwr &= ~BIT_MASK_LDO25_VOLTAGE;\n" + "> -\t\tldo_pwr = (BIT_LDO25_VOLTAGE_V25 << 4) | BIT_LDO25_EN;\n" + "> +\t\tldo_pwr |= (BIT_LDO25_VOLTAGE_V25 << 4) | BIT_LDO25_EN;\n" + "> \302\240\t} else {\n" + "> \302\240\t\tldo_pwr &= ~BIT_LDO25_EN;\n" + "> \302\240\t}\n" + "> --\302\240\n" + "> 2.25.1\n" + "> \n" + "> \n" + > ------Please consider the environment before printing this e-mail. -b5e8322a04415eacc3caeedae9810ce12c94f0b64badc162776e957331af127c +b26c70b4547f43ca9c7d446503baa6161705ccff2e21efa8ab32c4a8898abe1d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.