From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C32C433DF for ; Wed, 20 May 2020 02:50:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79ABD2070A for ; Wed, 20 May 2020 02:50:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KB8y8/Jf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="VNTQzhTh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79ABD2070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OK4WfXvObBzeVktWxts0kQqZZ1YEUxe2lIsTZ1pLmZo=; b=KB8y8/JfQwmaBG euGol7Apv14YNWpUAouOcaQZqfR1jF7RtTMUMp25WQyksZ2qjkHLkl6Dy8E1gzH0qBWV2aCEZ8Pml 5wodH6dJU/GYWiWmJ2P4Kf9qX8aJfy4KbREX/M9OH1V1TvSRxX//SDEXeLEeLlIXv36VpndK5RnQZ KMkB9I/dzsyEWgLgMt+lyP8yisNuh4bB3nQh6UvhvG9ceSLTL+1Oiu85q6cY/nge6YdAj3H5TKray TZDNW7L5i+7QpulHDjAK1Uekz9aHMediZacJ7a9PTlZxSO4ntc3JPz7HuGoghUVwmAAAouKIDrca8 ueiRVJ/ZpinXSTKSI2Lw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbEoK-0001Fm-Le; Wed, 20 May 2020 02:50:24 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbEnv-00076f-F3; Wed, 20 May 2020 02:50:01 +0000 X-UUID: 1ca7be2c6f684697b04def3fc5588bf0-20200519 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DrIY2R3TOB8CSwrRNRIw6OHgkvC+BEhomkjBceqSmqE=; b=VNTQzhThUoSY8byqrHXYFX1drSCgIVA+wSyhFUUNJyT4YaTKxDS/dDN8trS0omqaTgxkeL7ILct8T/bHs1VWMY8FiyIehVexJe41cqKTu7p7PV3/K+xaRFvtYr0G7wnEf74N7pzxnpnCnXeHzgEhbjIT2g7pOd/e0r9n55E59mc=; X-UUID: 1ca7be2c6f684697b04def3fc5588bf0-20200519 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1261498423; Tue, 19 May 2020 18:49:59 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 May 2020 19:49:52 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 May 2020 10:49:54 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 20 May 2020 10:49:50 +0800 Message-ID: <1589942995.29577.6.camel@mtksdccf07> Subject: Re: [PATCH v4 1/4] rcu/kasan: record and print call_rcu() call stack From: Walter Wu To: Date: Wed, 20 May 2020 10:49:55 +0800 In-Reply-To: <20200519154819.GJ2869@paulmck-ThinkPad-P72> References: <20200519022359.24115-1-walter-zh.wu@mediatek.com> <20200519154819.GJ2869@paulmck-ThinkPad-P72> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_194959_511866_C2C36AAC X-CRM114-Status: GOOD ( 22.62 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream , linux-mm@kvack.org, Lai Jiangshan , Josh Triplett , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Joel Fernandes , linux-mediatek@lists.infradead.org, Alexander Potapenko , linux-arm-kernel@lists.infradead.org, Matthias Brugger , Andrey Ryabinin , Andrew Morton , Dmitry Vyukov , Mathieu Desnoyers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2020-05-19 at 08:48 -0700, Paul E. McKenney wrote: > On Tue, May 19, 2020 at 10:23:59AM +0800, Walter Wu wrote: > > This feature will record the last two call_rcu() call stacks and > > prints up to 2 call_rcu() call stacks in KASAN report. > > > > When call_rcu() is called, we store the call_rcu() call stack into > > slub alloc meta-data, so that the KASAN report can print rcu stack. > > > > [1]https://bugzilla.kernel.org/show_bug.cgi?id=198437 > > [2]https://groups.google.com/forum/#!searchin/kasan-dev/better$20stack$20traces$20for$20rcu%7Csort:date/kasan-dev/KQsjT_88hDE/7rNUZprRBgAJ > > > > Signed-off-by: Walter Wu > > Suggested-by: Dmitry Vyukov > > Cc: Andrey Ryabinin > > Cc: Dmitry Vyukov > > Cc: Alexander Potapenko > > Cc: Andrew Morton > > Cc: Paul E. McKenney > > Cc: Josh Triplett > > Cc: Mathieu Desnoyers > > Cc: Lai Jiangshan > > Cc: Joel Fernandes > > From an RCU perspective: > > Acked-by: Paul E. McKenney > Hi Paul, Thank you for your suggestion and review. Walter > > --- > > include/linux/kasan.h | 2 ++ > > kernel/rcu/tree.c | 2 ++ > > lib/Kconfig.kasan | 2 ++ > > mm/kasan/common.c | 4 ++-- > > mm/kasan/generic.c | 19 +++++++++++++++++++ > > mm/kasan/kasan.h | 10 ++++++++++ > > mm/kasan/report.c | 24 ++++++++++++++++++++++++ > > 7 files changed, 61 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > > index 31314ca7c635..23b7ee00572d 100644 > > --- a/include/linux/kasan.h > > +++ b/include/linux/kasan.h > > @@ -174,11 +174,13 @@ static inline size_t kasan_metadata_size(struct kmem_cache *cache) { return 0; } > > > > void kasan_cache_shrink(struct kmem_cache *cache); > > void kasan_cache_shutdown(struct kmem_cache *cache); > > +void kasan_record_aux_stack(void *ptr); > > > > #else /* CONFIG_KASAN_GENERIC */ > > > > static inline void kasan_cache_shrink(struct kmem_cache *cache) {} > > static inline void kasan_cache_shutdown(struct kmem_cache *cache) {} > > +static inline void kasan_record_aux_stack(void *ptr) {} > > > > #endif /* CONFIG_KASAN_GENERIC */ > > > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > > index 06548e2ebb72..36a4ff7f320b 100644 > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > > @@ -57,6 +57,7 @@ > > #include > > #include > > #include > > +#include > > #include "../time/tick-internal.h" > > > > #include "tree.h" > > @@ -2668,6 +2669,7 @@ __call_rcu(struct rcu_head *head, rcu_callback_t func) > > head->func = func; > > head->next = NULL; > > local_irq_save(flags); > > + kasan_record_aux_stack(head); > > rdp = this_cpu_ptr(&rcu_data); > > > > /* Add the callback to our list. */ > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > > index 81f5464ea9e1..4e83cf6e3caa 100644 > > --- a/lib/Kconfig.kasan > > +++ b/lib/Kconfig.kasan > > @@ -58,6 +58,8 @@ config KASAN_GENERIC > > For better error detection enable CONFIG_STACKTRACE. > > Currently CONFIG_KASAN_GENERIC doesn't work with CONFIG_DEBUG_SLAB > > (the resulting kernel does not boot). > > + In generic mode KASAN prints the last two call_rcu() call stacks in > > + reports. > > > > config KASAN_SW_TAGS > > bool "Software tag-based mode" > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > index 2906358e42f0..8bc618289bb1 100644 > > --- a/mm/kasan/common.c > > +++ b/mm/kasan/common.c > > @@ -41,7 +41,7 @@ > > #include "kasan.h" > > #include "../slab.h" > > > > -static inline depot_stack_handle_t save_stack(gfp_t flags) > > +depot_stack_handle_t kasan_save_stack(gfp_t flags) > > { > > unsigned long entries[KASAN_STACK_DEPTH]; > > unsigned int nr_entries; > > @@ -54,7 +54,7 @@ static inline depot_stack_handle_t save_stack(gfp_t flags) > > static inline void set_track(struct kasan_track *track, gfp_t flags) > > { > > track->pid = current->pid; > > - track->stack = save_stack(flags); > > + track->stack = kasan_save_stack(flags); > > } > > > > void kasan_enable_current(void) > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > index 56ff8885fe2e..3372bdcaf92a 100644 > > --- a/mm/kasan/generic.c > > +++ b/mm/kasan/generic.c > > @@ -325,3 +325,22 @@ DEFINE_ASAN_SET_SHADOW(f2); > > DEFINE_ASAN_SET_SHADOW(f3); > > DEFINE_ASAN_SET_SHADOW(f5); > > DEFINE_ASAN_SET_SHADOW(f8); > > + > > +void kasan_record_aux_stack(void *addr) > > +{ > > + struct page *page = kasan_addr_to_page(addr); > > + struct kmem_cache *cache; > > + struct kasan_alloc_meta *alloc_info; > > + void *object; > > + > > + if (!(page && PageSlab(page))) > > + return; > > + > > + cache = page->slab_cache; > > + object = nearest_obj(cache, page, addr); > > + alloc_info = get_alloc_info(cache, object); > > + > > + /* record the last two call_rcu() call stacks */ > > + alloc_info->aux_stack[1] = alloc_info->aux_stack[0]; > > + alloc_info->aux_stack[0] = kasan_save_stack(GFP_NOWAIT); > > +} > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > index e8f37199d885..a7391bc83070 100644 > > --- a/mm/kasan/kasan.h > > +++ b/mm/kasan/kasan.h > > @@ -104,7 +104,15 @@ struct kasan_track { > > > > struct kasan_alloc_meta { > > struct kasan_track alloc_track; > > +#ifdef CONFIG_KASAN_GENERIC > > + /* > > + * call_rcu() call stack is stored into struct kasan_alloc_meta. > > + * The free stack is stored into struct kasan_free_meta. > > + */ > > + depot_stack_handle_t aux_stack[2]; > > +#else > > struct kasan_track free_track[KASAN_NR_FREE_STACKS]; > > +#endif > > #ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > u8 free_pointer_tag[KASAN_NR_FREE_STACKS]; > > u8 free_track_idx; > > @@ -159,6 +167,8 @@ void kasan_report_invalid_free(void *object, unsigned long ip); > > > > struct page *kasan_addr_to_page(const void *addr); > > > > +depot_stack_handle_t kasan_save_stack(gfp_t flags); > > + > > #if defined(CONFIG_KASAN_GENERIC) && \ > > (defined(CONFIG_SLAB) || defined(CONFIG_SLUB)) > > void quarantine_put(struct kasan_free_meta *info, struct kmem_cache *cache); > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > index 80f23c9da6b0..6f8f2bf8f53b 100644 > > --- a/mm/kasan/report.c > > +++ b/mm/kasan/report.c > > @@ -179,6 +179,17 @@ static struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > return &alloc_meta->free_track[i]; > > } > > > > +#ifdef CONFIG_KASAN_GENERIC > > +static void print_stack(depot_stack_handle_t stack) > > +{ > > + unsigned long *entries; > > + unsigned int nr_entries; > > + > > + nr_entries = stack_depot_fetch(stack, &entries); > > + stack_trace_print(entries, nr_entries, 0); > > +} > > +#endif > > + > > static void describe_object(struct kmem_cache *cache, void *object, > > const void *addr, u8 tag) > > { > > @@ -192,6 +203,19 @@ static void describe_object(struct kmem_cache *cache, void *object, > > free_track = kasan_get_free_track(cache, object, tag); > > print_track(free_track, "Freed"); > > pr_err("\n"); > > + > > +#ifdef CONFIG_KASAN_GENERIC > > + if (alloc_info->aux_stack[0]) { > > + pr_err("Last one call_rcu() call stack:\n"); > > + print_stack(alloc_info->aux_stack[0]); > > + pr_err("\n"); > > + } > > + if (alloc_info->aux_stack[1]) { > > + pr_err("Second to last call_rcu() call stack:\n"); > > + print_stack(alloc_info->aux_stack[1]); > > + pr_err("\n"); > > + } > > +#endif > > } > > > > describe_object_addr(cache, object, addr); > > -- > > 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D18CAC433DF for ; Wed, 20 May 2020 02:50:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90CC52070A for ; Wed, 20 May 2020 02:50:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ch+fXLZU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="VNTQzhTh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90CC52070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=co+FXph2PbKf9x3aHoEecqAaOaNgRtoCpcIGVyNMHnI=; b=Ch+fXLZUNB06oB 0SH3yN2NPvFvgO4NZUIvbZ+n/oAMGaCsGSnAbsEPSVZJfGz5b3B/IVklQizRjNUOT4aKHVSpPn61H 2a3zCId1zFpLyrPKWgjCUCYd/8jMKYP+YIqasrafnDqZQK6ZLubXasv+AYLwyvWifiExc+42/GaoN 0KTnk1MjWvVHDhp5ckf4vO4hsLKtUrvtz4M+VDaVny0URP0/geSzTYolljFVB/1LclRFR18fYRPJf n0K1qSDENUOhtOT2r9LIdMKpk8NHRUaB+gxiuQrjD6vjQLlpmEAoyjpE8gvB9N07z/GgcyUsXBG8U zxSfN9LrR1Z5kErEZA9A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbEnz-0007H6-OQ; Wed, 20 May 2020 02:50:03 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbEnv-00076f-F3; Wed, 20 May 2020 02:50:01 +0000 X-UUID: 1ca7be2c6f684697b04def3fc5588bf0-20200519 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DrIY2R3TOB8CSwrRNRIw6OHgkvC+BEhomkjBceqSmqE=; b=VNTQzhThUoSY8byqrHXYFX1drSCgIVA+wSyhFUUNJyT4YaTKxDS/dDN8trS0omqaTgxkeL7ILct8T/bHs1VWMY8FiyIehVexJe41cqKTu7p7PV3/K+xaRFvtYr0G7wnEf74N7pzxnpnCnXeHzgEhbjIT2g7pOd/e0r9n55E59mc=; X-UUID: 1ca7be2c6f684697b04def3fc5588bf0-20200519 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1261498423; Tue, 19 May 2020 18:49:59 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 May 2020 19:49:52 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 May 2020 10:49:54 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 20 May 2020 10:49:50 +0800 Message-ID: <1589942995.29577.6.camel@mtksdccf07> Subject: Re: [PATCH v4 1/4] rcu/kasan: record and print call_rcu() call stack From: Walter Wu To: Date: Wed, 20 May 2020 10:49:55 +0800 In-Reply-To: <20200519154819.GJ2869@paulmck-ThinkPad-P72> References: <20200519022359.24115-1-walter-zh.wu@mediatek.com> <20200519154819.GJ2869@paulmck-ThinkPad-P72> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_194959_511866_C2C36AAC X-CRM114-Status: GOOD ( 22.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream , linux-mm@kvack.org, Lai Jiangshan , Josh Triplett , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Joel Fernandes , linux-mediatek@lists.infradead.org, Alexander Potapenko , linux-arm-kernel@lists.infradead.org, Matthias Brugger , Andrey Ryabinin , Andrew Morton , Dmitry Vyukov , Mathieu Desnoyers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2020-05-19 at 08:48 -0700, Paul E. McKenney wrote: > On Tue, May 19, 2020 at 10:23:59AM +0800, Walter Wu wrote: > > This feature will record the last two call_rcu() call stacks and > > prints up to 2 call_rcu() call stacks in KASAN report. > > > > When call_rcu() is called, we store the call_rcu() call stack into > > slub alloc meta-data, so that the KASAN report can print rcu stack. > > > > [1]https://bugzilla.kernel.org/show_bug.cgi?id=198437 > > [2]https://groups.google.com/forum/#!searchin/kasan-dev/better$20stack$20traces$20for$20rcu%7Csort:date/kasan-dev/KQsjT_88hDE/7rNUZprRBgAJ > > > > Signed-off-by: Walter Wu > > Suggested-by: Dmitry Vyukov > > Cc: Andrey Ryabinin > > Cc: Dmitry Vyukov > > Cc: Alexander Potapenko > > Cc: Andrew Morton > > Cc: Paul E. McKenney > > Cc: Josh Triplett > > Cc: Mathieu Desnoyers > > Cc: Lai Jiangshan > > Cc: Joel Fernandes > > From an RCU perspective: > > Acked-by: Paul E. McKenney > Hi Paul, Thank you for your suggestion and review. Walter > > --- > > include/linux/kasan.h | 2 ++ > > kernel/rcu/tree.c | 2 ++ > > lib/Kconfig.kasan | 2 ++ > > mm/kasan/common.c | 4 ++-- > > mm/kasan/generic.c | 19 +++++++++++++++++++ > > mm/kasan/kasan.h | 10 ++++++++++ > > mm/kasan/report.c | 24 ++++++++++++++++++++++++ > > 7 files changed, 61 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > > index 31314ca7c635..23b7ee00572d 100644 > > --- a/include/linux/kasan.h > > +++ b/include/linux/kasan.h > > @@ -174,11 +174,13 @@ static inline size_t kasan_metadata_size(struct kmem_cache *cache) { return 0; } > > > > void kasan_cache_shrink(struct kmem_cache *cache); > > void kasan_cache_shutdown(struct kmem_cache *cache); > > +void kasan_record_aux_stack(void *ptr); > > > > #else /* CONFIG_KASAN_GENERIC */ > > > > static inline void kasan_cache_shrink(struct kmem_cache *cache) {} > > static inline void kasan_cache_shutdown(struct kmem_cache *cache) {} > > +static inline void kasan_record_aux_stack(void *ptr) {} > > > > #endif /* CONFIG_KASAN_GENERIC */ > > > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > > index 06548e2ebb72..36a4ff7f320b 100644 > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > > @@ -57,6 +57,7 @@ > > #include > > #include > > #include > > +#include > > #include "../time/tick-internal.h" > > > > #include "tree.h" > > @@ -2668,6 +2669,7 @@ __call_rcu(struct rcu_head *head, rcu_callback_t func) > > head->func = func; > > head->next = NULL; > > local_irq_save(flags); > > + kasan_record_aux_stack(head); > > rdp = this_cpu_ptr(&rcu_data); > > > > /* Add the callback to our list. */ > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > > index 81f5464ea9e1..4e83cf6e3caa 100644 > > --- a/lib/Kconfig.kasan > > +++ b/lib/Kconfig.kasan > > @@ -58,6 +58,8 @@ config KASAN_GENERIC > > For better error detection enable CONFIG_STACKTRACE. > > Currently CONFIG_KASAN_GENERIC doesn't work with CONFIG_DEBUG_SLAB > > (the resulting kernel does not boot). > > + In generic mode KASAN prints the last two call_rcu() call stacks in > > + reports. > > > > config KASAN_SW_TAGS > > bool "Software tag-based mode" > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > index 2906358e42f0..8bc618289bb1 100644 > > --- a/mm/kasan/common.c > > +++ b/mm/kasan/common.c > > @@ -41,7 +41,7 @@ > > #include "kasan.h" > > #include "../slab.h" > > > > -static inline depot_stack_handle_t save_stack(gfp_t flags) > > +depot_stack_handle_t kasan_save_stack(gfp_t flags) > > { > > unsigned long entries[KASAN_STACK_DEPTH]; > > unsigned int nr_entries; > > @@ -54,7 +54,7 @@ static inline depot_stack_handle_t save_stack(gfp_t flags) > > static inline void set_track(struct kasan_track *track, gfp_t flags) > > { > > track->pid = current->pid; > > - track->stack = save_stack(flags); > > + track->stack = kasan_save_stack(flags); > > } > > > > void kasan_enable_current(void) > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > index 56ff8885fe2e..3372bdcaf92a 100644 > > --- a/mm/kasan/generic.c > > +++ b/mm/kasan/generic.c > > @@ -325,3 +325,22 @@ DEFINE_ASAN_SET_SHADOW(f2); > > DEFINE_ASAN_SET_SHADOW(f3); > > DEFINE_ASAN_SET_SHADOW(f5); > > DEFINE_ASAN_SET_SHADOW(f8); > > + > > +void kasan_record_aux_stack(void *addr) > > +{ > > + struct page *page = kasan_addr_to_page(addr); > > + struct kmem_cache *cache; > > + struct kasan_alloc_meta *alloc_info; > > + void *object; > > + > > + if (!(page && PageSlab(page))) > > + return; > > + > > + cache = page->slab_cache; > > + object = nearest_obj(cache, page, addr); > > + alloc_info = get_alloc_info(cache, object); > > + > > + /* record the last two call_rcu() call stacks */ > > + alloc_info->aux_stack[1] = alloc_info->aux_stack[0]; > > + alloc_info->aux_stack[0] = kasan_save_stack(GFP_NOWAIT); > > +} > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > index e8f37199d885..a7391bc83070 100644 > > --- a/mm/kasan/kasan.h > > +++ b/mm/kasan/kasan.h > > @@ -104,7 +104,15 @@ struct kasan_track { > > > > struct kasan_alloc_meta { > > struct kasan_track alloc_track; > > +#ifdef CONFIG_KASAN_GENERIC > > + /* > > + * call_rcu() call stack is stored into struct kasan_alloc_meta. > > + * The free stack is stored into struct kasan_free_meta. > > + */ > > + depot_stack_handle_t aux_stack[2]; > > +#else > > struct kasan_track free_track[KASAN_NR_FREE_STACKS]; > > +#endif > > #ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > u8 free_pointer_tag[KASAN_NR_FREE_STACKS]; > > u8 free_track_idx; > > @@ -159,6 +167,8 @@ void kasan_report_invalid_free(void *object, unsigned long ip); > > > > struct page *kasan_addr_to_page(const void *addr); > > > > +depot_stack_handle_t kasan_save_stack(gfp_t flags); > > + > > #if defined(CONFIG_KASAN_GENERIC) && \ > > (defined(CONFIG_SLAB) || defined(CONFIG_SLUB)) > > void quarantine_put(struct kasan_free_meta *info, struct kmem_cache *cache); > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > index 80f23c9da6b0..6f8f2bf8f53b 100644 > > --- a/mm/kasan/report.c > > +++ b/mm/kasan/report.c > > @@ -179,6 +179,17 @@ static struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > return &alloc_meta->free_track[i]; > > } > > > > +#ifdef CONFIG_KASAN_GENERIC > > +static void print_stack(depot_stack_handle_t stack) > > +{ > > + unsigned long *entries; > > + unsigned int nr_entries; > > + > > + nr_entries = stack_depot_fetch(stack, &entries); > > + stack_trace_print(entries, nr_entries, 0); > > +} > > +#endif > > + > > static void describe_object(struct kmem_cache *cache, void *object, > > const void *addr, u8 tag) > > { > > @@ -192,6 +203,19 @@ static void describe_object(struct kmem_cache *cache, void *object, > > free_track = kasan_get_free_track(cache, object, tag); > > print_track(free_track, "Freed"); > > pr_err("\n"); > > + > > +#ifdef CONFIG_KASAN_GENERIC > > + if (alloc_info->aux_stack[0]) { > > + pr_err("Last one call_rcu() call stack:\n"); > > + print_stack(alloc_info->aux_stack[0]); > > + pr_err("\n"); > > + } > > + if (alloc_info->aux_stack[1]) { > > + pr_err("Second to last call_rcu() call stack:\n"); > > + print_stack(alloc_info->aux_stack[1]); > > + pr_err("\n"); > > + } > > +#endif > > } > > > > describe_object_addr(cache, object, addr); > > -- > > 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D809BC433DF for ; Wed, 20 May 2020 02:50:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B1E120835 for ; Wed, 20 May 2020 02:50:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="VNTQzhTh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B1E120835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2C39A80046; Tue, 19 May 2020 22:50:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 274718002C; Tue, 19 May 2020 22:50:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 189DA80046; Tue, 19 May 2020 22:50:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id F216F8002C for ; Tue, 19 May 2020 22:50:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AB85249960B for ; Wed, 20 May 2020 02:50:02 +0000 (UTC) X-FDA: 76835567844.30.hill28_370498acd3d X-HE-Tag: hill28_370498acd3d X-Filterd-Recvd-Size: 13503 Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 May 2020 02:50:01 +0000 (UTC) X-UUID: d382b904b7c74f2698ee5dae33da4e05-20200520 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DrIY2R3TOB8CSwrRNRIw6OHgkvC+BEhomkjBceqSmqE=; b=VNTQzhThUoSY8byqrHXYFX1drSCgIVA+wSyhFUUNJyT4YaTKxDS/dDN8trS0omqaTgxkeL7ILct8T/bHs1VWMY8FiyIehVexJe41cqKTu7p7PV3/K+xaRFvtYr0G7wnEf74N7pzxnpnCnXeHzgEhbjIT2g7pOd/e0r9n55E59mc=; X-UUID: d382b904b7c74f2698ee5dae33da4e05-20200520 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1382255477; Wed, 20 May 2020 10:49:57 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 May 2020 10:49:54 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 20 May 2020 10:49:50 +0800 Message-ID: <1589942995.29577.6.camel@mtksdccf07> Subject: Re: [PATCH v4 1/4] rcu/kasan: record and print call_rcu() call stack From: Walter Wu To: CC: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Matthias Brugger , Josh Triplett , "Mathieu Desnoyers" , Lai Jiangshan , Joel Fernandes , "Andrew Morton" , , , , , wsd_upstream , Date: Wed, 20 May 2020 10:49:55 +0800 In-Reply-To: <20200519154819.GJ2869@paulmck-ThinkPad-P72> References: <20200519022359.24115-1-walter-zh.wu@mediatek.com> <20200519154819.GJ2869@paulmck-ThinkPad-P72> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: T24gVHVlLCAyMDIwLTA1LTE5IGF0IDA4OjQ4IC0wNzAwLCBQYXVsIEUuIE1jS2VubmV5IHdyb3Rl Og0KPiBPbiBUdWUsIE1heSAxOSwgMjAyMCBhdCAxMDoyMzo1OUFNICswODAwLCBXYWx0ZXIgV3Ug d3JvdGU6DQo+ID4gVGhpcyBmZWF0dXJlIHdpbGwgcmVjb3JkIHRoZSBsYXN0IHR3byBjYWxsX3Jj dSgpIGNhbGwgc3RhY2tzIGFuZA0KPiA+IHByaW50cyB1cCB0byAyIGNhbGxfcmN1KCkgY2FsbCBz dGFja3MgaW4gS0FTQU4gcmVwb3J0Lg0KPiA+IA0KPiA+IFdoZW4gY2FsbF9yY3UoKSBpcyBjYWxs ZWQsIHdlIHN0b3JlIHRoZSBjYWxsX3JjdSgpIGNhbGwgc3RhY2sgaW50bw0KPiA+IHNsdWIgYWxs b2MgbWV0YS1kYXRhLCBzbyB0aGF0IHRoZSBLQVNBTiByZXBvcnQgY2FuIHByaW50IHJjdSBzdGFj ay4NCj4gPiANCj4gPiBbMV1odHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19idWcuY2dp P2lkPTE5ODQzNw0KPiA+IFsyXWh0dHBzOi8vZ3JvdXBzLmdvb2dsZS5jb20vZm9ydW0vIyFzZWFy Y2hpbi9rYXNhbi1kZXYvYmV0dGVyJDIwc3RhY2skMjB0cmFjZXMkMjBmb3IkMjByY3UlN0Nzb3J0 OmRhdGUva2FzYW4tZGV2L0tRc2pUXzg4aERFLzdyTlVacHJSQmdBSg0KPiA+IA0KPiA+IFNpZ25l ZC1vZmYtYnk6IFdhbHRlciBXdSA8d2FsdGVyLXpoLnd1QG1lZGlhdGVrLmNvbT4NCj4gPiBTdWdn ZXN0ZWQtYnk6IERtaXRyeSBWeXVrb3YgPGR2eXVrb3ZAZ29vZ2xlLmNvbT4NCj4gPiBDYzogQW5k cmV5IFJ5YWJpbmluIDxhcnlhYmluaW5AdmlydHVvenpvLmNvbT4NCj4gPiBDYzogRG1pdHJ5IFZ5 dWtvdiA8ZHZ5dWtvdkBnb29nbGUuY29tPg0KPiA+IENjOiBBbGV4YW5kZXIgUG90YXBlbmtvIDxn bGlkZXJAZ29vZ2xlLmNvbT4NCj4gPiBDYzogQW5kcmV3IE1vcnRvbiA8YWtwbUBsaW51eC1mb3Vu ZGF0aW9uLm9yZz4NCj4gPiBDYzogUGF1bCBFLiBNY0tlbm5leSA8cGF1bG1ja0BrZXJuZWwub3Jn Pg0KPiA+IENjOiBKb3NoIFRyaXBsZXR0IDxqb3NoQGpvc2h0cmlwbGV0dC5vcmc+DQo+ID4gQ2M6 IE1hdGhpZXUgRGVzbm95ZXJzIDxtYXRoaWV1LmRlc25veWVyc0BlZmZpY2lvcy5jb20+DQo+ID4g Q2M6IExhaSBKaWFuZ3NoYW4gPGppYW5nc2hhbmxhaUBnbWFpbC5jb20+DQo+ID4gQ2M6IEpvZWwg RmVybmFuZGVzIDxqb2VsQGpvZWxmZXJuYW5kZXMub3JnPg0KPiANCj4gRnJvbSBhbiBSQ1UgcGVy c3BlY3RpdmU6DQo+IA0KPiBBY2tlZC1ieTogUGF1bCBFLiBNY0tlbm5leSA8cGF1bG1ja0BrZXJu ZWwub3JnPg0KPiANCg0KSGkgUGF1bCwNCg0KVGhhbmsgeW91IGZvciB5b3VyIHN1Z2dlc3Rpb24g YW5kIHJldmlldy4NCg0KDQpXYWx0ZXINCg0KPiA+IC0tLQ0KPiA+ICBpbmNsdWRlL2xpbnV4L2th c2FuLmggfCAgMiArKw0KPiA+ICBrZXJuZWwvcmN1L3RyZWUuYyAgICAgfCAgMiArKw0KPiA+ICBs aWIvS2NvbmZpZy5rYXNhbiAgICAgfCAgMiArKw0KPiA+ICBtbS9rYXNhbi9jb21tb24uYyAgICAg fCAgNCArKy0tDQo+ID4gIG1tL2thc2FuL2dlbmVyaWMuYyAgICB8IDE5ICsrKysrKysrKysrKysr KysrKysNCj4gPiAgbW0va2FzYW4va2FzYW4uaCAgICAgIHwgMTAgKysrKysrKysrKw0KPiA+ICBt bS9rYXNhbi9yZXBvcnQuYyAgICAgfCAyNCArKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiAg NyBmaWxlcyBjaGFuZ2VkLCA2MSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPiA+IA0K PiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2thc2FuLmggYi9pbmNsdWRlL2xpbnV4L2th c2FuLmgNCj4gPiBpbmRleCAzMTMxNGNhN2M2MzUuLjIzYjdlZTAwNTcyZCAxMDA2NDQNCj4gPiAt LS0gYS9pbmNsdWRlL2xpbnV4L2thc2FuLmgNCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4L2thc2Fu LmgNCj4gPiBAQCAtMTc0LDExICsxNzQsMTMgQEAgc3RhdGljIGlubGluZSBzaXplX3Qga2FzYW5f bWV0YWRhdGFfc2l6ZShzdHJ1Y3Qga21lbV9jYWNoZSAqY2FjaGUpIHsgcmV0dXJuIDA7IH0NCj4g PiAgDQo+ID4gIHZvaWQga2FzYW5fY2FjaGVfc2hyaW5rKHN0cnVjdCBrbWVtX2NhY2hlICpjYWNo ZSk7DQo+ID4gIHZvaWQga2FzYW5fY2FjaGVfc2h1dGRvd24oc3RydWN0IGttZW1fY2FjaGUgKmNh Y2hlKTsNCj4gPiArdm9pZCBrYXNhbl9yZWNvcmRfYXV4X3N0YWNrKHZvaWQgKnB0cik7DQo+ID4g IA0KPiA+ICAjZWxzZSAvKiBDT05GSUdfS0FTQU5fR0VORVJJQyAqLw0KPiA+ICANCj4gPiAgc3Rh dGljIGlubGluZSB2b2lkIGthc2FuX2NhY2hlX3NocmluayhzdHJ1Y3Qga21lbV9jYWNoZSAqY2Fj aGUpIHt9DQo+ID4gIHN0YXRpYyBpbmxpbmUgdm9pZCBrYXNhbl9jYWNoZV9zaHV0ZG93bihzdHJ1 Y3Qga21lbV9jYWNoZSAqY2FjaGUpIHt9DQo+ID4gK3N0YXRpYyBpbmxpbmUgdm9pZCBrYXNhbl9y ZWNvcmRfYXV4X3N0YWNrKHZvaWQgKnB0cikge30NCj4gPiAgDQo+ID4gICNlbmRpZiAvKiBDT05G SUdfS0FTQU5fR0VORVJJQyAqLw0KPiA+ICANCj4gPiBkaWZmIC0tZ2l0IGEva2VybmVsL3JjdS90 cmVlLmMgYi9rZXJuZWwvcmN1L3RyZWUuYw0KPiA+IGluZGV4IDA2NTQ4ZTJlYmI3Mi4uMzZhNGZm N2YzMjBiIDEwMDY0NA0KPiA+IC0tLSBhL2tlcm5lbC9yY3UvdHJlZS5jDQo+ID4gKysrIGIva2Vy bmVsL3JjdS90cmVlLmMNCj4gPiBAQCAtNTcsNiArNTcsNyBAQA0KPiA+ICAjaW5jbHVkZSA8bGlu dXgvc2xhYi5oPg0KPiA+ICAjaW5jbHVkZSA8bGludXgvc2NoZWQvaXNvbGF0aW9uLmg+DQo+ID4g ICNpbmNsdWRlIDxsaW51eC9zY2hlZC9jbG9jay5oPg0KPiA+ICsjaW5jbHVkZSA8bGludXgva2Fz YW4uaD4NCj4gPiAgI2luY2x1ZGUgIi4uL3RpbWUvdGljay1pbnRlcm5hbC5oIg0KPiA+ICANCj4g PiAgI2luY2x1ZGUgInRyZWUuaCINCj4gPiBAQCAtMjY2OCw2ICsyNjY5LDcgQEAgX19jYWxsX3Jj dShzdHJ1Y3QgcmN1X2hlYWQgKmhlYWQsIHJjdV9jYWxsYmFja190IGZ1bmMpDQo+ID4gIAloZWFk LT5mdW5jID0gZnVuYzsNCj4gPiAgCWhlYWQtPm5leHQgPSBOVUxMOw0KPiA+ICAJbG9jYWxfaXJx X3NhdmUoZmxhZ3MpOw0KPiA+ICsJa2FzYW5fcmVjb3JkX2F1eF9zdGFjayhoZWFkKTsNCj4gPiAg CXJkcCA9IHRoaXNfY3B1X3B0cigmcmN1X2RhdGEpOw0KPiA+ICANCj4gPiAgCS8qIEFkZCB0aGUg Y2FsbGJhY2sgdG8gb3VyIGxpc3QuICovDQo+ID4gZGlmZiAtLWdpdCBhL2xpYi9LY29uZmlnLmth c2FuIGIvbGliL0tjb25maWcua2FzYW4NCj4gPiBpbmRleCA4MWY1NDY0ZWE5ZTEuLjRlODNjZjZl M2NhYSAxMDA2NDQNCj4gPiAtLS0gYS9saWIvS2NvbmZpZy5rYXNhbg0KPiA+ICsrKyBiL2xpYi9L Y29uZmlnLmthc2FuDQo+ID4gQEAgLTU4LDYgKzU4LDggQEAgY29uZmlnIEtBU0FOX0dFTkVSSUMN Cj4gPiAgCSAgRm9yIGJldHRlciBlcnJvciBkZXRlY3Rpb24gZW5hYmxlIENPTkZJR19TVEFDS1RS QUNFLg0KPiA+ICAJICBDdXJyZW50bHkgQ09ORklHX0tBU0FOX0dFTkVSSUMgZG9lc24ndCB3b3Jr IHdpdGggQ09ORklHX0RFQlVHX1NMQUINCj4gPiAgCSAgKHRoZSByZXN1bHRpbmcga2VybmVsIGRv ZXMgbm90IGJvb3QpLg0KPiA+ICsJICBJbiBnZW5lcmljIG1vZGUgS0FTQU4gcHJpbnRzIHRoZSBs YXN0IHR3byBjYWxsX3JjdSgpIGNhbGwgc3RhY2tzIGluDQo+ID4gKwkgIHJlcG9ydHMuDQo+ID4g IA0KPiA+ICBjb25maWcgS0FTQU5fU1dfVEFHUw0KPiA+ICAJYm9vbCAiU29mdHdhcmUgdGFnLWJh c2VkIG1vZGUiDQo+ID4gZGlmZiAtLWdpdCBhL21tL2thc2FuL2NvbW1vbi5jIGIvbW0va2FzYW4v Y29tbW9uLmMNCj4gPiBpbmRleCAyOTA2MzU4ZTQyZjAuLjhiYzYxODI4OWJiMSAxMDA2NDQNCj4g PiAtLS0gYS9tbS9rYXNhbi9jb21tb24uYw0KPiA+ICsrKyBiL21tL2thc2FuL2NvbW1vbi5jDQo+ ID4gQEAgLTQxLDcgKzQxLDcgQEANCj4gPiAgI2luY2x1ZGUgImthc2FuLmgiDQo+ID4gICNpbmNs dWRlICIuLi9zbGFiLmgiDQo+ID4gIA0KPiA+IC1zdGF0aWMgaW5saW5lIGRlcG90X3N0YWNrX2hh bmRsZV90IHNhdmVfc3RhY2soZ2ZwX3QgZmxhZ3MpDQo+ID4gK2RlcG90X3N0YWNrX2hhbmRsZV90 IGthc2FuX3NhdmVfc3RhY2soZ2ZwX3QgZmxhZ3MpDQo+ID4gIHsNCj4gPiAgCXVuc2lnbmVkIGxv bmcgZW50cmllc1tLQVNBTl9TVEFDS19ERVBUSF07DQo+ID4gIAl1bnNpZ25lZCBpbnQgbnJfZW50 cmllczsNCj4gPiBAQCAtNTQsNyArNTQsNyBAQCBzdGF0aWMgaW5saW5lIGRlcG90X3N0YWNrX2hh bmRsZV90IHNhdmVfc3RhY2soZ2ZwX3QgZmxhZ3MpDQo+ID4gIHN0YXRpYyBpbmxpbmUgdm9pZCBz ZXRfdHJhY2soc3RydWN0IGthc2FuX3RyYWNrICp0cmFjaywgZ2ZwX3QgZmxhZ3MpDQo+ID4gIHsN Cj4gPiAgCXRyYWNrLT5waWQgPSBjdXJyZW50LT5waWQ7DQo+ID4gLQl0cmFjay0+c3RhY2sgPSBz YXZlX3N0YWNrKGZsYWdzKTsNCj4gPiArCXRyYWNrLT5zdGFjayA9IGthc2FuX3NhdmVfc3RhY2so ZmxhZ3MpOw0KPiA+ICB9DQo+ID4gIA0KPiA+ICB2b2lkIGthc2FuX2VuYWJsZV9jdXJyZW50KHZv aWQpDQo+ID4gZGlmZiAtLWdpdCBhL21tL2thc2FuL2dlbmVyaWMuYyBiL21tL2thc2FuL2dlbmVy aWMuYw0KPiA+IGluZGV4IDU2ZmY4ODg1ZmUyZS4uMzM3MmJkY2FmOTJhIDEwMDY0NA0KPiA+IC0t LSBhL21tL2thc2FuL2dlbmVyaWMuYw0KPiA+ICsrKyBiL21tL2thc2FuL2dlbmVyaWMuYw0KPiA+ IEBAIC0zMjUsMyArMzI1LDIyIEBAIERFRklORV9BU0FOX1NFVF9TSEFET1coZjIpOw0KPiA+ICBE RUZJTkVfQVNBTl9TRVRfU0hBRE9XKGYzKTsNCj4gPiAgREVGSU5FX0FTQU5fU0VUX1NIQURPVyhm NSk7DQo+ID4gIERFRklORV9BU0FOX1NFVF9TSEFET1coZjgpOw0KPiA+ICsNCj4gPiArdm9pZCBr YXNhbl9yZWNvcmRfYXV4X3N0YWNrKHZvaWQgKmFkZHIpDQo+ID4gK3sNCj4gPiArCXN0cnVjdCBw YWdlICpwYWdlID0ga2FzYW5fYWRkcl90b19wYWdlKGFkZHIpOw0KPiA+ICsJc3RydWN0IGttZW1f Y2FjaGUgKmNhY2hlOw0KPiA+ICsJc3RydWN0IGthc2FuX2FsbG9jX21ldGEgKmFsbG9jX2luZm87 DQo+ID4gKwl2b2lkICpvYmplY3Q7DQo+ID4gKw0KPiA+ICsJaWYgKCEocGFnZSAmJiBQYWdlU2xh YihwYWdlKSkpDQo+ID4gKwkJcmV0dXJuOw0KPiA+ICsNCj4gPiArCWNhY2hlID0gcGFnZS0+c2xh Yl9jYWNoZTsNCj4gPiArCW9iamVjdCA9IG5lYXJlc3Rfb2JqKGNhY2hlLCBwYWdlLCBhZGRyKTsN Cj4gPiArCWFsbG9jX2luZm8gPSBnZXRfYWxsb2NfaW5mbyhjYWNoZSwgb2JqZWN0KTsNCj4gPiAr DQo+ID4gKwkvKiByZWNvcmQgdGhlIGxhc3QgdHdvIGNhbGxfcmN1KCkgY2FsbCBzdGFja3MgKi8N Cj4gPiArCWFsbG9jX2luZm8tPmF1eF9zdGFja1sxXSA9IGFsbG9jX2luZm8tPmF1eF9zdGFja1sw XTsNCj4gPiArCWFsbG9jX2luZm8tPmF1eF9zdGFja1swXSA9IGthc2FuX3NhdmVfc3RhY2soR0ZQ X05PV0FJVCk7DQo+ID4gK30NCj4gPiBkaWZmIC0tZ2l0IGEvbW0va2FzYW4va2FzYW4uaCBiL21t L2thc2FuL2thc2FuLmgNCj4gPiBpbmRleCBlOGYzNzE5OWQ4ODUuLmE3MzkxYmM4MzA3MCAxMDA2 NDQNCj4gPiAtLS0gYS9tbS9rYXNhbi9rYXNhbi5oDQo+ID4gKysrIGIvbW0va2FzYW4va2FzYW4u aA0KPiA+IEBAIC0xMDQsNyArMTA0LDE1IEBAIHN0cnVjdCBrYXNhbl90cmFjayB7DQo+ID4gIA0K PiA+ICBzdHJ1Y3Qga2FzYW5fYWxsb2NfbWV0YSB7DQo+ID4gIAlzdHJ1Y3Qga2FzYW5fdHJhY2sg YWxsb2NfdHJhY2s7DQo+ID4gKyNpZmRlZiBDT05GSUdfS0FTQU5fR0VORVJJQw0KPiA+ICsJLyoN Cj4gPiArCSAqIGNhbGxfcmN1KCkgY2FsbCBzdGFjayBpcyBzdG9yZWQgaW50byBzdHJ1Y3Qga2Fz YW5fYWxsb2NfbWV0YS4NCj4gPiArCSAqIFRoZSBmcmVlIHN0YWNrIGlzIHN0b3JlZCBpbnRvIHN0 cnVjdCBrYXNhbl9mcmVlX21ldGEuDQo+ID4gKwkgKi8NCj4gPiArCWRlcG90X3N0YWNrX2hhbmRs ZV90IGF1eF9zdGFja1syXTsNCj4gPiArI2Vsc2UNCj4gPiAgCXN0cnVjdCBrYXNhbl90cmFjayBm cmVlX3RyYWNrW0tBU0FOX05SX0ZSRUVfU1RBQ0tTXTsNCj4gPiArI2VuZGlmDQo+ID4gICNpZmRl ZiBDT05GSUdfS0FTQU5fU1dfVEFHU19JREVOVElGWQ0KPiA+ICAJdTggZnJlZV9wb2ludGVyX3Rh Z1tLQVNBTl9OUl9GUkVFX1NUQUNLU107DQo+ID4gIAl1OCBmcmVlX3RyYWNrX2lkeDsNCj4gPiBA QCAtMTU5LDYgKzE2Nyw4IEBAIHZvaWQga2FzYW5fcmVwb3J0X2ludmFsaWRfZnJlZSh2b2lkICpv YmplY3QsIHVuc2lnbmVkIGxvbmcgaXApOw0KPiA+ICANCj4gPiAgc3RydWN0IHBhZ2UgKmthc2Fu X2FkZHJfdG9fcGFnZShjb25zdCB2b2lkICphZGRyKTsNCj4gPiAgDQo+ID4gK2RlcG90X3N0YWNr X2hhbmRsZV90IGthc2FuX3NhdmVfc3RhY2soZ2ZwX3QgZmxhZ3MpOw0KPiA+ICsNCj4gPiAgI2lm IGRlZmluZWQoQ09ORklHX0tBU0FOX0dFTkVSSUMpICYmIFwNCj4gPiAgCShkZWZpbmVkKENPTkZJ R19TTEFCKSB8fCBkZWZpbmVkKENPTkZJR19TTFVCKSkNCj4gPiAgdm9pZCBxdWFyYW50aW5lX3B1 dChzdHJ1Y3Qga2FzYW5fZnJlZV9tZXRhICppbmZvLCBzdHJ1Y3Qga21lbV9jYWNoZSAqY2FjaGUp Ow0KPiA+IGRpZmYgLS1naXQgYS9tbS9rYXNhbi9yZXBvcnQuYyBiL21tL2thc2FuL3JlcG9ydC5j DQo+ID4gaW5kZXggODBmMjNjOWRhNmIwLi42ZjhmMmJmOGY1M2IgMTAwNjQ0DQo+ID4gLS0tIGEv bW0va2FzYW4vcmVwb3J0LmMNCj4gPiArKysgYi9tbS9rYXNhbi9yZXBvcnQuYw0KPiA+IEBAIC0x NzksNiArMTc5LDE3IEBAIHN0YXRpYyBzdHJ1Y3Qga2FzYW5fdHJhY2sgKmthc2FuX2dldF9mcmVl X3RyYWNrKHN0cnVjdCBrbWVtX2NhY2hlICpjYWNoZSwNCj4gPiAgCXJldHVybiAmYWxsb2NfbWV0 YS0+ZnJlZV90cmFja1tpXTsNCj4gPiAgfQ0KPiA+ICANCj4gPiArI2lmZGVmIENPTkZJR19LQVNB Tl9HRU5FUklDDQo+ID4gK3N0YXRpYyB2b2lkIHByaW50X3N0YWNrKGRlcG90X3N0YWNrX2hhbmRs ZV90IHN0YWNrKQ0KPiA+ICt7DQo+ID4gKwl1bnNpZ25lZCBsb25nICplbnRyaWVzOw0KPiA+ICsJ dW5zaWduZWQgaW50IG5yX2VudHJpZXM7DQo+ID4gKw0KPiA+ICsJbnJfZW50cmllcyA9IHN0YWNr X2RlcG90X2ZldGNoKHN0YWNrLCAmZW50cmllcyk7DQo+ID4gKwlzdGFja190cmFjZV9wcmludChl bnRyaWVzLCBucl9lbnRyaWVzLCAwKTsNCj4gPiArfQ0KPiA+ICsjZW5kaWYNCj4gPiArDQo+ID4g IHN0YXRpYyB2b2lkIGRlc2NyaWJlX29iamVjdChzdHJ1Y3Qga21lbV9jYWNoZSAqY2FjaGUsIHZv aWQgKm9iamVjdCwNCj4gPiAgCQkJCWNvbnN0IHZvaWQgKmFkZHIsIHU4IHRhZykNCj4gPiAgew0K PiA+IEBAIC0xOTIsNiArMjAzLDE5IEBAIHN0YXRpYyB2b2lkIGRlc2NyaWJlX29iamVjdChzdHJ1 Y3Qga21lbV9jYWNoZSAqY2FjaGUsIHZvaWQgKm9iamVjdCwNCj4gPiAgCQlmcmVlX3RyYWNrID0g a2FzYW5fZ2V0X2ZyZWVfdHJhY2soY2FjaGUsIG9iamVjdCwgdGFnKTsNCj4gPiAgCQlwcmludF90 cmFjayhmcmVlX3RyYWNrLCAiRnJlZWQiKTsNCj4gPiAgCQlwcl9lcnIoIlxuIik7DQo+ID4gKw0K PiA+ICsjaWZkZWYgQ09ORklHX0tBU0FOX0dFTkVSSUMNCj4gPiArCQlpZiAoYWxsb2NfaW5mby0+ YXV4X3N0YWNrWzBdKSB7DQo+ID4gKwkJCXByX2VycigiTGFzdCBvbmUgY2FsbF9yY3UoKSBjYWxs IHN0YWNrOlxuIik7DQo+ID4gKwkJCXByaW50X3N0YWNrKGFsbG9jX2luZm8tPmF1eF9zdGFja1sw XSk7DQo+ID4gKwkJCXByX2VycigiXG4iKTsNCj4gPiArCQl9DQo+ID4gKwkJaWYgKGFsbG9jX2lu Zm8tPmF1eF9zdGFja1sxXSkgew0KPiA+ICsJCQlwcl9lcnIoIlNlY29uZCB0byBsYXN0IGNhbGxf cmN1KCkgY2FsbCBzdGFjazpcbiIpOw0KPiA+ICsJCQlwcmludF9zdGFjayhhbGxvY19pbmZvLT5h dXhfc3RhY2tbMV0pOw0KPiA+ICsJCQlwcl9lcnIoIlxuIik7DQo+ID4gKwkJfQ0KPiA+ICsjZW5k aWYNCj4gPiAgCX0NCj4gPiAgDQo+ID4gIAlkZXNjcmliZV9vYmplY3RfYWRkcihjYWNoZSwgb2Jq ZWN0LCBhZGRyKTsNCj4gPiAtLSANCj4gPiAyLjE4LjANCg0K