From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jIqdI-0002hp-Sb for ath10k@lists.infradead.org; Mon, 30 Mar 2020 09:23:03 +0000 MIME-Version: 1.0 Date: Mon, 30 Mar 2020 14:52:53 +0530 From: ssreeela@codeaurora.org Subject: Re: [PATCH] ath10k: enable VHT160 and VHT80+80 modes In-Reply-To: <87bloi2g6h.fsf@kamboji.qca.qualcomm.com> References: <1585148169-2320-1-git-send-email-ssreeela@codeaurora.org> <20200326095907.5326BC433BA@smtp.codeaurora.org> <812e84a585ed3aeda9aa54f7d2b14e93@codeaurora.org> <87bloi2g6h.fsf@kamboji.qca.qualcomm.com> Message-ID: <158d2bdf5027a494d14cfdd6134b9c6f@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: Lei Wang , Rick Wu , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Sebastian Gottschall T24gMjAyMC0wMy0yNyAxNjo1NSwgS2FsbGUgVmFsbyB3cm90ZToKPiBzc3JlZWVsYUBjb2RlYXVy b3JhLm9yZyB3cml0ZXM6Cj4gCj4+IE9uIDIwMjAtMDMtMjYgMTU6MjksIEthbGxlIFZhbG8gd3Jv dGU6Cj4+PiBTb3dtaXlhIFNyZWUgRWxhdmFsYWdhbiA8c3NyZWVlbGFAY29kZWF1cm9yYS5vcmc+ IHdyb3RlOgo+Pj4gCj4+Pj4gRnJvbTogTGVpIFdhbmcgPGxlaXdhQGNvZGVhdXJvcmEub3JnPgo+ Pj4+IAo+Pj4+IFNldCByaWdodCBjaGFubmVsIGZyZXF1ZW5jaWVzIGluIFZIVDE2MCBtb2RlIGFj Y29yZGluZyB0byB0aGUgVkhUMTYwCj4+Pj4gaW50ZXJvcGVyYWJpbGl0eSB3b3JrYXJvdW5kIGFk ZGVkIGFzIHBhcnQgb2YgSUVFRSBTdGQgODAyLjEx4oSiLTIwMTYgCj4+Pj4gaW4KPj4+PiAiVGFi bGUgOS0yNTLigJRWSFQgT3BlcmF0aW9uIEluZm9ybWF0aW9uIHN1YmZpZWxkcyIsIGJhbmRfY2Vu dGVyX2ZyZXEyCj4+Pj4gY29ycmVzcG9uZHMgdG8gQ0NGUzEgaW4gVGFibGUgOS0yNTMuIFByZXZp b3VzIGltcGxlbWVudGF0aW9uCj4+Pj4gKGJhbmRfY2VudGVyX2ZyZXEyID0gMCBmb3IgVkhUMTYw KSBpcyBvbmx5IGRlcHJlY2F0ZWQuCj4+Pj4gCj4+Pj4gRW5hYmxlIFZIVDgwKzgwIG1vZGUgYW5k IHNldCB0aGUgcHJvcGVyIHBlZXIgUlggbnNzIHZhbHVlIGZvcgo+Pj4+IFZIVDE2MCBhbmQKPj4+ PiBWSFQ4MCs4MCBtb2RlLgo+Pj4+IAo+Pj4+IEJhc2VkIG9uIHBhdGNoZXMgYnkgU2ViYXN0aWFu IEdvdHRzY2hhbGw6Cj4+Pj4gCj4+Pj4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci8yMDE4MDcw NDA5NTQ0NC42NjItMS1zLmdvdHRzY2hhbGxAZGQtd3J0LmNvbQo+Pj4+IAo+Pj4+IGh0dHBzOi8v bGttbC5rZXJuZWwub3JnL3IvMjAxODA3MDQxMjA1MTkuNjQ3OS0xLXMuZ290dHNjaGFsbEBkZC13 cnQuY29tCj4+Pj4gCj4+Pj4gVGVzdGVkOiBxY2E5OTg0IHdpdGggZmlybXdhcmUgdmVyIDEwLjQt My4xMC0wMDA0Nwo+Pj4+IAo+Pj4+IENvLWRldmVsb3BlZC1ieTogU2ViYXN0aWFuIEdvdHRzY2hh bGwgPHMuZ290dHNjaGFsbEBkZC13cnQuY29tPgo+Pj4+IFNpZ25lZC1vZmYtYnk6IFNlYmFzdGlh biBHb3R0c2NoYWxsIDxzLmdvdHRzY2hhbGxAZGQtd3J0LmNvbT4KPj4+PiBDby1kZXZlbG9wZWQt Ynk6IFJpY2sgV3UgPHJ3dUBjb2RlYXVyb3JhLm9yZz4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBSaWNr IFd1IDxyd3VAY29kZWF1cm9yYS5vcmc+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogTGVpIFdhbmcgPGxl aXdhQGNvZGVhdXJvcmEub3JnPgo+Pj4+IFNpZ25lZC1vZmYtYnk6IFNvd21peWEgU3JlZSBFbGF2 YWxhZ2FuIDxzc3JlZWVsYUBjb2RlYXVyb3JhLm9yZz4KPj4+IAo+Pj4gRmFpbHMgdG8gYnVpbGQg b24gR0NDIDguMS4gRGlkIHlvdSB0ZXN0IHRoaXM/Cj4+PiAKPj4+IEluIGZpbGUgaW5jbHVkZWQg ZnJvbSAuL2luY2x1ZGUvYXNtLWdlbmVyaWMvYnVnLmg6NSwKPj4+ICAgICAgICAgICAgICAgICAg ZnJvbSAuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2J1Zy5oOjgzLAo+Pj4gICAgICAgICAgICAgICAg ICBmcm9tIC4vaW5jbHVkZS9saW51eC9idWcuaDo1LAo+Pj4gICAgICAgICAgICAgICAgICBmcm9t IC4vaW5jbHVkZS9uZXQvbWFjODAyMTEuaDoxNiwKPj4+ICAgICAgICAgICAgICAgICAgZnJvbSBk cml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoMTBrL21hYy5oOjEwLAo+Pj4gICAgICAgICAgICAg ICAgICBmcm9tIGRyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvbWFjLmM6ODoKPj4+IElu IGZ1bmN0aW9uICdhdGgxMGtfcGVlcl9hc3NvY19oX3ZodCcsCj4+PiAgICAgaW5saW5lZCBmcm9t ICdhdGgxMGtfcGVlcl9hc3NvY19wcmVwYXJlJyBhdAo+Pj4gZHJpdmVycy9uZXQvd2lyZWxlc3Mv YXRoL2F0aDEway9tYWMuYzoyNzkwOjI6Cj4+PiAuL2luY2x1ZGUvbGludXgvY29tcGlsZXIuaDoz NTA6Mzg6IGVycm9yOiBjYWxsIHRvCj4+PiAnX19jb21waWxldGltZV9hc3NlcnRfMjYzMScgZGVj bGFyZWQgd2l0aCBhdHRyaWJ1dGUgZXJyb3I6Cj4gCj4gWy4uLl0KPiAKPj4gSSBjaGVja2VkIHRo ZSBidWlsZC4gQnVpbGQgd2FzIHN1Y2Nlc3NmdWwgd2l0aCBHQ0MgdmVyc2lvbiA0LjguCj4+IFdp bGwgZml4IHRoZSBlcnJvciBhbmQgdXBkYXRlIHRoZSBwYXRjaC4KPiAKPiBHcmVhdCwgdGhhbmtz LiBIZXJlJ3MgaG93IEkgaW5zdGFsbGVkIEdDQyA4LjEgZnJvbSBjcm9zc3Rvb2w6Cj4gCj4gbGlz dGluZ3M6IGh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvcHViL3Rvb2xzL2Nyb3NzdG9vbC8KPiAKPiB3 Z2V0Cj4gaHR0cHM6Ly93d3cua2VybmVsLm9yZy9wdWIvdG9vbHMvY3Jvc3N0b29sL2ZpbGVzL2Jp bi94ODZfNjQvOC4xLjAveDg2XzY0LWdjYy04LjEuMC1ub2xpYmMteDg2XzY0LWxpbnV4LnRhci54 ego+IHB1c2hkIC9vcHQvY3Jvc3MvCj4gdGFyIC14ZiB+L3RtcC9jcm9zc3Rvb2wveDg2XzY0LWdj Yy04LjEuMC1ub2xpYmMteDg2XzY0LWxpbnV4LnRhci54ego+IAo+IEluIHRvcCBsZXZlbCBjcmVh dGUgR05VTWFrZWZpbGU6Cj4gCj4gQ1JPU1NfQ09NUElMRT0vb3B0L2Nyb3NzL2djYy04LjEuMC1u b2xpYmMveDg2XzY0LWxpbnV4L2Jpbi94ODZfNjQtbGludXgtCj4gaW5jbHVkZSBNYWtlZmlsZQoK VGhhbmtzIGZvciB0aGUgaW5mby4gV2lsbCBjaGVjayB0aGUgYnVpbGQgd2l0aCBHQ0MgOC4xIGFu ZCByZXNlbmQuCgpSZWdhcmRzLApTb3dtaXlhIFNyZWUKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DACC43331 for ; Mon, 30 Mar 2020 09:23:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 880E2206E6 for ; Mon, 30 Mar 2020 09:23:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="NsM1g+gS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728524AbgC3JXD (ORCPT ); Mon, 30 Mar 2020 05:23:03 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:53550 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727841AbgC3JXD (ORCPT ); Mon, 30 Mar 2020 05:23:03 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585560182; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=YFBdAzzo7+yb9xd0OHuyOAoYZCtYb0OdPlc71GVj/eE=; b=NsM1g+gS1HKtiYfnu7+slfXZX73Xsv6NO5W/faZEY/YgW10Y4jF5saBNuEOyWUA7jQu6Q9tP XEkIsOo7UPIFCeM7jOnc9TIFyjFu0deYI2h9O1xYe5CAGAkRXwC94OYWc4usAN8Os2UYa6Ym OUjqG1tLrvsYFNUrgUp5IMPsevM= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e81ba6e.7f90c35cb928-smtp-out-n04; Mon, 30 Mar 2020 09:22:54 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 19E94C433BA; Mon, 30 Mar 2020 09:22:54 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: ssreeela) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3FA49C433F2; Mon, 30 Mar 2020 09:22:53 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 30 Mar 2020 14:52:53 +0530 From: ssreeela@codeaurora.org To: Kalle Valo Cc: Lei Wang , Rick Wu , linux-wireless@vger.kernel.org, Sebastian Gottschall , ath10k@lists.infradead.org Subject: Re: [PATCH] ath10k: enable VHT160 and VHT80+80 modes In-Reply-To: <87bloi2g6h.fsf@kamboji.qca.qualcomm.com> References: <1585148169-2320-1-git-send-email-ssreeela@codeaurora.org> <20200326095907.5326BC433BA@smtp.codeaurora.org> <812e84a585ed3aeda9aa54f7d2b14e93@codeaurora.org> <87bloi2g6h.fsf@kamboji.qca.qualcomm.com> Message-ID: <158d2bdf5027a494d14cfdd6134b9c6f@codeaurora.org> X-Sender: ssreeela@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-03-27 16:55, Kalle Valo wrote: > ssreeela@codeaurora.org writes: > >> On 2020-03-26 15:29, Kalle Valo wrote: >>> Sowmiya Sree Elavalagan wrote: >>> >>>> From: Lei Wang >>>> >>>> Set right channel frequencies in VHT160 mode according to the VHT160 >>>> interoperability workaround added as part of IEEE Std 802.11™-2016 >>>> in >>>> "Table 9-252—VHT Operation Information subfields", band_center_freq2 >>>> corresponds to CCFS1 in Table 9-253. Previous implementation >>>> (band_center_freq2 = 0 for VHT160) is only deprecated. >>>> >>>> Enable VHT80+80 mode and set the proper peer RX nss value for >>>> VHT160 and >>>> VHT80+80 mode. >>>> >>>> Based on patches by Sebastian Gottschall: >>>> >>>> https://lkml.kernel.org/r/20180704095444.662-1-s.gottschall@dd-wrt.com >>>> >>>> https://lkml.kernel.org/r/20180704120519.6479-1-s.gottschall@dd-wrt.com >>>> >>>> Tested: qca9984 with firmware ver 10.4-3.10-00047 >>>> >>>> Co-developed-by: Sebastian Gottschall >>>> Signed-off-by: Sebastian Gottschall >>>> Co-developed-by: Rick Wu >>>> Signed-off-by: Rick Wu >>>> Signed-off-by: Lei Wang >>>> Signed-off-by: Sowmiya Sree Elavalagan >>> >>> Fails to build on GCC 8.1. Did you test this? >>> >>> In file included from ./include/asm-generic/bug.h:5, >>> from ./arch/x86/include/asm/bug.h:83, >>> from ./include/linux/bug.h:5, >>> from ./include/net/mac80211.h:16, >>> from drivers/net/wireless/ath/ath10k/mac.h:10, >>> from drivers/net/wireless/ath/ath10k/mac.c:8: >>> In function 'ath10k_peer_assoc_h_vht', >>> inlined from 'ath10k_peer_assoc_prepare' at >>> drivers/net/wireless/ath/ath10k/mac.c:2790:2: >>> ./include/linux/compiler.h:350:38: error: call to >>> '__compiletime_assert_2631' declared with attribute error: > > [...] > >> I checked the build. Build was successful with GCC version 4.8. >> Will fix the error and update the patch. > > Great, thanks. Here's how I installed GCC 8.1 from crosstool: > > listings: https://www.kernel.org/pub/tools/crosstool/ > > wget > https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/x86_64-gcc-8.1.0-nolibc-x86_64-linux.tar.xz > pushd /opt/cross/ > tar -xf ~/tmp/crosstool/x86_64-gcc-8.1.0-nolibc-x86_64-linux.tar.xz > > In top level create GNUMakefile: > > CROSS_COMPILE=/opt/cross/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- > include Makefile Thanks for the info. Will check the build with GCC 8.1 and resend. Regards, Sowmiya Sree