From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD017C433E0 for ; Fri, 22 May 2020 06:02:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A5A72078D for ; Fri, 22 May 2020 06:02:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nibbo/CC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="etQwEyKN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A5A72078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uA+zOBJVwG7RQVJhXsSxvVT1rt34tt1KPFGx5zYdPOE=; b=nibbo/CCh+qt5T MdaFM9ZaaPqAycLhG09ZCCeSnaMThRkCHsdlxeYA5ANidmY/7t2TUjTFGvmVHyiWo95Y9rG2oJxwA WQw6p1lW1/HXlb/SM1kBs5EdBagP62xm29pMKZbHXyLbqiEa8bjBlKsZ6B/HGNnHJiRc21rB+teww zqFwiqJwsTqPIBBcfNiKQ7y8uMsfmM0/0jj1UP3k2XczPLZHjQ8zw7U9mDDQTW7nbscMGOAyPxV1X uci/yfP2KnytDmoYa8owkGWzCq9jA8Yn37Dj/9G/9yhMlN0Ti0F4RElMuons0QWb9PXzW6huYfBiH HNzZ2bunMPykLJjpC/8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jc0ks-0004Nr-Mw; Fri, 22 May 2020 06:02:02 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jc0kg-0004FP-2b; Fri, 22 May 2020 06:01:53 +0000 X-UUID: 3884cfe726374df1ba8a59c7440f9f35-20200521 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qqEHW95WdmSOAWr9riOJVXKketJrkFgXfouzxJOvWDQ=; b=etQwEyKNvFcEhO5WbLfBescJVRQXY9OrUTJ/OABaLscv6yz2Ne0sU9ZXyTJ+gHN+fHQVcJHa8hzdpHzI6TDay5aGngSxMuRb0nA7PVHS7HjgGbSBkhvCDnLidELWkVt6ezLbS0xhjFXTOzb9WCBgkXwsAoSwZjgzh0z9faPSba0=; X-UUID: 3884cfe726374df1ba8a59c7440f9f35-20200521 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1070749144; Thu, 21 May 2020 22:01:29 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 21 May 2020 23:01:42 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 22 May 2020 14:01:41 +0800 Received: from [172.21.84.99] (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 22 May 2020 14:01:41 +0800 Message-ID: <1590127302.27807.3.camel@mtksdccf07> Subject: Re: [RFC PATCH V4 1/4] media: v4l2-mem2mem: add v4l2_m2m_suspend, v4l2_m2m_resume From: Jerry-ch Chen To: Tomasz Figa Date: Fri, 22 May 2020 14:01:42 +0800 In-Reply-To: <20200521171101.GA243874@chromium.org> References: <20191204124732.10932-1-Jerry-Ch.chen@mediatek.com> <20191204124732.10932-2-Jerry-Ch.chen@mediatek.com> <20200521171101.GA243874@chromium.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_230150_127770_906C0E4A X-CRM114-Status: GOOD ( 22.56 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, zwisler@chromium.org, srv_heupstream@mediatek.com, Jerry-ch Chen , Hans Verkuil , jungo.lin@mediatek.com, sj.huang@mediatek.com, yuzhao@chromium.org, linux-mediatek@lists.infradead.org, pihsun@chromium.org, frederic.chen@mediatek.com, matthias.bgg@gmail.com, christie.yu@mediatek.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Tomasz, On Thu, 2020-05-21 at 17:11 +0000, Tomasz Figa wrote: > Hi Jerry, > > On Wed, Dec 04, 2019 at 08:47:29PM +0800, Jerry-ch Chen wrote: > > From: Pi-Hsun Shih > > > > Add two functions that can be used to stop new jobs from being queued / > > continue running queued job. This can be used while a driver using m2m > > helper is going to suspend / wake up from resume, and can ensure that > > there's no job running in suspend process. > > > > BUG=b:143046833 > > TEST=build > > > > Signed-off-by: Pi-Hsun Shih > > Signed-off-by: Jerry-ch Chen > > --- > > drivers/media/v4l2-core/v4l2-mem2mem.c | 40 ++++++++++++++++++++++++++ > > include/media/v4l2-mem2mem.h | 22 ++++++++++++++ > > 2 files changed, 62 insertions(+) > > > > diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c > > index 5bbdec55b7d7..76ba203e0035 100644 > > --- a/drivers/media/v4l2-core/v4l2-mem2mem.c > > +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c > > @@ -47,6 +47,10 @@ module_param(debug, bool, 0644); > > #define TRANS_ABORT (1 << 2) > > > > > > +/* The job queue is not running new jobs */ > > +#define QUEUE_PAUSED (1 << 0) > > + > > + > > /* Offset base for buffers on the destination queue - used to distinguish > > * between source and destination buffers when mmapping - they receive the same > > * offsets but for different queues */ > > @@ -88,6 +92,7 @@ static const char * const m2m_entity_name[] = { > > * @job_queue: instances queued to run > > * @job_spinlock: protects job_queue > > * @job_work: worker to run queued jobs. > > + * @job_queue_flags: flags of the queue status, %QUEUE_PAUSED. > > * @m2m_ops: driver callbacks > > */ > > struct v4l2_m2m_dev { > > @@ -105,6 +110,7 @@ struct v4l2_m2m_dev { > > struct list_head job_queue; > > spinlock_t job_spinlock; > > struct work_struct job_work; > > + unsigned long job_queue_flags; > > > > const struct v4l2_m2m_ops *m2m_ops; > > }; > > @@ -267,6 +273,12 @@ static void v4l2_m2m_try_run(struct v4l2_m2m_dev *m2m_dev) > > return; > > } > > > > + if (m2m_dev->job_queue_flags & QUEUE_PAUSED) { > > + spin_unlock_irqrestore(&m2m_dev->job_spinlock, flags); > > + dprintk("Running new jobs is paused\n"); > > + return; > > + } > > + > > m2m_dev->curr_ctx = list_first_entry(&m2m_dev->job_queue, > > struct v4l2_m2m_ctx, queue); > > m2m_dev->curr_ctx->job_flags |= TRANS_RUNNING; > > @@ -447,6 +459,34 @@ void v4l2_m2m_job_finish(struct v4l2_m2m_dev *m2m_dev, > > } > > EXPORT_SYMBOL(v4l2_m2m_job_finish); > > > > +void v4l2_m2m_suspend(struct v4l2_m2m_dev *m2m_dev) > > +{ > > + unsigned long flags; > > + struct v4l2_m2m_ctx *curr_ctx; > > + > > + spin_lock_irqsave(&m2m_dev->job_spinlock, flags); > > + m2m_dev->job_queue_flags |= QUEUE_PAUSED; > > + curr_ctx = m2m_dev->curr_ctx; > > + spin_unlock_irqrestore(&m2m_dev->job_spinlock, flags); > > + > > + if (curr_ctx) > > + wait_event(curr_ctx->finished, > > + !(curr_ctx->job_flags & TRANS_RUNNING)); > > +} > > +EXPORT_SYMBOL(v4l2_m2m_suspend); > > + > > +void v4l2_m2m_resume(struct v4l2_m2m_dev *m2m_dev) > > +{ > > + unsigned long flags; > > + > > + spin_lock_irqsave(&m2m_dev->job_spinlock, flags); > > + m2m_dev->job_queue_flags &= ~QUEUE_PAUSED; > > + spin_unlock_irqrestore(&m2m_dev->job_spinlock, flags); > > + > > + v4l2_m2m_try_run(m2m_dev); > > +} > > +EXPORT_SYMBOL(v4l2_m2m_resume); > > + > > int v4l2_m2m_reqbufs(struct file *file, struct v4l2_m2m_ctx *m2m_ctx, > > struct v4l2_requestbuffers *reqbufs) > > { > > diff --git a/include/media/v4l2-mem2mem.h b/include/media/v4l2-mem2mem.h > > index 5467264771ec..119a195da390 100644 > > --- a/include/media/v4l2-mem2mem.h > > +++ b/include/media/v4l2-mem2mem.h > > @@ -183,6 +183,28 @@ v4l2_m2m_buf_done(struct vb2_v4l2_buffer *buf, enum vb2_buffer_state state) > > vb2_buffer_done(&buf->vb2_buf, state); > > } > > > > +/** > > + * v4l2_m2m_suspend() - stop new jobs from being run and wait for current job > > + * to finish > > + * > > + * @m2m_dev: opaque pointer to the internal data to handle M2M context > > + * > > + * Called by a driver in the suspend hook. Stop new jobs from being run, and > > + * wait for current running job to finish. > > + */ > > +void v4l2_m2m_suspend(struct v4l2_m2m_dev *m2m_dev); > > + > > +/** > > + * v4l2_m2m_resume() - resume job running and try to run a queued job > > + * > > + * @m2m_dev: opaque pointer to the internal data to handle M2M context > > + * > > + * Called by a driver in the resume hook. This reverts the operation of > > + * v4l2_m2m_suspend() and allows job to be run. Also try to run a queued job if > > + * there is any. > > + */ > > +void v4l2_m2m_resume(struct v4l2_m2m_dev *m2m_dev); > > + > > /** > > * v4l2_m2m_reqbufs() - multi-queue-aware REQBUFS multiplexer > > * > > -- > > 2.18.0 > > Reviewed-by: Tomasz Figa > Ok, I've added it in the commit message. Thanks and Best regards, Jerry > [Corrected Hans's email address.] > Hans, does this look good to you? > > Best regards, > Tomasz > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21617C433DF for ; Fri, 22 May 2020 06:01:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAF6F20757 for ; Fri, 22 May 2020 06:01:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lnC+yR3O"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="etQwEyKN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAF6F20757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PFy1r+lOXyurQ0wXCVuaYlak0s0AjmlQcFBASDwucsE=; b=lnC+yR3OZcqvM9 Z9OCDXOuIpiEutWDhvt84lIGbWXDB1ceyZRhMhmufsanwYj6hcy6X6j7t15AChHqXXVPg2EtxsB9C /iqrfiaU4qdRMo1yFgMluunDfK9Yi4gsVJOCageni2NvIUqDqiKjS/lNVzleFvAC1h4r2UtXSVecI U5yyM2ybioLNfR1J2ypfW8WKz0payZEyCUMV7SVgzRa87jXIWO28z03VpVKmwJEzqyIgoYFOoTpAs kuhuiGQfqwYAfbJ7BHjKdmUGQJIzVeA/4WLlDmsEjmhBERPXT6aT+aT1CHsM3nGOly8HoOD+ExklD bPYAc4nLhOqgQYtfEtJA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jc0kl-0004GA-Jq; Fri, 22 May 2020 06:01:55 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jc0kg-0004FP-2b; Fri, 22 May 2020 06:01:53 +0000 X-UUID: 3884cfe726374df1ba8a59c7440f9f35-20200521 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qqEHW95WdmSOAWr9riOJVXKketJrkFgXfouzxJOvWDQ=; b=etQwEyKNvFcEhO5WbLfBescJVRQXY9OrUTJ/OABaLscv6yz2Ne0sU9ZXyTJ+gHN+fHQVcJHa8hzdpHzI6TDay5aGngSxMuRb0nA7PVHS7HjgGbSBkhvCDnLidELWkVt6ezLbS0xhjFXTOzb9WCBgkXwsAoSwZjgzh0z9faPSba0=; X-UUID: 3884cfe726374df1ba8a59c7440f9f35-20200521 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1070749144; Thu, 21 May 2020 22:01:29 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 21 May 2020 23:01:42 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 22 May 2020 14:01:41 +0800 Received: from [172.21.84.99] (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 22 May 2020 14:01:41 +0800 Message-ID: <1590127302.27807.3.camel@mtksdccf07> Subject: Re: [RFC PATCH V4 1/4] media: v4l2-mem2mem: add v4l2_m2m_suspend, v4l2_m2m_resume From: Jerry-ch Chen To: Tomasz Figa Date: Fri, 22 May 2020 14:01:42 +0800 In-Reply-To: <20200521171101.GA243874@chromium.org> References: <20191204124732.10932-1-Jerry-Ch.chen@mediatek.com> <20191204124732.10932-2-Jerry-Ch.chen@mediatek.com> <20200521171101.GA243874@chromium.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_230150_127770_906C0E4A X-CRM114-Status: GOOD ( 22.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, zwisler@chromium.org, srv_heupstream@mediatek.com, Jerry-ch Chen , Hans Verkuil , jungo.lin@mediatek.com, sj.huang@mediatek.com, yuzhao@chromium.org, linux-mediatek@lists.infradead.org, pihsun@chromium.org, frederic.chen@mediatek.com, matthias.bgg@gmail.com, christie.yu@mediatek.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tomasz, On Thu, 2020-05-21 at 17:11 +0000, Tomasz Figa wrote: > Hi Jerry, > > On Wed, Dec 04, 2019 at 08:47:29PM +0800, Jerry-ch Chen wrote: > > From: Pi-Hsun Shih > > > > Add two functions that can be used to stop new jobs from being queued / > > continue running queued job. This can be used while a driver using m2m > > helper is going to suspend / wake up from resume, and can ensure that > > there's no job running in suspend process. > > > > BUG=b:143046833 > > TEST=build > > > > Signed-off-by: Pi-Hsun Shih > > Signed-off-by: Jerry-ch Chen > > --- > > drivers/media/v4l2-core/v4l2-mem2mem.c | 40 ++++++++++++++++++++++++++ > > include/media/v4l2-mem2mem.h | 22 ++++++++++++++ > > 2 files changed, 62 insertions(+) > > > > diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c > > index 5bbdec55b7d7..76ba203e0035 100644 > > --- a/drivers/media/v4l2-core/v4l2-mem2mem.c > > +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c > > @@ -47,6 +47,10 @@ module_param(debug, bool, 0644); > > #define TRANS_ABORT (1 << 2) > > > > > > +/* The job queue is not running new jobs */ > > +#define QUEUE_PAUSED (1 << 0) > > + > > + > > /* Offset base for buffers on the destination queue - used to distinguish > > * between source and destination buffers when mmapping - they receive the same > > * offsets but for different queues */ > > @@ -88,6 +92,7 @@ static const char * const m2m_entity_name[] = { > > * @job_queue: instances queued to run > > * @job_spinlock: protects job_queue > > * @job_work: worker to run queued jobs. > > + * @job_queue_flags: flags of the queue status, %QUEUE_PAUSED. > > * @m2m_ops: driver callbacks > > */ > > struct v4l2_m2m_dev { > > @@ -105,6 +110,7 @@ struct v4l2_m2m_dev { > > struct list_head job_queue; > > spinlock_t job_spinlock; > > struct work_struct job_work; > > + unsigned long job_queue_flags; > > > > const struct v4l2_m2m_ops *m2m_ops; > > }; > > @@ -267,6 +273,12 @@ static void v4l2_m2m_try_run(struct v4l2_m2m_dev *m2m_dev) > > return; > > } > > > > + if (m2m_dev->job_queue_flags & QUEUE_PAUSED) { > > + spin_unlock_irqrestore(&m2m_dev->job_spinlock, flags); > > + dprintk("Running new jobs is paused\n"); > > + return; > > + } > > + > > m2m_dev->curr_ctx = list_first_entry(&m2m_dev->job_queue, > > struct v4l2_m2m_ctx, queue); > > m2m_dev->curr_ctx->job_flags |= TRANS_RUNNING; > > @@ -447,6 +459,34 @@ void v4l2_m2m_job_finish(struct v4l2_m2m_dev *m2m_dev, > > } > > EXPORT_SYMBOL(v4l2_m2m_job_finish); > > > > +void v4l2_m2m_suspend(struct v4l2_m2m_dev *m2m_dev) > > +{ > > + unsigned long flags; > > + struct v4l2_m2m_ctx *curr_ctx; > > + > > + spin_lock_irqsave(&m2m_dev->job_spinlock, flags); > > + m2m_dev->job_queue_flags |= QUEUE_PAUSED; > > + curr_ctx = m2m_dev->curr_ctx; > > + spin_unlock_irqrestore(&m2m_dev->job_spinlock, flags); > > + > > + if (curr_ctx) > > + wait_event(curr_ctx->finished, > > + !(curr_ctx->job_flags & TRANS_RUNNING)); > > +} > > +EXPORT_SYMBOL(v4l2_m2m_suspend); > > + > > +void v4l2_m2m_resume(struct v4l2_m2m_dev *m2m_dev) > > +{ > > + unsigned long flags; > > + > > + spin_lock_irqsave(&m2m_dev->job_spinlock, flags); > > + m2m_dev->job_queue_flags &= ~QUEUE_PAUSED; > > + spin_unlock_irqrestore(&m2m_dev->job_spinlock, flags); > > + > > + v4l2_m2m_try_run(m2m_dev); > > +} > > +EXPORT_SYMBOL(v4l2_m2m_resume); > > + > > int v4l2_m2m_reqbufs(struct file *file, struct v4l2_m2m_ctx *m2m_ctx, > > struct v4l2_requestbuffers *reqbufs) > > { > > diff --git a/include/media/v4l2-mem2mem.h b/include/media/v4l2-mem2mem.h > > index 5467264771ec..119a195da390 100644 > > --- a/include/media/v4l2-mem2mem.h > > +++ b/include/media/v4l2-mem2mem.h > > @@ -183,6 +183,28 @@ v4l2_m2m_buf_done(struct vb2_v4l2_buffer *buf, enum vb2_buffer_state state) > > vb2_buffer_done(&buf->vb2_buf, state); > > } > > > > +/** > > + * v4l2_m2m_suspend() - stop new jobs from being run and wait for current job > > + * to finish > > + * > > + * @m2m_dev: opaque pointer to the internal data to handle M2M context > > + * > > + * Called by a driver in the suspend hook. Stop new jobs from being run, and > > + * wait for current running job to finish. > > + */ > > +void v4l2_m2m_suspend(struct v4l2_m2m_dev *m2m_dev); > > + > > +/** > > + * v4l2_m2m_resume() - resume job running and try to run a queued job > > + * > > + * @m2m_dev: opaque pointer to the internal data to handle M2M context > > + * > > + * Called by a driver in the resume hook. This reverts the operation of > > + * v4l2_m2m_suspend() and allows job to be run. Also try to run a queued job if > > + * there is any. > > + */ > > +void v4l2_m2m_resume(struct v4l2_m2m_dev *m2m_dev); > > + > > /** > > * v4l2_m2m_reqbufs() - multi-queue-aware REQBUFS multiplexer > > * > > -- > > 2.18.0 > > Reviewed-by: Tomasz Figa > Ok, I've added it in the commit message. Thanks and Best regards, Jerry > [Corrected Hans's email address.] > Hans, does this look good to you? > > Best regards, > Tomasz > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45363C433DF for ; Fri, 22 May 2020 06:01:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0B7D2078D for ; Fri, 22 May 2020 06:01:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="etQwEyKN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726578AbgEVGBu (ORCPT ); Fri, 22 May 2020 02:01:50 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:57323 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726449AbgEVGBu (ORCPT ); Fri, 22 May 2020 02:01:50 -0400 X-UUID: d7731f636675426d94a1e4397e86684f-20200522 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qqEHW95WdmSOAWr9riOJVXKketJrkFgXfouzxJOvWDQ=; b=etQwEyKNvFcEhO5WbLfBescJVRQXY9OrUTJ/OABaLscv6yz2Ne0sU9ZXyTJ+gHN+fHQVcJHa8hzdpHzI6TDay5aGngSxMuRb0nA7PVHS7HjgGbSBkhvCDnLidELWkVt6ezLbS0xhjFXTOzb9WCBgkXwsAoSwZjgzh0z9faPSba0=; X-UUID: d7731f636675426d94a1e4397e86684f-20200522 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 842208596; Fri, 22 May 2020 14:01:43 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 22 May 2020 14:01:41 +0800 Received: from [172.21.84.99] (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 22 May 2020 14:01:41 +0800 Message-ID: <1590127302.27807.3.camel@mtksdccf07> Subject: Re: [RFC PATCH V4 1/4] media: v4l2-mem2mem: add v4l2_m2m_suspend, v4l2_m2m_resume From: Jerry-ch Chen To: Tomasz Figa CC: Hans Verkuil , , , , , , , , , , , , , , , , , , Jerry-ch Chen Date: Fri, 22 May 2020 14:01:42 +0800 In-Reply-To: <20200521171101.GA243874@chromium.org> References: <20191204124732.10932-1-Jerry-Ch.chen@mediatek.com> <20191204124732.10932-2-Jerry-Ch.chen@mediatek.com> <20200521171101.GA243874@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgVG9tYXN6LA0KDQpPbiBUaHUsIDIwMjAtMDUtMjEgYXQgMTc6MTEgKzAwMDAsIFRvbWFzeiBG aWdhIHdyb3RlOg0KPiBIaSBKZXJyeSwNCj4gDQo+IE9uIFdlZCwgRGVjIDA0LCAyMDE5IGF0IDA4 OjQ3OjI5UE0gKzA4MDAsIEplcnJ5LWNoIENoZW4gd3JvdGU6DQo+ID4gRnJvbTogUGktSHN1biBT aGloIDxwaWhzdW5AY2hyb21pdW0ub3JnPg0KPiA+IA0KPiA+IEFkZCB0d28gZnVuY3Rpb25zIHRo YXQgY2FuIGJlIHVzZWQgdG8gc3RvcCBuZXcgam9icyBmcm9tIGJlaW5nIHF1ZXVlZCAvDQo+ID4g Y29udGludWUgcnVubmluZyBxdWV1ZWQgam9iLiBUaGlzIGNhbiBiZSB1c2VkIHdoaWxlIGEgZHJp dmVyIHVzaW5nIG0ybQ0KPiA+IGhlbHBlciBpcyBnb2luZyB0byBzdXNwZW5kIC8gd2FrZSB1cCBm cm9tIHJlc3VtZSwgYW5kIGNhbiBlbnN1cmUgdGhhdA0KPiA+IHRoZXJlJ3Mgbm8gam9iIHJ1bm5p bmcgaW4gc3VzcGVuZCBwcm9jZXNzLg0KPiA+IA0KPiA+IEJVRz1iOjE0MzA0NjgzMw0KPiA+IFRF U1Q9YnVpbGQNCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBQaS1Ic3VuIFNoaWggPHBpaHN1bkBj aHJvbWl1bS5vcmc+DQo+ID4gU2lnbmVkLW9mZi1ieTogSmVycnktY2ggQ2hlbiA8amVycnktY2gu Y2hlbkBtZWRpYXRlay5jb3JwLXBhcnRuZXIuZ29vZ2xlLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJp dmVycy9tZWRpYS92NGwyLWNvcmUvdjRsMi1tZW0ybWVtLmMgfCA0MCArKysrKysrKysrKysrKysr KysrKysrKysrKw0KPiA+ICBpbmNsdWRlL21lZGlhL3Y0bDItbWVtMm1lbS5oICAgICAgICAgICB8 IDIyICsrKysrKysrKysrKysrDQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNjIgaW5zZXJ0aW9ucygr KQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3Y0bDItY29yZS92NGwyLW1l bTJtZW0uYyBiL2RyaXZlcnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDItbWVtMm1lbS5jDQo+ID4gaW5k ZXggNWJiZGVjNTViN2Q3Li43NmJhMjAzZTAwMzUgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9t ZWRpYS92NGwyLWNvcmUvdjRsMi1tZW0ybWVtLmMNCj4gPiArKysgYi9kcml2ZXJzL21lZGlhL3Y0 bDItY29yZS92NGwyLW1lbTJtZW0uYw0KPiA+IEBAIC00Nyw2ICs0NywxMCBAQCBtb2R1bGVfcGFy YW0oZGVidWcsIGJvb2wsIDA2NDQpOw0KPiA+ICAjZGVmaW5lIFRSQU5TX0FCT1JUCQkoMSA8PCAy KQ0KPiA+ICANCj4gPiAgDQo+ID4gKy8qIFRoZSBqb2IgcXVldWUgaXMgbm90IHJ1bm5pbmcgbmV3 IGpvYnMgKi8NCj4gPiArI2RlZmluZSBRVUVVRV9QQVVTRUQJCSgxIDw8IDApDQo+ID4gKw0KPiA+ ICsNCj4gPiAgLyogT2Zmc2V0IGJhc2UgZm9yIGJ1ZmZlcnMgb24gdGhlIGRlc3RpbmF0aW9uIHF1 ZXVlIC0gdXNlZCB0byBkaXN0aW5ndWlzaA0KPiA+ICAgKiBiZXR3ZWVuIHNvdXJjZSBhbmQgZGVz dGluYXRpb24gYnVmZmVycyB3aGVuIG1tYXBwaW5nIC0gdGhleSByZWNlaXZlIHRoZSBzYW1lDQo+ ID4gICAqIG9mZnNldHMgYnV0IGZvciBkaWZmZXJlbnQgcXVldWVzICovDQo+ID4gQEAgLTg4LDYg KzkyLDcgQEAgc3RhdGljIGNvbnN0IGNoYXIgKiBjb25zdCBtMm1fZW50aXR5X25hbWVbXSA9IHsN Cj4gPiAgICogQGpvYl9xdWV1ZToJCWluc3RhbmNlcyBxdWV1ZWQgdG8gcnVuDQo+ID4gICAqIEBq b2Jfc3BpbmxvY2s6CXByb3RlY3RzIGpvYl9xdWV1ZQ0KPiA+ICAgKiBAam9iX3dvcms6CQl3b3Jr ZXIgdG8gcnVuIHF1ZXVlZCBqb2JzLg0KPiA+ICsgKiBAam9iX3F1ZXVlX2ZsYWdzOglmbGFncyBv ZiB0aGUgcXVldWUgc3RhdHVzLCAlUVVFVUVfUEFVU0VELg0KPiA+ICAgKiBAbTJtX29wczoJCWRy aXZlciBjYWxsYmFja3MNCj4gPiAgICovDQo+ID4gIHN0cnVjdCB2NGwyX20ybV9kZXYgew0KPiA+ IEBAIC0xMDUsNiArMTEwLDcgQEAgc3RydWN0IHY0bDJfbTJtX2RldiB7DQo+ID4gIAlzdHJ1Y3Qg bGlzdF9oZWFkCWpvYl9xdWV1ZTsNCj4gPiAgCXNwaW5sb2NrX3QJCWpvYl9zcGlubG9jazsNCj4g PiAgCXN0cnVjdCB3b3JrX3N0cnVjdAlqb2Jfd29yazsNCj4gPiArCXVuc2lnbmVkIGxvbmcJCWpv Yl9xdWV1ZV9mbGFnczsNCj4gPiAgDQo+ID4gIAljb25zdCBzdHJ1Y3QgdjRsMl9tMm1fb3BzICpt Mm1fb3BzOw0KPiA+ICB9Ow0KPiA+IEBAIC0yNjcsNiArMjczLDEyIEBAIHN0YXRpYyB2b2lkIHY0 bDJfbTJtX3RyeV9ydW4oc3RydWN0IHY0bDJfbTJtX2RldiAqbTJtX2RldikNCj4gPiAgCQlyZXR1 cm47DQo+ID4gIAl9DQo+ID4gIA0KPiA+ICsJaWYgKG0ybV9kZXYtPmpvYl9xdWV1ZV9mbGFncyAm IFFVRVVFX1BBVVNFRCkgew0KPiA+ICsJCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJm0ybV9kZXYt PmpvYl9zcGlubG9jaywgZmxhZ3MpOw0KPiA+ICsJCWRwcmludGsoIlJ1bm5pbmcgbmV3IGpvYnMg aXMgcGF1c2VkXG4iKTsNCj4gPiArCQlyZXR1cm47DQo+ID4gKwl9DQo+ID4gKw0KPiA+ICAJbTJt X2Rldi0+Y3Vycl9jdHggPSBsaXN0X2ZpcnN0X2VudHJ5KCZtMm1fZGV2LT5qb2JfcXVldWUsDQo+ ID4gIAkJCQkgICBzdHJ1Y3QgdjRsMl9tMm1fY3R4LCBxdWV1ZSk7DQo+ID4gIAltMm1fZGV2LT5j dXJyX2N0eC0+am9iX2ZsYWdzIHw9IFRSQU5TX1JVTk5JTkc7DQo+ID4gQEAgLTQ0Nyw2ICs0NTks MzQgQEAgdm9pZCB2NGwyX20ybV9qb2JfZmluaXNoKHN0cnVjdCB2NGwyX20ybV9kZXYgKm0ybV9k ZXYsDQo+ID4gIH0NCj4gPiAgRVhQT1JUX1NZTUJPTCh2NGwyX20ybV9qb2JfZmluaXNoKTsNCj4g PiAgDQo+ID4gK3ZvaWQgdjRsMl9tMm1fc3VzcGVuZChzdHJ1Y3QgdjRsMl9tMm1fZGV2ICptMm1f ZGV2KQ0KPiA+ICt7DQo+ID4gKwl1bnNpZ25lZCBsb25nIGZsYWdzOw0KPiA+ICsJc3RydWN0IHY0 bDJfbTJtX2N0eCAqY3Vycl9jdHg7DQo+ID4gKw0KPiA+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJm0y bV9kZXYtPmpvYl9zcGlubG9jaywgZmxhZ3MpOw0KPiA+ICsJbTJtX2Rldi0+am9iX3F1ZXVlX2Zs YWdzIHw9IFFVRVVFX1BBVVNFRDsNCj4gPiArCWN1cnJfY3R4ID0gbTJtX2Rldi0+Y3Vycl9jdHg7 DQo+ID4gKwlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZtMm1fZGV2LT5qb2Jfc3BpbmxvY2ssIGZs YWdzKTsNCj4gPiArDQo+ID4gKwlpZiAoY3Vycl9jdHgpDQo+ID4gKwkJd2FpdF9ldmVudChjdXJy X2N0eC0+ZmluaXNoZWQsDQo+ID4gKwkJCSAgICEoY3Vycl9jdHgtPmpvYl9mbGFncyAmIFRSQU5T X1JVTk5JTkcpKTsNCj4gPiArfQ0KPiA+ICtFWFBPUlRfU1lNQk9MKHY0bDJfbTJtX3N1c3BlbmQp Ow0KPiA+ICsNCj4gPiArdm9pZCB2NGwyX20ybV9yZXN1bWUoc3RydWN0IHY0bDJfbTJtX2RldiAq bTJtX2RldikNCj4gPiArew0KPiA+ICsJdW5zaWduZWQgbG9uZyBmbGFnczsNCj4gPiArDQo+ID4g KwlzcGluX2xvY2tfaXJxc2F2ZSgmbTJtX2Rldi0+am9iX3NwaW5sb2NrLCBmbGFncyk7DQo+ID4g KwltMm1fZGV2LT5qb2JfcXVldWVfZmxhZ3MgJj0gflFVRVVFX1BBVVNFRDsNCj4gPiArCXNwaW5f dW5sb2NrX2lycXJlc3RvcmUoJm0ybV9kZXYtPmpvYl9zcGlubG9jaywgZmxhZ3MpOw0KPiA+ICsN Cj4gPiArCXY0bDJfbTJtX3RyeV9ydW4obTJtX2Rldik7DQo+ID4gK30NCj4gPiArRVhQT1JUX1NZ TUJPTCh2NGwyX20ybV9yZXN1bWUpOw0KPiA+ICsNCj4gPiAgaW50IHY0bDJfbTJtX3JlcWJ1ZnMo c3RydWN0IGZpbGUgKmZpbGUsIHN0cnVjdCB2NGwyX20ybV9jdHggKm0ybV9jdHgsDQo+ID4gIAkJ ICAgICBzdHJ1Y3QgdjRsMl9yZXF1ZXN0YnVmZmVycyAqcmVxYnVmcykNCj4gPiAgew0KPiA+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL21lZGlhL3Y0bDItbWVtMm1lbS5oIGIvaW5jbHVkZS9tZWRpYS92 NGwyLW1lbTJtZW0uaA0KPiA+IGluZGV4IDU0NjcyNjQ3NzFlYy4uMTE5YTE5NWRhMzkwIDEwMDY0 NA0KPiA+IC0tLSBhL2luY2x1ZGUvbWVkaWEvdjRsMi1tZW0ybWVtLmgNCj4gPiArKysgYi9pbmNs dWRlL21lZGlhL3Y0bDItbWVtMm1lbS5oDQo+ID4gQEAgLTE4Myw2ICsxODMsMjggQEAgdjRsMl9t Mm1fYnVmX2RvbmUoc3RydWN0IHZiMl92NGwyX2J1ZmZlciAqYnVmLCBlbnVtIHZiMl9idWZmZXJf c3RhdGUgc3RhdGUpDQo+ID4gIAl2YjJfYnVmZmVyX2RvbmUoJmJ1Zi0+dmIyX2J1Ziwgc3RhdGUp Ow0KPiA+ICB9DQo+ID4gIA0KPiA+ICsvKioNCj4gPiArICogdjRsMl9tMm1fc3VzcGVuZCgpIC0g c3RvcCBuZXcgam9icyBmcm9tIGJlaW5nIHJ1biBhbmQgd2FpdCBmb3IgY3VycmVudCBqb2INCj4g PiArICogdG8gZmluaXNoDQo+ID4gKyAqDQo+ID4gKyAqIEBtMm1fZGV2OiBvcGFxdWUgcG9pbnRl ciB0byB0aGUgaW50ZXJuYWwgZGF0YSB0byBoYW5kbGUgTTJNIGNvbnRleHQNCj4gPiArICoNCj4g PiArICogQ2FsbGVkIGJ5IGEgZHJpdmVyIGluIHRoZSBzdXNwZW5kIGhvb2suIFN0b3AgbmV3IGpv YnMgZnJvbSBiZWluZyBydW4sIGFuZA0KPiA+ICsgKiB3YWl0IGZvciBjdXJyZW50IHJ1bm5pbmcg am9iIHRvIGZpbmlzaC4NCj4gPiArICovDQo+ID4gK3ZvaWQgdjRsMl9tMm1fc3VzcGVuZChzdHJ1 Y3QgdjRsMl9tMm1fZGV2ICptMm1fZGV2KTsNCj4gPiArDQo+ID4gKy8qKg0KPiA+ICsgKiB2NGwy X20ybV9yZXN1bWUoKSAtIHJlc3VtZSBqb2IgcnVubmluZyBhbmQgdHJ5IHRvIHJ1biBhIHF1ZXVl ZCBqb2INCj4gPiArICoNCj4gPiArICogQG0ybV9kZXY6IG9wYXF1ZSBwb2ludGVyIHRvIHRoZSBp bnRlcm5hbCBkYXRhIHRvIGhhbmRsZSBNMk0gY29udGV4dA0KPiA+ICsgKg0KPiA+ICsgKiBDYWxs ZWQgYnkgYSBkcml2ZXIgaW4gdGhlIHJlc3VtZSBob29rLiBUaGlzIHJldmVydHMgdGhlIG9wZXJh dGlvbiBvZg0KPiA+ICsgKiB2NGwyX20ybV9zdXNwZW5kKCkgYW5kIGFsbG93cyBqb2IgdG8gYmUg cnVuLiBBbHNvIHRyeSB0byBydW4gYSBxdWV1ZWQgam9iIGlmDQo+ID4gKyAqIHRoZXJlIGlzIGFu eS4NCj4gPiArICovDQo+ID4gK3ZvaWQgdjRsMl9tMm1fcmVzdW1lKHN0cnVjdCB2NGwyX20ybV9k ZXYgKm0ybV9kZXYpOw0KPiA+ICsNCj4gPiAgLyoqDQo+ID4gICAqIHY0bDJfbTJtX3JlcWJ1ZnMo KSAtIG11bHRpLXF1ZXVlLWF3YXJlIFJFUUJVRlMgbXVsdGlwbGV4ZXINCj4gPiAgICoNCj4gPiAt LSANCj4gPiAyLjE4LjANCj4gDQo+IFJldmlld2VkLWJ5OiBUb21hc3ogRmlnYSA8dGZpZ2FAY2hy b21pdW0ub3JnPg0KPiANCk9rLCBJJ3ZlIGFkZGVkIGl0IGluIHRoZSBjb21taXQgbWVzc2FnZS4N Cg0KVGhhbmtzIGFuZCBCZXN0IHJlZ2FyZHMsDQpKZXJyeQ0KDQo+IFtDb3JyZWN0ZWQgSGFucydz IGVtYWlsIGFkZHJlc3MuXQ0KPiBIYW5zLCBkb2VzIHRoaXMgbG9vayBnb29kIHRvIHlvdT8NCj4g DQo+IEJlc3QgcmVnYXJkcywNCj4gVG9tYXN6DQo+IA0KDQo=