All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>,
	Pawel Wodkowski <pawelx.wodkowski@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/3] librte_compat: fix macro deffinition
Date: Mon, 15 Jun 2015 11:12:08 +0200	[thread overview]
Message-ID: <1591170.szdQAMiik7@xps13> (raw)
In-Reply-To: <1432913219-11589-3-git-send-email-maciejx.t.gajdzica@intel.com>

Hi,

More fixes are needed in rte_compat.h

2015-05-29 17:26, Maciej Gajdzica:
> --- a/lib/librte_compat/rte_compat.h
> +++ b/lib/librte_compat/rte_compat.h
> @@ -103,7 +103,7 @@
>  #define VERSION_SYMBOL(b, e, v)

Should be b,e,n

>  #define __vsym
>  #define BASE_SYMBOL(b, n)

Should be b,e

> -#define BIND_DEFAULT_SYMBOL(b, v)
> +#define BIND_DEFAULT_SYMBOL(b, v, n)

Should be b,e,n

This comment needs also to be fixed:
 *  BIND_DEFAULT_SYMBOL(foo, 2.1);

  reply	other threads:[~2015-06-15  9:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 15:26 [PATCH 0/3] librte_cfgfile rework and extension Maciej Gajdzica
2015-05-29 15:26 ` [PATCH 1/3] librte_cfgfile: fix code formating in header file Maciej Gajdzica
2015-05-29 15:26 ` [PATCH 2/3] librte_compat: fix macro deffinition Maciej Gajdzica
2015-06-15  9:12   ` Thomas Monjalon [this message]
2015-05-29 15:26 ` [PATCH 3/3] librte_cfgfile: rework Maciej Gajdzica
2015-06-15  9:29   ` Thomas Monjalon
2015-06-01  8:34 ` [PATCH 0/3] librte_cfgfile rework and extension Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1591170.szdQAMiik7@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=maciejx.t.gajdzica@intel.com \
    --cc=pawelx.wodkowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.