From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60449C433E0 for ; Fri, 5 Jun 2020 03:32:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2733207D5 for ; Fri, 5 Jun 2020 03:32:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZotlyRCE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="KiRUwyi8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2733207D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HS7+rPv0odKEIQGQybprqMa33wjuR5qZRV43qV63zr4=; b=ZotlyRCEhi7J1P r0H5RFxy1xUp+vv39USOE2txjqh3wpoTztKRX000VkAdyV9QuEZd7V1o5xRRHj9DN48O3PoagMXCO b083ES4upLgWp7Ls1M7RVOausCF/oaoS1IuaBUzElE7BDXRgYJp0P8y78Cnle1/WfS/RfmyULfCAp UMYl5zeqDK37OMwhiPf+5TSBuISKWmF5rWWD/zdg6RenBLJ6+8fpqlmUJ/RXh4kSZqK/xm8CjDJTA V24FfjeHv1aJw6fRHpA8OSLS4PSYc4hMTrEg0zEc/1XRXTnrbBDCOuPud19oXXr8uFfVBZqjOiR4+ cIPByyuA495w5zOv0SAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jh359-00068b-Tl; Fri, 05 Jun 2020 03:31:47 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jh34m-0005jX-I1; Fri, 05 Jun 2020 03:31:28 +0000 X-UUID: 59927f6b1be94d76a788e74651131520-20200604 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=MHlq0MQzXxzGdzCp+WA3QekEd3SxtT46HLdvc3d72CY=; b=KiRUwyi8GFs77wQMyZGENwImTmg9YtwVdfVcEYU7rSFutzLPn0ERROX81yHQsZsidpYrsigZRxCVxR04wFlHc4WOfoNqtMOTZaVQ2z5Vqj+mRhLWTafdHbbt7M9YSaDLY3iHEgvd4Vq68biSU1vtCQ2ZbS/MwEeC9FkhyPrYAq4=; X-UUID: 59927f6b1be94d76a788e74651131520-20200604 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1200726263; Thu, 04 Jun 2020 19:31:14 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Jun 2020 20:21:15 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Jun 2020 11:21:11 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 5 Jun 2020 11:21:10 +0800 Message-ID: <1591327147.8804.561.camel@mhfsdcap03> Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver From: Dongchun Zhu To: Sakari Ailus Date: Fri, 5 Jun 2020 11:19:07 +0800 In-Reply-To: <20200604092616.GJ16711@paasikivi.fi.intel.com> References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <1591236845.8804.547.camel@mhfsdcap03> <20200604092616.GJ16711@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 28F51B7C61836675CD5E7C0BB31C57102791D8C41924DC04BA6D5AB6E2499ABA2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_203124_614473_DCA07B10 X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, drinkcat@chromium.org, andriy.shevchenko@linux.intel.com, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linus.walleij@linaro.org, shengnan.wang@mediatek.com, tfiga@chromium.org, bgolaszewski@baylibre.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, louis.kuo@mediatek.com, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Sakari, On Thu, 2020-06-04 at 12:26 +0300, Sakari Ailus wrote: > Hi Dongchun, > > On Thu, Jun 04, 2020 at 10:14:05AM +0800, Dongchun Zhu wrote: > > Hi Tomasz, Sakari, and sirs, > > > > Could anyone help to review this patch? > > > > On Sat, 2020-05-23 at 16:41 +0800, Dongchun Zhu wrote: > > > Add a V4L2 sub-device driver for OV02A10 image sensor. > > > > > > Signed-off-by: Dongchun Zhu > > > --- > > > MAINTAINERS | 1 + > > > drivers/media/i2c/Kconfig | 13 + > > > drivers/media/i2c/Makefile | 1 + > > > drivers/media/i2c/ov02a10.c | 1025 +++++++++++++++++++++++++++++++++++++++++++ > > > 4 files changed, 1040 insertions(+) > > > create mode 100644 drivers/media/i2c/ov02a10.c > > > > > > > [snip] > > > > > +static int ov02a10_probe(struct i2c_client *client) > > > +{ > > > + struct device *dev = &client->dev; > > > + struct ov02a10 *ov02a10; > > > + unsigned int rotation; > > > + unsigned int clock_lane_tx_speed; > > > + unsigned int i; > > > + int ret; > > > + > > > + ov02a10 = devm_kzalloc(dev, sizeof(*ov02a10), GFP_KERNEL); > > > + if (!ov02a10) > > > + return -ENOMEM; > > > + > > > + ret = ov02a10_check_hwcfg(dev, ov02a10); > > > + if (ret) { > > > + dev_err(dev, "failed to check HW configuration: %d", ret); > > > + return ret; > > > + } > > > + > > > + v4l2_i2c_subdev_init(&ov02a10->subdev, client, &ov02a10_subdev_ops); > > > + ov02a10->mipi_clock_tx_speed = OV02A10_MIPI_TX_SPEED_DEFAULT; > > > + ov02a10->fmt.code = MEDIA_BUS_FMT_SBGGR10_1X10; > > > + > > > + /* Optional indication of physical rotation of sensor */ > > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "rotation", &rotation); > > > + if (!ret && rotation == 180) { > > > + ov02a10->upside_down = true; > > > + ov02a10->fmt.code = MEDIA_BUS_FMT_SRGGB10_1X10; > > > + } > > > + > > > + /* Optional indication of mipi TX speed */ > > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "ovti,mipi-tx-speed", > > > + &clock_lane_tx_speed); > > > + > > > + if (!ret) > > > + ov02a10->mipi_clock_tx_speed = clock_lane_tx_speed; > > > + > > > + /* Get system clock (eclk) */ > > > + ov02a10->eclk = devm_clk_get(dev, "eclk"); > > > + if (IS_ERR(ov02a10->eclk)) { > > > + ret = PTR_ERR(ov02a10->eclk); > > > + dev_err(dev, "failed to get eclk %d\n", ret); > > > + return ret; > > > + } > > > + > > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", > > > + &ov02a10->eclk_freq); > > > + if (ret) { > > > + dev_err(dev, "failed to get eclk frequency\n"); > > > + return ret; > > > + } > > > + > > > + ret = clk_set_rate(ov02a10->eclk, ov02a10->eclk_freq); > > > + if (ret) { > > > + dev_err(dev, "failed to set eclk frequency (24MHz)\n"); > > > + return ret; > > > + } > > > + > > > + if (clk_get_rate(ov02a10->eclk) != OV02A10_ECLK_FREQ) { > > > + dev_warn(dev, "wrong eclk frequency %d Hz, expected: %d Hz\n", > > > + ov02a10->eclk_freq, OV02A10_ECLK_FREQ); > > > + return -EINVAL; > > > + } > > > + > > > + ov02a10->pd_gpio = devm_gpiod_get(dev, "powerdown", GPIOD_OUT_HIGH); > > > + if (IS_ERR(ov02a10->pd_gpio)) { > > > + ret = PTR_ERR(ov02a10->pd_gpio); > > > + dev_err(dev, "failed to get powerdown-gpios %d\n", ret); > > > + return ret; > > > + } > > > + > > > + ov02a10->n_rst_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); > > > + if (IS_ERR(ov02a10->n_rst_gpio)) { > > > + ret = PTR_ERR(ov02a10->n_rst_gpio); > > > + dev_err(dev, "failed to get reset-gpios %d\n", ret); > > > + return ret; > > > + } > > > + > > > + for (i = 0; i < ARRAY_SIZE(ov02a10_supply_names); i++) > > > + ov02a10->supplies[i].supply = ov02a10_supply_names[i]; > > > + > > > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ov02a10_supply_names), > > > + ov02a10->supplies); > > > + if (ret) { > > > + dev_err(dev, "failed to get regulators\n"); > > > + return ret; > > > + } > > > + > > > + mutex_init(&ov02a10->mutex); > > > + ov02a10->cur_mode = &supported_modes[0]; > > > + ret = ov02a10_initialize_controls(ov02a10); > > > + if (ret) { > > > + dev_err(dev, "failed to initialize controls\n"); > > > + goto err_destroy_mutex; > > > + } > > > + > > > + ov02a10->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > > > + ov02a10->subdev.entity.ops = &ov02a10_subdev_entity_ops; > > > + ov02a10->subdev.entity.function = MEDIA_ENT_F_CAM_SENSOR; > > > + ov02a10->pad.flags = MEDIA_PAD_FL_SOURCE; > > > + ret = media_entity_pads_init(&ov02a10->subdev.entity, 1, &ov02a10->pad); > > > + if (ret < 0) { > > > + dev_err(dev, "failed to init entity pads: %d", ret); > > > + goto err_free_handler; > > > + } > > > + > > > + pm_runtime_enable(dev); > > > + if (!pm_runtime_enabled(dev)) { > > > + ret = ov02a10_power_on(dev); > > > + if (ret < 0) { > > > + dev_err(dev, "failed to power on: %d\n", ret); > > > + goto err_free_handler; This is actually wrong, which should be replaced of "err_clean_entity". > > > + } > > > + } > > > + > > > + ret = v4l2_async_register_subdev(&ov02a10->subdev); > > > + if (ret) { > > > + dev_err(dev, "failed to register V4L2 subdev: %d", ret); > > > + if (!pm_runtime_enabled(dev)) > > > + ov02a10_power_off(dev); > > This should be moved to error handling section below. > Fine. It would be abstracted as "err_async_register" in next release. Something like: err_async_register: if (!pm_runtime_enabled(dev)) ov02a10_power_off(dev); err_clean_entity: media_entity_cleanup(&ov02a10->subdev.entity); ... > > > + goto err_clean_entity; > > > + } > > > > Tomasz, Sakari, is this ok? > > or coding like this: > > > > ret = v4l2_async_register_subdev(&ov02a10->subdev); > > if (!pm_runtime_enabled(dev)) > > ov02a10_power_off(dev); > > if (ret) { > > dev_err(dev, "failed to register V4L2 subdev: %d", ret); > > goto err_clean_entity; > > } > > > > What's your opinions about the change? > > This turns power off if runtime PM is disabled. I'd keep it as-is, as it'd > require re-implementing what runtime PM is used for now --- and that's not > a sensor driver's job. > > > > > > + > > > + return 0; > > > + > > > +err_clean_entity: > > > + media_entity_cleanup(&ov02a10->subdev.entity); > > > +err_free_handler: > > > + v4l2_ctrl_handler_free(ov02a10->subdev.ctrl_handler); > > > +err_destroy_mutex: > > > + mutex_destroy(&ov02a10->mutex); > > > + > > > + return ret; > > > +} > > > + > > > +static int ov02a10_remove(struct i2c_client *client) > > > +{ > > > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > + struct ov02a10 *ov02a10 = to_ov02a10(sd); > > > + > > > + v4l2_async_unregister_subdev(sd); > > > + media_entity_cleanup(&sd->entity); > > > + v4l2_ctrl_handler_free(sd->ctrl_handler); > > > + pm_runtime_disable(&client->dev); > > > + if (!pm_runtime_status_suspended(&client->dev)) > > > + ov02a10_power_off(&client->dev); > > > + pm_runtime_set_suspended(&client->dev); > > > + mutex_destroy(&ov02a10->mutex); > > > + > > > + return 0; > > > +} > > > + > > > +static const struct of_device_id ov02a10_of_match[] = { > > > + { .compatible = "ovti,ov02a10" }, > > > + {} > > > +}; > > > +MODULE_DEVICE_TABLE(of, ov02a10_of_match); > > > + > > > +static struct i2c_driver ov02a10_i2c_driver = { > > > + .driver = { > > > + .name = "ov02a10", > > > + .pm = &ov02a10_pm_ops, > > > + .of_match_table = ov02a10_of_match, > > > + }, > > > + .probe_new = &ov02a10_probe, > > > + .remove = &ov02a10_remove, > > > +}; > > > + > > > +module_i2c_driver(ov02a10_i2c_driver); > > > + > > > +MODULE_AUTHOR("Dongchun Zhu "); > > > +MODULE_DESCRIPTION("OmniVision OV02A10 sensor driver"); > > > +MODULE_LICENSE("GPL v2"); > > > + > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49A4C433DF for ; Fri, 5 Jun 2020 03:31:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6DA1207D3 for ; Fri, 5 Jun 2020 03:31:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kr9ZijJe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="KiRUwyi8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6DA1207D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lFQGxjnqcOYQepnB08hQyv7a1ilkvZ3e4SGEPMIFze4=; b=kr9ZijJejhDPeq 1h5GDGxEAm1EPkKlbh2BN5dqFD97NfE0SKAWR9HGJxVNCoFbQrlS0Smupmauvt0dRFSf7vXJmB84S 4++zS9nXipR8g89IQ9+RHv32g8kkxpFPKuA3pBRLJw7CfIOIafJ+gHC0naBM2+wbJMcprKS4/mmvJ R5efEsUa/3YfPfl47Y+PdJ39puMwBxQjNIuIgpaksRMfTARDTXWkcRJcRQqMVYqCri+fAccwg2IGs NW2ZeaK1LQpEtY1SwtoPw40ocK2sWdX6DuQNOk2jnolrT1GlduBK9mhBE3Sa7zOFMuo1foFwVPZg+ iHEQ5ABzx/s4ldkNe3og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jh35B-0006AL-HF; Fri, 05 Jun 2020 03:31:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jh34m-0005jX-I1; Fri, 05 Jun 2020 03:31:28 +0000 X-UUID: 59927f6b1be94d76a788e74651131520-20200604 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=MHlq0MQzXxzGdzCp+WA3QekEd3SxtT46HLdvc3d72CY=; b=KiRUwyi8GFs77wQMyZGENwImTmg9YtwVdfVcEYU7rSFutzLPn0ERROX81yHQsZsidpYrsigZRxCVxR04wFlHc4WOfoNqtMOTZaVQ2z5Vqj+mRhLWTafdHbbt7M9YSaDLY3iHEgvd4Vq68biSU1vtCQ2ZbS/MwEeC9FkhyPrYAq4=; X-UUID: 59927f6b1be94d76a788e74651131520-20200604 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1200726263; Thu, 04 Jun 2020 19:31:14 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Jun 2020 20:21:15 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Jun 2020 11:21:11 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 5 Jun 2020 11:21:10 +0800 Message-ID: <1591327147.8804.561.camel@mhfsdcap03> Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver From: Dongchun Zhu To: Sakari Ailus Date: Fri, 5 Jun 2020 11:19:07 +0800 In-Reply-To: <20200604092616.GJ16711@paasikivi.fi.intel.com> References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <1591236845.8804.547.camel@mhfsdcap03> <20200604092616.GJ16711@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 28F51B7C61836675CD5E7C0BB31C57102791D8C41924DC04BA6D5AB6E2499ABA2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_203124_614473_DCA07B10 X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, drinkcat@chromium.org, andriy.shevchenko@linux.intel.com, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linus.walleij@linaro.org, shengnan.wang@mediatek.com, tfiga@chromium.org, bgolaszewski@baylibre.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, louis.kuo@mediatek.com, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, On Thu, 2020-06-04 at 12:26 +0300, Sakari Ailus wrote: > Hi Dongchun, > > On Thu, Jun 04, 2020 at 10:14:05AM +0800, Dongchun Zhu wrote: > > Hi Tomasz, Sakari, and sirs, > > > > Could anyone help to review this patch? > > > > On Sat, 2020-05-23 at 16:41 +0800, Dongchun Zhu wrote: > > > Add a V4L2 sub-device driver for OV02A10 image sensor. > > > > > > Signed-off-by: Dongchun Zhu > > > --- > > > MAINTAINERS | 1 + > > > drivers/media/i2c/Kconfig | 13 + > > > drivers/media/i2c/Makefile | 1 + > > > drivers/media/i2c/ov02a10.c | 1025 +++++++++++++++++++++++++++++++++++++++++++ > > > 4 files changed, 1040 insertions(+) > > > create mode 100644 drivers/media/i2c/ov02a10.c > > > > > > > [snip] > > > > > +static int ov02a10_probe(struct i2c_client *client) > > > +{ > > > + struct device *dev = &client->dev; > > > + struct ov02a10 *ov02a10; > > > + unsigned int rotation; > > > + unsigned int clock_lane_tx_speed; > > > + unsigned int i; > > > + int ret; > > > + > > > + ov02a10 = devm_kzalloc(dev, sizeof(*ov02a10), GFP_KERNEL); > > > + if (!ov02a10) > > > + return -ENOMEM; > > > + > > > + ret = ov02a10_check_hwcfg(dev, ov02a10); > > > + if (ret) { > > > + dev_err(dev, "failed to check HW configuration: %d", ret); > > > + return ret; > > > + } > > > + > > > + v4l2_i2c_subdev_init(&ov02a10->subdev, client, &ov02a10_subdev_ops); > > > + ov02a10->mipi_clock_tx_speed = OV02A10_MIPI_TX_SPEED_DEFAULT; > > > + ov02a10->fmt.code = MEDIA_BUS_FMT_SBGGR10_1X10; > > > + > > > + /* Optional indication of physical rotation of sensor */ > > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "rotation", &rotation); > > > + if (!ret && rotation == 180) { > > > + ov02a10->upside_down = true; > > > + ov02a10->fmt.code = MEDIA_BUS_FMT_SRGGB10_1X10; > > > + } > > > + > > > + /* Optional indication of mipi TX speed */ > > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "ovti,mipi-tx-speed", > > > + &clock_lane_tx_speed); > > > + > > > + if (!ret) > > > + ov02a10->mipi_clock_tx_speed = clock_lane_tx_speed; > > > + > > > + /* Get system clock (eclk) */ > > > + ov02a10->eclk = devm_clk_get(dev, "eclk"); > > > + if (IS_ERR(ov02a10->eclk)) { > > > + ret = PTR_ERR(ov02a10->eclk); > > > + dev_err(dev, "failed to get eclk %d\n", ret); > > > + return ret; > > > + } > > > + > > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", > > > + &ov02a10->eclk_freq); > > > + if (ret) { > > > + dev_err(dev, "failed to get eclk frequency\n"); > > > + return ret; > > > + } > > > + > > > + ret = clk_set_rate(ov02a10->eclk, ov02a10->eclk_freq); > > > + if (ret) { > > > + dev_err(dev, "failed to set eclk frequency (24MHz)\n"); > > > + return ret; > > > + } > > > + > > > + if (clk_get_rate(ov02a10->eclk) != OV02A10_ECLK_FREQ) { > > > + dev_warn(dev, "wrong eclk frequency %d Hz, expected: %d Hz\n", > > > + ov02a10->eclk_freq, OV02A10_ECLK_FREQ); > > > + return -EINVAL; > > > + } > > > + > > > + ov02a10->pd_gpio = devm_gpiod_get(dev, "powerdown", GPIOD_OUT_HIGH); > > > + if (IS_ERR(ov02a10->pd_gpio)) { > > > + ret = PTR_ERR(ov02a10->pd_gpio); > > > + dev_err(dev, "failed to get powerdown-gpios %d\n", ret); > > > + return ret; > > > + } > > > + > > > + ov02a10->n_rst_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); > > > + if (IS_ERR(ov02a10->n_rst_gpio)) { > > > + ret = PTR_ERR(ov02a10->n_rst_gpio); > > > + dev_err(dev, "failed to get reset-gpios %d\n", ret); > > > + return ret; > > > + } > > > + > > > + for (i = 0; i < ARRAY_SIZE(ov02a10_supply_names); i++) > > > + ov02a10->supplies[i].supply = ov02a10_supply_names[i]; > > > + > > > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ov02a10_supply_names), > > > + ov02a10->supplies); > > > + if (ret) { > > > + dev_err(dev, "failed to get regulators\n"); > > > + return ret; > > > + } > > > + > > > + mutex_init(&ov02a10->mutex); > > > + ov02a10->cur_mode = &supported_modes[0]; > > > + ret = ov02a10_initialize_controls(ov02a10); > > > + if (ret) { > > > + dev_err(dev, "failed to initialize controls\n"); > > > + goto err_destroy_mutex; > > > + } > > > + > > > + ov02a10->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > > > + ov02a10->subdev.entity.ops = &ov02a10_subdev_entity_ops; > > > + ov02a10->subdev.entity.function = MEDIA_ENT_F_CAM_SENSOR; > > > + ov02a10->pad.flags = MEDIA_PAD_FL_SOURCE; > > > + ret = media_entity_pads_init(&ov02a10->subdev.entity, 1, &ov02a10->pad); > > > + if (ret < 0) { > > > + dev_err(dev, "failed to init entity pads: %d", ret); > > > + goto err_free_handler; > > > + } > > > + > > > + pm_runtime_enable(dev); > > > + if (!pm_runtime_enabled(dev)) { > > > + ret = ov02a10_power_on(dev); > > > + if (ret < 0) { > > > + dev_err(dev, "failed to power on: %d\n", ret); > > > + goto err_free_handler; This is actually wrong, which should be replaced of "err_clean_entity". > > > + } > > > + } > > > + > > > + ret = v4l2_async_register_subdev(&ov02a10->subdev); > > > + if (ret) { > > > + dev_err(dev, "failed to register V4L2 subdev: %d", ret); > > > + if (!pm_runtime_enabled(dev)) > > > + ov02a10_power_off(dev); > > This should be moved to error handling section below. > Fine. It would be abstracted as "err_async_register" in next release. Something like: err_async_register: if (!pm_runtime_enabled(dev)) ov02a10_power_off(dev); err_clean_entity: media_entity_cleanup(&ov02a10->subdev.entity); ... > > > + goto err_clean_entity; > > > + } > > > > Tomasz, Sakari, is this ok? > > or coding like this: > > > > ret = v4l2_async_register_subdev(&ov02a10->subdev); > > if (!pm_runtime_enabled(dev)) > > ov02a10_power_off(dev); > > if (ret) { > > dev_err(dev, "failed to register V4L2 subdev: %d", ret); > > goto err_clean_entity; > > } > > > > What's your opinions about the change? > > This turns power off if runtime PM is disabled. I'd keep it as-is, as it'd > require re-implementing what runtime PM is used for now --- and that's not > a sensor driver's job. > > > > > > + > > > + return 0; > > > + > > > +err_clean_entity: > > > + media_entity_cleanup(&ov02a10->subdev.entity); > > > +err_free_handler: > > > + v4l2_ctrl_handler_free(ov02a10->subdev.ctrl_handler); > > > +err_destroy_mutex: > > > + mutex_destroy(&ov02a10->mutex); > > > + > > > + return ret; > > > +} > > > + > > > +static int ov02a10_remove(struct i2c_client *client) > > > +{ > > > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > + struct ov02a10 *ov02a10 = to_ov02a10(sd); > > > + > > > + v4l2_async_unregister_subdev(sd); > > > + media_entity_cleanup(&sd->entity); > > > + v4l2_ctrl_handler_free(sd->ctrl_handler); > > > + pm_runtime_disable(&client->dev); > > > + if (!pm_runtime_status_suspended(&client->dev)) > > > + ov02a10_power_off(&client->dev); > > > + pm_runtime_set_suspended(&client->dev); > > > + mutex_destroy(&ov02a10->mutex); > > > + > > > + return 0; > > > +} > > > + > > > +static const struct of_device_id ov02a10_of_match[] = { > > > + { .compatible = "ovti,ov02a10" }, > > > + {} > > > +}; > > > +MODULE_DEVICE_TABLE(of, ov02a10_of_match); > > > + > > > +static struct i2c_driver ov02a10_i2c_driver = { > > > + .driver = { > > > + .name = "ov02a10", > > > + .pm = &ov02a10_pm_ops, > > > + .of_match_table = ov02a10_of_match, > > > + }, > > > + .probe_new = &ov02a10_probe, > > > + .remove = &ov02a10_remove, > > > +}; > > > + > > > +module_i2c_driver(ov02a10_i2c_driver); > > > + > > > +MODULE_AUTHOR("Dongchun Zhu "); > > > +MODULE_DESCRIPTION("OmniVision OV02A10 sensor driver"); > > > +MODULE_LICENSE("GPL v2"); > > > + > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E87C433DF for ; Fri, 5 Jun 2020 03:21:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6F67207D3 for ; Fri, 5 Jun 2020 03:21:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="KiRUwyi8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725968AbgFEDVX (ORCPT ); Thu, 4 Jun 2020 23:21:23 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:36377 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725954AbgFEDVX (ORCPT ); Thu, 4 Jun 2020 23:21:23 -0400 X-UUID: 7bfb038ff2134b2a9a596b5a348f6574-20200605 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=MHlq0MQzXxzGdzCp+WA3QekEd3SxtT46HLdvc3d72CY=; b=KiRUwyi8GFs77wQMyZGENwImTmg9YtwVdfVcEYU7rSFutzLPn0ERROX81yHQsZsidpYrsigZRxCVxR04wFlHc4WOfoNqtMOTZaVQ2z5Vqj+mRhLWTafdHbbt7M9YSaDLY3iHEgvd4Vq68biSU1vtCQ2ZbS/MwEeC9FkhyPrYAq4=; X-UUID: 7bfb038ff2134b2a9a596b5a348f6574-20200605 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1340088784; Fri, 05 Jun 2020 11:21:12 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Jun 2020 11:21:11 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 5 Jun 2020 11:21:10 +0800 Message-ID: <1591327147.8804.561.camel@mhfsdcap03> Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver From: Dongchun Zhu To: Sakari Ailus CC: , , , , , , , , , , , , , , , , , Date: Fri, 5 Jun 2020 11:19:07 +0800 In-Reply-To: <20200604092616.GJ16711@paasikivi.fi.intel.com> References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <1591236845.8804.547.camel@mhfsdcap03> <20200604092616.GJ16711@paasikivi.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 28F51B7C61836675CD5E7C0BB31C57102791D8C41924DC04BA6D5AB6E2499ABA2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgU2FrYXJpLA0KDQpPbiBUaHUsIDIwMjAtMDYtMDQgYXQgMTI6MjYgKzAzMDAsIFNha2FyaSBB aWx1cyB3cm90ZToNCj4gSGkgRG9uZ2NodW4sDQo+IA0KPiBPbiBUaHUsIEp1biAwNCwgMjAyMCBh dCAxMDoxNDowNUFNICswODAwLCBEb25nY2h1biBaaHUgd3JvdGU6DQo+ID4gSGkgVG9tYXN6LCBT YWthcmksIGFuZCBzaXJzLA0KPiA+IA0KPiA+IENvdWxkIGFueW9uZSBoZWxwIHRvIHJldmlldyB0 aGlzIHBhdGNoPw0KPiA+IA0KPiA+IE9uIFNhdCwgMjAyMC0wNS0yMyBhdCAxNjo0MSArMDgwMCwg RG9uZ2NodW4gWmh1IHdyb3RlOg0KPiA+ID4gQWRkIGEgVjRMMiBzdWItZGV2aWNlIGRyaXZlciBm b3IgT1YwMkExMCBpbWFnZSBzZW5zb3IuDQo+ID4gPiANCj4gPiA+IFNpZ25lZC1vZmYtYnk6IERv bmdjaHVuIFpodSA8ZG9uZ2NodW4uemh1QG1lZGlhdGVrLmNvbT4NCj4gPiA+IC0tLQ0KPiA+ID4g IE1BSU5UQUlORVJTICAgICAgICAgICAgICAgICB8ICAgIDEgKw0KPiA+ID4gIGRyaXZlcnMvbWVk aWEvaTJjL0tjb25maWcgICB8ICAgMTMgKw0KPiA+ID4gIGRyaXZlcnMvbWVkaWEvaTJjL01ha2Vm aWxlICB8ICAgIDEgKw0KPiA+ID4gIGRyaXZlcnMvbWVkaWEvaTJjL292MDJhMTAuYyB8IDEwMjUg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPiA+ID4gIDQgZmls ZXMgY2hhbmdlZCwgMTA0MCBpbnNlcnRpb25zKCspDQo+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGRyaXZlcnMvbWVkaWEvaTJjL292MDJhMTAuYw0KPiA+ID4gDQo+ID4gDQo+ID4gW3NuaXBdDQo+ ID4gDQo+ID4gPiArc3RhdGljIGludCBvdjAyYTEwX3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpj bGllbnQpDQo+ID4gPiArew0KPiA+ID4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmY2xpZW50LT5k ZXY7DQo+ID4gPiArCXN0cnVjdCBvdjAyYTEwICpvdjAyYTEwOw0KPiA+ID4gKwl1bnNpZ25lZCBp bnQgcm90YXRpb247DQo+ID4gPiArCXVuc2lnbmVkIGludCBjbG9ja19sYW5lX3R4X3NwZWVkOw0K PiA+ID4gKwl1bnNpZ25lZCBpbnQgaTsNCj4gPiA+ICsJaW50IHJldDsNCj4gPiA+ICsNCj4gPiA+ ICsJb3YwMmExMCA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqb3YwMmExMCksIEdGUF9LRVJO RUwpOw0KPiA+ID4gKwlpZiAoIW92MDJhMTApDQo+ID4gPiArCQlyZXR1cm4gLUVOT01FTTsNCj4g PiA+ICsNCj4gPiA+ICsJcmV0ID0gb3YwMmExMF9jaGVja19od2NmZyhkZXYsIG92MDJhMTApOw0K PiA+ID4gKwlpZiAocmV0KSB7DQo+ID4gPiArCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBjaGVj ayBIVyBjb25maWd1cmF0aW9uOiAlZCIsIHJldCk7DQo+ID4gPiArCQlyZXR1cm4gcmV0Ow0KPiA+ ID4gKwl9DQo+ID4gPiArDQo+ID4gPiArCXY0bDJfaTJjX3N1YmRldl9pbml0KCZvdjAyYTEwLT5z dWJkZXYsIGNsaWVudCwgJm92MDJhMTBfc3ViZGV2X29wcyk7DQo+ID4gPiArCW92MDJhMTAtPm1p cGlfY2xvY2tfdHhfc3BlZWQgPSBPVjAyQTEwX01JUElfVFhfU1BFRURfREVGQVVMVDsNCj4gPiA+ ICsJb3YwMmExMC0+Zm10LmNvZGUgPSBNRURJQV9CVVNfRk1UX1NCR0dSMTBfMVgxMDsNCj4gPiA+ ICsNCj4gPiA+ICsJLyogT3B0aW9uYWwgaW5kaWNhdGlvbiBvZiBwaHlzaWNhbCByb3RhdGlvbiBv ZiBzZW5zb3IgKi8NCj4gPiA+ICsJcmV0ID0gZndub2RlX3Byb3BlcnR5X3JlYWRfdTMyKGRldl9m d25vZGUoZGV2KSwgInJvdGF0aW9uIiwgJnJvdGF0aW9uKTsNCj4gPiA+ICsJaWYgKCFyZXQgJiYg cm90YXRpb24gPT0gMTgwKSB7DQo+ID4gPiArCQlvdjAyYTEwLT51cHNpZGVfZG93biA9IHRydWU7 DQo+ID4gPiArCQlvdjAyYTEwLT5mbXQuY29kZSA9IE1FRElBX0JVU19GTVRfU1JHR0IxMF8xWDEw Ow0KPiA+ID4gKwl9DQo+ID4gPiArDQo+ID4gPiArCS8qIE9wdGlvbmFsIGluZGljYXRpb24gb2Yg bWlwaSBUWCBzcGVlZCAqLw0KPiA+ID4gKwlyZXQgPSBmd25vZGVfcHJvcGVydHlfcmVhZF91MzIo ZGV2X2Z3bm9kZShkZXYpLCAib3Z0aSxtaXBpLXR4LXNwZWVkIiwNCj4gPiA+ICsJCQkJICAgICAg ICZjbG9ja19sYW5lX3R4X3NwZWVkKTsNCj4gPiA+ICsNCj4gPiA+ICsJaWYgKCFyZXQpDQo+ID4g PiArCQlvdjAyYTEwLT5taXBpX2Nsb2NrX3R4X3NwZWVkID0gY2xvY2tfbGFuZV90eF9zcGVlZDsN Cj4gPiA+ICsNCj4gPiA+ICsJLyogR2V0IHN5c3RlbSBjbG9jayAoZWNsaykgKi8NCj4gPiA+ICsJ b3YwMmExMC0+ZWNsayA9IGRldm1fY2xrX2dldChkZXYsICJlY2xrIik7DQo+ID4gPiArCWlmIChJ U19FUlIob3YwMmExMC0+ZWNsaykpIHsNCj4gPiA+ICsJCXJldCA9IFBUUl9FUlIob3YwMmExMC0+ ZWNsayk7DQo+ID4gPiArCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgZWNsayAlZFxuIiwg cmV0KTsNCj4gPiA+ICsJCXJldHVybiByZXQ7DQo+ID4gPiArCX0NCj4gPiA+ICsNCj4gPiA+ICsJ cmV0ID0gZndub2RlX3Byb3BlcnR5X3JlYWRfdTMyKGRldl9md25vZGUoZGV2KSwgImNsb2NrLWZy ZXF1ZW5jeSIsDQo+ID4gPiArCQkJCSAgICAgICAmb3YwMmExMC0+ZWNsa19mcmVxKTsNCj4gPiA+ ICsJaWYgKHJldCkgew0KPiA+ID4gKwkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gZ2V0IGVjbGsg ZnJlcXVlbmN5XG4iKTsNCj4gPiA+ICsJCXJldHVybiByZXQ7DQo+ID4gPiArCX0NCj4gPiA+ICsN Cj4gPiA+ICsJcmV0ID0gY2xrX3NldF9yYXRlKG92MDJhMTAtPmVjbGssIG92MDJhMTAtPmVjbGtf ZnJlcSk7DQo+ID4gPiArCWlmIChyZXQpIHsNCj4gPiA+ICsJCWRldl9lcnIoZGV2LCAiZmFpbGVk IHRvIHNldCBlY2xrIGZyZXF1ZW5jeSAoMjRNSHopXG4iKTsNCj4gPiA+ICsJCXJldHVybiByZXQ7 DQo+ID4gPiArCX0NCj4gPiA+ICsNCj4gPiA+ICsJaWYgKGNsa19nZXRfcmF0ZShvdjAyYTEwLT5l Y2xrKSAhPSBPVjAyQTEwX0VDTEtfRlJFUSkgew0KPiA+ID4gKwkJZGV2X3dhcm4oZGV2LCAid3Jv bmcgZWNsayBmcmVxdWVuY3kgJWQgSHosIGV4cGVjdGVkOiAlZCBIelxuIiwNCj4gPiA+ICsJCQkg b3YwMmExMC0+ZWNsa19mcmVxLCBPVjAyQTEwX0VDTEtfRlJFUSk7DQo+ID4gPiArCQlyZXR1cm4g LUVJTlZBTDsNCj4gPiA+ICsJfQ0KPiA+ID4gKw0KPiA+ID4gKwlvdjAyYTEwLT5wZF9ncGlvID0g ZGV2bV9ncGlvZF9nZXQoZGV2LCAicG93ZXJkb3duIiwgR1BJT0RfT1VUX0hJR0gpOw0KPiA+ID4g KwlpZiAoSVNfRVJSKG92MDJhMTAtPnBkX2dwaW8pKSB7DQo+ID4gPiArCQlyZXQgPSBQVFJfRVJS KG92MDJhMTAtPnBkX2dwaW8pOw0KPiA+ID4gKwkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gZ2V0 IHBvd2VyZG93bi1ncGlvcyAlZFxuIiwgcmV0KTsNCj4gPiA+ICsJCXJldHVybiByZXQ7DQo+ID4g PiArCX0NCj4gPiA+ICsNCj4gPiA+ICsJb3YwMmExMC0+bl9yc3RfZ3BpbyA9IGRldm1fZ3Bpb2Rf Z2V0KGRldiwgInJlc2V0IiwgR1BJT0RfT1VUX0xPVyk7DQo+ID4gPiArCWlmIChJU19FUlIob3Yw MmExMC0+bl9yc3RfZ3BpbykpIHsNCj4gPiA+ICsJCXJldCA9IFBUUl9FUlIob3YwMmExMC0+bl9y c3RfZ3Bpbyk7DQo+ID4gPiArCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgcmVzZXQtZ3Bp b3MgJWRcbiIsIHJldCk7DQo+ID4gPiArCQlyZXR1cm4gcmV0Ow0KPiA+ID4gKwl9DQo+ID4gPiAr DQo+ID4gPiArCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKG92MDJhMTBfc3VwcGx5X25hbWVz KTsgaSsrKQ0KPiA+ID4gKwkJb3YwMmExMC0+c3VwcGxpZXNbaV0uc3VwcGx5ID0gb3YwMmExMF9z dXBwbHlfbmFtZXNbaV07DQo+ID4gPiArDQo+ID4gPiArCXJldCA9IGRldm1fcmVndWxhdG9yX2J1 bGtfZ2V0KGRldiwgQVJSQVlfU0laRShvdjAyYTEwX3N1cHBseV9uYW1lcyksDQo+ID4gPiArCQkJ CSAgICAgIG92MDJhMTAtPnN1cHBsaWVzKTsNCj4gPiA+ICsJaWYgKHJldCkgew0KPiA+ID4gKwkJ ZGV2X2VycihkZXYsICJmYWlsZWQgdG8gZ2V0IHJlZ3VsYXRvcnNcbiIpOw0KPiA+ID4gKwkJcmV0 dXJuIHJldDsNCj4gPiA+ICsJfQ0KPiA+ID4gKw0KPiA+ID4gKwltdXRleF9pbml0KCZvdjAyYTEw LT5tdXRleCk7DQo+ID4gPiArCW92MDJhMTAtPmN1cl9tb2RlID0gJnN1cHBvcnRlZF9tb2Rlc1sw XTsNCj4gPiA+ICsJcmV0ID0gb3YwMmExMF9pbml0aWFsaXplX2NvbnRyb2xzKG92MDJhMTApOw0K PiA+ID4gKwlpZiAocmV0KSB7DQo+ID4gPiArCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBpbml0 aWFsaXplIGNvbnRyb2xzXG4iKTsNCj4gPiA+ICsJCWdvdG8gZXJyX2Rlc3Ryb3lfbXV0ZXg7DQo+ ID4gPiArCX0NCj4gPiA+ICsNCj4gPiA+ICsJb3YwMmExMC0+c3ViZGV2LmZsYWdzIHw9IFY0TDJf U1VCREVWX0ZMX0hBU19ERVZOT0RFOw0KPiA+ID4gKwlvdjAyYTEwLT5zdWJkZXYuZW50aXR5Lm9w cyA9ICZvdjAyYTEwX3N1YmRldl9lbnRpdHlfb3BzOw0KPiA+ID4gKwlvdjAyYTEwLT5zdWJkZXYu ZW50aXR5LmZ1bmN0aW9uID0gTUVESUFfRU5UX0ZfQ0FNX1NFTlNPUjsNCj4gPiA+ICsJb3YwMmEx MC0+cGFkLmZsYWdzID0gTUVESUFfUEFEX0ZMX1NPVVJDRTsNCj4gPiA+ICsJcmV0ID0gbWVkaWFf ZW50aXR5X3BhZHNfaW5pdCgmb3YwMmExMC0+c3ViZGV2LmVudGl0eSwgMSwgJm92MDJhMTAtPnBh ZCk7DQo+ID4gPiArCWlmIChyZXQgPCAwKSB7DQo+ID4gPiArCQlkZXZfZXJyKGRldiwgImZhaWxl ZCB0byBpbml0IGVudGl0eSBwYWRzOiAlZCIsIHJldCk7DQo+ID4gPiArCQlnb3RvIGVycl9mcmVl X2hhbmRsZXI7DQo+ID4gPiArCX0NCj4gPiA+ICsNCj4gPiA+ICsJcG1fcnVudGltZV9lbmFibGUo ZGV2KTsNCj4gPiA+ICsJaWYgKCFwbV9ydW50aW1lX2VuYWJsZWQoZGV2KSkgew0KPiA+ID4gKwkJ cmV0ID0gb3YwMmExMF9wb3dlcl9vbihkZXYpOw0KPiA+ID4gKwkJaWYgKHJldCA8IDApIHsNCj4g PiA+ICsJCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBwb3dlciBvbjogJWRcbiIsIHJldCk7DQo+ ID4gPiArCQkJZ290byBlcnJfZnJlZV9oYW5kbGVyOw0KDQpUaGlzIGlzIGFjdHVhbGx5IHdyb25n LCB3aGljaCBzaG91bGQgYmUgcmVwbGFjZWQgb2YgImVycl9jbGVhbl9lbnRpdHkiLg0KDQo+ID4g PiArCQl9DQo+ID4gPiArCX0NCj4gPiA+ICsNCj4gPiA+ICsJcmV0ID0gdjRsMl9hc3luY19yZWdp c3Rlcl9zdWJkZXYoJm92MDJhMTAtPnN1YmRldik7DQo+ID4gPiArCWlmIChyZXQpIHsNCj4gPiA+ ICsJCWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIHJlZ2lzdGVyIFY0TDIgc3ViZGV2OiAlZCIsIHJl dCk7DQo+ID4gPiArCQlpZiAoIXBtX3J1bnRpbWVfZW5hYmxlZChkZXYpKQ0KPiA+ID4gKwkJCW92 MDJhMTBfcG93ZXJfb2ZmKGRldik7DQo+IA0KPiBUaGlzIHNob3VsZCBiZSBtb3ZlZCB0byBlcnJv ciBoYW5kbGluZyBzZWN0aW9uIGJlbG93Lg0KPiANCg0KRmluZS4NCkl0IHdvdWxkIGJlIGFic3Ry YWN0ZWQgYXMgImVycl9hc3luY19yZWdpc3RlciIgaW4gbmV4dCByZWxlYXNlLg0KU29tZXRoaW5n IGxpa2U6DQplcnJfYXN5bmNfcmVnaXN0ZXI6DQoJaWYgKCFwbV9ydW50aW1lX2VuYWJsZWQoZGV2 KSkNCgkJb3YwMmExMF9wb3dlcl9vZmYoZGV2KTsNCmVycl9jbGVhbl9lbnRpdHk6DQoJbWVkaWFf ZW50aXR5X2NsZWFudXAoJm92MDJhMTAtPnN1YmRldi5lbnRpdHkpOw0KLi4uDQoNCj4gPiA+ICsJ CWdvdG8gZXJyX2NsZWFuX2VudGl0eTsNCj4gPiA+ICsJfQ0KPiA+IA0KPiA+IFRvbWFzeiwgU2Fr YXJpLCBpcyB0aGlzIG9rPw0KPiA+IG9yIGNvZGluZyBsaWtlIHRoaXM6DQo+ID4gDQo+ID4gcmV0 ID0gdjRsMl9hc3luY19yZWdpc3Rlcl9zdWJkZXYoJm92MDJhMTAtPnN1YmRldik7DQo+ID4gaWYg KCFwbV9ydW50aW1lX2VuYWJsZWQoZGV2KSkNCj4gPiAJb3YwMmExMF9wb3dlcl9vZmYoZGV2KTsN Cj4gPiBpZiAocmV0KSB7DQo+ID4gCWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIHJlZ2lzdGVyIFY0 TDIgc3ViZGV2OiAlZCIsIHJldCk7DQo+ID4gCWdvdG8gZXJyX2NsZWFuX2VudGl0eTsNCj4gPiB9 DQo+ID4gDQo+ID4gV2hhdCdzIHlvdXIgb3BpbmlvbnMgYWJvdXQgdGhlIGNoYW5nZT8NCj4gDQo+ IFRoaXMgdHVybnMgcG93ZXIgb2ZmIGlmIHJ1bnRpbWUgUE0gaXMgZGlzYWJsZWQuIEknZCBrZWVw IGl0IGFzLWlzLCBhcyBpdCdkDQo+IHJlcXVpcmUgcmUtaW1wbGVtZW50aW5nIHdoYXQgcnVudGlt ZSBQTSBpcyB1c2VkIGZvciBub3cgLS0tIGFuZCB0aGF0J3Mgbm90DQo+IGEgc2Vuc29yIGRyaXZl cidzIGpvYi4NCj4gDQo+ID4gDQo+ID4gPiArDQo+ID4gPiArCXJldHVybiAwOw0KPiA+ID4gKw0K PiA+ID4gK2Vycl9jbGVhbl9lbnRpdHk6DQo+ID4gPiArCW1lZGlhX2VudGl0eV9jbGVhbnVwKCZv djAyYTEwLT5zdWJkZXYuZW50aXR5KTsNCj4gPiA+ICtlcnJfZnJlZV9oYW5kbGVyOg0KPiA+ID4g Kwl2NGwyX2N0cmxfaGFuZGxlcl9mcmVlKG92MDJhMTAtPnN1YmRldi5jdHJsX2hhbmRsZXIpOw0K PiA+ID4gK2Vycl9kZXN0cm95X211dGV4Og0KPiA+ID4gKwltdXRleF9kZXN0cm95KCZvdjAyYTEw LT5tdXRleCk7DQo+ID4gPiArDQo+ID4gPiArCXJldHVybiByZXQ7DQo+ID4gPiArfQ0KPiA+ID4g Kw0KPiA+ID4gK3N0YXRpYyBpbnQgb3YwMmExMF9yZW1vdmUoc3RydWN0IGkyY19jbGllbnQgKmNs aWVudCkNCj4gPiA+ICt7DQo+ID4gPiArCXN0cnVjdCB2NGwyX3N1YmRldiAqc2QgPSBpMmNfZ2V0 X2NsaWVudGRhdGEoY2xpZW50KTsNCj4gPiA+ICsJc3RydWN0IG92MDJhMTAgKm92MDJhMTAgPSB0 b19vdjAyYTEwKHNkKTsNCj4gPiA+ICsNCj4gPiA+ICsJdjRsMl9hc3luY191bnJlZ2lzdGVyX3N1 YmRldihzZCk7DQo+ID4gPiArCW1lZGlhX2VudGl0eV9jbGVhbnVwKCZzZC0+ZW50aXR5KTsNCj4g PiA+ICsJdjRsMl9jdHJsX2hhbmRsZXJfZnJlZShzZC0+Y3RybF9oYW5kbGVyKTsNCj4gPiA+ICsJ cG1fcnVudGltZV9kaXNhYmxlKCZjbGllbnQtPmRldik7DQo+ID4gPiArCWlmICghcG1fcnVudGlt ZV9zdGF0dXNfc3VzcGVuZGVkKCZjbGllbnQtPmRldikpDQo+ID4gPiArCQlvdjAyYTEwX3Bvd2Vy X29mZigmY2xpZW50LT5kZXYpOw0KPiA+ID4gKwlwbV9ydW50aW1lX3NldF9zdXNwZW5kZWQoJmNs aWVudC0+ZGV2KTsNCj4gPiA+ICsJbXV0ZXhfZGVzdHJveSgmb3YwMmExMC0+bXV0ZXgpOw0KPiA+ ID4gKw0KPiA+ID4gKwlyZXR1cm4gMDsNCj4gPiA+ICt9DQo+ID4gPiArDQo+ID4gPiArc3RhdGlj IGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgb3YwMmExMF9vZl9tYXRjaFtdID0gew0KPiA+ID4g Kwl7IC5jb21wYXRpYmxlID0gIm92dGksb3YwMmExMCIgfSwNCj4gPiA+ICsJe30NCj4gPiA+ICt9 Ow0KPiA+ID4gK01PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIG92MDJhMTBfb2ZfbWF0Y2gpOw0KPiA+ ID4gKw0KPiA+ID4gK3N0YXRpYyBzdHJ1Y3QgaTJjX2RyaXZlciBvdjAyYTEwX2kyY19kcml2ZXIg PSB7DQo+ID4gPiArCS5kcml2ZXIgPSB7DQo+ID4gPiArCQkubmFtZSA9ICJvdjAyYTEwIiwNCj4g PiA+ICsJCS5wbSA9ICZvdjAyYTEwX3BtX29wcywNCj4gPiA+ICsJCS5vZl9tYXRjaF90YWJsZSA9 IG92MDJhMTBfb2ZfbWF0Y2gsDQo+ID4gPiArCX0sDQo+ID4gPiArCS5wcm9iZV9uZXcJPSAmb3Yw MmExMF9wcm9iZSwNCj4gPiA+ICsJLnJlbW92ZQkJPSAmb3YwMmExMF9yZW1vdmUsDQo+ID4gPiAr fTsNCj4gPiA+ICsNCj4gPiA+ICttb2R1bGVfaTJjX2RyaXZlcihvdjAyYTEwX2kyY19kcml2ZXIp Ow0KPiA+ID4gKw0KPiA+ID4gK01PRFVMRV9BVVRIT1IoIkRvbmdjaHVuIFpodSA8ZG9uZ2NodW4u emh1QG1lZGlhdGVrLmNvbT4iKTsNCj4gPiA+ICtNT0RVTEVfREVTQ1JJUFRJT04oIk9tbmlWaXNp b24gT1YwMkExMCBzZW5zb3IgZHJpdmVyIik7DQo+ID4gPiArTU9EVUxFX0xJQ0VOU0UoIkdQTCB2 MiIpOw0KPiA+ID4gKw0KPiA+IA0KPiANCg0K