From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C70B7C433DF for ; Sat, 6 Jun 2020 06:36:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9877B2064C for ; Sat, 6 Jun 2020 06:36:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CKUAEkwm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="n0JtMNET" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9877B2064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yZm+M9HWZEYCzFUxdLGUXZKl0fWQSefSZdMzeqwANeo=; b=CKUAEkwmyk2b7S T7v3L8RHLnFpZJK3Tqjuj9y7xrh4Gh6T/UO8feAeKesw4kB18KMkhMs6l2DFXmu2jmZYh6MNkTmu1 tpUyw1MZCfXAHycY8wTXzssd8I/qBt0DeLva48v++kMgljQr1JhPj4vbVNxZzI36hALlBhXePGSkU CWI+ES1/IQFo/D1ZXyETs84adajqe8HMyQXmVueQjrY5fDx13QEgLMfY239H24nP6AZSsl84+jNJP f6PWMxTyTxqozTydtIVGA9vRUElPoJXljO+6jQWOE6JR8O/nMQVbemnMR+DOWu8rXPILSk641RT98 Jx65eCzT8VyQStiO8SZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhSRT-0001g6-Oi; Sat, 06 Jun 2020 06:36:31 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhSRQ-0001fW-8j; Sat, 06 Jun 2020 06:36:30 +0000 X-UUID: b47471d4add94e56be8d7ab0291f756d-20200605 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=8YaqCRtr6t04Pgcsa7rHWNWRrI7JnwIs3OrBZi9nFCA=; b=n0JtMNETz+ZFxQ/8o87sxPtmLwh5Z/g0mxBt92EmbVV87hyWFBiNWy6EKphePH7b/SlF65NEQ4JEmBU81Kfc+Cw49vuD0jeszGwY4MggTiiuZAo6zvu4xFEAtr9kJW8brTc3ttw8zavr0d1gyd1qtpboHWEa//xgxhfboZCn4fI=; X-UUID: b47471d4add94e56be8d7ab0291f756d-20200605 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2145508808; Fri, 05 Jun 2020 22:36:31 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Jun 2020 23:26:20 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 6 Jun 2020 14:26:18 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 6 Jun 2020 14:26:17 +0800 Message-ID: <1591424652.8804.603.camel@mhfsdcap03> Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver From: Dongchun Zhu To: Sakari Ailus Date: Sat, 6 Jun 2020 14:24:12 +0800 In-Reply-To: <20200605121459.GS16711@paasikivi.fi.intel.com> References: <20200605105412.18813-1-dongchun.zhu@mediatek.com> <20200605105412.18813-3-dongchun.zhu@mediatek.com> <20200605121459.GS16711@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 360CD1EF4D21478AF26A82D6FCE3FA9A3A1CFBDD2931EBABAF5492227401BB2F2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200605_233628_315196_051E8347 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, drinkcat@chromium.org, andriy.shevchenko@linux.intel.com, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linus.walleij@linaro.org, shengnan.wang@mediatek.com, tfiga@chromium.org, bgolaszewski@baylibre.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, louis.kuo@mediatek.com, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Sakari, Thanks for the timely review. On Fri, 2020-06-05 at 15:14 +0300, Sakari Ailus wrote: > Hi Dongchun, > > Thank you for the update. > > On Fri, Jun 05, 2020 at 06:54:12PM +0800, Dongchun Zhu wrote: > > Add a V4L2 sub-device driver for DW9768 voice coil motor, providing > > control to set the desired focus via IIC serial interface. > > > > Signed-off-by: Dongchun Zhu > > --- > > MAINTAINERS | 1 + > > drivers/media/i2c/Kconfig | 13 ++ > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/dw9768.c | 566 +++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 581 insertions(+) > > create mode 100644 drivers/media/i2c/dw9768.c > > [snip]... > > + > > +static int dw9768_probe(struct i2c_client *client) > > +{ > > + struct device *dev = &client->dev; > > + struct dw9768 *dw9768; > > + u32 aac_mode_select; > > + u32 aac_timing_select; > > + u32 clock_presc_select; > > + unsigned int i; > > + int ret; > > + > > + dw9768 = devm_kzalloc(dev, sizeof(*dw9768), GFP_KERNEL); > > + if (!dw9768) > > + return -ENOMEM; > > + > > + /* Initialize subdev */ > > + v4l2_i2c_subdev_init(&dw9768->sd, client, &dw9768_ops); > > + > > + dw9768->aac_mode = DW9768_AAC_MODE_DEFAULT; > > + dw9768->aac_timing = DW9768_AAC_TIME_DEFAULT; > > + dw9768->clock_presc = DW9768_CLOCK_PRE_SCALE_DEFAULT; > > + > > + /* Optional indication of AAC mode select */ > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "dongwoon,aac-mode", > > + &aac_mode_select); > > + > > + if (!ret) > > + dw9768->aac_mode = aac_mode_select; > > + > > + /* Optional indication of clock pre-scale select */ > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "dongwoon,clock-presc", > > + &clock_presc_select); > > + > > + if (!ret) > > + dw9768->clock_presc = clock_presc_select; > > + > > + /* Optional indication of AAC Timing */ > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "dongwoon,aac-timing", > > + &aac_timing_select); > > + > > + if (!ret) > > + dw9768->aac_timing = aac_timing_select; > > You can assign the defaults to the dw9768 struct and use the fwnode > property API to read the properties into the same fields. No return values > need to be checked. > Good idea :-) > > + > > + for (i = 0; i < ARRAY_SIZE(dw9768_supply_names); i++) > > + dw9768->supplies[i].supply = dw9768_supply_names[i]; > > + > > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(dw9768_supply_names), > > + dw9768->supplies); > > + if (ret) { > > + dev_err(dev, "failed to get regulators\n"); > > + return ret; > > + } > > + > > + /* Initialize controls */ > > + ret = dw9768_init_controls(dw9768); > > + if (ret) > > + goto err_free_handler; > > + > > + /* Initialize subdev */ > > + dw9768->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > > + dw9768->sd.internal_ops = &dw9768_int_ops; > > + > > + ret = media_entity_pads_init(&dw9768->sd.entity, 0, NULL); > > + if (ret < 0) > > + goto err_free_handler; > > + > > + dw9768->sd.entity.function = MEDIA_ENT_F_LENS; > > + > > + pm_runtime_enable(dev); > > + if (!pm_runtime_enabled(dev)) { > > + ret = dw9768_runtime_resume(dev); > > + if (ret < 0) { > > + dev_err(dev, "failed to power on: %d\n", ret); > > + goto err_clean_entity; > > + } > > + } > > + > > + ret = v4l2_async_register_subdev(&dw9768->sd); > > + if (ret < 0) { > > + dev_err(dev, "failed to register V4L2 subdev: %d", ret); > > + goto error_async_register; > > + } > > + > > + return 0; > > + > > +error_async_register: > > + if (!pm_runtime_enabled(dev)) > > + dw9768_runtime_suspend(dev); > > +err_clean_entity: > > + media_entity_cleanup(&dw9768->sd.entity); > > +err_free_handler: > > + v4l2_ctrl_handler_free(&dw9768->ctrls); > > + > > + return ret; > > +} > > + [snip]... _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7769DC433DF for ; Sat, 6 Jun 2020 06:36:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C89D2064C for ; Sat, 6 Jun 2020 06:36:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GWacLFdP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="n0JtMNET" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C89D2064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ddqfm1PaCZ02O0IRp+seaSC02uZsgTWyLLjfPTiHk84=; b=GWacLFdPb8ZCxB ILl6csiMlZGU3RWbm/pMIkGPLTrsjIeZGPATfn2yBfmerKajIAtJYYXlM++9zNZ6vJhN+c/qJSomh 3YpQ12l822TVx2808gDvmoz1XTJQZYMb5C1gxWkFz4M5MirULVJL6EpagKfeUzSd+wo/nk5dKiXly r2Kj/4RIiOghFZsfwK+AZ67JyWugj/Gf3m0WnT6CqBv9L0wRrQ/H2sXNAOQoWryu1tGKNEIwsrnxv LfG+bYH4Rf0ud/EmIplu/ei1JktNkByUEoqHNTzZKGjlWSYvfIwxsJK8LZxlleiFM8r48oZ0RGyiI bFZ7r4csvCGRCVDlMleg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhSRU-0001go-NG; Sat, 06 Jun 2020 06:36:32 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhSRQ-0001fW-8j; Sat, 06 Jun 2020 06:36:30 +0000 X-UUID: b47471d4add94e56be8d7ab0291f756d-20200605 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=8YaqCRtr6t04Pgcsa7rHWNWRrI7JnwIs3OrBZi9nFCA=; b=n0JtMNETz+ZFxQ/8o87sxPtmLwh5Z/g0mxBt92EmbVV87hyWFBiNWy6EKphePH7b/SlF65NEQ4JEmBU81Kfc+Cw49vuD0jeszGwY4MggTiiuZAo6zvu4xFEAtr9kJW8brTc3ttw8zavr0d1gyd1qtpboHWEa//xgxhfboZCn4fI=; X-UUID: b47471d4add94e56be8d7ab0291f756d-20200605 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2145508808; Fri, 05 Jun 2020 22:36:31 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Jun 2020 23:26:20 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 6 Jun 2020 14:26:18 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 6 Jun 2020 14:26:17 +0800 Message-ID: <1591424652.8804.603.camel@mhfsdcap03> Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver From: Dongchun Zhu To: Sakari Ailus Date: Sat, 6 Jun 2020 14:24:12 +0800 In-Reply-To: <20200605121459.GS16711@paasikivi.fi.intel.com> References: <20200605105412.18813-1-dongchun.zhu@mediatek.com> <20200605105412.18813-3-dongchun.zhu@mediatek.com> <20200605121459.GS16711@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 360CD1EF4D21478AF26A82D6FCE3FA9A3A1CFBDD2931EBABAF5492227401BB2F2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200605_233628_315196_051E8347 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, drinkcat@chromium.org, andriy.shevchenko@linux.intel.com, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linus.walleij@linaro.org, shengnan.wang@mediatek.com, tfiga@chromium.org, bgolaszewski@baylibre.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, louis.kuo@mediatek.com, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, Thanks for the timely review. On Fri, 2020-06-05 at 15:14 +0300, Sakari Ailus wrote: > Hi Dongchun, > > Thank you for the update. > > On Fri, Jun 05, 2020 at 06:54:12PM +0800, Dongchun Zhu wrote: > > Add a V4L2 sub-device driver for DW9768 voice coil motor, providing > > control to set the desired focus via IIC serial interface. > > > > Signed-off-by: Dongchun Zhu > > --- > > MAINTAINERS | 1 + > > drivers/media/i2c/Kconfig | 13 ++ > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/dw9768.c | 566 +++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 581 insertions(+) > > create mode 100644 drivers/media/i2c/dw9768.c > > [snip]... > > + > > +static int dw9768_probe(struct i2c_client *client) > > +{ > > + struct device *dev = &client->dev; > > + struct dw9768 *dw9768; > > + u32 aac_mode_select; > > + u32 aac_timing_select; > > + u32 clock_presc_select; > > + unsigned int i; > > + int ret; > > + > > + dw9768 = devm_kzalloc(dev, sizeof(*dw9768), GFP_KERNEL); > > + if (!dw9768) > > + return -ENOMEM; > > + > > + /* Initialize subdev */ > > + v4l2_i2c_subdev_init(&dw9768->sd, client, &dw9768_ops); > > + > > + dw9768->aac_mode = DW9768_AAC_MODE_DEFAULT; > > + dw9768->aac_timing = DW9768_AAC_TIME_DEFAULT; > > + dw9768->clock_presc = DW9768_CLOCK_PRE_SCALE_DEFAULT; > > + > > + /* Optional indication of AAC mode select */ > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "dongwoon,aac-mode", > > + &aac_mode_select); > > + > > + if (!ret) > > + dw9768->aac_mode = aac_mode_select; > > + > > + /* Optional indication of clock pre-scale select */ > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "dongwoon,clock-presc", > > + &clock_presc_select); > > + > > + if (!ret) > > + dw9768->clock_presc = clock_presc_select; > > + > > + /* Optional indication of AAC Timing */ > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "dongwoon,aac-timing", > > + &aac_timing_select); > > + > > + if (!ret) > > + dw9768->aac_timing = aac_timing_select; > > You can assign the defaults to the dw9768 struct and use the fwnode > property API to read the properties into the same fields. No return values > need to be checked. > Good idea :-) > > + > > + for (i = 0; i < ARRAY_SIZE(dw9768_supply_names); i++) > > + dw9768->supplies[i].supply = dw9768_supply_names[i]; > > + > > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(dw9768_supply_names), > > + dw9768->supplies); > > + if (ret) { > > + dev_err(dev, "failed to get regulators\n"); > > + return ret; > > + } > > + > > + /* Initialize controls */ > > + ret = dw9768_init_controls(dw9768); > > + if (ret) > > + goto err_free_handler; > > + > > + /* Initialize subdev */ > > + dw9768->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > > + dw9768->sd.internal_ops = &dw9768_int_ops; > > + > > + ret = media_entity_pads_init(&dw9768->sd.entity, 0, NULL); > > + if (ret < 0) > > + goto err_free_handler; > > + > > + dw9768->sd.entity.function = MEDIA_ENT_F_LENS; > > + > > + pm_runtime_enable(dev); > > + if (!pm_runtime_enabled(dev)) { > > + ret = dw9768_runtime_resume(dev); > > + if (ret < 0) { > > + dev_err(dev, "failed to power on: %d\n", ret); > > + goto err_clean_entity; > > + } > > + } > > + > > + ret = v4l2_async_register_subdev(&dw9768->sd); > > + if (ret < 0) { > > + dev_err(dev, "failed to register V4L2 subdev: %d", ret); > > + goto error_async_register; > > + } > > + > > + return 0; > > + > > +error_async_register: > > + if (!pm_runtime_enabled(dev)) > > + dw9768_runtime_suspend(dev); > > +err_clean_entity: > > + media_entity_cleanup(&dw9768->sd.entity); > > +err_free_handler: > > + v4l2_ctrl_handler_free(&dw9768->ctrls); > > + > > + return ret; > > +} > > + [snip]... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7329AC433DF for ; Sat, 6 Jun 2020 06:26:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49860206DC for ; Sat, 6 Jun 2020 06:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="n0JtMNET" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726323AbgFFG00 (ORCPT ); Sat, 6 Jun 2020 02:26:26 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:53793 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725765AbgFFG00 (ORCPT ); Sat, 6 Jun 2020 02:26:26 -0400 X-UUID: 57578fce974149e88b60b64395ef083d-20200606 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=8YaqCRtr6t04Pgcsa7rHWNWRrI7JnwIs3OrBZi9nFCA=; b=n0JtMNETz+ZFxQ/8o87sxPtmLwh5Z/g0mxBt92EmbVV87hyWFBiNWy6EKphePH7b/SlF65NEQ4JEmBU81Kfc+Cw49vuD0jeszGwY4MggTiiuZAo6zvu4xFEAtr9kJW8brTc3ttw8zavr0d1gyd1qtpboHWEa//xgxhfboZCn4fI=; X-UUID: 57578fce974149e88b60b64395ef083d-20200606 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1987694961; Sat, 06 Jun 2020 14:26:19 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 6 Jun 2020 14:26:18 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 6 Jun 2020 14:26:17 +0800 Message-ID: <1591424652.8804.603.camel@mhfsdcap03> Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver From: Dongchun Zhu To: Sakari Ailus CC: , , , , , , , , , , , , , , , , , Date: Sat, 6 Jun 2020 14:24:12 +0800 In-Reply-To: <20200605121459.GS16711@paasikivi.fi.intel.com> References: <20200605105412.18813-1-dongchun.zhu@mediatek.com> <20200605105412.18813-3-dongchun.zhu@mediatek.com> <20200605121459.GS16711@paasikivi.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 360CD1EF4D21478AF26A82D6FCE3FA9A3A1CFBDD2931EBABAF5492227401BB2F2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgU2FrYXJpLA0KDQpUaGFua3MgZm9yIHRoZSB0aW1lbHkgcmV2aWV3Lg0KDQpPbiBGcmksIDIw MjAtMDYtMDUgYXQgMTU6MTQgKzAzMDAsIFNha2FyaSBBaWx1cyB3cm90ZToNCj4gSGkgRG9uZ2No dW4sDQo+IA0KPiBUaGFuayB5b3UgZm9yIHRoZSB1cGRhdGUuDQo+IA0KPiBPbiBGcmksIEp1biAw NSwgMjAyMCBhdCAwNjo1NDoxMlBNICswODAwLCBEb25nY2h1biBaaHUgd3JvdGU6DQo+ID4gQWRk IGEgVjRMMiBzdWItZGV2aWNlIGRyaXZlciBmb3IgRFc5NzY4IHZvaWNlIGNvaWwgbW90b3IsIHBy b3ZpZGluZw0KPiA+IGNvbnRyb2wgdG8gc2V0IHRoZSBkZXNpcmVkIGZvY3VzIHZpYSBJSUMgc2Vy aWFsIGludGVyZmFjZS4NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBEb25nY2h1biBaaHUgPGRv bmdjaHVuLnpodUBtZWRpYXRlay5jb20+DQo+ID4gLS0tDQo+ID4gIE1BSU5UQUlORVJTICAgICAg ICAgICAgICAgIHwgICAxICsNCj4gPiAgZHJpdmVycy9tZWRpYS9pMmMvS2NvbmZpZyAgfCAgMTMg KysNCj4gPiAgZHJpdmVycy9tZWRpYS9pMmMvTWFrZWZpbGUgfCAgIDEgKw0KPiA+ICBkcml2ZXJz L21lZGlhL2kyYy9kdzk3NjguYyB8IDU2NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysNCj4gPiAgNCBmaWxlcyBjaGFuZ2VkLCA1ODEgaW5zZXJ0aW9ucygrKQ0K PiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tZWRpYS9pMmMvZHc5NzY4LmMNCj4gPiAN Cg0KW3NuaXBdLi4uDQoNCj4gPiArDQo+ID4gK3N0YXRpYyBpbnQgZHc5NzY4X3Byb2JlKHN0cnVj dCBpMmNfY2xpZW50ICpjbGllbnQpDQo+ID4gK3sNCj4gPiArCXN0cnVjdCBkZXZpY2UgKmRldiA9 ICZjbGllbnQtPmRldjsNCj4gPiArCXN0cnVjdCBkdzk3NjggKmR3OTc2ODsNCj4gPiArCXUzMiBh YWNfbW9kZV9zZWxlY3Q7DQo+ID4gKwl1MzIgYWFjX3RpbWluZ19zZWxlY3Q7DQo+ID4gKwl1MzIg Y2xvY2tfcHJlc2Nfc2VsZWN0Ow0KPiA+ICsJdW5zaWduZWQgaW50IGk7DQo+ID4gKwlpbnQgcmV0 Ow0KPiA+ICsNCj4gPiArCWR3OTc2OCA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqZHc5NzY4 KSwgR0ZQX0tFUk5FTCk7DQo+ID4gKwlpZiAoIWR3OTc2OCkNCj4gPiArCQlyZXR1cm4gLUVOT01F TTsNCj4gPiArDQo+ID4gKwkvKiBJbml0aWFsaXplIHN1YmRldiAqLw0KPiA+ICsJdjRsMl9pMmNf c3ViZGV2X2luaXQoJmR3OTc2OC0+c2QsIGNsaWVudCwgJmR3OTc2OF9vcHMpOw0KPiA+ICsNCj4g PiArCWR3OTc2OC0+YWFjX21vZGUgPSBEVzk3NjhfQUFDX01PREVfREVGQVVMVDsNCj4gPiArCWR3 OTc2OC0+YWFjX3RpbWluZyA9IERXOTc2OF9BQUNfVElNRV9ERUZBVUxUOw0KPiA+ICsJZHc5NzY4 LT5jbG9ja19wcmVzYyA9IERXOTc2OF9DTE9DS19QUkVfU0NBTEVfREVGQVVMVDsNCj4gPiArDQo+ ID4gKwkvKiBPcHRpb25hbCBpbmRpY2F0aW9uIG9mIEFBQyBtb2RlIHNlbGVjdCAqLw0KPiA+ICsJ cmV0ID0gZndub2RlX3Byb3BlcnR5X3JlYWRfdTMyKGRldl9md25vZGUoZGV2KSwgImRvbmd3b29u LGFhYy1tb2RlIiwNCj4gPiArCQkJCSAgICAgICAmYWFjX21vZGVfc2VsZWN0KTsNCj4gPiArDQo+ ID4gKwlpZiAoIXJldCkNCj4gPiArCQlkdzk3NjgtPmFhY19tb2RlID0gYWFjX21vZGVfc2VsZWN0 Ow0KPiA+ICsNCj4gPiArCS8qIE9wdGlvbmFsIGluZGljYXRpb24gb2YgY2xvY2sgcHJlLXNjYWxl IHNlbGVjdCAqLw0KPiA+ICsJcmV0ID0gZndub2RlX3Byb3BlcnR5X3JlYWRfdTMyKGRldl9md25v ZGUoZGV2KSwgImRvbmd3b29uLGNsb2NrLXByZXNjIiwNCj4gPiArCQkJCSAgICAgICAmY2xvY2tf cHJlc2Nfc2VsZWN0KTsNCj4gPiArDQo+ID4gKwlpZiAoIXJldCkNCj4gPiArCQlkdzk3NjgtPmNs b2NrX3ByZXNjID0gY2xvY2tfcHJlc2Nfc2VsZWN0Ow0KPiA+ICsNCj4gPiArCS8qIE9wdGlvbmFs IGluZGljYXRpb24gb2YgQUFDIFRpbWluZyAqLw0KPiA+ICsJcmV0ID0gZndub2RlX3Byb3BlcnR5 X3JlYWRfdTMyKGRldl9md25vZGUoZGV2KSwgImRvbmd3b29uLGFhYy10aW1pbmciLA0KPiA+ICsJ CQkJICAgICAgICZhYWNfdGltaW5nX3NlbGVjdCk7DQo+ID4gKw0KPiA+ICsJaWYgKCFyZXQpDQo+ ID4gKwkJZHc5NzY4LT5hYWNfdGltaW5nID0gYWFjX3RpbWluZ19zZWxlY3Q7DQo+IA0KPiBZb3Ug Y2FuIGFzc2lnbiB0aGUgZGVmYXVsdHMgdG8gdGhlIGR3OTc2OCBzdHJ1Y3QgYW5kIHVzZSB0aGUg Zndub2RlDQo+IHByb3BlcnR5IEFQSSB0byByZWFkIHRoZSBwcm9wZXJ0aWVzIGludG8gdGhlIHNh bWUgZmllbGRzLiBObyByZXR1cm4gdmFsdWVzDQo+IG5lZWQgdG8gYmUgY2hlY2tlZC4NCj4gDQoN Ckdvb2QgaWRlYSA6LSkNCg0KPiA+ICsNCj4gPiArCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpF KGR3OTc2OF9zdXBwbHlfbmFtZXMpOyBpKyspDQo+ID4gKwkJZHc5NzY4LT5zdXBwbGllc1tpXS5z dXBwbHkgPSBkdzk3Njhfc3VwcGx5X25hbWVzW2ldOw0KPiA+ICsNCj4gPiArCXJldCA9IGRldm1f cmVndWxhdG9yX2J1bGtfZ2V0KGRldiwgQVJSQVlfU0laRShkdzk3Njhfc3VwcGx5X25hbWVzKSwN Cj4gPiArCQkJCSAgICAgIGR3OTc2OC0+c3VwcGxpZXMpOw0KPiA+ICsJaWYgKHJldCkgew0KPiA+ ICsJCWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIGdldCByZWd1bGF0b3JzXG4iKTsNCj4gPiArCQly ZXR1cm4gcmV0Ow0KPiA+ICsJfQ0KPiA+ICsNCj4gPiArCS8qIEluaXRpYWxpemUgY29udHJvbHMg Ki8NCj4gPiArCXJldCA9IGR3OTc2OF9pbml0X2NvbnRyb2xzKGR3OTc2OCk7DQo+ID4gKwlpZiAo cmV0KQ0KPiA+ICsJCWdvdG8gZXJyX2ZyZWVfaGFuZGxlcjsNCj4gPiArDQo+ID4gKwkvKiBJbml0 aWFsaXplIHN1YmRldiAqLw0KPiA+ICsJZHc5NzY4LT5zZC5mbGFncyB8PSBWNEwyX1NVQkRFVl9G TF9IQVNfREVWTk9ERTsNCj4gPiArCWR3OTc2OC0+c2QuaW50ZXJuYWxfb3BzID0gJmR3OTc2OF9p bnRfb3BzOw0KPiA+ICsNCj4gPiArCXJldCA9IG1lZGlhX2VudGl0eV9wYWRzX2luaXQoJmR3OTc2 OC0+c2QuZW50aXR5LCAwLCBOVUxMKTsNCj4gPiArCWlmIChyZXQgPCAwKQ0KPiA+ICsJCWdvdG8g ZXJyX2ZyZWVfaGFuZGxlcjsNCj4gPiArDQo+ID4gKwlkdzk3NjgtPnNkLmVudGl0eS5mdW5jdGlv biA9IE1FRElBX0VOVF9GX0xFTlM7DQo+ID4gKw0KPiA+ICsJcG1fcnVudGltZV9lbmFibGUoZGV2 KTsNCj4gPiArCWlmICghcG1fcnVudGltZV9lbmFibGVkKGRldikpIHsNCj4gPiArCQlyZXQgPSBk dzk3NjhfcnVudGltZV9yZXN1bWUoZGV2KTsNCj4gPiArCQlpZiAocmV0IDwgMCkgew0KPiA+ICsJ CQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBwb3dlciBvbjogJWRcbiIsIHJldCk7DQo+ID4gKwkJ CWdvdG8gZXJyX2NsZWFuX2VudGl0eTsNCj4gPiArCQl9DQo+ID4gKwl9DQo+ID4gKw0KPiA+ICsJ cmV0ID0gdjRsMl9hc3luY19yZWdpc3Rlcl9zdWJkZXYoJmR3OTc2OC0+c2QpOw0KPiA+ICsJaWYg KHJldCA8IDApIHsNCj4gPiArCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byByZWdpc3RlciBWNEwy IHN1YmRldjogJWQiLCByZXQpOw0KPiA+ICsJCWdvdG8gZXJyb3JfYXN5bmNfcmVnaXN0ZXI7DQo+ ID4gKwl9DQo+ID4gKw0KPiA+ICsJcmV0dXJuIDA7DQo+ID4gKw0KPiA+ICtlcnJvcl9hc3luY19y ZWdpc3RlcjoNCj4gPiArCWlmICghcG1fcnVudGltZV9lbmFibGVkKGRldikpDQo+ID4gKwkJZHc5 NzY4X3J1bnRpbWVfc3VzcGVuZChkZXYpOw0KPiA+ICtlcnJfY2xlYW5fZW50aXR5Og0KPiA+ICsJ bWVkaWFfZW50aXR5X2NsZWFudXAoJmR3OTc2OC0+c2QuZW50aXR5KTsNCj4gPiArZXJyX2ZyZWVf aGFuZGxlcjoNCj4gPiArCXY0bDJfY3RybF9oYW5kbGVyX2ZyZWUoJmR3OTc2OC0+Y3RybHMpOw0K PiA+ICsNCj4gPiArCXJldHVybiByZXQ7DQo+ID4gK30NCj4gPiArDQoNCltzbmlwXS4uLg0KDQo=