From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9994C433E0 for ; Tue, 9 Jun 2020 03:48:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B80BC20775 for ; Tue, 9 Jun 2020 03:48:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TNDHTugQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="OMW37jJJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B80BC20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wPff6xvaPKv6csW38JKnap3QnMD4gmrET65ZKWddRGg=; b=TNDHTugQlyRrA5 pQz4Lpp1SfSnga9HsXtiW2Io3PJX1yYT8+/Fhdqqd7kZ7vqoLzdP3JL7yEspTSD5G2Hky9vU/LS+F o9RFvkXmIFWJn3t0HvNf8dXDU6bEZTFM0zHHJr3npwcNDm6TUw+SaOxQOowyZGjUWZ4hSwKHxUXa7 vIT/TZ0K3rHcUXQ78gfk72d0BZJ7Hy/L0ZiSbACLm4/xzo8k/YsdidrF7lMsAarhf5lVDJt+liKkH VlfG8pVrRWR59bbQgZ7Tuvh3peLVjQurswXfa4SuBnb8mQDIE4YAyi6zNaummx8c6wPzYmpKkeJn+ lrNLJ765t9cac+88qp2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiVFG-0007r3-KR; Tue, 09 Jun 2020 03:48:14 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiVFD-0007qP-6F; Tue, 09 Jun 2020 03:48:13 +0000 X-UUID: 11186d23897f4382addd68684bb287fa-20200608 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=40bvsHbdvRwM9Lgi+QQEZZMxTMobgTcPYCKNo+R6gBM=; b=OMW37jJJKadCQAdW+GKVWwY3XoA5m1aWfD9XDMSCmM0zMGrWkvWXD6BJn/G2NT/cKnCGLP+U7DMBHoYC86Gx0iSkMs06roOgoApOOrfIDXvoS41DxA5kMlUVuMgZ0ip6xnwnw+LyuaToGyFWMby8CWkSUZlJnR2Pvf0Sogcq+PU=; X-UUID: 11186d23897f4382addd68684bb287fa-20200608 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1597433306; Mon, 08 Jun 2020 19:48:04 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Jun 2020 20:48:01 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 9 Jun 2020 11:47:54 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 9 Jun 2020 11:47:52 +0800 Message-ID: <1591674341.8804.628.camel@mhfsdcap03> Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver From: Dongchun Zhu To: Andy Shevchenko Date: Tue, 9 Jun 2020 11:45:41 +0800 In-Reply-To: <20200608132720.GS2428291@smile.fi.intel.com> References: <20200605105412.18813-1-dongchun.zhu@mediatek.com> <20200605105412.18813-3-dongchun.zhu@mediatek.com> <20200605124643.GG2428291@smile.fi.intel.com> <1591424358.8804.599.camel@mhfsdcap03> <20200608132720.GS2428291@smile.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 831D5E9863D577205AEB68EF6132BEFD4D39F2DA95B875E27B49D7640377CC602000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200608_204811_236930_0AC675F7 X-CRM114-Status: GOOD ( 25.81 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, drinkcat@chromium.org, louis.kuo@mediatek.com, srv_heupstream@mediatek.com, linus.walleij@linaro.org, shengnan.wang@mediatek.com, tfiga@chromium.org, bgolaszewski@baylibre.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, sakari.ailus@linux.intel.com, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Andy, On Mon, 2020-06-08 at 16:27 +0300, Andy Shevchenko wrote: > On Sat, Jun 06, 2020 at 02:19:18PM +0800, Dongchun Zhu wrote: > > On Fri, 2020-06-05 at 15:46 +0300, Andy Shevchenko wrote: > > > On Fri, Jun 05, 2020 at 06:54:12PM +0800, Dongchun Zhu wrote: > > ... > > > > > + depends on I2C && VIDEO_V4L2 > > > > > > No compile test? > > > > > > > Sorry? > > Kconfig here is based on the current media tree master branch. > > It is also what the other similar drivers from Dongwoon do. > > COMPILE_TEST. > I dunno if it's established or not practice in media subsystem. > > ... > > > > > +/* > > > > + * DW9768 requires waiting time (delay time) of t_OPR after power-up, > > > > + * or in the case of PD reset taking place. > > > > + */ > > > > +#define DW9768_T_OPR_US 1000 > > > > +#define DW9768_Tvib_MS_BASE10 (64 - 1) > > > > +#define DW9768_AAC_MODE_DEFAULT 2 > > > > > > > +#define DW9768_AAC_TIME_DEFAULT 0x20 > > > > > > Hex? Why not decimal? > > > > > > > There is one optional property 'dongwoon,aac-timing' defined in DT. > > I don't know whether you have noticed that. > > > > 'DW9768_AAC_TIME_DEFAULT' is the value set to AACT[5:0] register. > > I thought the Hex unit should be proper as it is directly written to the > > Hex register. > > I see. I would rather put it like (BIT(6) / 2) to show explicitly that we > choose half of the resolution. > I knew your idea. '(BIT(6) / 2)' may somewhat show the meaning of 'median of the total range of AACT[5:0]'. But this value is still very obscure relative to '0x20'. As I thought that simple is the best, especially for kernel upstream patch. > ... > > > > > + val = ((unsigned char)ret & ~mask) | (val & mask); > > > > > > This cast is weird. > > > > > > > Thanks for the review, but this cast is using classical pattern from > > your suggestion on OV02A10 v5: > > https://patchwork.linuxtv.org/patch/59788/ > > > > So I wonder whether it is still required to be refined currently. > > Or what would it be supposed to do for the cast? > > Okay, does it produce a warning w/o cast? > If yes, replace it at least to be the same type as mask and val. > No. > ... > > > > > + for ( ; val >= 0; val -= DW9768_MOVE_STEPS) { > > > > + ret = dw9768_set_dac(dw9768, val); > > > > + if (ret) { > > > > + dev_err(&client->dev, "I2C write fail: %d", ret); > > > > + return ret; > > > > + } > > > > + usleep_range(move_delay_us, move_delay_us + 1000); > > > > + } > > > > > > > > > It will look more naturally in the multiplier kind of value. > > > > > > unsigned int steps = DIV_ROUND_UP(...); > > > > > > while (steps--) { > > > ...(..., steps * ..._MOVE_STEPS); > > > ... > > > } > > > > > > but double check arithmetics. > > > > The current coding style is actually updated with reference to your > > previous comments on DW9768 v3: > > https://patchwork.linuxtv.org/patch/61856/ > > I understand, but can you consider to go further and see if the proposal works? > In fact, your suggestion is something like one another method to set DAC value to actuator. It is like there may be several solutions to a question. Yes. I just tried the new method and it works as expected. u32 steps = DIV_ROUND_UP(dw9768->focus->val, DW9768_MOVE_STEPS); while (steps--) { ret = dw9768_set_dac(dw9768, steps * DW9768_MOVE_STEPS); if (ret) return ret; usleep_range(move_delay_us, move_delay_us + 1000); } But from my perspective, I may prefer to the original method. As here what we really care is the DAC value, 'dw9768_set_dac(dw9768, val)' seems more simple. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18DA1C433E0 for ; Tue, 9 Jun 2020 03:48:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4ADC20775 for ; Tue, 9 Jun 2020 03:48:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B7iqLocx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="OMW37jJJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4ADC20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xWPziyIiYNly9LVsUlyL4MA9P22ubLqNzLfxWN5Qqs4=; b=B7iqLocxOvR+bo +OEoysiWOGWMvbrXulBeQDRN3UED2SKt8WSzxa51PQKKXgWzyFbCzuWzJj6DSWSFlzsBFFXizJg6n 5u+r8Pm0uSEd9JyuucG6OvZ/SWv7Pc7KZJPULRWJZg83jiLAj1xRWwUBGRcRZAHj+DgoEa7D0DSPb 7Gd0S30RkD0r31W3/8K5Rb68gtbOu3KeTDEHxuRoUcIJGHfg6yfvjX5OVjZQVe/jH3HtwY0tJlAlv PRRkFmwPKIiX9afc3l7LybdSDIcWXh1W9pM1MlCFVcEbUDsc8CXrSmTrro6tHDX1NUBaVeTRZygY3 Smf/AW16zUB6lcsRGRiw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiVFH-0007rf-FY; Tue, 09 Jun 2020 03:48:15 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiVFD-0007qP-6F; Tue, 09 Jun 2020 03:48:13 +0000 X-UUID: 11186d23897f4382addd68684bb287fa-20200608 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=40bvsHbdvRwM9Lgi+QQEZZMxTMobgTcPYCKNo+R6gBM=; b=OMW37jJJKadCQAdW+GKVWwY3XoA5m1aWfD9XDMSCmM0zMGrWkvWXD6BJn/G2NT/cKnCGLP+U7DMBHoYC86Gx0iSkMs06roOgoApOOrfIDXvoS41DxA5kMlUVuMgZ0ip6xnwnw+LyuaToGyFWMby8CWkSUZlJnR2Pvf0Sogcq+PU=; X-UUID: 11186d23897f4382addd68684bb287fa-20200608 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1597433306; Mon, 08 Jun 2020 19:48:04 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Jun 2020 20:48:01 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 9 Jun 2020 11:47:54 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 9 Jun 2020 11:47:52 +0800 Message-ID: <1591674341.8804.628.camel@mhfsdcap03> Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver From: Dongchun Zhu To: Andy Shevchenko Date: Tue, 9 Jun 2020 11:45:41 +0800 In-Reply-To: <20200608132720.GS2428291@smile.fi.intel.com> References: <20200605105412.18813-1-dongchun.zhu@mediatek.com> <20200605105412.18813-3-dongchun.zhu@mediatek.com> <20200605124643.GG2428291@smile.fi.intel.com> <1591424358.8804.599.camel@mhfsdcap03> <20200608132720.GS2428291@smile.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 831D5E9863D577205AEB68EF6132BEFD4D39F2DA95B875E27B49D7640377CC602000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200608_204811_236930_0AC675F7 X-CRM114-Status: GOOD ( 25.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, drinkcat@chromium.org, louis.kuo@mediatek.com, srv_heupstream@mediatek.com, linus.walleij@linaro.org, shengnan.wang@mediatek.com, tfiga@chromium.org, bgolaszewski@baylibre.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, sakari.ailus@linux.intel.com, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Mon, 2020-06-08 at 16:27 +0300, Andy Shevchenko wrote: > On Sat, Jun 06, 2020 at 02:19:18PM +0800, Dongchun Zhu wrote: > > On Fri, 2020-06-05 at 15:46 +0300, Andy Shevchenko wrote: > > > On Fri, Jun 05, 2020 at 06:54:12PM +0800, Dongchun Zhu wrote: > > ... > > > > > + depends on I2C && VIDEO_V4L2 > > > > > > No compile test? > > > > > > > Sorry? > > Kconfig here is based on the current media tree master branch. > > It is also what the other similar drivers from Dongwoon do. > > COMPILE_TEST. > I dunno if it's established or not practice in media subsystem. > > ... > > > > > +/* > > > > + * DW9768 requires waiting time (delay time) of t_OPR after power-up, > > > > + * or in the case of PD reset taking place. > > > > + */ > > > > +#define DW9768_T_OPR_US 1000 > > > > +#define DW9768_Tvib_MS_BASE10 (64 - 1) > > > > +#define DW9768_AAC_MODE_DEFAULT 2 > > > > > > > +#define DW9768_AAC_TIME_DEFAULT 0x20 > > > > > > Hex? Why not decimal? > > > > > > > There is one optional property 'dongwoon,aac-timing' defined in DT. > > I don't know whether you have noticed that. > > > > 'DW9768_AAC_TIME_DEFAULT' is the value set to AACT[5:0] register. > > I thought the Hex unit should be proper as it is directly written to the > > Hex register. > > I see. I would rather put it like (BIT(6) / 2) to show explicitly that we > choose half of the resolution. > I knew your idea. '(BIT(6) / 2)' may somewhat show the meaning of 'median of the total range of AACT[5:0]'. But this value is still very obscure relative to '0x20'. As I thought that simple is the best, especially for kernel upstream patch. > ... > > > > > + val = ((unsigned char)ret & ~mask) | (val & mask); > > > > > > This cast is weird. > > > > > > > Thanks for the review, but this cast is using classical pattern from > > your suggestion on OV02A10 v5: > > https://patchwork.linuxtv.org/patch/59788/ > > > > So I wonder whether it is still required to be refined currently. > > Or what would it be supposed to do for the cast? > > Okay, does it produce a warning w/o cast? > If yes, replace it at least to be the same type as mask and val. > No. > ... > > > > > + for ( ; val >= 0; val -= DW9768_MOVE_STEPS) { > > > > + ret = dw9768_set_dac(dw9768, val); > > > > + if (ret) { > > > > + dev_err(&client->dev, "I2C write fail: %d", ret); > > > > + return ret; > > > > + } > > > > + usleep_range(move_delay_us, move_delay_us + 1000); > > > > + } > > > > > > > > > It will look more naturally in the multiplier kind of value. > > > > > > unsigned int steps = DIV_ROUND_UP(...); > > > > > > while (steps--) { > > > ...(..., steps * ..._MOVE_STEPS); > > > ... > > > } > > > > > > but double check arithmetics. > > > > The current coding style is actually updated with reference to your > > previous comments on DW9768 v3: > > https://patchwork.linuxtv.org/patch/61856/ > > I understand, but can you consider to go further and see if the proposal works? > In fact, your suggestion is something like one another method to set DAC value to actuator. It is like there may be several solutions to a question. Yes. I just tried the new method and it works as expected. u32 steps = DIV_ROUND_UP(dw9768->focus->val, DW9768_MOVE_STEPS); while (steps--) { ret = dw9768_set_dac(dw9768, steps * DW9768_MOVE_STEPS); if (ret) return ret; usleep_range(move_delay_us, move_delay_us + 1000); } But from my perspective, I may prefer to the original method. As here what we really care is the DAC value, 'dw9768_set_dac(dw9768, val)' seems more simple. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78981C433DF for ; Tue, 9 Jun 2020 03:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F4F920775 for ; Tue, 9 Jun 2020 03:48:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="OMW37jJJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727093AbgFIDsI (ORCPT ); Mon, 8 Jun 2020 23:48:08 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:44086 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727088AbgFIDsH (ORCPT ); Mon, 8 Jun 2020 23:48:07 -0400 X-UUID: e43f4377fad742a1a8c541d0b5730a20-20200609 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=40bvsHbdvRwM9Lgi+QQEZZMxTMobgTcPYCKNo+R6gBM=; b=OMW37jJJKadCQAdW+GKVWwY3XoA5m1aWfD9XDMSCmM0zMGrWkvWXD6BJn/G2NT/cKnCGLP+U7DMBHoYC86Gx0iSkMs06roOgoApOOrfIDXvoS41DxA5kMlUVuMgZ0ip6xnwnw+LyuaToGyFWMby8CWkSUZlJnR2Pvf0Sogcq+PU=; X-UUID: e43f4377fad742a1a8c541d0b5730a20-20200609 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 988240142; Tue, 09 Jun 2020 11:47:59 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 9 Jun 2020 11:47:54 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 9 Jun 2020 11:47:52 +0800 Message-ID: <1591674341.8804.628.camel@mhfsdcap03> Subject: Re: [V7, 2/2] media: i2c: dw9768: Add DW9768 VCM driver From: Dongchun Zhu To: Andy Shevchenko CC: , , , , , , , , , , , , , , , , , Date: Tue, 9 Jun 2020 11:45:41 +0800 In-Reply-To: <20200608132720.GS2428291@smile.fi.intel.com> References: <20200605105412.18813-1-dongchun.zhu@mediatek.com> <20200605105412.18813-3-dongchun.zhu@mediatek.com> <20200605124643.GG2428291@smile.fi.intel.com> <1591424358.8804.599.camel@mhfsdcap03> <20200608132720.GS2428291@smile.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 831D5E9863D577205AEB68EF6132BEFD4D39F2DA95B875E27B49D7640377CC602000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgQW5keSwNCg0KT24gTW9uLCAyMDIwLTA2LTA4IGF0IDE2OjI3ICswMzAwLCBBbmR5IFNoZXZj aGVua28gd3JvdGU6DQo+IE9uIFNhdCwgSnVuIDA2LCAyMDIwIGF0IDAyOjE5OjE4UE0gKzA4MDAs IERvbmdjaHVuIFpodSB3cm90ZToNCj4gPiBPbiBGcmksIDIwMjAtMDYtMDUgYXQgMTU6NDYgKzAz MDAsIEFuZHkgU2hldmNoZW5rbyB3cm90ZToNCj4gPiA+IE9uIEZyaSwgSnVuIDA1LCAyMDIwIGF0 IDA2OjU0OjEyUE0gKzA4MDAsIERvbmdjaHVuIFpodSB3cm90ZToNCj4gDQo+IC4uLg0KPiANCj4g PiA+ID4gKwlkZXBlbmRzIG9uIEkyQyAmJiBWSURFT19WNEwyDQo+ID4gPiANCj4gPiA+IE5vIGNv bXBpbGUgdGVzdD8NCj4gPiA+IA0KPiA+IA0KPiA+IFNvcnJ5Pw0KPiA+IEtjb25maWcgaGVyZSBp cyBiYXNlZCBvbiB0aGUgY3VycmVudCBtZWRpYSB0cmVlIG1hc3RlciBicmFuY2guDQo+ID4gSXQg aXMgYWxzbyB3aGF0IHRoZSBvdGhlciBzaW1pbGFyIGRyaXZlcnMgZnJvbSBEb25nd29vbiBkby4g DQo+IA0KPiBDT01QSUxFX1RFU1QuDQo+IEkgZHVubm8gaWYgaXQncyBlc3RhYmxpc2hlZCBvciBu b3QgcHJhY3RpY2UgaW4gbWVkaWEgc3Vic3lzdGVtLg0KPiANCj4gLi4uDQo+IA0KPiA+ID4gPiAr LyoNCj4gPiA+ID4gKyAqIERXOTc2OCByZXF1aXJlcyB3YWl0aW5nIHRpbWUgKGRlbGF5IHRpbWUp IG9mIHRfT1BSIGFmdGVyIHBvd2VyLXVwLA0KPiA+ID4gPiArICogb3IgaW4gdGhlIGNhc2Ugb2Yg UEQgcmVzZXQgdGFraW5nIHBsYWNlLg0KPiA+ID4gPiArICovDQo+ID4gPiA+ICsjZGVmaW5lIERX OTc2OF9UX09QUl9VUwkJCQkxMDAwDQo+ID4gPiA+ICsjZGVmaW5lIERXOTc2OF9UdmliX01TX0JB U0UxMAkJCSg2NCAtIDEpDQo+ID4gPiA+ICsjZGVmaW5lIERXOTc2OF9BQUNfTU9ERV9ERUZBVUxU CQkJMg0KPiA+ID4gDQo+ID4gPiA+ICsjZGVmaW5lIERXOTc2OF9BQUNfVElNRV9ERUZBVUxUCQkJ MHgyMA0KPiA+ID4gDQo+ID4gPiBIZXg/IFdoeSBub3QgZGVjaW1hbD8NCj4gPiA+IA0KPiA+IA0K PiA+IFRoZXJlIGlzIG9uZSBvcHRpb25hbCBwcm9wZXJ0eSAnZG9uZ3dvb24sYWFjLXRpbWluZycg ZGVmaW5lZCBpbiBEVC4NCj4gPiBJIGRvbid0IGtub3cgd2hldGhlciB5b3UgaGF2ZSBub3RpY2Vk IHRoYXQuDQo+ID4gDQo+ID4gJ0RXOTc2OF9BQUNfVElNRV9ERUZBVUxUJyBpcyB0aGUgdmFsdWUg c2V0IHRvIEFBQ1RbNTowXSByZWdpc3Rlci4NCj4gPiBJIHRob3VnaHQgdGhlIEhleCB1bml0IHNo b3VsZCBiZSBwcm9wZXIgYXMgaXQgaXMgZGlyZWN0bHkgd3JpdHRlbiB0byB0aGUNCj4gPiBIZXgg cmVnaXN0ZXIuDQo+IA0KPiBJIHNlZS4gSSB3b3VsZCByYXRoZXIgcHV0IGl0IGxpa2UgKEJJVCg2 KSAvIDIpIHRvIHNob3cgZXhwbGljaXRseSB0aGF0IHdlDQo+IGNob29zZSBoYWxmIG9mIHRoZSBy ZXNvbHV0aW9uLg0KPiANCg0KSSBrbmV3IHlvdXIgaWRlYS4NCicoQklUKDYpIC8gMiknIG1heSBz b21ld2hhdCBzaG93IHRoZSBtZWFuaW5nIG9mICdtZWRpYW4gb2YgdGhlIHRvdGFsDQpyYW5nZSBv ZiBBQUNUWzU6MF0nLg0KDQpCdXQgdGhpcyB2YWx1ZSBpcyBzdGlsbCB2ZXJ5IG9ic2N1cmUgcmVs YXRpdmUgdG8gJzB4MjAnLg0KQXMgSSB0aG91Z2h0IHRoYXQgc2ltcGxlIGlzIHRoZSBiZXN0LCBl c3BlY2lhbGx5IGZvciBrZXJuZWwgdXBzdHJlYW0NCnBhdGNoLg0KDQo+IC4uLg0KPiANCj4gPiA+ ID4gKwl2YWwgPSAoKHVuc2lnbmVkIGNoYXIpcmV0ICYgfm1hc2spIHwgKHZhbCAmIG1hc2spOw0K PiA+ID4gDQo+ID4gPiBUaGlzIGNhc3QgaXMgd2VpcmQuDQo+ID4gPiANCj4gPiANCj4gPiBUaGFu a3MgZm9yIHRoZSByZXZpZXcsIGJ1dCB0aGlzIGNhc3QgaXMgdXNpbmcgY2xhc3NpY2FsIHBhdHRl cm4gZnJvbQ0KPiA+IHlvdXIgc3VnZ2VzdGlvbiBvbiBPVjAyQTEwIHY1Og0KPiA+IGh0dHBzOi8v cGF0Y2h3b3JrLmxpbnV4dHYub3JnL3BhdGNoLzU5Nzg4Lw0KPiA+IA0KPiA+IFNvIEkgd29uZGVy IHdoZXRoZXIgaXQgaXMgc3RpbGwgcmVxdWlyZWQgdG8gYmUgcmVmaW5lZCBjdXJyZW50bHkuDQo+ ID4gT3Igd2hhdCB3b3VsZCBpdCBiZSBzdXBwb3NlZCB0byBkbyBmb3IgdGhlIGNhc3Q/DQo+IA0K PiBPa2F5LCBkb2VzIGl0IHByb2R1Y2UgYSB3YXJuaW5nIHcvbyBjYXN0Pw0KPiBJZiB5ZXMsIHJl cGxhY2UgaXQgYXQgbGVhc3QgdG8gYmUgdGhlIHNhbWUgdHlwZSBhcyBtYXNrIGFuZCB2YWwuDQo+ IA0KDQpOby4NCg0KPiAuLi4NCj4gDQo+ID4gPiA+ICsJZm9yICggOyB2YWwgPj0gMDsgdmFsIC09 IERXOTc2OF9NT1ZFX1NURVBTKSB7DQo+ID4gPiA+ICsJCXJldCA9IGR3OTc2OF9zZXRfZGFjKGR3 OTc2OCwgdmFsKTsNCj4gPiA+ID4gKwkJaWYgKHJldCkgew0KPiA+ID4gPiArCQkJZGV2X2Vycigm Y2xpZW50LT5kZXYsICJJMkMgd3JpdGUgZmFpbDogJWQiLCByZXQpOw0KPiA+ID4gPiArCQkJcmV0 dXJuIHJldDsNCj4gPiA+ID4gKwkJfQ0KPiA+ID4gPiArCQl1c2xlZXBfcmFuZ2UobW92ZV9kZWxh eV91cywgbW92ZV9kZWxheV91cyArIDEwMDApOw0KPiA+ID4gPiArCX0NCj4gPiA+IA0KPiA+ID4g DQo+ID4gPiBJdCB3aWxsIGxvb2sgbW9yZSBuYXR1cmFsbHkgaW4gdGhlIG11bHRpcGxpZXIga2lu ZCBvZiB2YWx1ZS4NCj4gPiA+IA0KPiA+ID4gCXVuc2lnbmVkIGludCBzdGVwcyA9IERJVl9ST1VO RF9VUCguLi4pOw0KPiA+ID4gDQo+ID4gPiAJd2hpbGUgKHN0ZXBzLS0pIHsNCj4gPiA+IAkJLi4u KC4uLiwgc3RlcHMgKiAuLi5fTU9WRV9TVEVQUyk7DQo+ID4gPiAJCS4uLg0KPiA+ID4gCX0NCj4g PiA+IA0KPiA+ID4gYnV0IGRvdWJsZSBjaGVjayBhcml0aG1ldGljcy4NCj4gPiANCj4gPiBUaGUg Y3VycmVudCBjb2Rpbmcgc3R5bGUgaXMgYWN0dWFsbHkgdXBkYXRlZCB3aXRoIHJlZmVyZW5jZSB0 byB5b3VyDQo+ID4gcHJldmlvdXMgY29tbWVudHMgb24gRFc5NzY4IHYzOg0KPiA+IGh0dHBzOi8v cGF0Y2h3b3JrLmxpbnV4dHYub3JnL3BhdGNoLzYxODU2Lw0KPiANCj4gSSB1bmRlcnN0YW5kLCBi dXQgY2FuIHlvdSBjb25zaWRlciB0byBnbyBmdXJ0aGVyIGFuZCBzZWUgaWYgdGhlIHByb3Bvc2Fs IHdvcmtzPw0KPiANCg0KSW4gZmFjdCwgeW91ciBzdWdnZXN0aW9uIGlzIHNvbWV0aGluZyBsaWtl IG9uZSBhbm90aGVyIG1ldGhvZCB0byBzZXQgREFDDQp2YWx1ZSB0byBhY3R1YXRvci4NCkl0IGlz IGxpa2UgdGhlcmUgbWF5IGJlIHNldmVyYWwgc29sdXRpb25zIHRvIGEgcXVlc3Rpb24uDQoNClll cy4gSSBqdXN0IHRyaWVkIHRoZSBuZXcgbWV0aG9kIGFuZCBpdCB3b3JrcyBhcyBleHBlY3RlZC4N CnUzMiBzdGVwcyA9IERJVl9ST1VORF9VUChkdzk3NjgtPmZvY3VzLT52YWwsIERXOTc2OF9NT1ZF X1NURVBTKTsNCndoaWxlIChzdGVwcy0tKSB7DQoJcmV0ID0gZHc5NzY4X3NldF9kYWMoZHc5NzY4 LCBzdGVwcyAqIERXOTc2OF9NT1ZFX1NURVBTKTsNCglpZiAocmV0KQ0KCQlyZXR1cm4gcmV0Ow0K CXVzbGVlcF9yYW5nZShtb3ZlX2RlbGF5X3VzLCBtb3ZlX2RlbGF5X3VzICsgMTAwMCk7DQp9DQoN CkJ1dCBmcm9tIG15IHBlcnNwZWN0aXZlLCBJIG1heSBwcmVmZXIgdG8gdGhlIG9yaWdpbmFsIG1l dGhvZC4NCkFzIGhlcmUgd2hhdCB3ZSByZWFsbHkgY2FyZSBpcyB0aGUgREFDIHZhbHVlLA0KJ2R3 OTc2OF9zZXRfZGFjKGR3OTc2OCwgdmFsKScgc2VlbXMgbW9yZSBzaW1wbGUuDQoNCg==