From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 1/2] ARM: EXYNOS: Support Suspend-to-RAM on EXYNOS5420 Date: Fri, 20 Dec 2013 22:23:41 +0100 Message-ID: <1591935.tG52kkhDHl@flatron> References: <1387195271-3613-1-git-send-email-a.kesavan@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mail-ea0-f169.google.com ([209.85.215.169]:37271 "EHLO mail-ea0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343Ab3LTVXo (ORCPT ); Fri, 20 Dec 2013 16:23:44 -0500 Received: by mail-ea0-f169.google.com with SMTP id l9so1110693eaj.0 for ; Fri, 20 Dec 2013 13:23:43 -0800 (PST) In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Olof Johansson Cc: Abhilash Kesavan , sunil joshi , abrestic@chromium.org, Bartlomiej Zolnierkiewicz , linux-arm-kernel , linux-samsung-soc , Douglas Anderson , Kukjin Kim On Friday 20 of December 2013 13:22:06 Olof Johansson wrote: > On Fri, Dec 20, 2013 at 3:38 AM, Abhilash Kesavan > wrote: > > Hi Sunil, > > > > On Fri, Dec 20, 2013 at 3:56 PM, sunil joshi wrote: > >> Hi Abhilash, > >> I saw another patch in chrome tree ..by Andrew Bresticker > >> which may be relevant here .. > >> > >> Just wondering if you missed adding this ? or this is not needed ? > >> You did not face any issue in getting core to suspend ? > > > > This has not been added for Exynos5250 in mainline yet. We did notice > > that the system would fail to suspend on the rare occasion (~1% of the > > time on exynos5250) when we repeatedly suspended and resumed the > > system. > > > > I have not run s2r stress tests, but have had no issues suspending the > > system in my limited testing. We can probably let this be for now as > > the system would resume fine even on a failed suspend. I will do some > > stress testing and then post if needed. > > Hold on, you're claiming that this patch you've posted has only seen > very limited testing, and that you are aware of failures? > > Don't merge known-broken code into the mainline kernel. I'm afraid that a "failed suspend" does not really mean a failure here, but let me wait for clarification of things I asked in another part of this thread. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Fri, 20 Dec 2013 22:23:41 +0100 Subject: [PATCH 1/2] ARM: EXYNOS: Support Suspend-to-RAM on EXYNOS5420 In-Reply-To: References: <1387195271-3613-1-git-send-email-a.kesavan@samsung.com> Message-ID: <1591935.tG52kkhDHl@flatron> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 20 of December 2013 13:22:06 Olof Johansson wrote: > On Fri, Dec 20, 2013 at 3:38 AM, Abhilash Kesavan > wrote: > > Hi Sunil, > > > > On Fri, Dec 20, 2013 at 3:56 PM, sunil joshi wrote: > >> Hi Abhilash, > >> I saw another patch in chrome tree ..by Andrew Bresticker > >> which may be relevant here .. > >> > >> Just wondering if you missed adding this ? or this is not needed ? > >> You did not face any issue in getting core to suspend ? > > > > This has not been added for Exynos5250 in mainline yet. We did notice > > that the system would fail to suspend on the rare occasion (~1% of the > > time on exynos5250) when we repeatedly suspended and resumed the > > system. > > > > I have not run s2r stress tests, but have had no issues suspending the > > system in my limited testing. We can probably let this be for now as > > the system would resume fine even on a failed suspend. I will do some > > stress testing and then post if needed. > > Hold on, you're claiming that this patch you've posted has only seen > very limited testing, and that you are aware of failures? > > Don't merge known-broken code into the mainline kernel. I'm afraid that a "failed suspend" does not really mean a failure here, but let me wait for clarification of things I asked in another part of this thread. Best regards, Tomasz