From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD692C433DF for ; Mon, 15 Jun 2020 06:03:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC12420663 for ; Mon, 15 Jun 2020 06:03:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ARzN++w6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="HYbN0mFl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC12420663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EEsAcmAhWTumJ7iGtkH1hI/FbEq24xuzN1rPKANMgOk=; b=ARzN++w6Vu0BsN F6QG97JqFc/H8LQb+UxwjUKXnahZjqZFm8eLtH3i3b0pIkI2UqvUNXvW7R3B4A+v8vUz3WKr84T26 XGJDACGpzczhOCx1FWkFiAvfHfsEQ2sSFhfs938T5eK7SsxPNaC+pjH2Qo/9yZZiQxpyKRpobLm4N aqy4Qrczjic2Y2/DREkWzo3OkvkyxF70Lrsmd6+jC+C2HTEq+0IfZe9/HLPoaA1RDPato5BapZ6Vc T9vFv1R9HlFmkjs7LlMXx/d6ahy3BirxdqBR+ts4LQ15e2yrasFL19y+V50SrpjlrWZfNj1KkZk+6 yyXnD8/Onk1YYnOo4zFg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkiCl-0007Ve-FL; Mon, 15 Jun 2020 06:02:47 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkiCb-0007KC-0t; Mon, 15 Jun 2020 06:02:40 +0000 X-UUID: 8b5a6460b39c4466a6cd639c400fcaa8-20200614 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=fnDevRc5gzT9pEFX+fLR5VMrjoY4YqsLtT0zU0Ke8Vo=; b=HYbN0mFli9pFHjzfVPtWFdBpE6Uum9IVibhYDTcZzYFFY+iaS42bn24Oalc84YJGI7r0SAt65iRby/MK7jcfYSR7C/XMLOi9rkkNB//Jd0hxCRBkGI/T2G947yHztReHKT3FMRPCo8gtbDsznehDOM6OoELspzcvHgBhkwbLMMA=; X-UUID: 8b5a6460b39c4466a6cd639c400fcaa8-20200614 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1812739201; Sun, 14 Jun 2020 22:02:27 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 14 Jun 2020 22:57:00 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 15 Jun 2020 13:56:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 15 Jun 2020 13:56:54 +0800 Message-ID: <1592200471.8804.681.camel@mhfsdcap03> Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver From: Dongchun Zhu To: Tomasz Figa Date: Mon, 15 Jun 2020 13:54:31 +0800 In-Reply-To: References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <20200610194455.GK201868@chromium.org> <1591958798.8804.660.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 05083A7EAA71BA34896525D44F4E88087FD14958F89E60E60F8969B81D033BF72000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200614_230237_067279_8EA574FC X-CRM114-Status: GOOD ( 22.26 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?= , Louis Kuo , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , dongchun.zhu@mediatek.com, Sakari Ailus , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Tomasz, On Fri, 2020-06-12 at 20:39 +0200, Tomasz Figa wrote: > On Fri, Jun 12, 2020 at 12:49 PM Dongchun Zhu wrote: > > > > Hi Tomasz, > > > > On Wed, 2020-06-10 at 19:44 +0000, Tomasz Figa wrote: > > > Hi Dongchun, > > > > > > On Sat, May 23, 2020 at 04:41:03PM +0800, Dongchun Zhu wrote: > > > > Add a V4L2 sub-device driver for OV02A10 image sensor. > > > > > > > > Signed-off-by: Dongchun Zhu > > > > --- > > > > MAINTAINERS | 1 + > > > > drivers/media/i2c/Kconfig | 13 + > > > > drivers/media/i2c/Makefile | 1 + > > > > drivers/media/i2c/ov02a10.c | 1025 +++++++++++++++++++++++++++++++++++++++++++ > > > > 4 files changed, 1040 insertions(+) > > > > create mode 100644 drivers/media/i2c/ov02a10.c > > > > > > > > > > Thank you for the patch. Please see my comments inline. > > > > > > [snip] > > > > diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c > > > > new file mode 100644 > > > > index 0000000..160a0b5 > > > > --- /dev/null > > > > +++ b/drivers/media/i2c/ov02a10.c > > > [snip] > > > > +static const char * const ov02a10_test_pattern_menu[] = { > > > > + "Disabled", > > > > + "Color Bar", > > > > > > nit: We should normalize this to one of the standard names. What is the > > > pattern on this sensor? Is it perhaps "Eight Vertical Colour Bars"? > > > > > > > Yes. It is one kind of 'Eight Vertical Colour Bars'. > > This pattern is called as 'MIPI color bar' per the datasheet. > > Can we here use 'Vertical Color Bar' or 'MIPI Color Bar'? > > > > We should try to stick to the names as exposed by existing drivers. > There was an attempt to unify the naming of some Sony sensors some > time ago [1]. Perhaps one of the names there matches the pattern of > this sensor? > > [1] https://patchwork.kernel.org/patch/10711777/ > Sounds great. It is one good idea to summarize test patterns from various sensors. But one question plaguing me is that it seems even for the same "Eight Vertical Colour Bars", different sensors may have different RGB color map. Moreover, definition standards of color bar style may differ among different sensor chip vendors. For instance, Sony often uses "Solid Color", "Color Bars With Fade to Grey", "PN9" to abstract test pattern output type; while OmniVision adopts color bar type 1, 2, 3, 4 or "MIPI Color Bar", "ISP Color Bar" instead. > Best regards, > Tomasz _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DD4C433DF for ; Mon, 15 Jun 2020 06:02:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0735620663 for ; Mon, 15 Jun 2020 06:02:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Vdohp8dr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="HYbN0mFl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0735620663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zj84LGHXt5TEUTk6Khc0YEaQVK9FEnfv+r2WGs8IC5s=; b=Vdohp8drNnpoha LUWqhuMAY4hYAZ/ZKVfaL+V7UAux9bkHXsuRfRNHy7CozJ/OqsFoIZr/tGCZzzch3/xNMSUSsGRdm ApFTp8nZyz0ju2gnmnCjarV8X9bhREvN9iB8dkfGQpXZkHHaGue5cudHiQGaDWtn6nB5K3GRlVNSM Zi+Q1lZ5RaQDZTjRtwUgWn/a25hkWIOym2Zatfmzc/4jOGjlIlC/zfMIiMsRXRDWyeq7FJ+pHTIe+ CG+qdUR7H1mKzPJczbi7hXM8FuaBvye+jkiOnl7UuoTwNolw8M9UEDgXfUnSeJzNmem37OuzVdgCn YfitkeNeG2vG+ZObkv+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkiCn-0007XP-KF; Mon, 15 Jun 2020 06:02:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkiCb-0007KC-0t; Mon, 15 Jun 2020 06:02:40 +0000 X-UUID: 8b5a6460b39c4466a6cd639c400fcaa8-20200614 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=fnDevRc5gzT9pEFX+fLR5VMrjoY4YqsLtT0zU0Ke8Vo=; b=HYbN0mFli9pFHjzfVPtWFdBpE6Uum9IVibhYDTcZzYFFY+iaS42bn24Oalc84YJGI7r0SAt65iRby/MK7jcfYSR7C/XMLOi9rkkNB//Jd0hxCRBkGI/T2G947yHztReHKT3FMRPCo8gtbDsznehDOM6OoELspzcvHgBhkwbLMMA=; X-UUID: 8b5a6460b39c4466a6cd639c400fcaa8-20200614 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1812739201; Sun, 14 Jun 2020 22:02:27 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 14 Jun 2020 22:57:00 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 15 Jun 2020 13:56:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 15 Jun 2020 13:56:54 +0800 Message-ID: <1592200471.8804.681.camel@mhfsdcap03> Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver From: Dongchun Zhu To: Tomasz Figa Date: Mon, 15 Jun 2020 13:54:31 +0800 In-Reply-To: References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <20200610194455.GK201868@chromium.org> <1591958798.8804.660.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 05083A7EAA71BA34896525D44F4E88087FD14958F89E60E60F8969B81D033BF72000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200614_230237_067279_8EA574FC X-CRM114-Status: GOOD ( 22.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?= , Louis Kuo , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , dongchun.zhu@mediatek.com, Sakari Ailus , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tomasz, On Fri, 2020-06-12 at 20:39 +0200, Tomasz Figa wrote: > On Fri, Jun 12, 2020 at 12:49 PM Dongchun Zhu wrote: > > > > Hi Tomasz, > > > > On Wed, 2020-06-10 at 19:44 +0000, Tomasz Figa wrote: > > > Hi Dongchun, > > > > > > On Sat, May 23, 2020 at 04:41:03PM +0800, Dongchun Zhu wrote: > > > > Add a V4L2 sub-device driver for OV02A10 image sensor. > > > > > > > > Signed-off-by: Dongchun Zhu > > > > --- > > > > MAINTAINERS | 1 + > > > > drivers/media/i2c/Kconfig | 13 + > > > > drivers/media/i2c/Makefile | 1 + > > > > drivers/media/i2c/ov02a10.c | 1025 +++++++++++++++++++++++++++++++++++++++++++ > > > > 4 files changed, 1040 insertions(+) > > > > create mode 100644 drivers/media/i2c/ov02a10.c > > > > > > > > > > Thank you for the patch. Please see my comments inline. > > > > > > [snip] > > > > diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c > > > > new file mode 100644 > > > > index 0000000..160a0b5 > > > > --- /dev/null > > > > +++ b/drivers/media/i2c/ov02a10.c > > > [snip] > > > > +static const char * const ov02a10_test_pattern_menu[] = { > > > > + "Disabled", > > > > + "Color Bar", > > > > > > nit: We should normalize this to one of the standard names. What is the > > > pattern on this sensor? Is it perhaps "Eight Vertical Colour Bars"? > > > > > > > Yes. It is one kind of 'Eight Vertical Colour Bars'. > > This pattern is called as 'MIPI color bar' per the datasheet. > > Can we here use 'Vertical Color Bar' or 'MIPI Color Bar'? > > > > We should try to stick to the names as exposed by existing drivers. > There was an attempt to unify the naming of some Sony sensors some > time ago [1]. Perhaps one of the names there matches the pattern of > this sensor? > > [1] https://patchwork.kernel.org/patch/10711777/ > Sounds great. It is one good idea to summarize test patterns from various sensors. But one question plaguing me is that it seems even for the same "Eight Vertical Colour Bars", different sensors may have different RGB color map. Moreover, definition standards of color bar style may differ among different sensor chip vendors. For instance, Sony often uses "Solid Color", "Color Bars With Fade to Grey", "PN9" to abstract test pattern output type; while OmniVision adopts color bar type 1, 2, 3, 4 or "MIPI Color Bar", "ISP Color Bar" instead. > Best regards, > Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB0BC433E1 for ; Mon, 15 Jun 2020 05:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B6A820663 for ; Mon, 15 Jun 2020 05:57:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="KyqdcA5D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728284AbgFOF5N (ORCPT ); Mon, 15 Jun 2020 01:57:13 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:50516 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728162AbgFOF5N (ORCPT ); Mon, 15 Jun 2020 01:57:13 -0400 X-UUID: 9abc56e96e1048909a776cb841c925ee-20200615 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=fnDevRc5gzT9pEFX+fLR5VMrjoY4YqsLtT0zU0Ke8Vo=; b=KyqdcA5Do0y9bMA6H3+uabWe1c4s3kmjolNH0KbG6DwdnK8N7s39aHknayMvdo+RZVd9ttExpZ2KQToGpXdHPfPQq4yBz1gKJa4CesKvNPAmh0h0YC4Jr0mDbt9SOvF6dsLL8ycdkveCpBrH2uANri0QxOTZ09xDiST7QOrdjXc=; X-UUID: 9abc56e96e1048909a776cb841c925ee-20200615 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1471708032; Mon, 15 Jun 2020 13:56:57 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 15 Jun 2020 13:56:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 15 Jun 2020 13:56:54 +0800 Message-ID: <1592200471.8804.681.camel@mhfsdcap03> Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver From: Dongchun Zhu To: Tomasz Figa CC: Linus Walleij , Bartosz Golaszewski , Mauro Carvalho Chehab , Andy Shevchenko , Rob Herring , Mark Rutland , Sakari Ailus , Nicolas Boichat , Matthias Brugger , Cao Bing Bu , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Sj Huang , Linux Media Mailing List , linux-devicetree , Louis Kuo , "Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?=" , Date: Mon, 15 Jun 2020 13:54:31 +0800 In-Reply-To: References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <20200610194455.GK201868@chromium.org> <1591958798.8804.660.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 05083A7EAA71BA34896525D44F4E88087FD14958F89E60E60F8969B81D033BF72000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgVG9tYXN6LA0KDQpPbiBGcmksIDIwMjAtMDYtMTIgYXQgMjA6MzkgKzAyMDAsIFRvbWFzeiBG aWdhIHdyb3RlOg0KPiBPbiBGcmksIEp1biAxMiwgMjAyMCBhdCAxMjo0OSBQTSBEb25nY2h1biBa aHUgPGRvbmdjaHVuLnpodUBtZWRpYXRlay5jb20+IHdyb3RlOg0KPiA+DQo+ID4gSGkgVG9tYXN6 LA0KPiA+DQo+ID4gT24gV2VkLCAyMDIwLTA2LTEwIGF0IDE5OjQ0ICswMDAwLCBUb21hc3ogRmln YSB3cm90ZToNCj4gPiA+IEhpIERvbmdjaHVuLA0KPiA+ID4NCj4gPiA+IE9uIFNhdCwgTWF5IDIz LCAyMDIwIGF0IDA0OjQxOjAzUE0gKzA4MDAsIERvbmdjaHVuIFpodSB3cm90ZToNCj4gPiA+ID4g QWRkIGEgVjRMMiBzdWItZGV2aWNlIGRyaXZlciBmb3IgT1YwMkExMCBpbWFnZSBzZW5zb3IuDQo+ ID4gPiA+DQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IERvbmdjaHVuIFpodSA8ZG9uZ2NodW4uemh1 QG1lZGlhdGVrLmNvbT4NCj4gPiA+ID4gLS0tDQo+ID4gPiA+ICBNQUlOVEFJTkVSUyAgICAgICAg ICAgICAgICAgfCAgICAxICsNCj4gPiA+ID4gIGRyaXZlcnMvbWVkaWEvaTJjL0tjb25maWcgICB8 ICAgMTMgKw0KPiA+ID4gPiAgZHJpdmVycy9tZWRpYS9pMmMvTWFrZWZpbGUgIHwgICAgMSArDQo+ ID4gPiA+ICBkcml2ZXJzL21lZGlhL2kyYy9vdjAyYTEwLmMgfCAxMDI1ICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiA+ID4gIDQgZmlsZXMgY2hhbmdlZCwg MTA0MCBpbnNlcnRpb25zKCspDQo+ID4gPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9t ZWRpYS9pMmMvb3YwMmExMC5jDQo+ID4gPiA+DQo+ID4gPg0KPiA+ID4gVGhhbmsgeW91IGZvciB0 aGUgcGF0Y2guIFBsZWFzZSBzZWUgbXkgY29tbWVudHMgaW5saW5lLg0KPiA+ID4NCj4gPiA+IFtz bmlwXQ0KPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9pMmMvb3YwMmExMC5jIGIv ZHJpdmVycy9tZWRpYS9pMmMvb3YwMmExMC5jDQo+ID4gPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0 DQo+ID4gPiA+IGluZGV4IDAwMDAwMDAuLjE2MGEwYjUNCj4gPiA+ID4gLS0tIC9kZXYvbnVsbA0K PiA+ID4gPiArKysgYi9kcml2ZXJzL21lZGlhL2kyYy9vdjAyYTEwLmMNCj4gPiA+IFtzbmlwXQ0K PiA+ID4gPiArc3RhdGljIGNvbnN0IGNoYXIgKiBjb25zdCBvdjAyYTEwX3Rlc3RfcGF0dGVybl9t ZW51W10gPSB7DQo+ID4gPiA+ICsgICAiRGlzYWJsZWQiLA0KPiA+ID4gPiArICAgIkNvbG9yIEJh ciIsDQo+ID4gPg0KPiA+ID4gbml0OiBXZSBzaG91bGQgbm9ybWFsaXplIHRoaXMgdG8gb25lIG9m IHRoZSBzdGFuZGFyZCBuYW1lcy4gV2hhdCBpcyB0aGUNCj4gPiA+IHBhdHRlcm4gb24gdGhpcyBz ZW5zb3I/IElzIGl0IHBlcmhhcHMgIkVpZ2h0IFZlcnRpY2FsIENvbG91ciBCYXJzIj8NCj4gPiA+ DQo+ID4NCj4gPiBZZXMuIEl0IGlzIG9uZSBraW5kIG9mICdFaWdodCBWZXJ0aWNhbCBDb2xvdXIg QmFycycuDQo+ID4gVGhpcyBwYXR0ZXJuIGlzIGNhbGxlZCBhcyAnTUlQSSBjb2xvciBiYXInIHBl ciB0aGUgZGF0YXNoZWV0Lg0KPiA+IENhbiB3ZSBoZXJlIHVzZSAnVmVydGljYWwgQ29sb3IgQmFy JyBvciAnTUlQSSBDb2xvciBCYXInPw0KPiA+DQo+IA0KPiBXZSBzaG91bGQgdHJ5IHRvIHN0aWNr IHRvIHRoZSBuYW1lcyBhcyBleHBvc2VkIGJ5IGV4aXN0aW5nIGRyaXZlcnMuDQo+IFRoZXJlIHdh cyBhbiBhdHRlbXB0IHRvIHVuaWZ5IHRoZSBuYW1pbmcgb2Ygc29tZSBTb255IHNlbnNvcnMgc29t ZQ0KPiB0aW1lIGFnbyBbMV0uIFBlcmhhcHMgb25lIG9mIHRoZSBuYW1lcyB0aGVyZSBtYXRjaGVz IHRoZSBwYXR0ZXJuIG9mDQo+IHRoaXMgc2Vuc29yPw0KPiANCj4gWzFdIGh0dHBzOi8vcGF0Y2h3 b3JrLmtlcm5lbC5vcmcvcGF0Y2gvMTA3MTE3NzcvDQo+IA0KDQpTb3VuZHMgZ3JlYXQuDQpJdCBp cyBvbmUgZ29vZCBpZGVhIHRvIHN1bW1hcml6ZSB0ZXN0IHBhdHRlcm5zIGZyb20gdmFyaW91cyBz ZW5zb3JzLg0KQnV0IG9uZSBxdWVzdGlvbiBwbGFndWluZyBtZSBpcyB0aGF0IGl0IHNlZW1zIGV2 ZW4gZm9yIHRoZSBzYW1lICJFaWdodA0KVmVydGljYWwgQ29sb3VyIEJhcnMiLCBkaWZmZXJlbnQg c2Vuc29ycyBtYXkgaGF2ZSBkaWZmZXJlbnQgUkdCIGNvbG9yDQptYXAuDQoNCk1vcmVvdmVyLCBk ZWZpbml0aW9uIHN0YW5kYXJkcyBvZiBjb2xvciBiYXIgc3R5bGUgbWF5IGRpZmZlciBhbW9uZw0K ZGlmZmVyZW50IHNlbnNvciBjaGlwIHZlbmRvcnMuDQpGb3IgaW5zdGFuY2UsIFNvbnkgb2Z0ZW4g dXNlcyAiU29saWQgQ29sb3IiLCAiQ29sb3IgQmFycyBXaXRoIEZhZGUgdG8NCkdyZXkiLCAiUE45 IiB0byBhYnN0cmFjdCB0ZXN0IHBhdHRlcm4gb3V0cHV0IHR5cGU7IHdoaWxlIE9tbmlWaXNpb24N CmFkb3B0cyBjb2xvciBiYXIgdHlwZSAxLCAyLCAzLCA0IG9yICJNSVBJIENvbG9yIEJhciIsICJJ U1AgQ29sb3IgQmFyIg0KaW5zdGVhZC4NCg0KPiBCZXN0IHJlZ2FyZHMsDQo+IFRvbWFzeg0KDQo=