All of lore.kernel.org
 help / color / mirror / Atom feed
From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	Owen Chen <owen.chen@mediatek.com>,
	Mars Cheng <mars.cheng@mediatek.com>,
	"kbuild test robot" <lkp@intel.com>
Subject: Re: [PATCH] clk: mediatek: Remove ifr{0,1}_cfg_regs structures
Date: Thu, 18 Jun 2020 18:42:15 +0800	[thread overview]
Message-ID: <1592476935.32278.2.camel@mtkswgap22> (raw)
In-Reply-To: <20200609211847.27366-1-sboyd@kernel.org>

On Tue, 2020-06-09 at 14:18 -0700, Stephen Boyd wrote:
> These aren't used and the macros that reference them aren't used either.
> Remove the dead code to avoid compile warnings.
> 
> Cc: Owen Chen <owen.chen@mediatek.com>
> Cc: Mars Cheng <mars.cheng@mediatek.com>
> Cc: Macpaul Lin <macpaul.lin@mediatek.com>
> Fixes: 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> ---
>  drivers/clk/mediatek/clk-mt6765.c | 30 ------------------------------
>  1 file changed, 30 deletions(-)
> 
> diff --git a/drivers/clk/mediatek/clk-mt6765.c b/drivers/clk/mediatek/clk-mt6765.c
> index 3ec53cb62ece..db8db1b3b79d 100644
> --- a/drivers/clk/mediatek/clk-mt6765.c
> +++ b/drivers/clk/mediatek/clk-mt6765.c
> @@ -534,18 +534,6 @@ static const struct mtk_gate top_clks[] = {
>  	GATE_TOP2(CLK_TOP_APLL12_DIV3, "apll12_div3", "aud_1_ck", 5),
>  };
>  
> -static const struct mtk_gate_regs ifr0_cg_regs = {
> -	.set_ofs = 0x200,
> -	.clr_ofs = 0x200,
> -	.sta_ofs = 0x200,
> -};
> -
> -static const struct mtk_gate_regs ifr1_cg_regs = {
> -	.set_ofs = 0x74,
> -	.clr_ofs = 0x74,
> -	.sta_ofs = 0x74,
> -};
> -
>  static const struct mtk_gate_regs ifr2_cg_regs = {
>  	.set_ofs = 0x80,
>  	.clr_ofs = 0x84,
> @@ -570,24 +558,6 @@ static const struct mtk_gate_regs ifr5_cg_regs = {
>  	.sta_ofs = 0xc8,
>  };
>  
> -#define GATE_IFR0(_id, _name, _parent, _shift) {	\
> -		.id = _id,				\
> -		.name = _name,				\
> -		.parent_name = _parent,			\
> -		.regs = &ifr0_cg_regs,			\
> -		.shift = _shift,			\
> -		.ops = &mtk_clk_gate_ops_no_setclr_inv,	\
> -	}
> -
> -#define GATE_IFR1(_id, _name, _parent, _shift) {	\
> -		.id = _id,				\
> -		.name = _name,				\
> -		.parent_name = _parent,			\
> -		.regs = &ifr1_cg_regs,			\
> -		.shift = _shift,			\
> -		.ops = &mtk_clk_gate_ops_no_setclr,	\
> -	}
> -
>  #define GATE_IFR2(_id, _name, _parent, _shift) {	\
>  		.id = _id,				\
>  		.name = _name,				\

Thank you so much!
Owen and I were busy in other issues hence cannot help fix this issue
in time.

Thanks a lot!
BR,
Macpaul Lin

      reply	other threads:[~2020-06-18 10:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 21:18 [PATCH] clk: mediatek: Remove ifr{0,1}_cfg_regs structures Stephen Boyd
2020-06-18 10:42 ` Macpaul Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1592476935.32278.2.camel@mtkswgap22 \
    --to=macpaul.lin@mediatek.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mars.cheng@mediatek.com \
    --cc=mturquette@baylibre.com \
    --cc=owen.chen@mediatek.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.