From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmnhi-0004dx-V0 for qemu-devel@nongnu.org; Wed, 21 Sep 2016 16:01:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmnhe-00066K-0k for qemu-devel@nongnu.org; Wed, 21 Sep 2016 16:01:13 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:55867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmnhd-000668-MY for qemu-devel@nongnu.org; Wed, 21 Sep 2016 16:01:09 -0400 Date: Wed, 21 Sep 2016 16:01:08 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1592483129.530259.1474488068217.JavaMail.zimbra@redhat.com> In-Reply-To: References: <20160913130209.695-1-marcandre.lureau@redhat.com> <20160913130209.695-16-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-devel@nongnu.org, armbru@redhat.com Hi ----- Original Message ----- > On 09/13/2016 08:01 AM, Marc-Andr=C3=A9 Lureau wrote: > > Signed-off-by: Marc-Andr=C3=A9 Lureau > > --- > > docs/qmp-commands.txt | 29 ----------------------------- > > qapi-schema.json | 13 +++++++++++++ > > 2 files changed, 13 insertions(+), 29 deletions(-) > >=20 >=20 > > +++ b/qapi-schema.json > > @@ -1011,6 +1011,19 @@ > > # Returns: @MigrationParameters > > # > > # Since: 2.4 > > +# > > +# Example: > > +# > > +# -> { "execute": "query-migrate-parameters" } > > +# <- { "return": { > > +# "decompress-threads": 2, > > +# "cpu-throttle-increment": 10, > > +# "compress-threads": 8, > > +# "compress-level": 1, > > +# "cpu-throttle-initial": 20 > > +# } > > +# } > > +# > > ## > > { 'command': 'query-migrate-parameters', > > 'returns': 'MigrationParameters' } >=20 > The example lacks 'cpu-throttle-increment', 'tls-creds', and > 'tls-hostname'; do we want to take this opportunity to touch it up? I suggest to put a [...] in the returned example, as this example could gro= w again, and there isn't much to learn from that query. =20 > Meanwhile, I have a series that touches this code, and will obviously > create a merge conflict for whoever gets in second: > https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01946.html Yes, the more we wait to review the series, the more conflicts we will get.= There is still over 100 patches to go, I'll send the next 30. > At any rate, 11-15 are > Reviewed-by: Eric Blake thanks