diff for duplicates of <1592849.BGn9Ftusvr@avalon> diff --git a/a/1.txt b/N1/1.txt index 97be784..1497db3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -45,7 +45,7 @@ Good point, I'll add support for your comment to the commit message :-D > > { > > + unsigned int i; > > + -> > if (stack_top(graph) = NULL) +> > if (stack_top(graph) == NULL) > > return NULL; > > > > @@ -181,8 +183,13 @@ media_entity_graph_walk_next(struct @@ -54,10 +54,10 @@ Good point, I'll add support for your comment to the commit message :-D > > next = media_entity_other(entity, link); > > > > - /* Was it the entity we came here from? */ -> > - if (next = stack_peek(graph)) { +> > - if (next == stack_peek(graph)) { > > + /* Is the entity already in the path? */ > > + for (i = 1; i < graph->top; ++i) { -> > + if (next = stack_peek(graph, i)) +> > + if (next == stack_peek(graph, i)) > > + break; > > + } > > + diff --git a/a/content_digest b/N1/content_digest index 68738a6..50c3e9f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020130717194703.GB11369@valkosipuli.retiisi.org.uk\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH v2 1/5] media: Fix circular graph traversal\0" - "Date\0Wed, 17 Jul 2013 23:06:40 +0000\0" + "Date\0Thu, 18 Jul 2013 01:06:40 +0200\0" "To\0Sakari Ailus <sakari.ailus@iki.fi>\0" "Cc\0Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>" linux-media@vger.kernel.org @@ -58,7 +58,7 @@ "> > {\n" "> > +\tunsigned int i;\n" "> > +\n" - "> > \tif (stack_top(graph) = NULL)\n" + "> > \tif (stack_top(graph) == NULL)\n" "> > \t\treturn NULL;\n" "> > \n" "> > @@ -181,8 +183,13 @@ media_entity_graph_walk_next(struct\n" @@ -67,10 +67,10 @@ "> > \t\tnext = media_entity_other(entity, link);\n" "> > \n" "> > -\t\t/* Was it the entity we came here from? */\n" - "> > -\t\tif (next = stack_peek(graph)) {\n" + "> > -\t\tif (next == stack_peek(graph)) {\n" "> > +\t\t/* Is the entity already in the path? */\n" "> > +\t\tfor (i = 1; i < graph->top; ++i) {\n" - "> > +\t\t\tif (next = stack_peek(graph, i))\n" + "> > +\t\t\tif (next == stack_peek(graph, i))\n" "> > +\t\t\t\tbreak;\n" "> > +\t\t}\n" "> > +\n" @@ -101,4 +101,4 @@ "\n" Laurent Pinchart -0ac8858c3680ba0fdbd48b8af037bfa314b2f13d0a16286b3388303c0c7ae999 +b1a18de21f6e51360aca45e4d91137befaeae17926b6b9bf95c2757ce1887a6b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.