From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70B12C433E0 for ; Tue, 30 Jun 2020 02:31:20 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A60720702 for ; Tue, 30 Jun 2020 02:31:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bIriXmoh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A60720702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49wpJP0YqtzDqfH for ; Tue, 30 Jun 2020 12:31:17 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=bIriXmoh; dkim-atps=neutral Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49wpGN22RjzDqQT for ; Tue, 30 Jun 2020 12:29:32 +1000 (AEST) Received: by mail-wr1-x444.google.com with SMTP id f18so10482403wrs.0 for ; Mon, 29 Jun 2020 19:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=fG2+FlqjbrdlLbr3Ppcqc3zl/OoR7H2pDj/tVDccong=; b=bIriXmohgKziJJP/cp+ODrk3HzaUmkMIXU1VeFWkC9Y7Gh3gvxW7kDuvebiWlEIbX0 dF+7zKxXWVixBgcINDP0/bXyrpksoI0TLLKU68kJT5qbpi2MUZ2e1vFBj/KnGJP8icPu QWwR2GYoPmzv/NpVjCdlsE0CW8nkqzjJE3NCZ4b1CzIWc++lS7TfyGiQ8gvD/4QicCZv QlInoexH02eCKAPJCI0m8tH4MGCiLkSRRcC547qFPCYmDPiAdbbqYUkjXLk6zOATtHcl FyduJAtq9rro3kSoca2SWwinrnD0CGmwF0NyJReM/y3dXo/6jEVc3Y2ohhh6Z2IDGczT CaWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=fG2+FlqjbrdlLbr3Ppcqc3zl/OoR7H2pDj/tVDccong=; b=GysqGS5VFsjlbmFdyKJCERV8yRem0+j7fZZzJMsCXmEkdZoFACPRtTZ9ft85t2djn7 gyAY4WnQGSI3B8umhJx9wDfK4mUfDOa3dbDCAVxBdgt0pGHOJ9O870vcppbxj5ziiXSZ kFd+81DKtosXg6vA4RW/dWvFnAAAtLgBOMYO/3tA1a2bKl4V8p2c2Zu7VgB3SiqKT0ic h4Nlkz+uWnZsfqa8Ql1euJOKtvXSwBojSeHM7bSrH0rUJ9mE2CrU3sH8lk1C7ZJY948V F3NEBd6RHDfsg3vHZrdz3F2CDck49/M0se/K0c8k2NJTaiZkxhLsMPRCFZhQ2OGq896P nEgA== X-Gm-Message-State: AOAM532+i6MzCDHBlK96i2zAIEia49DREO5y5ND134XYOByKdC0zLBdW lbyXYb2jwG3k3PhsAHTmZNc= X-Google-Smtp-Source: ABdhPJxQy/N+VHD3JrQe6Tp7EZYtKpUgN45eNTRvW+FDA05VVkkCSsrogKCJ1TUhuvWPNWWH5nxT6Q== X-Received: by 2002:a5d:610a:: with SMTP id v10mr19488668wrt.108.1593484169436; Mon, 29 Jun 2020 19:29:29 -0700 (PDT) Received: from localhost (61-68-186-125.tpgi.com.au. [61.68.186.125]) by smtp.gmail.com with ESMTPSA id a22sm1792381wmj.9.2020.06.29.19.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 19:29:28 -0700 (PDT) Date: Tue, 30 Jun 2020 12:29:22 +1000 From: Nicholas Piggin Subject: Re: [PATCH] xmon: Reset RCU and soft lockup watchdogs To: Anton Blanchard , linuxppc-dev@lists.ozlabs.org References: <20200630100218.62a3c3fb@kryten.localdomain> In-Reply-To: <20200630100218.62a3c3fb@kryten.localdomain> MIME-Version: 1.0 Message-Id: <1593484122.fip6nom71z.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Mackerras Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Excerpts from Anton Blanchard's message of June 30, 2020 10:02 am: > I'm seeing RCU warnings when exiting xmon. xmon resets the NMI watchdog, > but does nothing with the RCU stall or soft lockup watchdogs. Add a > helper function that handles all three. >=20 > Signed-off-by: Anton Blanchard Acked-by: Nicholas Piggin > --- > arch/powerpc/xmon/xmon.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c > index 7efe4bc3ccf6..d27944e38b04 100644 > --- a/arch/powerpc/xmon/xmon.c > +++ b/arch/powerpc/xmon/xmon.c > @@ -481,6 +481,13 @@ static inline int unrecoverable_excp(struct pt_regs = *regs) > #endif > } > =20 > +static void xmon_touch_watchdogs(void) > +{ > + touch_softlockup_watchdog_sync(); > + rcu_cpu_stall_reset(); > + touch_nmi_watchdog(); > +} > + > static int xmon_core(struct pt_regs *regs, int fromipi) > { > int cmd =3D 0; > @@ -718,7 +725,7 @@ static int xmon_core(struct pt_regs *regs, int fromip= i) > else > insert_cpu_bpts(); > =20 > - touch_nmi_watchdog(); > + xmon_touch_watchdogs(); > local_irq_restore(flags); > =20 > return cmd !=3D 'X' && cmd !=3D EOF; > --=20 > 2.26.2 >=20 >=20