From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bart van Assche <bvanassche@acm.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: allow state transitions BLOCK -> BLOCK
Date: Thu, 02 Jul 2020 07:34:03 -0700 [thread overview]
Message-ID: <1593700443.9652.2.camel@HansenPartnership.com> (raw)
In-Reply-To: <20200702142436.98336-1-hare@suse.de>
On Thu, 2020-07-02 at 16:24 +0200, Hannes Reinecke wrote:
> scsi_transport_srp.c will call scsi_target_block() repeatedly
> without calling scsi_target_unblock() first.
> So allow the idempotent state transition BLOCK -> BLOCK to avoid
> a warning here.
That really doesn't sound like a good idea. Block and unblock should
be matched pairs and since you don't have a running->running transition
allowed this implies that srp calls block many times but unblock only
once. It really sounds like srp needs fixing.
James
next prev parent reply other threads:[~2020-07-02 14:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 14:24 [PATCH] scsi: allow state transitions BLOCK -> BLOCK Hannes Reinecke
2020-07-02 14:34 ` James Bottomley [this message]
2020-07-02 15:14 ` Hannes Reinecke
2020-07-02 17:23 ` Bart Van Assche
2020-07-03 5:30 ` Hannes Reinecke
2020-07-06 2:30 ` Bart Van Assche
2020-07-06 6:22 ` Hannes Reinecke
2020-07-12 4:13 ` Bart Van Assche
2020-07-13 6:19 ` Hannes Reinecke
2020-07-18 2:51 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593700443.9652.2.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.