All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <jejb@linux.ibm.com>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>,
	fischer@norbit.de, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: AHA152X SCSI driver
Date: Sun, 05 Jul 2020 18:02:17 -0700	[thread overview]
Message-ID: <1593997337.4657.30.camel@linux.ibm.com> (raw)
In-Reply-To: <20200705214442.28370-1-grandmaster@al2klimov.de>

On Sun, 2020-07-05 at 23:44 +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>   If not .svg:
>     For each line:
>       If doesn't contain `\bxmlns\b`:
>         For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>           If both the HTTP and HTTPS versions
>           return 200 OK and serve the same content:
>             Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
> ---
>  Continuing my work started at 93431e0607e5.
> 
>  If there are any URLs to be removed completely or at least not
> HTTPSified:
>  Just clearly say so and I'll *undo my change*.
>  See also https://lkml.org/lkml/2020/6/27/64
> 
>  If there are any valid, but yet not changed URLs:
>  See https://lkml.org/lkml/2020/6/26/837
> 
>  drivers/scsi/pcmcia/aha152x_stub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/pcmcia/aha152x_stub.c
> b/drivers/scsi/pcmcia/aha152x_stub.c
> index df82a349e969..0c471915b20f 100644
> --- a/drivers/scsi/pcmcia/aha152x_stub.c
> +++ b/drivers/scsi/pcmcia/aha152x_stub.c
> @@ -10,7 +10,7 @@
>      The contents of this file are subject to the Mozilla Public
>      License Version 1.1 (the "License"); you may not use this file
>      except in compliance with the License. You may obtain a copy of
> -    the License at http://www.mozilla.org/MPL/
> +    the License at https://www.mozilla.org/MPL/

Um, no, you can't do that: that's licence boilerplate copied from the
actual standard licence header:

https://spdx.org/licenses/MPL-1.1.html

However, it does strike me that the whole of this should have been
replaced by a SPDX header.

James


      reply	other threads:[~2020-07-06  1:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-05 21:44 [PATCH] Replace HTTP links with HTTPS ones: AHA152X SCSI driver Alexander A. Klimov
2020-07-06  1:02 ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1593997337.4657.30.camel@linux.ibm.com \
    --to=jejb@linux.ibm.com \
    --cc=fischer@norbit.de \
    --cc=grandmaster@al2klimov.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.