From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 0/6] video: udlfb: (not only) Logging cleanup
Date: Thu, 04 Jan 2018 15:40:38 +0000 [thread overview]
Message-ID: <1594475.76bM9bkN7v@amdc3058> (raw)
On Monday, December 11, 2017 10:39:48 PM Ladislav Michl wrote:
> This patchset is a side product of debugging on unreliable USB host
> where devices saw a lot of disconnects. It turned out that udlfb
> logging is just too noisy to be usefull as produced syslog is hard
> to read.
>
> Hence this attempt to clean things up.
>
> Comments and suggestions welcome and appreciated, as always.
>
> Ladislav Michl (6):
> video: udlfb: Do not name private data 'dev'
This patch no longer applies cleanly after following patches:
11ab5a6 video: udlfb: Delete an unnecessary return statement in two functions
74fb251 video: udlfb: Improve a size determination in dlfb_alloc_urb_list()
have been merged into fbdev-for-next.
> video: udlfb: Remove unnecessary 'return'
I've already applied identical patch from Markus which was posted
some time earlier.
> video: udlfb: Remove unnecessary local variable
Please make this patch #1 in the series.
> video: udlfb: Delete error messages for failed allocations
In one place this patch removes the information about the device for
which the allocation fails and generally I would prefer to still have
the information about devices for which allocation fails (so please
consider dropping this patch and converting relevant places to use
dev_*() logging functions).
> video: udlfb: Remove redundant gdev variable
Please make this patch #2 in the series.
> video: udlfb: Switch from the pr_*() to the dev_*() logging functions
This patch also removes some log entries completely and I would prefer
such changes to be split into a separate pre-patch (please also give
a valid rationale for the removal in the patch description).
> drivers/video/fbdev/udlfb.c | 617 ++++++++++++++++++++------------------------
> include/video/udlfb.h | 3 +-
> 2 files changed, 284 insertions(+), 336 deletions(-)
Please rebase, fix and resubmit, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next reply other threads:[~2018-01-04 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 15:40 Bartlomiej Zolnierkiewicz [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-11 21:39 [PATCH 0/6] video: udlfb: (not only) Logging cleanup Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594475.76bM9bkN7v@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.